Re: [PATCH] mbedtls: fix defects in coverity scan

On Thu, 17 Oct 2024 at 00:49, Raymond Mao wrote: > > Fixes of unreleased buffer, deadcode and wrong variable type detected > by coverity scan. > > Addresses-Coverity-ID: 510809: Resource leaks (RESOURCE_LEAK) > Addresses-Coverity-ID: 510806: Control flow issues (DEADCODE) > Addresses-Coverity-

[PATCH 1/1] configs: visionfive2: enable CONFIG_CMD_ERASEENV

When moving from vendor U-Boot to the upstream U-Boot it is necessary to reset the environment. Provide the 'env erase' sub-command. Signed-off-by: Heinrich Schuchardt --- configs/starfive_visionfive2_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/starfive_visionfive2_def

Re: [PATCH v2 2/2] sandbox: add bootmethod EFI boot-manager

> Date: Fri, 18 Oct 2024 19:26:01 +0200 > From: Heinrich Schuchardt Hi Heinrich, > On 10/18/24 19:21, Simon Glass wrote: > > Hi Heinrich, > > > > On Thu, 17 Oct 2024 at 19:18, Heinrich Schuchardt > > wrote: > >> > >> The EFI boot-manager is the default method to boot EFI binaries. > >> We shou

Fwd: New Defects reported by Coverity Scan for Das U-Boot

Here's a short update. -- Forwarded message - From: Date: Sat, Oct 19, 2024, 8:35 AM Subject: New Defects reported by Coverity Scan for Das U-Boot To: Hi, Please find the latest report on new defect(s) introduced to Das U-Boot found with Coverity Scan. 2 new defect(s) introdu

[PATCH v2 21/31] bootstd: Update bootmeth_alloc_file() to record images

As a first step to recording images and where they came from, update this function to do so, since it is used by two bootmeths Signed-off-by: Simon Glass --- Changes in v2: - Update to use a new image-type enum in bootflow.h boot/bootmeth-uclass.c | 17 - boot/bootmeth_extlin

[PATCH v2 22/31] boot: pxe: Drop the duplicate comment on get_pxe_file()

This function is exported, so document it in the header file. Drop the duplicate comment in the C file. Signed-off-by: Simon Glass --- (no changes since v1) boot/pxe_utils.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c index d6a4b2cb859..4f

[PATCH v2 18/31] test: boot: Update bootflow_iter() for console checking

This test checks console output so should have the UTF_CONSOLE flag. Add it. Signed-off-by: Simon Glass --- (no changes since v1) test/boot/bootflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/boot/bootflow.c b/test/boot/bootflow.c index 8ea284098e7..efb82ee628b

[PATCH v2 00/31] bootstd: Support recording images

This series provides a way to keep track of the images used in bootstd, including the type of each image. At present this is sort-of handled by struct bootflow but in quite an ad-hoc way. The structure has become quite large and is hard to query. Future work will be able to reduce its size. Ultim

[PATCH v7 1/7] test: boot: Update bootflow_iter() for console checking

This test checks console output so should have the UTF_CONSOLE flag. Add it. Signed-off-by: Simon Glass --- (no changes since v1) test/boot/bootflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/boot/bootflow.c b/test/boot/bootflow.c index 154dea70a59..cc894e804a4

Re: [PATCH 23/34] bootstd: Maintain a list of images

On Sat, Oct 19, 2024 at 05:49:40AM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 18 Oct 2024 at 15:30, Tom Rini wrote: > > > > On Fri, Oct 18, 2024 at 12:48:31PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 18 Oct 2024 at 12:04, Tom Rini wrote: > > > > > > > > On Fri, Oct 18, 20

[PATCH v2 20/31] bootstd: Maintain a list of images

We want to keep track of images which are loaded, or those which could perhaps be loaded. This will make it easier to manage memory allocation, as well as permit removal of the EFI set_efi_bootdev() feature. Add a list of these, attached to the bootflow. For now the list is empty. Signed-off-by:

[PATCH v2 19/31] bootstd: cros: Correct the x86-setup address

This should really use an address rather than the buffer. Update it in the command. Signed-off-by: Simon Glass --- (no changes since v1) cmd/bootflow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/bootflow.c b/cmd/bootflow.c index 5f656814b29..3e9769e0d42 100644 --

[PATCH v2 26/31] boot: Update extlinux pxe_getfile_func() to include type

Add a file-type parameter to this function and update all users. Add a proper comment to the function which we are here. This will allow tracking of the file types loaded by the extlinux bootmeth. Signed-off-by: Simon Glass --- Changes in v2: - Update to use a new image-type enum in bootflow.h

[PATCH v2 17/31] test: Drop the duplicate line in setup_bootmenu_image()

The mkimage call is done twice. Remove the duplicate. Signed-off-by: Simon Glass --- (no changes since v1) test/py/tests/test_ut.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/py/tests/test_ut.py b/test/py/tests/test_ut.py index 39aa1035e34..9166c8f6b6e 100644 --- a/test/py/tests

[PATCH v2 29/31] bootstd: Avoid showing an invalid buffer address

When the buffer address is not set, say so, rather than showing an address which looks very strange, on sandbox. Signed-off-by: Simon Glass --- (no changes since v1) cmd/bootflow.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmd/bootflow.c b/cmd/bootflow.c index 3e

[PATCH v2 02/31] alist: Add a comment for alist_init_struct()

Comment this macro so that it is clear how to use it. Signed-off-by: Simon Glass --- (no changes since v1) include/alist.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/alist.h b/include/alist.h index 0343946bc4a..a727f1c7dfa 100644 --- a/include/alist.h +++ b/include/alist

[PATCH v2 07/31] alist: Add a way to efficiently filter an alist

Unlike linked lists, it is inefficient to remove items from an alist, particularly if it is large. If most items need to be removed, then the time-complexity approaches O(n2). Provide a way to do this efficiently, by working through the alist once and copying elements down. Signed-off-by: Simon G

[PATCH v2 05/31] alist: Add for-loop helpers

Add some macros which permit easy iteration through an alist, similar to those provided by the 'list' implementation. Signed-off-by: Simon Glass --- (no changes since v1) include/alist.h | 50 lib/alist.c | 7 + test/lib/alist.c | 74

[PATCH v2 04/31] alist: Add a way to get the next element

Add a new function which returns the next element after the one provided, if it exists in the list. Signed-off-by: Simon Glass --- (no changes since v1) include/alist.h | 34 +++ lib/alist.c | 21 +++ test/lib/alist.c | 52 +

[PATCH v2 06/31] alist: Add a function to empty the list

Sometimes it is useful to empty the list without de-allocating any of the memory used, e.g. when the list will be re-populated immediately afterwards. Add a new function for this. Signed-off-by: Simon Glass --- (no changes since v1) include/alist.h | 7 +++ lib/alist.c | 5 +

[PATCH v2 08/31] alist: Add maintainer

Add myself as maintainer of alist Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to put myself as maintainer of alist MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 573403734b2..65e21ba9965 100644 --- a/MAINTAINERS +++ b/MA

[PATCH v2 03/31] alist: Expand the comment for alist_get()

Add a better description for this macro. Signed-off-by: Simon Glass --- (no changes since v1) include/alist.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/alist.h b/include/alist.h index a727f1c7dfa..2c78ede201e 100644 --- a/include/alist.h +++ b/include/al

[PATCH v2 10/31] test: boot: Use a consistent name for the script bootmeth

In the bootflow tests the script bootmeth is bound with the name bootmeth_script whereas the others have a name without the bootmeth_ prefix. Adjust it to be the same. Signed-off-by: Simon Glass --- (no changes since v1) test/boot/bootflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH v2 01/31] alist: Mention the error condition in alist_add_placeholder()

Update the function comment to note that this function can return NULL if it runs out of memory. Signed-off-by: Simon Glass --- (no changes since v1) include/alist.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/alist.h b/include/alist.h index 68d268f01af..03

[PATCH v2 13/31] bootstd: Add a function to get bootstd only if available

Provide a function which is safe to call in the 'unbind' path, which returns the bootstd priv data if available. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootstd-uclass.c | 11 +++ include/bootstd.h | 17 + 2 files changed, 28 insertions(+) diff --

[PATCH v2 14/31] bootstd: Drop the bootdev-specific list of bootflows

This list is only used by two functions, which can be updated to iterate through the global list. Take this approach, which allows the bootdev list to be dropped. Overall this makes the code slightly more complicated, but will allow moving the bootflow list into an alist Signed-off-by: Simon Glas

[PATCH v2 12/31] bootstd: Move bootflow-clearing to bootstd

This relates to more than just the bootdev, since there is a global list of bootflows. Move the function to the bootstd file and rename it. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootdev-uclass.c | 19 +-- boot/bootstd-uclass.c | 15 +++ cmd/bootf

[PATCH v2 15/31] bootstd: Move the bootflow list into an alist

Use an alist for this data structure as it is somewhat simpler to manage. This means that bootstd holds a simple list of bootflow structs and can drop it at will, without chasing down lists. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootdev-uclass.c | 47 +--

[PATCH v2 11/31] bootstd: Move bootflow-adding to bootstd

This relates to more than just the bootdev, since there is a global list of bootflows. Move the function to the bootstd file and rename it. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootdev-uclass.c | 25 - boot/bootstd-uclass.c | 25

[PATCH v2 09/31] dm: core: Add a function to see if a device exists

All the uclass functions for finding a device end up creating a uclass if it doesn't exist. Add a function which instead returns NULL in this case. This is useful when in the 'unbind' path, since we don't want to undo any unbinding which has already happened. Signed-off-by: Simon Glass --- (no

[PATCH v2 31/31] bootstd: Add a simple command to list images

Add a new 'bootstd images' command, which lists the images which have been loaded. Update some existing tests to use it. Provide some documentation about images in general and this command in particular. Use a more realistic kernel command-line to make the test easier to follow. Signed-off-by: S

[PATCH v7 0/7] efi: Add a test for EFI bootmeth

The test coverage for the EFI bootmeth is incomplete since it does not actually boot the application. This series creates a simple test for this purpose. It includes a few patches to make this work: - Revert of an unreviewed patch to change the sandbox efi filename - Hang in sandbox virtio due to

[PATCH v2 25/31] bootmeth_efi: Check the filename-allocation in the network path

If the filename cannot be set we should give up. Add the missing error check. Signed-off-by: Simon Glass --- Changes in v2: - Change the tag to bootmeth_efi boot/bootmeth_efi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boot/bootmeth_efi.c b/boot/bootmeth_efi.c index e8109e19bcb..1f

[PATCH v2 30/31] bootstd: Update cros bootmeth to record images

Record images loaded by this bootmeth. Signed-off-by: Simon Glass --- Changes in v2: - Update to use a new image-type enum in bootflow.h boot/bootmeth_cros.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/boot/bootmeth_cros.c b/boot/bootmeth_cros.c index 18

[PATCH v2 24/31] bootmeth: Update the read_file() method to include a type

We want to record the type of each file which is loaded. Add an new parameter for this, to the read_file() method. Update all users. Make bootmeth_common_read_file() store information about the image that is read. Signed-off-by: Simon Glass --- Changes in v2: - Update to use a new image-type en

[PATCH v2 28/31] Update bootmeth_alloc_other() to record images

Update this function to add the image to the list. Signed-off-by: Simon Glass --- Changes in v2: - Update to use a new image-type enum in bootflow.h boot/bootmeth-uclass.c | 15 ++- boot/bootmeth_script.c | 4 ++-- include/bootmeth.h | 3 ++- 3 files changed, 18 insertions(+)

[PATCH v2 27/31] boot: Update pxe bootmeth to record images

Record images loaded by this bootmeth. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootmeth_pxe.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/boot/bootmeth_pxe.c b/boot/bootmeth_pxe.c index b2873075ba5..d7b30d1c745 100644 --- a/boot/bootmeth

[PATCH v2 23/31] bootmeth_efi: Simplify reading files by using the common function

The efiload_read_file() does similar things to a common function, so update it to use that instead. Signed-off-by: Simon Glass --- Changes in v2: - Change the tag to bootmeth_efi boot/bootmeth_efi.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/boot/bootmeth_e

[PATCH v7 6/7] test: efi: boot: Set up an image suitable for EFI testing

Create a new disk for use with tests, which contains the new 'testapp' EFI app specifically intended for testing the EFI loader. Attach it to the USB device, since most testing is currently done with mmc. Initially this image will be used to test the EFI bootmeth. Fix a stale comment in prep_mmc

[PATCH v7 7/7] test: efi: boot: Add a test for the efi bootmeth

Add a simple test of booting with the EFI bootmeth, which runs the app and checks that it can call 'exit boot-services' (to check that all the device-removal code doesn't break anything) and then exit back to U-Boot. This uses a disk image containing the testapp, ready for execution by sandbox whe

[PATCH v7 2/7] Revert "efi_loader: correctly identify binary name"

This patch was applied without sandbox review. It has changed how sandbox works and the original author has not been willing to discuss alternatives. This reverts commit 3a0654ecd0d6a39406e6fe91f7a40ce589594ae9. Signed-off-by: Simon Glass --- Changes in v7: - Add a revert of the un-reviewed pat

[PATCH v7 4/7] efi_loader: Add a test app

Add a simple app to use for testing. This is intended to do whatever it needs to for testing purposes. For now it just prints a message and exits boot services. There was a considerable amount of discussion about whether it is OK to call exit-boot-services and then return to U-Boot. This is not no

Re: [PATCH v4 0/5] Adjust initial EFI memory-allocation to be in the U-Boot region

On Sat, Oct 19, 2024 at 05:51:03AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 17 Oct 2024 at 17:35, Tom Rini wrote: > > > > On Thu, Oct 17, 2024 at 05:22:52PM -0600, Simon Glass wrote: > > > Hi Ilias, > > > > > > On Tue, 15 Oct 2024 at 07:32, Ilias Apalodimas > > > wrote: > > > > > > > > On

Re: [PATCH v3 03/15] efi: memory: use the lmb API's for allocating and freeing memory

On Thu, Oct 17, 2024 at 05:23:08PM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 15 Oct 2024 at 13:05, Tom Rini wrote: > > > > On Tue, Oct 15, 2024 at 07:10:27AM -0600, Simon Glass wrote: [snip] > > > Even if efi_init_obj_list(), I don't like treating U-Boot's memory as > > > a stack to just g

Re: [PATCH v7 6/7] test: efi: boot: Set up an image suitable for EFI testing

On Sat, Oct 19, 2024 at 09:24:33AM -0600, Simon Glass wrote: > Create a new disk for use with tests, which contains the new 'testapp' > EFI app specifically intended for testing the EFI loader. > > Attach it to the USB device, since most testing is currently done with > mmc. > > Initially this i

[PATCH 1/1] efi_selftest: fix typo 'got languages' in HII test

%s/got languages are/Available languages:/ Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_hii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_selftest/efi_selftest_hii.c b/lib/efi_selftest/efi_selftest_hii.c index f219c0120a3..c363df466dc 1006

[PATCH 1/1] efi_selftest: make HII test data static

Variables that are only used locally in a module should not be exported. * Make the HII test data variables static. * Remove unused GUIDs. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_hii_data.c | 28 1 file changed, 4 insertions(+), 24 deletions

Re: [PATCH 23/34] bootstd: Maintain a list of images

Hi Tom, On Fri, 18 Oct 2024 at 15:30, Tom Rini wrote: > > On Fri, Oct 18, 2024 at 12:48:31PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 18 Oct 2024 at 12:04, Tom Rini wrote: > > > > > > On Fri, Oct 18, 2024 at 11:20:52AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Fri

Re: [PATCH 6/6] doc: uefi: Describe UEFI HTTPs boot

On Fri, 18 Oct 2024 at 08:23, Ilias Apalodimas wrote: > > We now can use a combination og lwIP & mbedTLS and download from > https://. Describe the config options needed to enable it as well > as some limitations > > Signed-off-by: Ilias Apalodimas > --- > doc/develop/uefi/uefi.rst | 45

Re: [PATCH 4/6] net: lwip: Enable https:// support for wget

Hi Ilias, On Fri, 18 Oct 2024 at 08:23, Ilias Apalodimas wrote: > > With the recent changes of lwip & mbedTLS we can now download from > https:// urls instead of just http://. > Adjust our wget lwip version parsing to support both URLs. > While at it adjust the default TCP window for QEMU since h

Re: [PATCH 1/1] efi_selftest: make HII test data static

On Sat, 19 Oct 2024 at 03:04, Heinrich Schuchardt wrote: > > Variables that are only used locally in a module should not be exported. > > * Make the HII test data variables static. > * Remove unused GUIDs. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_hii_data.c |

Re: [PATCH 1/1] efi_selftest: fix typo 'got languages' in HII test

On Sat, 19 Oct 2024 at 02:50, Heinrich Schuchardt wrote: > > %s/got languages are/Available languages:/ > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_hii.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass > diff --git a/lib/efi

Re: [PATCH 1/1] efi_loader: fix CONFIG_EFI_HTTP dependencies

Hi Heinrich, On Sat, 19 Oct 2024 at 05:00, Heinrich Schuchardt wrote: > > CONFIG_CMD_DNS and CONFIG_CMD_WGET depend on CONFIG_CMD_NET. > CONFIG_CMD_NET depends on CONFIG_NET or CONFIG_NET_LWIP. > > We shall only enable CONFIG_EFI_HTTP if there is network support. > We have to select CONFIG_CMD_NE

Re: [PATCH 5/6] configs: Enable htts for wget on qemu arm64

On Fri, 18 Oct 2024 at 08:23, Ilias Apalodimas wrote: > > QEMU already has an lwip variant of a defconfig. That defconfig > is also configured with mbedTLS by default. So let's enable the > remaining config options to enable wget for https:// as well > and test that codepath in the CI > > Signed-o

Re: [PATCH 1/3] rockchip: block: simplify rkmtd driver

Hi Johan, On Fri, 18 Oct 2024 at 07:33, Johan Jonker wrote: > > > > On 10/18/24 03:30, Heinrich Schuchardt wrote: > > By using blk_create_devicef() instead of blk_create_devicef() the driver > > can be simplified and brought into line with other block device drivers. > > > > Signed-off-by: Heinri

Re: [PATCH v4 0/5] Adjust initial EFI memory-allocation to be in the U-Boot region

Hi Tom, On Thu, 17 Oct 2024 at 17:35, Tom Rini wrote: > > On Thu, Oct 17, 2024 at 05:22:52PM -0600, Simon Glass wrote: > > Hi Ilias, > > > > On Tue, 15 Oct 2024 at 07:32, Ilias Apalodimas > > wrote: > > > > > > On Tue, 15 Oct 2024 at 16:26, Simon Glass wrote: > > > > > > > > Hi Ilias, > > > > >

Re: [PATCH v1 1/1] x86: cpu: Describe board final hooks in the header

On Fri, 18 Oct 2024 at 09:56, Andy Shevchenko wrote: > > The new two declarations board_final_init() and board_final_cleanup() > need a description. Add it here. > > Suggested-by: Simon Glass > Signed-off-by: Andy Shevchenko > --- > arch/x86/include/asm/cpu.h | 13 + > 1 file change

[PATCH v7 3/7] efi_loader: sandbox: Use a different filename for sandbox

Sandbox is a separate architecture in U-Boot. We want to create binaries which can run no matter what host architecture is in use. Create a special filename for sandbox, to avoid needing different code paths when creating the file in CI. Signed-off-by: Simon Glass --- Changes in v7: - Just do t

[PATCH v7 5/7] sandbox: virtio: Disable the sandbox virtio blk device

This is not implemented so cannot actually be used to read blocks. Disable it until it is implemented, to avoid causing a hang with EFI, which probes every available BLK device. Signed-off-by: Simon Glass Issue: https://source.denx.de/u-boot/u-boot/-/issues/37 --- (no changes since v6) Changes

Re: [PATCH v7 5/7] sandbox: virtio: Disable the sandbox virtio blk device

On Sat, Oct 19, 2024 at 09:24:32AM -0600, Simon Glass wrote: > This is not implemented so cannot actually be used to read blocks. > Disable it until it is implemented, to avoid causing a hang with EFI, > which probes every available BLK device. > > Signed-off-by: Simon Glass > Issue: https://sou

Re: [PATCH v4 5/5] efi: Keep early allocations to the U-Boot region

Hi Ilias, On Wed, 16 Oct 2024 at 08:02, Ilias Apalodimas wrote: > > [...] > > > > > + > > > > +/** > > > > + * efi_memory_coop() - Allow EFI to use all available memory > > > > + * > > > > + * Up until this function is called, only a small portion of memory is > > > > available > > > > + * for u

[PATCH v2 16/31] test: Expand implementation of ut_list_has_dm_tests()

This function assumes that all tests in a suite are being run. This means that it can sometimes call dm_test_restore() when it should not. The impact of this is that it is not possible, for example, to run 'ut bootstd bootflow_cros' and then check the state of bootstd afterwards, since all devices

[PATCH] ARM: imx: soc: Select default TEXT_BASE for i.MX6

Select default U-Boot and SPL text base for the i.MX6 SoC. The U-Boot and SPL text base is picked as the one used by various i.MX6 boards. Update all the boards. Signed-off-by: Marek Vasut --- Cc: "Eric Bénard" Cc: "Huan 'Kitty' Wang" Cc: "Marek Behún" Cc: "NXP i.MX U-Boot Team" Cc: "Sébastie

Re: [PATCH v2 00/31] bootstd: Support recording images

On Sat, Oct 19, 2024 at 09:21:40AM -0600, Simon Glass wrote: > This series provides a way to keep track of the images used in bootstd, > including the type of each image. > > At present this is sort-of handled by struct bootflow but in quite an > ad-hoc way. The structure has become quite large a

Re: [PATCH] ARM: imx: soc: Select default TEXT_BASE for i.MX6

On 10/20/24 2:27 AM, Tom Rini wrote: On Sun, Oct 20, 2024 at 12:09:03AM +0200, Marek Vasut wrote: Select default U-Boot and SPL text base for the i.MX6 SoC. The U-Boot and SPL text base is picked as the one used by various i.MX6 boards. Update all the boards. Signed-off-by: Marek Vasut [snip

Re: [PATCH] ARM: imx: soc: Select default TEXT_BASE for i.MX6

On Sun, Oct 20, 2024 at 04:25:38AM +0200, Marek Vasut wrote: > On 10/20/24 2:27 AM, Tom Rini wrote: > > On Sun, Oct 20, 2024 at 12:09:03AM +0200, Marek Vasut wrote: > > > > > Select default U-Boot and SPL text base for the i.MX6 SoC. The U-Boot > > > and SPL text base is picked as the one used by

Re: [PATCH 1/1] configs: visionfive2: enable CONFIG_CMD_ERASEENV

Hi, On Sat, Oct 19, 2024 at 1:31 AM Heinrich Schuchardt wrote: > > When moving from vendor U-Boot to the upstream U-Boot it is necessary to > reset the environment. > > Provide the 'env erase' sub-command. > > Signed-off-by: Heinrich Schuchardt > --- > configs/starfive_visionfive2_defconfig | 1

[PATCH v2 2/2] board: rockchip: Add support for rk3588 GenBook

Add support for Cool Pi GenBook, it works as a carrier board connect with CM5 SOM. Specification: - Rockchip RK3588 - LPDDR5X 8/32 GB - eMMC 64 GB - HDMI Type A out x 1 - USB 3.0 Host x 1 - USB-C 3.0 with DisplayPort AltMode - PCIE M.2 E Key for RTL8852BE Wireless connection - PCIE M.2 M Key for N

[PATCH v2 1/2] arm64: dts: rockchip: Add support for rk3588 based Cool Pi CM5 GenBook

Cool Pi CM5 GenBook works as a carrier board connect with CM5 [0]. Specification: - Rockchip RK3588 - LPDDR5X 8/32 GB - eMMC 64 GB - HDMI Type A out x 1 - USB 3.0 Host x 1 - USB-C 3.0 with DisplayPort AltMode - PCIE M.2 E Key for RTL8852BE Wireless connection - PCIE M.2 M Key for NVME connection -

[PATCH v2 0/2] Add support for Cool Pi GenBook

Support for Cool Pi GenBook is landing Linux 6.12-rc1, so also add the support for u-boot here. Changes in v2: - Cherry pick it from https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git - split the dts to a separate commit - rename to genbook_cm5_rk3588 - move readme

[PATCH 1/1] efi_loader: fix CONFIG_EFI_HTTP dependencies

CONFIG_CMD_DNS and CONFIG_CMD_WGET depend on CONFIG_CMD_NET. CONFIG_CMD_NET depends on CONFIG_NET or CONFIG_NET_LWIP. We shall only enable CONFIG_EFI_HTTP if there is network support. We have to select CONFIG_CMD_NET. Fixes: d7d07a8b508b ("efi_loader: support boot from URI device path") Signed-of

[PATCH 1/1] cmd: simplify network definitions in Makefile

/Makefile already adds lib include paths to UBOOTINCLUDE. There is no point in adding the same paths again. Clearly separate the lines relating to NET and to NET_LWIP. Signed-off-by: Heinrich Schuchardt --- cmd/Makefile | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --g

Re: Please pull u-boot-dm (take 2)

On Fri, Oct 18, 2024 at 02:14:11PM -0600, Simon Glass wrote: > Hi Tom, > > The following changes since commit 8ab2178de069194d2eed8fe1b90db7e12cf032bb: > > Merge tag 'u-boot-imx-master-20241018a' of > https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2024-10-18 > 09:05:04 -0600) > > are av

Re: [PATCH] mbedtls: fix defects in coverity scan

On Sat, Oct 19, 2024 at 10:37:38AM +0100, Peter Robinson wrote: > On Thu, 17 Oct 2024 at 00:49, Raymond Mao wrote: > > > > Fixes of unreleased buffer, deadcode and wrong variable type detected > > by coverity scan. > > > > Addresses-Coverity-ID: 510809: Resource leaks (RESOURCE_LEAK) > > Address

Re: [PATCH 00/11] boards: siemens: iot2050: SM variant, sysinfo support, fixes & cleanups

On Thu, Oct 10, 2024 at 07:55:44AM +0200, Jan Kiszka wrote: > This series depends on: > https://patchwork.ozlabs.org/project/uboot/patch/a54b501a-9a98-426c-a5ca-faf547411...@siemens.com/ > > This adds support for the new IOT2050 SM variant, introduces a sysinfo > driver which also permits SMBIOS

Re: [PATCH 1/1] efi_selftest: make HII test data static

On Sat, 19 Oct 2024 at 12:04, Heinrich Schuchardt wrote: > > Variables that are only used locally in a module should not be exported. > > * Make the HII test data variables static. > * Remove unused GUIDs. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_hii_data.c |

Re: [PATCH 1/1] efi_selftest: fix typo 'got languages' in HII test

On Sat, 19 Oct 2024 at 11:50, Heinrich Schuchardt wrote: > > %s/got languages are/Available languages:/ > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_hii.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_selftest/efi_selftest_hii.c

Re: [PATCH 1/1] efi_loader: fix CONFIG_EFI_HTTP dependencies

On Sat, 19 Oct 2024 at 14:00, Heinrich Schuchardt wrote: > > CONFIG_CMD_DNS and CONFIG_CMD_WGET depend on CONFIG_CMD_NET. > CONFIG_CMD_NET depends on CONFIG_NET or CONFIG_NET_LWIP. > > We shall only enable CONFIG_EFI_HTTP if there is network support. > We have to select CONFIG_CMD_NET. > > Fixes:

RE: [PATCH 1/1] Fixed sama5d3 dts file so PIO sections are inside pinctrl as in kernel dts

Hi Manikandan, I have tested gpio cmd option on SAMA5D3 EDS board (BTW it wasn't enabled by default in sama5d3_xplained_mmc_defconfig which is used by this board) in u-boot with the DT change as I proposed and it seems to work fine, at least it detects all the 5 GPIO ports (A-E). pinmux cmd does n

Re: [PATCH 03/10] ARM: dts: socfpga: add Mercury+ AA1 for u-boot dts

On 10/18/24 11:57 PM, Lothar Rubusch wrote: On Mon, Oct 14, 2024 at 8:42 PM Marek Vasut wrote: On 10/13/24 4:32 PM, Lothar Rubusch wrote: [...] diff --git a/arch/arm/dts/socfpga_arria10_enclustra_mercury_aa1.dts b/arch/arm/dts/socfpga_arria10_enclustra_mercury_aa1.dts new file mode 100644

Re: [PATCH] ARM: imx: soc: Select default TEXT_BASE for i.MX6

On 10/20/24 4:55 AM, Tom Rini wrote: On Sun, Oct 20, 2024 at 04:25:38AM +0200, Marek Vasut wrote: On 10/20/24 2:27 AM, Tom Rini wrote: On Sun, Oct 20, 2024 at 12:09:03AM +0200, Marek Vasut wrote: Select default U-Boot and SPL text base for the i.MX6 SoC. The U-Boot and SPL text base is picked

Re: [PATCH 02/10] ARM: socfpga: add Mercury+ AA1 SoM support

On 10/18/24 11:47 PM, Lothar Rubusch wrote: On Mon, Oct 14, 2024 at 8:42 PM Marek Vasut wrote: [...] diff --git a/board/enclustra/mercury_aa1/fpga.its b/board/enclustra/mercury_aa1/fpga.its new file mode 100644 index 00..cb42d61fbd --- /dev/null +++ b/board/enclustra/mercury_aa1/fpga

Re: [PATCH v7 2/7] Revert "efi_loader: correctly identify binary name"

> From: Simon Glass > Date: Sat, 19 Oct 2024 09:24:29 -0600 > > This patch was applied without sandbox review. It has changed how > sandbox works and the original author has not been willing to > discuss alternatives. > > This reverts commit 3a0654ecd0d6a39406e6fe91f7a40ce589594ae9. > > Signed-

Re: [PATCH 1/2] rockchip: rk356x: Implement checkboard() to print SoC variant

Hi Simon, On 2024-10-19 04:00, Simon Glass wrote: > Hi Jonas, > > On Fri, 18 Oct 2024 at 10:34, Jonas Karlman wrote: >> >> Implement checkboard() to print current SoC model, e.g. one of: >> >> SoC: RK3566 v1 >> SoC: RK3566 v2 >> SoC: RK3566T v2 >> SoC: RK3568 v2 >> SoC: RK356

[PATCH 1/5] arm64: imx: imx8mp: Enable DM regulator on DH i.MX8MP DHCOM SoM on DRC02 board

Make sure DM regulator support is enabled on this board, just like on all the other DH i.MX8MP DHCOM SoM based boards. Signed-off-by: Marek Vasut --- Cc: Andreas Geisreiter Cc: Christoph Niedermaier Cc: Fabio Estevam Cc: Quentin Schulz Cc: Sean Anderson Cc: Simon Glass Cc: Sumit Garg Cc: T

[PATCH 2/5] arm64: imx: imx8mp: Disable PCI support on DH i.MX8MP DHCOM SoM on DRC02 board

The DRC02 carrier board does not expose PCIe in any way, disable PCIe support. Signed-off-by: Marek Vasut --- Cc: Andreas Geisreiter Cc: Christoph Niedermaier Cc: Fabio Estevam Cc: Quentin Schulz Cc: Sean Anderson Cc: Simon Glass Cc: Sumit Garg Cc: Tom Rini Cc: u-b...@dh-electronics.com C

[PATCH 4/5] arm64: imx: Deduplicate DH i.MX8MP DHSOM defconfigs

Deduplicate defconfigs for all DH i.MX8MP DHSOM by factoring out the common parts into generic _dhsom_defconfig and including those using the #include preprocessor macro, which is applicable to defconfigs as well. This enables CMD_EXPORTENV on all iMX8MP DHSOM systems to be consistent with other D

[PATCH 5/5] arm64: imx: Deduplicate DH i.MX6 DHSOM defconfig

Deduplicate defconfigs for all DH i.MX6 DHSOM by including common configs/imx_dhsom_defconfig . This does introduce changes to the board configuration, namely it enables commands used on all DHSOM devices consistenty, the prompt is changed to u-boot=>, support for booting non-Linux OS which was lik

[PATCH 3/5] arm64: imx: imx8mp: Disable PCA954x I2C mux on DH i.MX8MP DRC02 and PicoITX

Neither the DRC02 nor PicoITX carrier board contains the PCA954x I2C mux chip, the chip is only present on PDK3 carrier board. Disable support for the PCA954x mux chip and I2C mux altogether on both i.MX8MP DHCOM DRC02 and PicoITX. Signed-off-by: Marek Vasut --- Cc: Andreas Geisreiter Cc: Christ

Re: [PATCH] ARM: imx: soc: Select default TEXT_BASE for i.MX6

On Sun, Oct 20, 2024 at 12:09:03AM +0200, Marek Vasut wrote: > Select default U-Boot and SPL text base for the i.MX6 SoC. The U-Boot > and SPL text base is picked as the one used by various i.MX6 boards. > Update all the boards. > > Signed-off-by: Marek Vasut [snip] > diff --git a/arch/arm/mach-