Re: [PATCH v3 02/25] mbedtls: Add script to update MbedTLS subtree

2024-06-05 Thread Ilias Apalodimas
On Tue, 4 Jun 2024 at 23:10, Andy Shevchenko wrote: > > On Fri, May 31, 2024 at 09:32:38AM +0300, Ilias Apalodimas wrote: > > On Tue, 28 May 2024 at 17:10, Raymond Mao wrote: > > > > > > lib/mbedtls/update-mbedtls-subtree.sh is a wrapper of git subtree > > > commands. > > > Usage from U-Boot top

Re: [PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)

2024-06-05 Thread Mattijs Korpershoek
Hi Quentin, Thank you for the review. On mar., juin 04, 2024 at 17:25, Quentin Schulz wrote: > Hi Mattijs, > > On 6/4/24 5:15 PM, Mattijs Korpershoek wrote: >> According to [1], we should use bootmeth when describing the >> struct bootmeth: >> >> """ >> For version 2, a new naming scheme is u

Re: [PATCH 3/9] rockchip: veyron: Add logging for power init

2024-06-05 Thread Quentin Schulz
Hi Simon, On 6/5/24 5:25 AM, Simon Glass wrote: Add better logging for power init so that CONFIG_LOG_ERROR_RETURN can be enabled. Signed-off-by: Simon Glass --- board/google/veyron/veyron.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/bo

Re: [PATCH 4/9] power: regulator: Handle autoset in regulators_enable_boot_on()

2024-06-05 Thread Quentin Schulz
Hi Simon, On 6/5/24 5:25 AM, Simon Glass wrote: With a recent change, regulators_enable_boot_on() returns an error if a regulator is already set. Check for and handle this situation. Fixes: d99fb64a98a power: regulator: Only run autoset once for each regulator Signed-off-by: Simon Glass Rev

Re: [PATCH v2 0/8] efi_loader: improve device-tree loading

2024-06-05 Thread Heinrich Schuchardt
On 29.05.24 18:30, Simon Glass wrote: Hi, On Tue, 28 May 2024 at 18:38, E Shattow wrote: Hi, On Tue, May 28, 2024 at 7:43 AM Heinrich Schuchardt wrote: In U-Boot EFI boot options can already specify both an EFI binary and an initrd. With this series we can additionally define the matching

[PATCH v1] arm: dts: k3-am625-verdin: add combined binaries

2024-06-05 Thread Andrejs Cainikovs
From: Andrejs Cainikovs Add combined binaries for all Verdin AM62 variants. These binaries can be used to flash the U-Boot via single binary instead of few as it is done at the moment. Signed-off-by: Andrejs Cainikovs --- .../dts/k3-am625-verdin-wifi-dev-binman.dtsi | 68 +++

Re: [PATCH 8/9] regulator: rk8xx: Fix incorrect parameter

2024-06-05 Thread Quentin Schulz
Hi Simon, On 6/5/24 5:25 AM, Simon Glass wrote: A recent change introduced a bug whereby a PMIC device is used in place of the regulator device. Fix it. Good catch, but the suggested fix is only fixing one of those bugs, I've introduced quite a few actually. I'm sending a patch series to f

Re: [PATCH v3 6/7] tools: add genguid tool

2024-06-05 Thread Ilias Apalodimas
Hi Heinrich On Wed, 5 Jun 2024 at 09:36, Heinrich Schuchardt wrote: > > On 5/31/24 15:50, Caleb Connolly wrote: > > Add a tool that can generate GUIDs that match those generated internally > > by U-Boot for capsule update fw_images. > > > > Dynamic UUIDs in U-Boot work by taking a namespace UUID

Re: [PATCH v3 02/25] mbedtls: Add script to update MbedTLS subtree

2024-06-05 Thread Andy Shevchenko
On Wed, Jun 05, 2024 at 10:11:04AM +0300, Ilias Apalodimas wrote: > On Tue, 4 Jun 2024 at 23:10, Andy Shevchenko > wrote: > > On Fri, May 31, 2024 at 09:32:38AM +0300, Ilias Apalodimas wrote: > > > On Tue, 28 May 2024 at 17:10, Raymond Mao wrote: ... > > > > +if ! git remote get-url mbedtls

Re: [PATCH v3 03/25] mbedtls: add mbedtls into the build system

2024-06-05 Thread Andy Shevchenko
On Tue, Jun 04, 2024 at 05:50:08PM -0400, Raymond Mao wrote: > On Tue, 4 Jun 2024 at 16:17, Andy Shevchenko < > andriy.shevche...@linux.intel.com> wrote: > > On Tue, May 28, 2024 at 07:09:14AM -0700, Raymond Mao wrote: ... > > > This patch series requires mbedtls git repo to be added as a > > > s

[PATCH 0/3] rockchip: rk8xx: fix broken [np]ldo callbacks

2024-06-05 Thread Quentin Schulz
), 27 deletions(-) --- base-commit: c0ea27bccfb7d2d37fd36806ac2a2f7389099420 change-id: 20240605-pmic-rk8xx-52f2286be334 Best regards, -- Quentin Schulz

[PATCH 1/3] regulator: rk8xx: fix incorrect device used for _ldo_[sg]et_suspend_value

2024-06-05 Thread Quentin Schulz
From: Quentin Schulz _ldo_get_suspend_value and _ldo_set_suspend_value get passed the parent of the regulator (so the pmic) as first argument, therefore this udevice should be used for pmic_* callbacks instead of using the parent of the pmic. To avoid further confusion, let's rename the argument

[PATCH 2/3] regulator: rk8xx: pass pmic udevice instead of regulator to all internal functions

2024-06-05 Thread Quentin Schulz
From: Quentin Schulz For the sake of consistency, make all internal (starting with _) functions expect a pmic udevice instead of a regulator udevice. Signed-off-by: Quentin Schulz --- drivers/power/regulator/rk8xx.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-)

[PATCH 3/3] regulator: rk8xx: clarify operator precedence

2024-06-05 Thread Quentin Schulz
From: Quentin Schulz My linter complains that the order isn't clear enough so let's put parentheses around the ternary condition to make it happy. Signed-off-by: Quentin Schulz --- drivers/power/regulator/rk8xx.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-

Re: [PATCH v3 03/25] mbedtls: add mbedtls into the build system

2024-06-05 Thread Ilias Apalodimas
Hi Andy, On Wed, 5 Jun 2024 at 12:30, Andy Shevchenko wrote: > > On Tue, Jun 04, 2024 at 05:50:08PM -0400, Raymond Mao wrote: > > On Tue, 4 Jun 2024 at 16:17, Andy Shevchenko < > > andriy.shevche...@linux.intel.com> wrote: > > > On Tue, May 28, 2024 at 07:09:14AM -0700, Raymond Mao wrote: > > ...

[PATCH v7] test/py: net_boot: Add test cases for net boot

2024-06-05 Thread Love Kumar
Add tests for booting image using tftpboot/pxe boot commands, tftpboot boot case loads the FIT image into DDR and boots using bootm command whereas pxe boot cases downloads the pxe configuration file from the TFTP server and interprets it to boot the images mentioned in the pxe configurations file.

[PATCH 0/7] Add the USB5744 hub driver as per new DT binding

2024-06-05 Thread Venkatesh Yadav Abbarapu
Add the usb5744/usb2744 hub driver which does the reset gpio toggling and the i2c initialization sequence. Tested the USB5744/USB2744 usb hub for usb0, usb1 with the DT nodes on KR260 board. Venkatesh Yadav Abbarapu (7): usb: onboard-hub: Add reset-gpio support usb: onboard-hub: Fix the retur

[PATCH 1/7] usb: onboard-hub: Add reset-gpio support

2024-06-05 Thread Venkatesh Yadav Abbarapu
As part of the reset, sets the direction of the pin to output before toggling the pin. Delay of millisecond is added in between low and high to meet the setup and hold time requirement of the reset. Signed-off-by: Venkatesh Yadav Abbarapu --- common/usb_onboard_hub.c | 44 +++

[PATCH 2/7] usb: onboard-hub: Fix the return values of regulator APIs

2024-06-05 Thread Venkatesh Yadav Abbarapu
Use the regulator API's only if the config DM_REGULATOR is enabled. Don't error out if there is no vdd regulator supply, as these are optional properties. Signed-off-by: Venkatesh Yadav Abbarapu --- common/usb_onboard_hub.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletio

[PATCH 3/7] usb: onboard-hub: add support for Microchip USB5744

2024-06-05 Thread Venkatesh Yadav Abbarapu
Add support for the Microchip USB5744 USB3.0 and USB2.0 Hub. The usb5744 driver trigger hub reset signal after soft reset. The usb5744 hub need to reset after the phy initialization, which toggles the gpio. Signed-off-by: Venkatesh Yadav Abbarapu --- common/usb_onboard_hub.c | 10 ++ 1 f

[PATCH 4/7] usb: onboard-hub: Add i2c initialization for usb5744 hub

2024-06-05 Thread Venkatesh Yadav Abbarapu
Add i2c initialization hook and set usb5744 platform data with function having required i2c initialization sequence. Apart from the USB command attach, prevent the hub from suspend. when the “USB Attach with SMBUS (0xAA56)” command is issued to the hub, the hub is getting enumerated and then it pu

[PATCH 6/7] configs: zynqmp_kria: Enable the USB onboard hub

2024-06-05 Thread Venkatesh Yadav Abbarapu
USB host support on ZYNQMP KRIA SOM needs onboard USB hub driver for handling reset GPIO and for i2c initialization sequence. Signed-off-by: Venkatesh Yadav Abbarapu --- configs/xilinx_zynqmp_kria_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/xilinx_zynqmp_kria_defconfig

[PATCH 5/7] usb: onboard-hub: Bail out if peer hub is already probed

2024-06-05 Thread Venkatesh Yadav Abbarapu
Many physical hub chips include multiple logical hubs to handle both USB and 2 and 3. Both logical hubs will then match the onboard hub driver, which means it will end up with two driver instances trying to control the reset GPIO that is only present once on the physical chip. The reference for th

[PATCH 7/7] arm64: zynqmp: Update the usb5744 hub node as per binding

2024-06-05 Thread Venkatesh Yadav Abbarapu
Updating the usb5744 hub node as per the latest upstream DT binding https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ tree/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml?h=v6.8.8 Signed-off-by: Venkatesh Yadav Abbarapu --- arch/arm/dts/zynqmp-sck-kr-g-revA.dtso | 48

Re: [PATCH v3 03/25] mbedtls: add mbedtls into the build system

2024-06-05 Thread Andy Shevchenko
On Wed, Jun 05, 2024 at 12:35:37PM +0300, Ilias Apalodimas wrote: > On Wed, 5 Jun 2024 at 12:30, Andy Shevchenko > wrote: > > On Tue, Jun 04, 2024 at 05:50:08PM -0400, Raymond Mao wrote: > > > On Tue, 4 Jun 2024 at 16:17, Andy Shevchenko < > > > andriy.shevche...@linux.intel.com> wrote: > > > > On

Re: Several potential vulnerabilities in the filesystem

2024-06-05 Thread jianqiang wang
Hi, I do have the crafted image. payload_00500, payload_00763, payload_00846 can be used to reproduce 1,2,3 vulnerabilities respectively. Each image is a hard drive file and the vulnerabilities can be triggered by performing the following operations: struct udevice *dev; uclass_first_de

Re: [PATCH 4/9] power: regulator: Handle autoset in regulators_enable_boot_on()

2024-06-05 Thread Jonas Karlman
Hi Simon, On 2024-06-05 05:25, Simon Glass wrote: > With a recent change, regulators_enable_boot_on() returns an error if a > regulator is already set. Check for and handle this situation. I am guessing this is being hit because of the call in veyron_init() ? regulators_enable_boot_on() is also

Re: [PATCH 7/9] rockchip: bob: kevin: Disable dcache in SPL

2024-06-05 Thread Jonas Karlman
Hi Simon, On 2024-06-05 05:25, Simon Glass wrote: > This causes a hang, so disable it. When I initially tested this on multiple boards there was some boards that also hanged, that turned out to be an issue in one of the drivers. If I remember correctly such hang was related to a null pointer der

Re: [PATCH] cmd: bcb: Fix bcb compilation when CONFIG_CMD_BCB=n

2024-06-05 Thread Guillaume LA ROQUE
hi, Le 03/06/2024 à 11:04, Mattijs Korpershoek a écrit : commit dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields") introduced the bcb_get() function. When CONFIG_CMD_BCB=n, that function is stubbed. The stubbed function has a wrong prototype: value_size arg is missing.

Re: [PATCH v2 1/2] bootstd: Fix a handful of doc typos in bootmeth

2024-06-05 Thread Guillaume LA ROQUE
Hi, Le 04/06/2024 à 17:15, Mattijs Korpershoek a écrit : Fix some trivial typos found by browsing the code. Done with flyspell. Reviewed-by: Quentin Schulz Signed-off-by: Mattijs Korpershoek --- include/bootmeth.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --

Re: Several potential vulnerabilities in the filesystem

2024-06-05 Thread Gao Xiang
Hi Jianqiang, On 2024/6/5 19:00, jianqiang wang wrote: Hi, I do have the crafted image. payload_00500, payload_00763, payload_00846 can be used to reproduce 1,2,3 vulnerabilities respectively. Each image is a hard drive file and the vulnerabilities can be triggered by performing the following

Re: [PATCH 3/3] regulator: rk8xx: clarify operator precedence

2024-06-05 Thread Mattijs Korpershoek
Hi Quentin, Thank you for the patch. On mer., juin 05, 2024 at 11:33, Quentin Schulz wrote: > From: Quentin Schulz > > My linter complains that the order isn't clear enough so let's put > parentheses around the ternary condition to make it happy. > > Signed-off-by: Quentin Schulz Reviewed-by

Re: [PATCH] cmd: bcb: Fix bcb compilation when CONFIG_CMD_BCB=n

2024-06-05 Thread Dmitrii Merkurev
Thank you and sorry for missing that Reviewed-by: Dmitrii Merkurev

Re: Several potential vulnerabilities in the filesystem

2024-06-05 Thread jianqiang wang
Hi Xiang, I just checked the second crash, the patch can solve this issue. Did you also look into the other two issues? Best Jianqiang Gao Xiang 于2024年6月5日周三 13:18写道: > > Hi Jianqiang, > > On 2024/6/5 19:00, jianqiang wang wrote: > > Hi, > > > > I do have the crafted image. > > > > payload_0050

Re: Several potential vulnerabilities in the filesystem

2024-06-05 Thread Gao Xiang
On 2024/6/5 19:26, jianqiang wang wrote: Hi Xiang, I just checked the second crash, the patch can solve this issue. Did you also look into the other two issues? I'm only responsible for the EROFS project. Thanks, Gao Xiang Best Jianqiang Gao Xiang 于2024年6月5日周三 13:18写道: Hi Jianqiang,

Re: Several potential vulnerabilities in the filesystem

2024-06-05 Thread jianqiang wang
Could you please forward the issues to whoever is responsible for them? Gao Xiang 于2024年6月5日周三 13:35写道: > > > > On 2024/6/5 19:26, jianqiang wang wrote: > > Hi Xiang, > > > > I just checked the second crash, the patch can solve this issue. Did > > you also look into the other two issues? > > I'm

Re: [PATCH v3 1/7] lib: uuid: add UUID v5 support

2024-06-05 Thread Caleb Connolly
Hi Simon, On 05/06/2024 04:13, Simon Glass wrote: Hi Caleb, On Fri, 31 May 2024 at 07:50, Caleb Connolly wrote: Add support for generating version 5 UUIDs, these are determistic and work spelling by hashing a "namespace" UUID together with some unique data. One intended usecase is to all

Re: [PATCH v3 2/7] efi: add a helper to generate dynamic UUIDs

2024-06-05 Thread Caleb Connolly
On 05/06/2024 07:52, Heinrich Schuchardt wrote: On 5/31/24 15:50, Caleb Connolly wrote: Introduce a new helper efi_capsule_update_info_gen_ids() which populates the capsule update fw images image_type_id field. This allows for determinstic UUIDs to be used that can scale to a large number of

Re: [PATCH v3 6/7] tools: add genguid tool

2024-06-05 Thread Caleb Connolly
On 05/06/2024 11:25, Ilias Apalodimas wrote: Hi Heinrich On Wed, 5 Jun 2024 at 09:36, Heinrich Schuchardt wrote: On 5/31/24 15:50, Caleb Connolly wrote: Add a tool that can generate GUIDs that match those generated internally by U-Boot for capsule update fw_images. Dynamic UUIDs in U-Boo

Re: [PATCH v3 4/8] mach-snapdragon: implement capsule update support

2024-06-05 Thread Caleb Connolly
Hi Sumit, +/** + * qcom_configure_capsule_updates() - Configure the DFU string for capsule updates + * + * U-Boot is flashed to the boot partition on Qualcomm boards. In most cases there + * are two boot partitions, boot_a and boot_b. As we don't currently support doing + * full A/B updates, w

RE: [PATCH v1 0/4] Sync StarFive JH7110 clock and reset dt-bindings with Linux

2024-06-05 Thread Hal Feng
> On 04.06.24 04:32, E Shattow wrote: > Hi Hal, > > Instead of manual dt-bindings sync can we please adopt OF_UPSTREAM for > JH7110 ? Yeah, I will try to do it recently, although I am not sure whether the U-Boot drivers and Linux drivers are compatible so that they can use the same DT. Best rega

Re: [PATCH v5 0/3] Introduce mtdblock device

2024-06-05 Thread Alexey Romanov
Hi Simon, your message is empty. On Tue, Jun 04, 2024 at 08:13:34PM -0600, Simon Glass wrote: > Hi Alexey, > > On Mon, Jun 3, 2024, 09:57 Alexey Romanov > wrote: > > > Hello! > > > > This series adds support for the mtdblock device, which > > allows to read/write data block by block. For exampl

Re: [PATCH v3 0/8] qcom: implement capsule updates

2024-06-05 Thread Caleb Connolly
Hi Sumit, On 05/06/2024 07:31, Sumit Garg wrote: Hi Caleb, On Mon, 3 Jun 2024 at 18:19, Caleb Connolly wrote: Hook up support for capsule updates loaded from disk on Qualcomm platforms. Most Qualcomm devices have an A/B partition layout, with most partitions duplicated. The metadata on whic

Re: [PATCH 0/3] rockchip: rk8xx: fix broken [np]ldo callbacks

2024-06-05 Thread Anand Moon
ator: rk8xx: clarify operator precedence > > drivers/power/regulator/rk8xx.c | 54 > - > 1 file changed, 27 insertions(+), 27 deletions(-) > --- > base-commit: c0ea27bccfb7d2d37fd36806ac2a2f7389099420 > change-id: 20240605-pmic-rk8xx-52f2286be334 > > Best regards, > -- > Quentin Schulz >

Re: [PATCH v5 0/3] Introduce mtdblock device

2024-06-05 Thread Simon Glass
Hi Alexey, On Wed, 5 Jun 2024 at 04:09, Alexey Romanov wrote: > > Hi Simon, > your message is empty. > > On Tue, Jun 04, 2024 at 08:13:34PM -0600, Simon Glass wrote: > > Hi Alexey, > > > > On Mon, Jun 3, 2024, 09:57 Alexey Romanov > > wrote: > > > > > Hello! > > > > > > This series adds support

Re: [PATCH v2 0/8] efi_loader: improve device-tree loading

2024-06-05 Thread Simon Glass
Hi Heinrich, On Wed, 5 Jun 2024 at 02:40, Heinrich Schuchardt wrote: > > On 29.05.24 18:30, Simon Glass wrote: > > Hi, > > > > On Tue, 28 May 2024 at 18:38, E Shattow wrote: > >> > >> Hi, > >> > >> On Tue, May 28, 2024 at 7:43 AM Heinrich Schuchardt > >> wrote: > >>> > >>> In U-Boot EFI boot op

Re: [PATCH v3 03/25] mbedtls: add mbedtls into the build system

2024-06-05 Thread Ilias Apalodimas
Hi Andy, [...] > > > > > Is this approach maintainable? > > > > > I don't remember if we have similar in Linux kernel, for example. > > > > > (There are few candidates like compression algorithms that are usually > > > > > being > > > > > hosted elsewhere) > > > > > > No answer? > > > > subtrees

Needs a check in the device tree

2024-06-05 Thread jianqiang wang
Dear Das U-Boot developers, I found that the u-boot device tree implementation lacks a check for the off_dt_struct field in the device tree. In file scripts\dtc\libfdt\libfdt_internal.h, fdt_offset_ptr_ returns the dt struct address. It calculates the address by adding the header address, fdt off

Re: [PATCH v3 6/7] tools: add genguid tool

2024-06-05 Thread Ilias Apalodimas
+ CC Sughosh On Wed, 5 Jun 2024 at 15:29, Caleb Connolly wrote: > > > > On 05/06/2024 11:25, Ilias Apalodimas wrote: > > Hi Heinrich > > > > On Wed, 5 Jun 2024 at 09:36, Heinrich Schuchardt wrote: > >> > >> On 5/31/24 15:50, Caleb Connolly wrote: > >>> Add a tool that can generate GUIDs that mat

Re: [PATCH v2 0/8] efi_loader: improve device-tree loading

2024-06-05 Thread Heinrich Schuchardt
On 05.06.24 15:17, Simon Glass wrote: Hi Heinrich, On Wed, 5 Jun 2024 at 02:40, Heinrich Schuchardt wrote: On 29.05.24 18:30, Simon Glass wrote: Hi, On Tue, 28 May 2024 at 18:38, E Shattow wrote: Hi, On Tue, May 28, 2024 at 7:43 AM Heinrich Schuchardt wrote: In U-Boot EFI boot option

[PATCH] fs/erofs: fix an overflow issue of unmapped extents

2024-06-05 Thread Jianan Huang
Here the size should be `length - skip`, otherwise it could cause the destination buffer overflow. Reported-by: jianqiang wang Fixes: 65cb73057b65 ("fs/erofs: add lz4 decompression support") Signed-off-by: Jianan Huang --- fs/erofs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: Several potential vulnerabilities in the filesystem

2024-06-05 Thread Jianan Huang
On 2024/6/5 19:18, Gao Xiang wrote: > Hi Jianqiang, > > On 2024/6/5 19:00, jianqiang wang wrote: >> Hi, >> >> I do have the crafted image. >> >> payload_00500, payload_00763, payload_00846 can be used to reproduce >> 1,2,3 vulnerabilities respectively. >> >> Each image is a hard drive file and the

Re: [PATCH v3 03/25] mbedtls: add mbedtls into the build system

2024-06-05 Thread Raymond Mao
Hi Andy and Ilias, On Wed, 5 Jun 2024 at 09:31, Ilias Apalodimas wrote: > Hi Andy, > > [...] > > > > > > > Is this approach maintainable? > > > > > > I don't remember if we have similar in Linux kernel, for example. > > > > > > (There are few candidates like compression algorithms that are > usu

Re: [PATCH v1 0/4] Sync StarFive JH7110 clock and reset dt-bindings with Linux

2024-06-05 Thread Tom Rini
On Wed, Jun 05, 2024 at 01:56:13AM +, Hal Feng wrote: > > On 04.06.24 04:32, E Shattow wrote: > > Hi Hal, > > > > Instead of manual dt-bindings sync can we please adopt OF_UPSTREAM for > > JH7110 ? > > Yeah, I will try to do it recently, although I am not sure whether the U-Boot > drivers and

Re: [PATCH 6/9] spl: Allow ATF to work when dcache is disabled

2024-06-05 Thread Tom Rini
On Tue, Jun 04, 2024 at 09:25:18PM -0600, Simon Glass wrote: > The dcache may not be enabled in SPL. Add a check to avoid trying to > use an undefined function. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH 9/9] Revert "arm: am335x: Enable SPL_OF_CONTROL on some configs"

2024-06-05 Thread Tom Rini
On Tue, Jun 04, 2024 at 09:25:21PM -0600, Simon Glass wrote: > This is a partial revert which makes boneblack_vboot boot again. > > This reverts commit f4b64e9736e73ceec14d51600bed9a8ac48f9fe8. > > Signed-off-by: Simon Glass > --- > > configs/am335x_boneblack_vboot_defconfig | 1 - > 1 file c

Re: [PATCH] arm: dts; am625_beagleplay: Switch to OF_UPSTREAM

2024-06-05 Thread Nishanth Menon
On 08:47-20240604, Nishanth Menon wrote: > Enable OF_UPSTREAM for AM625-beagleplay board. Remove DT files that > are now available in dts/upstream. Update the appended files based on > version of latest OF_UPSTREAM sync point (v6.10-rc1). > > Signed-off-by: Nishanth Menon > --- > > Based off u-b

[RFC PATCH] cmd: fwu: Dump custom fields from mdata structure

2024-06-05 Thread Michal Simek
The commit cb9ae40a16f0 ("tools: mkfwumdata: add logic to append vendor data to the FWU metadata") added support for adding vendor data to mdata structure but it is not visible anywhere that's why extend fwu command to dump it. Signed-off-by: Michal Simek --- I am using this for some time to che

[PATCH] cmd: fwu: Also print information about size

2024-06-05 Thread Michal Simek
It is useful when structure is also used for saving vendor data covered by CRC32. Signed-off-by: Michal Simek --- cmd/fwu_mdata.c | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/fwu_mdata.c b/cmd/fwu_mdata.c index 3c8be576ac7a..9c048d69a131 100644 --- a/cmd/fwu_mdata.c +++ b/cmd/fwu_mda

Re: [PATCH] fs/erofs: fix an overflow issue of unmapped extents

2024-06-05 Thread Gao Xiang
On 2024/6/5 22:05, Jianan Huang wrote: Here the size should be `length - skip`, otherwise it could cause the destination buffer overflow. Reported-by: jianqiang wang Fixes: 65cb73057b65 ("fs/erofs: add lz4 decompression support") Signed-off-by: Jianan Huang Reviewed-by: Gao Xiang Thanks

Re: [PATCH] cmd: fwu: Also print information about size

2024-06-05 Thread Ilias Apalodimas
On Wed, 5 Jun 2024 at 17:58, Michal Simek wrote: > > It is useful when structure is also used for saving vendor data covered > by CRC32. > > Signed-off-by: Michal Simek > --- > > cmd/fwu_mdata.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/cmd/fwu_mdata.c b/cmd/fwu_mdata.c > index 3c

RE: [External] Re: [PATCH 2/3] tools: binman: fix deprecated Python ConfigParser methods

2024-06-05 Thread Maier, Brandon L Collins
Hi Simon, > -Original Message- > From: Simon Glass > Sent: Tuesday, June 4, 2024 9:14 PM > To: Maier, Brandon L Collins > Cc: u-boot@lists.denx.de > Subject: [External] Re: [PATCH 2/3] tools: binman: fix deprecated Python > ConfigParser methods > > Hi Brandon, > > On Tue, 4 Jun 2024 at 1

Re: [PATCH v3 03/25] mbedtls: add mbedtls into the build system

2024-06-05 Thread Tom Rini
On Wed, Jun 05, 2024 at 04:30:58PM +0300, Ilias Apalodimas wrote: > Hi Andy, > > [...] > > > > > > > Is this approach maintainable? > > > > > > I don't remember if we have similar in Linux kernel, for example. > > > > > > (There are few candidates like compression algorithms that are > > > > > >

Re: [PATCH v2 0/8] efi_loader: improve device-tree loading

2024-06-05 Thread Ilias Apalodimas
Hi Simon, [...] > > >>> > > >> > > > > > > Can we use the best-match compatible approach as expected by the new > > > 'make image.fit' in Linux? > > > > > > Filenames should be deprecated IMO. I am happy to help work on how to > > > do that if you agree. > > > > Hello Simon, > > > > It is the OS

[PATCH 0/3] arm: dts: am625/am62a7: Switch over to OF_UPSTREAM

2024-06-05 Thread Nishanth Menon
Cleanup am625 on by switching over the last two platforms (SK and beagleplay) over to OF_UPSTREAM, and while at it, switch over am62a7 (last of the am62* family) over as well. This superscedes the previous version of beagleplay only patch[1] Test logs: https://gist.github.com/nmenon/ba310d3750a80

[PATCH 1/3] arm: dts: am625_beagleplay: Switch to OF_UPSTREAM

2024-06-05 Thread Nishanth Menon
Enable OF_UPSTREAM for AM625-beagleplay board. Remove DT files that are now available in dts/upstream. Update the appended files based on version of latest OF_UPSTREAM sync point (v6.10-rc1). Signed-off-by: Nishanth Menon --- arch/arm/dts/Makefile| 1 - arch/arm/dts/k3-

[PATCH 3/3] arm: dts: am62a7_sk: Switch to OF_UPSTREAM

2024-06-05 Thread Nishanth Menon
Enable OF_UPSTREAM for am62a7-sk board. Remove DT files that are now available in dts/upstream. Update the appended files based on version of latest OF_UPSTREAM sync point (v6.10-rc1). Signed-off-by: Nishanth Menon --- arch/arm/dts/Makefile|3 +- arch/arm/dts/k3-am62a-main.dt

[PATCH 2/3] arm: dts: am625_sk: Switch to OF_UPSTREAM

2024-06-05 Thread Nishanth Menon
Enable OF_UPSTREAM for am625-sk board. Remove DT files that are now available in dts/upstream. Update the appended files based on version of latest OF_UPSTREAM sync point (v6.10-rc1). Signed-off-by: Nishanth Menon --- arch/arm/dts/Makefile|3 +- arch/arm/dts/k3-am62-main.dtsi

Re: [PATCH v1 0/4] Sync StarFive JH7110 clock and reset dt-bindings with Linux

2024-06-05 Thread Conor Dooley
On Wed, Jun 05, 2024 at 08:35:15AM -0600, Tom Rini wrote: > On Wed, Jun 05, 2024 at 01:56:13AM +, Hal Feng wrote: > > > On 04.06.24 04:32, E Shattow wrote: > > > Hi Hal, > > > > > > Instead of manual dt-bindings sync can we please adopt OF_UPSTREAM for > > > JH7110 ? > > > > Yeah, I will try

Re: [PATCH 0/2] Cleanup fit documentation

2024-06-05 Thread Simon Glass
Hi Sam, On Tue, 4 Jun 2024 at 20:13, Simon Glass wrote: > > Hi Sam, > > On Tue, 4 Jun 2024 at 13:53, Sam Povilus wrote: > > > > Sam Povilus (2): > > doc: Remove extraneous curly braces > > doc: add clarity to what a "fpga" image is > > > > doc/usage/fit/source_file_format.rst | 28 +

[PATCH next v2 0/6] rockchip: display PMIC variant properly + misc fixes for Theobroma boards

2024-06-05 Thread Quentin Schulz
This fixes how the Rockchip PMIC variant is shown for all but RK808 by stripping the LSB. Also fix the size of the environment on Jaguar to match the default (smaller) size. Fix SPL_PAD_TO on Ringneck. Remove duplicated default value of ENV_OFFSET in puma defconfig. Remove unnecessary override

[PATCH next v2 1/6] rockchip: jaguar-rk3588: use default env size for Rockchip on MMC

2024-06-05 Thread Quentin Schulz
From: Quentin Schulz The default env size is 0x8000 when building for Rockchip SoCs with support for environment stored in MMC. Jaguar hasn't entered mass production just yet, so it's a breaking change we can afford in the name of consistency. Signed-off-by: Quentin Schulz --- configs/jaguar-

[PATCH next v2 2/6] rockchip: rk3399-puma: remove default value from defconfig

2024-06-05 Thread Quentin Schulz
From: Quentin Schulz CONFIG_ENV_OFFSET already defaults to 0x3F8000, however it is stored in lowercase hexdigits instead of uppercase like in the defconfig. No change in behavior intended. Signed-off-by: Quentin Schulz --- configs/puma-rk3399_defconfig | 1 - 1 file changed, 1 deletion(-) di

[PATCH next v2 3/6] rockchip: rk3399-puma: remove unnecessary simple-bin:fit:offset override

2024-06-05 Thread Quentin Schulz
From: Quentin Schulz Since commit 6007b69d544e ("rockchip: rk3399-puma: Update SPL_PAD_TO Kconfig option"), SPL_PAD_TO matches (CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR - 64) * 512 and the default value for simple-bin:fit:offset in rockchip-u-boot.dtsi is SPL_PAD_TO, so let's remove this override.

[PATCH next v2 4/6] rockchip: px30-ringneck: Update SPL_PAD_TO Kconfig option

2024-06-05 Thread Quentin Schulz
From: Quentin Schulz On px30-ringneck the FIT payload is located at sector 0x200 compared to the more Rockchip common sector 0x4000 offset: SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x200 Because FIT payload is located at sector 0x200 and the TPL+SPL is located at sector 64, the combined size of

[PATCH next v2 5/6] power: rk8xx: properly print all supported PMICs name

2024-06-05 Thread Quentin Schulz
From: Quentin Schulz The ID of the PMIC is stored in the 2 16b registers but the only part that matters right now is the 3 MSB, which make the 3 digits (in hex) of the part number. Right now, only RK808 was properly displayed, with this all currently supported PMICs should display the proper par

[PATCH next v2 6/6] rockchip: ringneck-px30: fix TPL_MAX_SIZE

2024-06-05 Thread Quentin Schulz
From: Quentin Schulz Ringneck was mistakenly set to allow up to 128KiB for the TPL code size while PX30 SoC only has 16KiB of SRAM. Therefore, let's use the default value of TPL_MAX_SIZE from the SoC (which is 10KiB) so that the max code size is actually checked and useful. Fixes: c925be73a0a8

Re: [PATCH 0/3] rockchip: rk8xx: fix broken [np]ldo callbacks

2024-06-05 Thread Quentin Schulz
Hi Anand, On 6/5/24 3:11 PM, Anand Moon wrote: Hi Quentin, On Wed, 5 Jun 2024 at 15:03, Quentin Schulz wrote: This is for master branch, merge ASAP as it's known to break at least Chromebook Jerry. @Simon, can you please check that this fixes your CB? The wrong udevice was passed to the fu

[PULL] u-boot-usb/master

2024-06-05 Thread Marek Vasut
The following changes since commit ea722aa5eb33740ae77e8816aeb72b385e621cd0: Merge branch '2024-05-29-assorted-small-fixes' (2024-05-29 11:21:14 -0600) are available in the Git repository at: git://source.denx.de/u-boot-usb.git master for you to fetch changes up to 8f8b4b0833fb8e890d053860e

Re: [PATCH v7] test/py: net_boot: Add test cases for net boot

2024-06-05 Thread Tom Rini
On Wed, Jun 05, 2024 at 03:19:35PM +0530, Love Kumar wrote: > Add tests for booting image using tftpboot/pxe boot commands, tftpboot > boot case loads the FIT image into DDR and boots using bootm command > whereas pxe boot cases downloads the pxe configuration file from the > TFTP server and inter

Re: [PATCH v3 0/7] efi: CapsuleUpdate: support for dynamic UUIDs

2024-06-05 Thread Caleb Connolly
On 05/06/2024 07:59, Heinrich Schuchardt wrote: On 5/31/24 15:50, Caleb Connolly wrote: As more boards adopt support for the EFI CapsuleUpdate mechanism, there is a growing issue of being able to target updates to them properly. The current mechanism of hardcoding UUIDs for each board at comp

[PATCH] board: rockchip: Add FriendlyElec NanoPi R6C

2024-06-05 Thread Sebastian Kropatsch
The NanoPi R6C is a SBC by FriendlyElec based on the Rockchip RK3588s. It comes with 4GB or 8GB of RAM, a microSD card slot, optional 32GB eMMC storage, one M.2 M-Key connector, one RTL8211F 1GbE and one RTL8125 2.5GbE Ethernet port, one USB 2.0 Type-A and one USB 3.0 Type-A port, a HDMI port, a 30

Re: [PATCH v2 01/14] net: introduce alternative implementation as net-lwip/

2024-06-05 Thread Jerome Forissier
On 5/27/24 17:34, Tom Rini wrote: > On Fri, May 24, 2024 at 06:19:55PM +0200, Jerome Forissier wrote: > >> Prepare the introduction of the lwIP (lightweight IP) TCP/IP stack by >> adding a new net-lwip/ directory and the NET_LWIP symbol. At this >> point, enabling NET_LWIP simply disables NET. Sub

Re: [PATCH 0/3] arm: dts: am625/am62a7: Switch over to OF_UPSTREAM

2024-06-05 Thread Dhruva Gole
Hi, On Jun 05, 2024 at 10:27:49 -0500, Nishanth Menon wrote: > Cleanup am625 on by switching over the last two platforms (SK and > beagleplay) over to OF_UPSTREAM, and while at it, switch over am62a7 > (last of the am62* family) over as well. Thanks for the cleanup. > > This superscedes the pre

[PATCH] cmd: move ELF load and boot to lib/elf.c

2024-06-05 Thread Maxim Moskalets
From: Maxim Moskalets Loading and running the ELF image is the responsibility of the library and should not be associated with the command line interface. It is also required to run ELF images from FIT with the bootm command so as not to depend on the command line interface. Signed-off-by: Maxi

[PATCH v5] cmd: move ELF load and boot to lib/elf.c

2024-06-05 Thread Maxim Moskalets
From: Maxim Moskalets Loading and running the ELF image is the responsibility of the library and should not be associated with the command line interface. It is also required to run ELF images from FIT with the bootm command so as not to depend on the command line interface. Signed-off-by: Maxi

Re: [PULL] u-boot-usb/master

2024-06-05 Thread Tom Rini
On Wed, Jun 05, 2024 at 06:48:53PM +0200, Marek Vasut wrote: > The following changes since commit ea722aa5eb33740ae77e8816aeb72b385e621cd0: > > Merge branch '2024-05-29-assorted-small-fixes' (2024-05-29 11:21:14 -0600) > > are available in the Git repository at: > > git://source.denx.de/u-b

Re: [RFC PATCH 0/1] drivers: bootcount: Add support for FAT filesystem

2024-06-05 Thread Tom Rini
On Wed, Jun 05, 2024 at 08:10:40PM +0200, Vasileios Amoiridis wrote: > From: Vasileios Amoiridis > > This patch adds support to save the bootcount variable in a file located in > FAT filesystem. Up to now, there was support only for EXT filesystem. > > The reason I put this as RFC is because the

[RFC PATCH 0/1] drivers: bootcount: Add support for FAT filesystem

2024-06-05 Thread Vasileios Amoiridis
From: Vasileios Amoiridis This patch adds support to save the bootcount variable in a file located in FAT filesystem. Up to now, there was support only for EXT filesystem. The reason I put this as RFC is because the file "bootcount_ext.c" will no longer represent the implementation for the EXT f

[RFC PATCH] drivers: bootcount: Add support for FAT filesystem

2024-06-05 Thread Vasileios Amoiridis
From: Vasileios Amoiridis Add support to save boot count variable in a file in a FAT filesystem. Signed-off-by: Vasileios Amoiridis --- doc/README.bootcount | 12 drivers/bootcount/Kconfig | 49 +++ drivers/bootcount/Makefile|

[PATCH 00/11] mediatek: cumulative trivial fix for OF_UPSTREAM support

2024-06-05 Thread Christian Marangi
This is an initial series that have all the initial trivial fixes required for usage of OF_UPSTREAM for the mediatek SoC This also contains the pcie-gen3 driver and the required tphy support driver to make it work. Subsequent series will follow with conversion of the mtk-clk to permit usage of OF

[PATCH 01/11] phy: phy-mtk-tphy: add support for phy type switch

2024-06-05 Thread Christian Marangi
Add support for PHY type switch via the mediatek topmisc syscon. This is needed on mt7981 to make the PCIe correctly work and display LinkUp. Follow the same implementation done on Linux kernel with the usage of the mediatek,syscon-type property. Example: u3port0: usb-phy@11e10700 { reg

[PATCH 02/11] pci: mediatek: add PCIe controller support for filogic silicon

2024-06-05 Thread Christian Marangi
From: John Crispin Add MediaTek GEN3 PCIe controller support for filogic silicon. This is adapted from the Linux version of the driver. Signed-off-by: John Crispin [ fix minor problems, fix checkpatch errors ] Signed-off-by: Christian Marangi --- drivers/pci/Kconfig | 7 + driv

[PATCH 03/11] spi: mtk_spim: add support for upstream mediatek, spi-ipm compatible

2024-06-05 Thread Christian Marangi
Upstream kernel linux use a different compatible mediatek,spi-ipm. Add support for this compatible and add handling for the additional clock similar to how it's done by the upstream driver and handling for all the property enabled by default. Signed-off-by: Christian Marangi --- drivers/spi/mtk

[PATCH 04/11] net: mediatek: handle alternative name for pn_swap property

2024-06-05 Thread Christian Marangi
Handle alternative name for pn_swap property as upstream linux use mediatek,pnswap. Signed-off-by: Christian Marangi --- drivers/net/mtk_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mtk_eth.c b/drivers/net/mtk_eth.c index 75e7bcf83b7..87e2e1d9cda 10064

[PATCH 05/11] i2c: mediatek: add support for optional arb and pmic clock

2024-06-05 Thread Christian Marangi
Add support for optional arb and pmic clock for i2c provided in upstream linux DTSI. Signed-off-by: Christian Marangi --- drivers/i2c/mtk_i2c.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/i2c/mtk_i2c.c b/drivers/i2c/mtk_i2c.c index 5592fe91817..345

[PATCH 06/11] serial: mediatek: add support for bus clock and enable it

2024-06-05 Thread Christian Marangi
Upstream linux also provide the additional optional bus clock. Add support for it and also enable the baud and bus clock on probe. Signed-off-by: Christian Marangi --- drivers/serial/serial_mtk.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/serial/serial_mtk.c b/drivers/s

[PATCH 07/11] serial: mediatek: add special handling for highspeed and linux compat

2024-06-05 Thread Christian Marangi
Upstream linux serial driver use a different logic to setup serial regs. They have 2 interval: - < 115200 we use lowspeed regs and 16 * baud - >= 115200 we use highspeed We currently use force_highspeed property to force usage of highspeed regs even with low baud rate. Add special handling if th

[PATCH 08/11] mmc: mediatek: add support for upstream linux clock and property

2024-06-05 Thread Christian Marangi
Add support for upstream linux clock and map U-Boot property to the one use in upstream linux where supported. Also add handling for the use_internal_cd that on upstream is hardcoded enabled on mt7620. Signed-off-by: Christian Marangi --- drivers/mmc/mtk-sd.c | 33 +-

[PATCH 09/11] clk: mediatek: mt7981: support alternative compatible for fixed-plls

2024-06-05 Thread Christian Marangi
Support alternative compatible for fixed-plls clocks used upstream with the compatible mediatek,mt7981-apmixedsys. Signed-off-by: Christian Marangi --- drivers/clk/mediatek/clk-mt7981.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/mediatek/clk-mt7981.c b/drivers/clk/mediatek/

  1   2   >