Hi Anand,
On 6/5/24 3:11 PM, Anand Moon wrote:
Hi Quentin,
On Wed, 5 Jun 2024 at 15:03, Quentin Schulz <foss+ub...@0leil.net> wrote:
This is for master branch, merge ASAP as it's known to break at least
Chromebook Jerry.
@Simon, can you please check that this fixes your CB?
The wrong udevice was passed to the functions, making them call the
pmic callbacks on the parent of the pmic udevice instead of the pmic
udevice itself.
While at it, ensure consistency by having all internal functions use
pmic udevice instead of the regulator udevice.
Finally, clarify operator precedence in ternary condition as reported by
my linter.
Signed-off-by: Quentin Schulz <quentin.sch...@cherry.de>
I see we have not been able to follow configs on a few of the board's for RK3588
CONFIG_CMD_REGULATOR=y
CONFIG_PMIC_RK8XX=y
CONFIG_REGULATOR_RK8XX=y
could you enable the options with imply for all the rockchip boards?
This patch series is a bug fix (ok, plus some cosmetic stuff) for master
before the next release in July, the suggested change is not a bug fix
so feel free to send a patch for the next branch instead :)
I'm personally not too keen in adding a lot of "imply" but I am no
authority there, so whatever the maintainer(s) prefer :)
Thanks,
Quentin
