Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-22 Thread Krzysztof Kozlowski
On 22/12/2023 07:12, Sumit Garg wrote: > Changes in v2: > -- > - Patch #1: excluded gitab CI config check and added commit description. > - Patch #3: s/UBOOT_DTSI_LOC/u_boot_dtsi_loc/ > - Patch #4: s/DEVICE_TREE_LOC/dt_dir/ and s/U-boot/U-Boot/ > - Patch #5: s/U-boot/U-Boot/ > - Patch #

Re: [PATCH v3 5/7] mmc: bcmstb: Add support for bcm2712 SD controller

2023-12-22 Thread Ivan T. Ivanov
On 12-21 16:39, Stefan Wahren wrote: > To: Florian Fainelli , "Ivan T. Ivanov" > > > > On 12/18/2023 10:03 PM, Ivan T. Ivanov wrote: > > > Borrow SD quirks from vendor Linux driver. > > > > > > "BCM2712 unfortunately carries with it a perennial bug with the SD > > > controller register interface

Re: [PATCH v2 8/8] dts: meson-gxbb: Drop redundant devicetree files

2023-12-22 Thread neil . armstrong
On 22/12/2023 07:12, Sumit Garg wrote: Since meson-gxbb based boards switched to using upstream DT, so drop redundant files from arch/arm/dts directory. Only *-u-boot.dtsi files kept in arch/arm/dts directory for these boards. Signed-off-by: Sumit Garg --- arch/arm/dts/Makefile

Re: [PATCH 0/7] Add SE HMBSC board support

2023-12-22 Thread Sumit Garg
On Thu, 21 Dec 2023 at 19:09, Caleb Connolly wrote: > > > > On 20/12/2023 13:36, Sumit Garg wrote: > > On Tue, 19 Dec 2023 at 21:56, Caleb Connolly > > wrote: > >> > >> > >> > >> On 19/12/2023 06:25, Sumit Garg wrote: > >>> Hi Simon, > >>> > >>> On Mon, 18 Dec 2023 at 20:32, Simon Glass wrote:

Re: [RFC PATCH 00/16] Introduce ICSSG Ethernet driver

2023-12-22 Thread MD Danish Anwar
Hi Roger, On 20/12/23 3:29 pm, Roger Quadros wrote: > Hi, > > On 19/12/2023 12:11, MD Danish Anwar wrote: >> Introduce ICSSG PRUETH support in uboot. The ICSSG driver is used in TI >> AM654 SR2.0. >> >> The ICSSG PRU Sub-system runs on EMAC firmware. This series Introduces >> support for ICSSG dr

Re: [PATCH v2 6/8] MAINTAINERS: Add myself as devicetree-rebasing maintainer

2023-12-22 Thread Ilias Apalodimas
On Fri, 22 Dec 2023 at 08:13, Sumit Garg wrote: > > Reviewed-by: Simon Glass > Signed-off-by: Sumit Garg > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 969514468cb..253092c345c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS >

Re: New TPM commands.

2023-12-22 Thread Ilias Apalodimas
Hi Niek, On Thu, 21 Dec 2023 at 04:12, niek.nooij...@omron.com wrote: > > Hi Ilias > > I implemented the feedback and checked the htmldocs build target. no error > there. > I also applied the patch to the latest github version (was using an older > one, but no compatibility issues) and used git

Re: [PATCH v2 1/9] bloblist: add API to check the register conventions

2023-12-22 Thread Ilias Apalodimas
Hi Raymond, On Thu, 21 Dec 2023 at 02:40, Raymond Mao wrote: > > Add bloblist_check_reg_conv() to check whether the bloblist is compliant > to the register conventions defined in Firmware Handoff specification. > This API can be used for all Arm platforms. > > Signed-off-by: Raymond Mao > --- >

Re: [PATCH v2 2/9] bloblist: check bloblist with specified buffer size

2023-12-22 Thread Ilias Apalodimas
On Thu, 21 Dec 2023 at 02:40, Raymond Mao wrote: > > Instead of expecting the bloblist total size to be the same as the > pre-allocated buffer size, practically we are more interested in > whether the pre-allocated buffer size is bigger than the bloblist > total size. > > Signed-off-by: Raymond Ma

Re: [PATCH v3 2/7] rpi5: Use devicetree as alternative way to read IO base addresses

2023-12-22 Thread Matthias Brugger
On 18/12/2023 22:03, Ivan T. Ivanov wrote: From: Dmitry Malkin MBOX and Watchdog on RPi5/bcm2712 has a different base IO offsets. Find them via devicetree blob passed by bootloader. Signed-off-by: Dmitry Malkin Signed-off-by: Ivan T. Ivanov Reviewed-by: Matthias Brugger --- arch/ar

Re: [PATCH v2 3/9] bloblist: refactor of bloblist_reloc()

2023-12-22 Thread Ilias Apalodimas
Hi Raymond, On Thu, 21 Dec 2023 at 02:41, Raymond Mao wrote: > > The current bloblist pointer and size can be retrieved from global > data, so we don't need to pass them from the function arguments. > This change also help to remove all external access of gd->bloblist > outside of bloblist module

Re: [PATCH v2 6/9] qemu-arm: Get bloblist from boot arguments

2023-12-22 Thread Ilias Apalodimas
> #endif > > +/* Boot parameters saved from start.S */ > +extern unsigned long saved_args[]; > + > int board_init(void) > { > return 0; > @@ -144,6 +148,35 @@ void *board_fdt_blob_setup(int *err) > return (void *)CFG_SYS_SDRAM_BASE; > } > > +int board_bloblist_from_boot_arg(unsi

Re: [PATCH v3 3/7] rpi5: Use devicetree to retrieve board revision

2023-12-22 Thread Matthias Brugger
On 18/12/2023 22:03, Ivan T. Ivanov wrote: Firmware on RPi5 return error on board revision query through firmware interface, but on the other hand it fills "linux,revision" in "system" node, so use it to detect board revision. system { linux,revision = <0xc04170>;

Re: [PATCH v3 7/7] pci: pcie-brcmstb: Add bcm2712 PCIe controller support

2023-12-22 Thread Matthias Brugger
On 18/12/2023 22:03, Ivan T. Ivanov wrote: PCIe controller have minor register map difference compared to bcm2711 variant. Handle this using device specific register offset. Signed-off-by: Ivan T. Ivanov Reviewed-by: Matthias Brugger --- drivers/pci/pcie_brcmstb.c | 23 +++

Re: Proposal: U-Boot memory management

2023-12-22 Thread Ilias Apalodimas
Hi Simon I'll respond to the rest more thoroughly but I since I caught this early, [...] > > 5. Avoid calling efi_allocate_pages() and efi_allocate_pool() outside > boot-time services. This solves the problem 6. If memory is needed by > an app, allocate it with malloc() and see 3. There are only

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-22 Thread Shantur Rathore
Hi all, On Mon, Dec 11, 2023 at 6:27 PM Tom Rini wrote: > > On Mon, Dec 11, 2023 at 11:22:45AM -0700, Simon Glass wrote: > > Hi Tom, > [snip] > > > I think in hind-sight too much stuff is omitted without BOOTSTD_FULL. > > > The option itself then enables other stuff too by default, but some > > >

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 12:05:39PM +, Shantur Rathore wrote: > Hi all, > > On Mon, Dec 11, 2023 at 6:27 PM Tom Rini wrote: > > > > On Mon, Dec 11, 2023 at 11:22:45AM -0700, Simon Glass wrote: > > > Hi Tom, > > [snip] > > > > I think in hind-sight too much stuff is omitted without BOOTSTD_FULL

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-22 Thread Shantur Rathore
On Fri, Dec 22, 2023 at 12:07 PM Tom Rini wrote: > > On Fri, Dec 22, 2023 at 12:05:39PM +, Shantur Rathore wrote: > > Hi all, > > > > On Mon, Dec 11, 2023 at 6:27 PM Tom Rini wrote: > > > > > > On Mon, Dec 11, 2023 at 11:22:45AM -0700, Simon Glass wrote: > > > > Hi Tom, > > > [snip] > > > > >

Re: [PATCH v3 0/7] rpi5: initial support

2023-12-22 Thread Marc Zyngier
Hi Ivan, On 2023-12-18 21:03, Ivan T. Ivanov wrote: Hi, These patches are adding basic support for RPi5. They are based on v2 series from Dmitry Malkin[1]. With them I am able to _start_ current openSUSE Tumbleweed without modification. They are still a lot of things to be added to the upstrea

Re: [PATCH v2 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 11:42:07AM +0530, Sumit Garg wrote: > Although there were still some variations in board DTS files based on > meson-gxbb SoC but I think those were minor differences from upstream > and shouldn't impact boot on these devices. > > So switch to upstream DT via mirroring amlo

Re: [PATCH v2 1/8] CI: Exclude devicetree-rebasing subtree for CONFIG checks

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 11:42:01AM +0530, Sumit Garg wrote: > Since devicetree-rebasing is an external repo with its own coding style, > exclude it from Azure and gitlab CI CONFIG checks. > > Signed-off-by: Sumit Garg Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 11:42:03AM +0530, Sumit Garg wrote: > Allow u-boot to build DTB from a different directory tree such that > *-u-boot.dtsi files can be included from a common location. Currently > that location is arch/$(ARCH)/dts/, so statically define that common > location. > > This is

Re: [PATCH v3 0/7] rpi5: initial support

2023-12-22 Thread Ivan T. Ivanov
On 12-22 12:19, Marc Zyngier wrote: > > Hi Ivan, > > On 2023-12-18 21:03, Ivan T. Ivanov wrote: > > Hi, > > > > These patches are adding basic support for RPi5. > > They are based on v2 series from Dmitry Malkin[1]. > > > > With them I am able to _start_ current openSUSE > > Tumbleweed without

Re: [PATCH v2 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 11:42:05AM +0530, Sumit Garg wrote: > Encourage SoC/board maintainers to migrate to using devicetree-rebasing > subtree and maintain a regular sync with Linux kernel devicetree files > and bindings. > > Along with that add documentation regarding how to run DT bindings > s

Re: [RFC PATCH 00/16] Introduce ICSSG Ethernet driver

2023-12-22 Thread Roger Quadros
On 22/12/2023 12:26, MD Danish Anwar wrote: > Hi Roger, > > On 20/12/23 3:29 pm, Roger Quadros wrote: >> Hi, >> >> On 19/12/2023 12:11, MD Danish Anwar wrote: >>> Introduce ICSSG PRUETH support in uboot. The ICSSG driver is used in TI >>> AM654 SR2.0. >>> >>> The ICSSG PRU Sub-system runs on EMA

Re: [PATCH v3 0/7] rpi5: initial support

2023-12-22 Thread Marc Zyngier
On 2023-12-22 12:33, Ivan T. Ivanov wrote: On 12-22 12:19, Marc Zyngier wrote: Hi Ivan, On 2023-12-18 21:03, Ivan T. Ivanov wrote: > Hi, > > These patches are adding basic support for RPi5. > They are based on v2 series from Dmitry Malkin[1]. > > With them I am able to _start_ current openSUSE

Re: [PATCH v7 2/2] schemas: Add some common reserved-memory usages

2023-12-22 Thread Ard Biesheuvel
On Thu, 21 Dec 2023 at 17:50, Chiu, Chasel wrote: > > > Hi Ard, > > Please see my reply below inline and let me know your thoughts. > > Thanks, > Chasel > > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Thursday, December 21, 2023 6:31 AM > > To: Chiu, Chasel > > Cc: Simon Gl

Re: [PATCH v2 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 18:01, Tom Rini wrote: > > On Fri, Dec 22, 2023 at 11:42:07AM +0530, Sumit Garg wrote: > > > Although there were still some variations in board DTS files based on > > meson-gxbb SoC but I think those were minor differences from upstream > > and shouldn't impact boot on these

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 13:48, Krzysztof Kozlowski wrote: > > On 22/12/2023 07:12, Sumit Garg wrote: > > Changes in v2: > > -- > > - Patch #1: excluded gitab CI config check and added commit description. > > - Patch #3: s/UBOOT_DTSI_LOC/u_boot_dtsi_loc/ > > - Patch #4: s/DEVICE_TREE_LOC

Re: [PATCH v2 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 18:05, Tom Rini wrote: > > On Fri, Dec 22, 2023 at 11:42:05AM +0530, Sumit Garg wrote: > > > Encourage SoC/board maintainers to migrate to using devicetree-rebasing > > subtree and maintain a regular sync with Linux kernel devicetree files > > and bindings. > > > > Along wit

Re: [PATCH v2 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 06:50:32PM +0530, Sumit Garg wrote: > On Fri, 22 Dec 2023 at 18:01, Tom Rini wrote: > > > > On Fri, Dec 22, 2023 at 11:42:07AM +0530, Sumit Garg wrote: > > > > > Although there were still some variations in board DTS files based on > > > meson-gxbb SoC but I think those wer

Re: [PATCH v2 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 07:18:05PM +0530, Sumit Garg wrote: > On Fri, 22 Dec 2023 at 18:05, Tom Rini wrote: > > > > On Fri, Dec 22, 2023 at 11:42:05AM +0530, Sumit Garg wrote: > > > > > Encourage SoC/board maintainers to migrate to using devicetree-rebasing > > > subtree and maintain a regular syn

Re: [PATCH v2 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 19:24, Tom Rini wrote: > > On Fri, Dec 22, 2023 at 06:50:32PM +0530, Sumit Garg wrote: > > On Fri, 22 Dec 2023 at 18:01, Tom Rini wrote: > > > > > > On Fri, Dec 22, 2023 at 11:42:07AM +0530, Sumit Garg wrote: > > > > > > > Although there were still some variations in board

Re: [PATCH v2 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2023-12-22 Thread Sumit Garg
On Fri, 22 Dec 2023 at 19:26, Tom Rini wrote: > > On Fri, Dec 22, 2023 at 07:18:05PM +0530, Sumit Garg wrote: > > On Fri, 22 Dec 2023 at 18:05, Tom Rini wrote: > > > > > > On Fri, Dec 22, 2023 at 11:42:05AM +0530, Sumit Garg wrote: > > > > > > > Encourage SoC/board maintainers to migrate to using

[PATCH v4] dts: rockpro64: Disable usb regulators-always-on

2023-12-22 Thread Shantur Rathore
USB port regulators should be controlled by PHYs so we remove always-on property and let phy manage the regulator. phy-supply isn't configured for TypeC port in upstream and now that we are removing always-on, we need to add the phy-supply until its fixed upstream. Signed-off-by: Shantur Rathore

[PATCH 1/1] bootmeth: pass size to efi_binary_run()

2023-12-22 Thread Heinrich Schuchardt
If we call efi_binary_run() with size parameter set to zero, we get an error Not a PE-COFF file Fill the missing value. Fixes: 1373ffde52e1 ("Merge tag 'v2024.01-rc5' into next") Fixes: 7017fc54a5bc ("bootmeth: use efi_loader interfaces instead of bootefi command") Signed-off-by: Heinrich

Re: [PATCH 1/1] bootmeth: pass size to efi_binary_run()

2023-12-22 Thread Ilias Apalodimas
On Fri, 22 Dec 2023 at 17:02, Heinrich Schuchardt wrote: > > If we call efi_binary_run() with size parameter set to zero, we get an error > > Not a PE-COFF file > > Fill the missing value. > > Fixes: 1373ffde52e1 ("Merge tag 'v2024.01-rc5' into next") > Fixes: 7017fc54a5bc ("bootmeth: use efi

Re: [PATCH v2 1/9] bloblist: add API to check the register conventions

2023-12-22 Thread Raymond Mao
On Fri, 22 Dec 2023 at 05:55, Ilias Apalodimas wrote: > ... > The function looks correct, but the name is a bit off. There are no > registers conventions check AFAICT. We are just comparing 2 addresses. > Am I missing anything? > The function name is from the spec. Below is the section describes

Re: [PATCH v2 3/9] bloblist: refactor of bloblist_reloc()

2023-12-22 Thread Raymond Mao
Hi Ilias, On Fri, 22 Dec 2023 at 06:12, Ilias Apalodimas wrote: > Hi Raymond, > > On Thu, 21 Dec 2023 at 02:41, Raymond Mao wrote: > > > > The current bloblist pointer and size can be retrieved from global > > data, so we don't need to pass them from the function arguments. > > This change also

Re: [PATCH v2 6/9] qemu-arm: Get bloblist from boot arguments

2023-12-22 Thread Raymond Mao
On Fri, 22 Dec 2023 at 06:19, Ilias Apalodimas wrote: > > #endif > > > > +/* Boot parameters saved from start.S */ > > +extern unsigned long saved_args[]; > > + > > int board_init(void) > > { > > return 0; > > @@ -144,6 +148,35 @@ void *board_fdt_blob_setup(int *err) > > return

Re: [PATCH 1/1] bootmeth: pass size to efi_binary_run()

2023-12-22 Thread Tom Rini
On Fri, 22 Dec 2023 16:01:56 +0100, Heinrich Schuchardt wrote: > If we call efi_binary_run() with size parameter set to zero, we get an error > > Not a PE-COFF file > > Fill the missing value. > > > [...] Applied to u-boot/next, thanks! -- Tom

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-22 Thread Krzysztof Kozlowski
On 22/12/2023 14:43, Sumit Garg wrote: > On Fri, 22 Dec 2023 at 13:48, Krzysztof Kozlowski > wrote: >> >> On 22/12/2023 07:12, Sumit Garg wrote: >>> Changes in v2: >>> -- >>> - Patch #1: excluded gitab CI config check and added commit description. >>> - Patch #3: s/UBOOT_DTSI_LOC/u_boo

Re: [PATCH 1/1] bootmeth: pass size to efi_binary_run()

2023-12-22 Thread Peter Robinson
On Fri, Dec 22, 2023 at 3:37 PM Tom Rini wrote: > > On Fri, 22 Dec 2023 16:01:56 +0100, Heinrich Schuchardt wrote: > > > If we call efi_binary_run() with size parameter set to zero, we get an error > > > > Not a PE-COFF file > > > > Fill the missing value. > > > > > > [...] > > Applied to u-b

[PATCH 0/1] MAINTAINERS: fix folders within glob pattern

2023-12-22 Thread Anthony Loiseau
From: Anthony Loiseau This patch fixes few folders I think mishandled within MAINTAINERS file. For example, files within drivers/clk/tegra/ were not affilated to ARM TEGRA because rule "F: drivers/*/tegra*" does not match them. See MAINTAINERS file embedded documentation on top. The same for to

[PATCH 1/1] MAINTAINERS: fix folders within glob pattern

2023-12-22 Thread Anthony Loiseau
From: Anthony Loiseau A "F: foo*" entry does not match any foo*/ folder nor its subtree, another "F: foo*/" entry is needed for that. Add missing foo*/ entries where an existing folder was ignored, so this folder and its subtree is properly covered. Arm tegra, Arm TI and Environment sections ar

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-22 Thread Conor Dooley
On Fri, Dec 22, 2023 at 04:38:01PM +0100, Krzysztof Kozlowski wrote: > On 22/12/2023 14:43, Sumit Garg wrote: > > On Fri, 22 Dec 2023 at 13:48, Krzysztof Kozlowski > > wrote: > >> > >> On 22/12/2023 07:12, Sumit Garg wrote: > >>> Changes in v2: > >>> -- > >>> - Patch #1: excluded gitab

Re: [PATCH v2 3/9] bloblist: refactor of bloblist_reloc()

2023-12-22 Thread Ilias Apalodimas
Hi Raymond, On Fri, 22 Dec 2023 at 17:30, Raymond Mao wrote: > > Hi Ilias, > > On Fri, 22 Dec 2023 at 06:12, Ilias Apalodimas > wrote: >> >> Hi Raymond, >> >> On Thu, 21 Dec 2023 at 02:41, Raymond Mao wrote: >> > >> > The current bloblist pointer and size can be retrieved from global >> > data

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 04:38:01PM +0100, Krzysztof Kozlowski wrote: > On 22/12/2023 14:43, Sumit Garg wrote: > > On Fri, 22 Dec 2023 at 13:48, Krzysztof Kozlowski > > wrote: > >> > >> On 22/12/2023 07:12, Sumit Garg wrote: > >>> Changes in v2: > >>> -- > >>> - Patch #1: excluded gitab

Re: [PATCH 1/1] bootmeth: pass size to efi_binary_run()

2023-12-22 Thread Ilias Apalodimas
On Fri, 22 Dec 2023 at 17:43, Peter Robinson wrote: > > On Fri, Dec 22, 2023 at 3:37 PM Tom Rini wrote: > > > > On Fri, 22 Dec 2023 16:01:56 +0100, Heinrich Schuchardt wrote: > > > > > If we call efi_binary_run() with size parameter set to zero, we get an > > > error > > > > > > Not a PE-CO

Re: [PATCH 1/1] bootmeth: pass size to efi_binary_run()

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 05:46:11PM +0200, Ilias Apalodimas wrote: > On Fri, 22 Dec 2023 at 17:43, Peter Robinson wrote: > > > > On Fri, Dec 22, 2023 at 3:37 PM Tom Rini wrote: > > > > > > On Fri, 22 Dec 2023 16:01:56 +0100, Heinrich Schuchardt wrote: > > > > > > > If we call efi_binary_run() with

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-22 Thread Krzysztof Kozlowski
On 22/12/2023 16:45, Conor Dooley wrote: >>> >>> I suppose we have to relay information to kernel sub-arch maintainers >>> who aren't the same as maintaining U-Boot counterparts. How about >>> adding U-Boot ML to CC for whichever DT change gets submitted in the >> >> And every other project? Just s

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-22 Thread Krzysztof Kozlowski
On 22/12/2023 16:46, Tom Rini wrote: > On Fri, Dec 22, 2023 at 04:38:01PM +0100, Krzysztof Kozlowski wrote: >> On 22/12/2023 14:43, Sumit Garg wrote: >>> On Fri, 22 Dec 2023 at 13:48, Krzysztof Kozlowski >>> wrote: On 22/12/2023 07:12, Sumit Garg wrote: > Changes in v2: > ---

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 04:55:54PM +0100, Krzysztof Kozlowski wrote: > On 22/12/2023 16:46, Tom Rini wrote: > > On Fri, Dec 22, 2023 at 04:38:01PM +0100, Krzysztof Kozlowski wrote: > >> On 22/12/2023 14:43, Sumit Garg wrote: > >>> On Fri, 22 Dec 2023 at 13:48, Krzysztof Kozlowski > >>> wrote: > >>

Re: [PATCH v2 12/32] board: dragonboard410c: upstream DT compat

2023-12-22 Thread Caleb Connolly
Hi Sumit, [...] >> - if (init == USB_INIT_HOST) { >> - /* Start USB Hub */ >> - dm_gpio_set_dir_flags(&hub_reset, >> - GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); >> - mdelay(100); >> - /* Switch usb to host

Re: [PATCH v2 3/9] bloblist: refactor of bloblist_reloc()

2023-12-22 Thread Raymond Mao
Hi Ilias, On Fri, 22 Dec 2023 at 10:46, Ilias Apalodimas wrote: > Hi Raymond, > > On Fri, 22 Dec 2023 at 17:30, Raymond Mao wrote: > > > > Hi Ilias, > > > > On Fri, 22 Dec 2023 at 06:12, Ilias Apalodimas < > ilias.apalodi...@linaro.org> wrote: > >> > >> Hi Raymond, > >> > >> On Thu, 21 Dec 2023

Re: [PATCH 0/7] Add SE HMBSC board support

2023-12-22 Thread Caleb Connolly
[snip] Sumit, could you rebase this series on my generic board support? [1] in it's current form this series conflicts, and includes some of the major anti-patterns I'm trying to move away from in mach-snapdragon. >>> >>> Although, I haven't gone through your series but I was expect

Re: [PATCH 00/13] Complete decoupling of zboot logic from commands

2023-12-22 Thread Tom Rini
On Sun, Dec 03, 2023 at 05:29:25PM -0700, Simon Glass wrote: > This series refactors the zboot code to allow it to be used with > CONFIG_COMMAND disabled. > > A new zboot_run() function is used to boot a zimage. > > This is cmde (part e of CMDLINE refactoring) > It depends on dm/cmdd-working > w

[PATCH 1/1] lib: smbios: remove redundant next_header()

2023-12-22 Thread Heinrich Schuchardt
next_header() and get_next_header() only differ in how the const attribute is used. One function taking a const parameter and returning a non-const is good enough. Fixes: 3d49ee8510d3 ("efi_loader: add SMBIOS table measurement") Signed-off-by: Heinrich Schuchardt --- lib/smbios-parser.c | 11 ++-

[PATCH 1/1] lib: smbios: verify_checksum() is duplicate

2023-12-22 Thread Heinrich Schuchardt
The function verify_checksum() duplicates what table_compute_checksum() does. Replace it. Fixes: 415eab0655a8 ("smbios: add parsing API") Signed-off-by: Heinrich Schuchardt --- lib/smbios-parser.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/lib/smbios-

Re: [PATCH 1/1] lib: smbios: remove redundant next_header()

2023-12-22 Thread Ilias Apalodimas
Hi Heinrich, On Fri, 22 Dec 2023 at 19:54, Heinrich Schuchardt wrote: > > next_header() and get_next_header() only differ in how the const attribute > is used. One function taking a const parameter and returning a non-const is > good enough. > > Fixes: 3d49ee8510d3 ("efi_loader: add SMBIOS table

[PATCH 1/1] smbios: type2: contained object handles

2023-12-22 Thread Heinrich Schuchardt
The type 2 structure must include information about the contained objects. It is fine to set the number of contained object handles to 0. Add the missing field. Fixes: 721e992a8af5 ("x86: Add SMBIOS table support") Signed-off-by: Heinrich Schuchardt --- include/smbios.h | 1 + 1 file changed, 1

RE: [PATCH v7 2/2] schemas: Add some common reserved-memory usages

2023-12-22 Thread Chiu, Chasel
Please see my reply below inline. Thanks, Chasel > -Original Message- > From: Ard Biesheuvel > Sent: Friday, December 22, 2023 4:48 AM > To: Chiu, Chasel > Cc: Simon Glass ; devicet...@vger.kernel.org; Mark Rutland > ; Rob Herring ; Tan, Lean Sheng > ; lkml ; Dhaval > Sharma ; Brune,

[PATCH v13 00/24] Modernize U-Boot shell

2023-12-22 Thread Francis Laniel
Hi! During 2021 summer, Sean Anderson wrote a contribution to add a new shell, based on LIL, to U-Boot [1, 2]. While one of the goals of this contribution was to address the fact actual U-Boot shell, which is based on Busybox hush, is old there was a discussion about adding a new shell versus upd

[PATCH v13 01/24] test: Add framework to test hush behavior

2023-12-22 Thread Francis Laniel
Introduce a new subcommand to ut: ut hush. For the moment, this command does nothing, future commits will add tests which will be run on command call. Note that CONFIG_HUSH_PARSER must be defined to compile this new subcommand. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- include

[PATCH v13 02/24] test: hush: Test hush if/else

2023-12-22 Thread Francis Laniel
As asked in commit 9c6bf1715f6a ("test/py: hush_if_test: Add tests to cover octal/hex values"), this commit translates test_hush_if_test.py to a C test. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- test/hush/Makefile | 1 + test/hush/if.c | 316 ++

[PATCH v13 03/24] test/py: hush_if_test: Remove the test file

2023-12-22 Thread Francis Laniel
5804ebfeb1ce ("test: hush: Test hush if/else") translated this test to a C test, so this python file is no more needed. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- test/py/tests/test_hush_if_test.py | 197 - 1 file changed, 197 deletions(-) delete mod

[PATCH v13 04/24] test: hush: Test hush variable expansion

2023-12-22 Thread Francis Laniel
Verifies shell variables are replaced by their values. Reviewed-by: Simon Glass Signed-off-by: Francis Laniel --- test/hush/Makefile | 1 + test/hush/dollar.c | 167 +++ test/py/tests/test_ut.py | 8 +- 3 files changed, 175 insertions(+), 1 de

[PATCH v13 05/24] test: hush: Test hush commands list

2023-12-22 Thread Francis Laniel
Verifies behavior of commands separated by ';', '&&' and '||'. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- test/hush/Makefile | 1 + test/hush/list.c | 79 ++ 2 files changed, 80 insertions(+) create mode 100644 test/hush/list.c di

[PATCH v13 06/24] test: hush: Test hush loops

2023-12-22 Thread Francis Laniel
The added tests verifies correct behavior of for, while and until loops. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- test/hush/Makefile | 1 + test/hush/loop.c | 65 ++ 2 files changed, 66 insertions(+) create mode 100644 test/hush/

[PATCH v13 09/24] cli: Add menu for hush parser

2023-12-22 Thread Francis Laniel
For the moment, the menu contains only entry: HUSH_OLD_PARSER which is the default. The goal is to prepare the field to add a new hush parser which guarantees actual behavior is still correct. Reviewed-by: Simon Glass Signed-off-by: Francis Laniel --- cmd/Kconfig | 13 + common/

[PATCH v13 08/24] cli: Port upstream Busybox hush to U-Boot

2023-12-22 Thread Francis Laniel
Adds new file cli_hush_upstream.c, it is a copy of Busybox hush file as it was of time to commit 37460f5da. This commit modifies Busybox hush to not compile some part specific to Busybox and adds some code needed by U-Boot. The modifications consists mainly on adding code #if(n)def guards. For th

[PATCH v13 10/24] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag

2023-12-22 Thread Francis Laniel
This flag is used to indicate we are using the hush parser. Reviewed-by: Simon Glass Signed-off-by: Francis Laniel --- common/cli.c | 2 ++ include/asm-generic/global_data.h | 4 2 files changed, 6 insertions(+) diff --git a/common/cli.c b/common/cli.c index 3916a7b10

[PATCH v13 11/24] cmd: Add new cli command

2023-12-22 Thread Francis Laniel
This command can be used to print the current parser with 'cli get'. It can also be used to set the current parser with 'cli set'. For the moment, only one value is valid for set: old. Signed-off-by: Francis Laniel --- cmd/Makefile | 2 + cmd/cli.c | 114 ++

[PATCH v13 12/24] cli: Enables using modern hush parser as command line parser

2023-12-22 Thread Francis Laniel
If one defines HUSH_MODERN_PARSER, it is then possible to use modern parser with: => cli get old => cli set modern => cli get modern Reviewed-by: Simon Glass Signed-off-by: Francis Laniel --- cmd/Kconfig | 12 cmd/Makefile | 2 +- cmd/cli.c

[PATCH v13 14/24] cli: hush_modern: Add functions to be called from run_command()

2023-12-22 Thread Francis Laniel
run_command() is called internally by the command run and it can also be called directly from U-Boot code, e.g. to do unit tests. This commit adds this path to go to modern hush. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- common/cli_hush_upstream.c | 66 +

[PATCH v13 13/24] cli: hush_modern: Enable variables expansion for modern hush

2023-12-22 Thread Francis Laniel
Enables variables expansion for modern hush, both for local and environment variables. So the following commands: foo=bar echo $foo setenv bar foo echo $bar leads to "bar" and "foo" being printed on console output. Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- common/cli_hush_moder

[PATCH v13 15/24] cli: add modern hush as parser for run_command*()

2023-12-22 Thread Francis Laniel
Enables using, in code, modern hush as parser for run_command function family. It also enables the command run to be used by CLI user of modern hush. Reviewed-by: Simon Glass Signed-off-by: Francis Laniel --- common/cli.c | 67 -- common/cli_hus

[PATCH v13 16/24] test: hush: Fix instructions list tests for modern hush

2023-12-22 Thread Francis Laniel
Modifies the expected result for modern hush. Indeed, there were bugs in actual U-Boot hush which were fixed in upstream Busybox. As modern hush is based on upstream Busybox, these bugs no longer exist. Reviewed-by: Simon Glass Signed-off-by: Francis Laniel --- test/hush/list.c | 69 +++

[PATCH v13 17/24] test: hush: Fix variable expansion tests for modern hush

2023-12-22 Thread Francis Laniel
Modifies the expected result for modern hush. Indeed, there were bugs in actual U-Boot hush which were fixed in upstream Busybox. As modern hush is based on upstream Busybox, these bugs no longer exist. Reviewed-by: Simon Glass Signed-off-by: Francis Laniel --- test/hush/dollar.c | 79 +

[PATCH v13 18/24] cli: hush_modern: Enable using < and > as string compare operators

2023-12-22 Thread Francis Laniel
In Busybox hush, '<' and '>' are used as redirection operators. For example, cat foo > bar will write content of file foo inside file bar. In U-Boot, we do not have file system, so we can hardly redirect command output inside a file. But, in actual U-Boot hush, these operators ('<' and '>') are us

[PATCH v13 19/24] cli: hush_modern: Enable if keyword

2023-12-22 Thread Francis Laniel
Adds support for "if then else" construct both for command line interface and through run_command(). Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- common/cli_hush_modern.c | 11 +++ common/cli_hush_upstream.c | 12 2 files changed, 15 insertions(+), 8 deletio

[PATCH v13 20/24] cli: hush_modern: Enable loops

2023-12-22 Thread Francis Laniel
Enables the use of for, while and until loops for command line as well as with run_command(). Signed-off-by: Francis Laniel Reviewed-by: Simon Glass --- common/cli_hush_modern.c | 1 + common/cli_hush_upstream.c | 15 ++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --g

[PATCH v13 21/24] test: hush: Fix loop tests for modern hush

2023-12-22 Thread Francis Laniel
Modifies return code got from while loop as modern hush always returns 0 from while loop. Reviewed-by: Simon Glass Signed-off-by: Francis Laniel --- test/hush/loop.c | 34 ++ 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/test/hush/loop.c b/test/h

[PATCH v13 22/24] cli: modern_hush: Add upstream commits up to 2nd October 2023.

2023-12-22 Thread Francis Laniel
This commit adds the following hush busybox upstream commits: 791b222dd55d ("sleep: fix "sleep -- ARGS"") 5353df91cba7 ("Update applet size estimates") e41e481fd571 ("hush: fix a compile failure") 07a95cfcabb0 ("ash: disable check for "good" function name, bash does not check this") e5692e2342c6 (

[PATCH v13 23/24] cmd: Set modern hush as default shell

2023-12-22 Thread Francis Laniel
Signed-off-by: Francis Laniel --- cmd/Kconfig | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index e25578cde3..26ad03 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -27,21 +27,17 @@ depends on HUSH_PARSER config HUSH_OLD_PARSER boo

[PATCH v13 24/24] configs: Use old hush for several boards

2023-12-22 Thread Francis Laniel
The keymile board family is not compatible with modern hush parser. Indeed, This boards used set_local_var() to store some variables as local shell. They then used get_local_var() to retrieve the variables values. Sadly, this two functions do not exist with CONFIG_HUSH_MODERN_PARSER. A patch was pr

Re: [PATCH v13 15/24] cli: add modern hush as parser for run_command*()

2023-12-22 Thread Francis Laniel
Hi! Le vendredi 22 décembre 2023, 22:02:35 CET Francis Laniel a écrit : > Enables using, in code, modern hush as parser for run_command function > family. It also enables the command run to be used by CLI user of modern > hush. > > Reviewed-by: Simon Glass > Signed-off-by: Francis Laniel > ---

Re: [PATCH v13 15/24] cli: add modern hush as parser for run_command*()

2023-12-22 Thread Tom Rini
On Fri, Dec 22, 2023 at 10:10:42PM +0100, Francis Laniel wrote: > Hi! > > > Le vendredi 22 décembre 2023, 22:02:35 CET Francis Laniel a écrit : > > Enables using, in code, modern hush as parser for run_command function > > family. It also enables the command run to be used by CLI user of modern >

[PATCH v3 0/9] Handoff bloblist from previous boot stage

2023-12-22 Thread Raymond Mao
This patch set depends on another series: "[PATCH v3 00/14] Support Firmware Handoff spec via bloblist". This patch set implements Qemu-Arm platform custom functions to retrieve the bloblist (aka. Transfer List) from previous loader via boot arguments when CONFIG_OF_BOARD option is enabled and all

[PATCH v3 1/9] bloblist: add API to check the register conventions

2023-12-22 Thread Raymond Mao
Add bloblist_check_reg_conv() to check whether the bloblist is compliant to the register conventions defined in Firmware Handoff specification. This API can be used for all Arm platforms. Signed-off-by: Raymond Mao --- Changes in v2 - Refactor of bloblist_check_reg_conv(). Changes in v3 - bloblis

[PATCH v3 2/9] bloblist: check bloblist with specified buffer size

2023-12-22 Thread Raymond Mao
Instead of expecting the bloblist total size to be the same as the pre-allocated buffer size, practically we are more interested in whether the pre-allocated buffer size is bigger than the bloblist total size. Signed-off-by: Raymond Mao Reviewed-by: Ilias Apalodimas --- Changes in v2 - New patch

[PATCH v3 3/9] bloblist: refactor of bloblist_reloc()

2023-12-22 Thread Raymond Mao
The current bloblist pointer and size can be retrieved from global data, so we don't need to pass them from the function arguments. This change also help to remove all external access of gd->bloblist outside of bloblist module. Signed-off-by: Raymond Mao --- Changes in v2 - New patch file created

[PATCH v3 4/9] arm: armv7: save boot arguments

2023-12-22 Thread Raymond Mao
Save boot arguments r[0-3] into an array for handover of bloblist from previous boot stage. Signed-off-by: Raymond Mao --- Changes in v2 - New patch file created for v2. Changes in v3 - Swap value of r0 with r2. arch/arm/cpu/armv7/start.S | 13 + 1 file changed, 13 insertions(+) di

[PATCH v3 5/9] arm: armv8: save boot arguments

2023-12-22 Thread Raymond Mao
Save boot arguments x[0-3] into an array for handover of bloblist from previous boot stage. Signed-off-by: Raymond Mao --- Changes in v2 - New patch file created for v2. arch/arm/cpu/armv8/start.S | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/cpu/armv8/start.S b/a

[PATCH v3 6/9] qemu-arm: Get bloblist from boot arguments

2023-12-22 Thread Raymond Mao
Add platform custom function to get bloblist from boot arguments. Check whether boot arguments aligns with the register conventions defined in FW Handoff spec v0.9. Add bloblist related options into qemu default config. Signed-off-by: Raymond Mao --- Changes in v2 - Remove low level code for copy

[PATCH v3 7/9] bloblist: Load the bloblist from the previous loader

2023-12-22 Thread Raymond Mao
During bloblist initialization, when CONFIG_OF_BOARD is defined, invoke the platform custom function to load the bloblist via boot arguments from the previous loader. If the bloblist exists, copy it into the fixed bloblist memory region. Signed-off-by: Raymond Mao --- common/bloblist.c | 47 +++

[PATCH v3 8/9] fdt: update the document and Kconfig description

2023-12-22 Thread Raymond Mao
Update the document and Kconfig to describe the behavior of board specific custom functions when CONFIG_OF_BOARD is defined. Signed-off-by: Raymond Mao --- doc/develop/devicetree/control.rst | 6 +++--- dts/Kconfig| 7 +-- 2 files changed, 8 insertions(+), 5 deletions

[PATCH v3 9/9] qemu-arm: get FDT from bloblist

2023-12-22 Thread Raymond Mao
Get devicetree from a bloblist if it exists. If not, fallback to get FDT from the specified memory address. Signed-off-by: Raymond Mao --- Changes in v2 - Refactor of board_fdt_blob_setup(). board/emulation/qemu-arm/qemu-arm.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-)

[PATCH v4] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-22 Thread Shantur Rathore
Rockchip SoCs can support wide range of bootflows. Without full bootflow commands, it can be difficult to figure out issues if any, hence enable by default. Reviewed-by: Simon Glass Signed-off-by: Shantur Rathore --- Changes in v4: - Replace BOOTSTD_DEFAULT with BOOTSTD_FULL as previous versio

Re: [PATCH v3] arch: arm: Kconfig: Enable BOOTSTD_FULL for Rockchip SoCs

2023-12-22 Thread Shantur Rathore
Hi, On Fri, Dec 22, 2023 at 12:09 PM Shantur Rathore wrote: > > On Fri, Dec 22, 2023 at 12:07 PM Tom Rini wrote: > > > > On Fri, Dec 22, 2023 at 12:05:39PM +, Shantur Rathore wrote: > > > Hi all, > > > > > > On Mon, Dec 11, 2023 at 6:27 PM Tom Rini wrote: > > > > > > > > On Mon, Dec 11, 202

  1   2   >