[v5 28/30] clk_k210.c: Clean up how we handle nop

2023-10-26 Thread Tom Rini
Now that sandbox has and defines nop() there we should include that in our driver for clarity and then remove our local nop() from . Signed-off-by: Tom Rini Reviewed-by: Sean Anderson --- Changes in v5: - Add Sean's RB, drop explanation portion --- drivers/clk/clk_k210.c | 1 + include/k210/pl

[v5 29/30] sandbox: Add a test for disabling CONFIG_CMDLINE

2023-10-26 Thread Tom Rini
From: Simon Glass Now that everything is working, add a test to make sure that this builds correctly. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- test/py/tests/test_sandbox_opts.py | 20 1 file changed, 20 insertions(+) create mode 100644 test/py/tests/test_sand

[v5 30/30] CI, pytest: Add a test for sandbox without LTO

2023-10-26 Thread Tom Rini
The primary motivation for having a sandbox without LTO build in CI is to ensure that we don't have that option break. We now have the ability to run tests of specific options being enabled/disabled, so drop the parts of CI that build and test that configuration specifically and add a build test in

Re: quick question about TPM

2023-10-26 Thread Ilias Apalodimas
Hi all On Thu, 26 Oct 2023 at 20:44, Simon Glass wrote: > > +Ilias Apalodimas as well > > On Thu, 26 Oct 2023 at 02:22, niek.nooij...@omron.com > wrote: > > > > Hi Simon > > > > Yes that fixes it! Thanks! > > Maybe an Idea to add a dedicated TPM page to the docs with information like > > this?

Re: [PATCH 1/3] board: developerbox: remove obsolete NOR flash layout definition

2023-10-26 Thread Ilias Apalodimas
On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima wrote: > > There are two kinds of NOR flash layout for the Developerbox. > Capsule update for the old layout is no longer available since > it has small capacity for secure world images and can not > house the TA such as fTPM. > This commit removes the

Re: [PATCH 2/3] board: developerbox: update old NOR flash layout build instruction

2023-10-26 Thread Ilias Apalodimas
On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima wrote: > > v2023.07 is the last version supporting old NOR flash layout > by default. The later versions of U-Boot, Developerbox is > configured to enable A/B update and new NOR Flash layout > by default. > This commit updates the documentation to pin

Re: [PATCH 3/3] board: developerbox: update flash rawwrite binary size

2023-10-26 Thread Ilias Apalodimas
On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima wrote: > > Current documentation limits the firmware size to 1.5MB. > When the fTPM and StandaloneMM-based RPMB secure storage is > enabled, firmware size is bigger than that size. > Let's specify the A/B update bank size(4MB) for flash > rawwrite para

Re: [PATCH v8 6/7] cmd: efidebug: add uri device path

2023-10-26 Thread Ilias Apalodimas
On Wed, 25 Oct 2023 at 09:30, Masahisa Kojima wrote: > > This adds the URI device path option for 'boot add' subcommand. > User can add the URI load option for downloading ISO image file > or EFI application through network. Currently HTTP is only supported. > > Signed-off-by: Masahisa Kojima > -

Re: [PATCH v8 5/7] efi_loader: support boot from URI device path

2023-10-26 Thread Ilias Apalodimas
Kojima-san, Thanks the device path handling seems saner in this version. On Wed, 25 Oct 2023 at 09:30, Masahisa Kojima wrote: > > This supports to boot from the URI device path. > When user selects the URI device path, bootmgr downloads > the file using wget into the address specified by loadadd

Re: [PATCH v2] board: ti: common: board_detect: Fix EEPROM offset read for 1-byte

2023-10-26 Thread Matwey V. Kornilov
чт, 26 окт. 2023 г. в 15:24, Prasanth Babu Mantena : > > EEPROM detection logic in ti_i2c_eeprom_get() involves reading the total > size followed by reading 1-byte size with an offset 1. This commit fixes > the header matching issue in commit 9f393a2d7af8 ("board: ti: common: > board_detect: Fix EE

[PATCH] boot: Fix syntax in fdt_overlay_apply_verbose() error message

2023-10-26 Thread Hugo Villeneuve
From: Hugo Villeneuve Remove superfluous "did". Signed-off-by: Hugo Villeneuve --- boot/fdt_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/fdt_support.c b/boot/fdt_support.c index 5e49078f8c3..b15d07765fe 100644 --- a/boot/fdt_support.c +++ b/boot/fdt_suppor

[PATCH] tools: gitignore: Fix tools/generated path

2023-10-26 Thread Sam Protsenko
'git status' shows 'tools/generated/' after running the build, which is wrong. The corresponding .gitignore rule was already added in commit c623642d29be ("Adjust gitignore for tools/generated/"), but because of superfluous 'tools/' part it wasn't in effect. Remove incorrect 'tools/' part to fix it

[PATCH] pico-pi-imx7d: Convert to watchdog driver model

2023-10-26 Thread Fabio Estevam
From: Fabio Estevam Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset Signed-off-by:

Re: [PATCH v2] board: ti: common: board_detect: Fix EEPROM offset read for 1-byte

2023-10-26 Thread Nishanth Menon
On 17:54-20231026, Prasanth Babu Mantena wrote: > EEPROM detection logic in ti_i2c_eeprom_get() involves reading the total > size followed by reading 1-byte size with an offset 1. This commit fixes > the header matching issue in commit 9f393a2d7af8 ("board: ti: common: > board_d

[PATCH 0/8] USB fixes: xHCI error handling

2023-10-26 Thread Hector Martin
This series is the first of a few bundles of USB fixes we have been carrying downstream on the Asahi U-Boot branch for a few months. Most importantly, this related set of patches makes xHCI error/stall recovery more robust (or work at all in some cases). There are also a couple patches fixing othe

[PATCH 1/8] usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-26 Thread Hector Martin
xhci_wait_for_event returns NULL on timeout, so the caller always has to check for that. This addresses the immediate explosions in this part of the code, but not the original cause. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 15 ++- drivers/usb/host/xhci.c

[PATCH 2/8] usb: xhci: Better error handling in abort_td()

2023-10-26 Thread Hector Martin
If the xHC has a problem with our STOP ENDPOINT command, it is likely to return a completion directly instead of first a transfer event for the in-progress transfer. Handle that more gracefully. Right now we still BUG() on the error code, but at least we don't end up timing out on the event and en

[PATCH 3/8] usb: xhci: Allow context state errors when halting an endpoint

2023-10-26 Thread Hector Martin
There is a race where an endpoint may halt by itself while we are trying to halt it, which results in a context state error. See xHCI 4.6.9 which mentions this case. This also avoids BUGging when we attempt to stop an endpoint which was already stopped to begin with, which is probably a bug elsewh

[PATCH 4/8] usb: xhci: Recover from halted non-control endpoints

2023-10-26 Thread Hector Martin
There is currently no codepath to recover from this case. In principle we could require that the upper layer do this explicitly, but let's just do it in xHCI when the next bulk transfer is started, since that reasonably implies whatever caused the problem has been dealt with. Signed-off-by: Hector

[PATCH 5/8] usb: xhci: Fail on attempt to queue TRBs to a halted endpoint

2023-10-26 Thread Hector Martin
This isn't going to work, don't pretend it will and then end up timing out. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 60f2cf72dffa..3ef8c2f1

[PATCH 7/8] usb: xhci: Fix DMA address calculation in queue_trb

2023-10-26 Thread Hector Martin
We need to get the DMA address before incrementing the pointer, as that might move us onto another segment. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-

[PATCH 6/8] usb: xhci: Do not panic on event timeouts

2023-10-26 Thread Hector Martin
Now that we always check the return value, just return NULL on timeouts. We can still log the error since this is a problem, but it's not reason to panic. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 8/8] usb: xhci: Add more debugging

2023-10-26 Thread Hector Martin
A bunch of miscellaneous debug messages to aid in working out USB issues. Signed-off-by: Hector Martin --- drivers/usb/host/xhci-ring.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c i

[PATCH] fixup! usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-26 Thread Hector Martin
Gah, I should've paid more attention to that rebase. Here's a dumb fixup for this patch. I'll squash it into a v2 if needed alongside any other changes, or if it looks good feel free to apply/squash it in directly. --- drivers/usb/host/xhci-ring.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 1/3] board: developerbox: remove obsolete NOR flash layout definition

2023-10-26 Thread Masahisa Kojima
Hi Ilias, On Fri, 27 Oct 2023 at 03:58, Ilias Apalodimas wrote: > > On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima > wrote: > > > > There are two kinds of NOR flash layout for the Developerbox. > > Capsule update for the old layout is no longer available since > > it has small capacity for secure

[PATCH 0/3] Revert HAFDBS changes

2023-10-26 Thread Chris Packham
As discussed this series reverts the HAFDBS changes that caused an issue on AC5/AC5X. I think there are some improvements that can be made to the initial memory map for the AC5/AC5X but so far nothing I've found makes it compatible with the HAFDBS changes. Chris Packham (3): Revert "armv8: enab

[PATCH 1/3] Revert "armv8: enable HAFDBS for other ELx when FEAT_HAFDBS is present"

2023-10-26 Thread Chris Packham
This reverts commit c1da6fdb5c239b432440721772d993e63cfdeb20. This is part of a series trying to make use of the arm64 hardware features for tracking dirty pages. Unfortunately this series causes problems for the AC5/AC5X SoCs. Having exhausted other options the consensus seems to be reverting this

[PATCH 2/3] Revert "arm64: Use level-2 for largest block mappings when FEAT_HAFDBS is present"

2023-10-26 Thread Chris Packham
This reverts commit 836b8d4b205d2175b57cb9ef271e638b0c116e89. This is part of a series trying to make use of the arm64 hardware features for tracking dirty pages. Unfortunately this series causes problems for the AC5/AC5X SoCs. Having exhausted other options the consensus seems to be reverting this

[PATCH 3/3] Revert "arm64: Use FEAT_HAFDBS to track dirty pages when available"

2023-10-26 Thread Chris Packham
This reverts commit 6cdf6b7a340db4ddd008516181de7e08e3f8c213. This is part of a series trying to make use of the arm64 hardware features for tracking dirty pages. Unfortunately this series causes problems for the AC5/AC5X SoCs. Having exhausted other options the consensus seems to be reverting this

Re: [RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 01:01:52PM +0200, Heinrich Schuchardt wrote: > On 10/26/23 07:30, AKASHI Takahiro wrote: > > Unfold do_bootefi_image() into do_bootefi() for the sake of the succeeding > > refactor work. > > > > Signed-off-by: AKASHI Takahiro > > --- > > cmd/bootefi.c | 101 +

Re: [RFC 02/13] cmd: bootefi: re-organize do_bootefi_image()

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 12:44:00PM +0200, Heinrich Schuchardt wrote: > On 10/26/23 07:30, AKASHI Takahiro wrote: > > Decompose and re-organize do_bootefi_image() into three parts for > > the succeeding refactor work. > > > > Signed-off-by: AKASHI Takahiro > > --- > > cmd/Kconfig | 15 +

[PATCH] arm: mvebu: AC5: Use finer grained memory map

2023-10-26 Thread Chris Packham
The ATF implementation for AC5/AC5X ends up with bl31 living in some internal SRAM. This is in the middle of the large MMIO region that we were using. Adjust this to be finer grained blocks based on the address map from the AC5X Family Control and Management Subsystem Functional Datasheet. Signed-

Re: [PATCH] arm: mvebu: AC5: Use finer grained memory map

2023-10-26 Thread Tom Rini
On Fri, Oct 27, 2023 at 01:44:11PM +1300, Chris Packham wrote: > The ATF implementation for AC5/AC5X ends up with bl31 living in some > internal SRAM. This is in the middle of the large MMIO region that we > were using. Adjust this to be finer grained blocks based on the address > map from the AC5

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 08:47:52AM -0400, Tom Rini wrote: > On Thu, Oct 26, 2023 at 05:48:30PM +0900, AKASHI Takahiro wrote: > > On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > > > > > > > > > Am 26. Oktober 2023 07:30:50 MESZ schrieb AKASHI Takahiro > > > : > > > >Now it

Re: [RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-26 Thread Tom Rini
On Fri, Oct 27, 2023 at 09:25:44AM +0900, AKASHI Takahiro wrote: > On Thu, Oct 26, 2023 at 01:01:52PM +0200, Heinrich Schuchardt wrote: > > On 10/26/23 07:30, AKASHI Takahiro wrote: > > > Unfold do_bootefi_image() into do_bootefi() for the sake of the succeeding > > > refactor work. > > > > > > Si

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread Tom Rini
On Fri, Oct 27, 2023 at 09:59:02AM +0900, AKASHI Takahiro wrote: > On Thu, Oct 26, 2023 at 08:47:52AM -0400, Tom Rini wrote: > > On Thu, Oct 26, 2023 at 05:48:30PM +0900, AKASHI Takahiro wrote: > > > On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > > > > > > > > > > > > Am 2

Re: [PATCH 2/8] usb: xhci: Better error handling in abort_td()

2023-10-26 Thread Marek Vasut
On 10/27/23 01:16, Hector Martin wrote: If the xHC has a problem with our STOP ENDPOINT command, it is likely to return a completion directly instead of first a transfer event for the in-progress transfer. Handle that more gracefully. Right now we still BUG() on the error code, but at least we d

Re: [PATCH 3/3] arm: rmobile: rzg2_beacon: Auto select Linux device tree by SoC

2023-10-26 Thread Marek Vasut
On 10/26/23 01:13, Adam Ford wrote: There is a function inside the board file to autodetect which device tree is needed by U-Boot to properly load its own device tree, but it currently defaults to always loading RZ/G2M for Linux. This is not correct for other SoC variants. Add board_late_init f

Re: [PATCH] fixup! usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-26 Thread Marek Vasut
On 10/27/23 01:26, Hector Martin wrote: Gah, I should've paid more attention to that rebase. Here's a dumb fixup for this patch. I'll squash it into a v2 if needed alongside any other changes, or if it looks good feel free to apply/squash it in directly. --- drivers/usb/host/xhci-ring.c | 1 +

Re: [PATCH 1/3] configs: rzg2_beacon: Disable the ability to remove devices

2023-10-26 Thread Marek Vasut
On 10/26/23 01:13, Adam Ford wrote: In order to save some space, disable the ability to dynamically remove devices. Without this, U-Boot is too large to load without recompiling TF-A. Did you enable LTO yet ? Striping DM_REMOVE seems like a really bad idea, doesn't that break 'usb reset' and

Re: [PATCH 1/3] configs: rzg2_beacon: Disable the ability to remove devices

2023-10-26 Thread Adam Ford
On Thu, Oct 26, 2023 at 8:44 PM Marek Vasut wrote: > > On 10/26/23 01:13, Adam Ford wrote: > > In order to save some space, disable the ability to dynamically > > remove devices. Without this, U-Boot is too large to load without > > recompiling TF-A. > > Did you enable LTO yet ? Yes. > > Stripi

Re: [PATCH 3/3] arm: rmobile: rzg2_beacon: Auto select Linux device tree by SoC

2023-10-26 Thread Adam Ford
On Thu, Oct 26, 2023 at 8:44 PM Marek Vasut wrote: > > On 10/26/23 01:13, Adam Ford wrote: > > There is a function inside the board file to autodetect which device > > tree is needed by U-Boot to properly load its own device tree, but > > it currently defaults to always loading RZ/G2M for Linux.

[PATCH] arm64: versal-net: enable CONFIG_MMC_SDHCI_ADMA

2023-10-26 Thread Venkatesh Yadav Abbarapu
The Standard Host Controller Interface (SDHCI) specification version 3.00 adds support for Advanced DMA (ADMA) for both 64 and 32 bit widths of DMA. This significantly improves read and write throughput. Signed-off-by: Venkatesh Yadav Abbarapu --- configs/xilinx_versal_net_virt_defconfig | 1 +

Re: [PATCH 1/3] board: developerbox: remove obsolete NOR flash layout definition

2023-10-26 Thread Ilias Apalodimas
On Fri, 27 Oct 2023 at 03:21, Masahisa Kojima wrote: > > Hi Ilias, > > On Fri, 27 Oct 2023 at 03:58, Ilias Apalodimas > wrote: > > > > On Wed, 25 Oct 2023 at 09:52, Masahisa Kojima > > wrote: > > > > > > There are two kinds of NOR flash layout for the Developerbox. > > > Capsule update for the o

Re: [PATCH] arm: mvebu: AC5: Use finer grained memory map

2023-10-26 Thread Chris Packham
Hi Tom, On Fri, 27 Oct 2023, 1:54 pm Tom Rini, wrote: > On Fri, Oct 27, 2023 at 01:44:11PM +1300, Chris Packham wrote: > > > The ATF implementation for AC5/AC5X ends up with bl31 living in some > > internal SRAM. This is in the middle of the large MMIO region that we > > were using. Adjust this

Re: [PATCH] fixup! usb: xhci: Guard all calls to xhci_wait_for_event

2023-10-26 Thread Hector Martin
On 27/10/2023 09.36, Marek Vasut wrote: > On 10/27/23 01:26, Hector Martin wrote: >> Gah, I should've paid more attention to that rebase. Here's a dumb >> fixup for this patch. I'll squash it into a v2 if needed alongside >> any other changes, or if it looks good feel free to apply/squash >> it in

Re: [PATCH v13 6/8] doc: Add measured boot documentation

2023-10-26 Thread Ilias Apalodimas
Hi Heinrich On Thu, 19 Oct 2023 at 21:22, Heinrich Schuchardt wrote: > > On 10/19/23 18:21, Eddie James wrote: > > Briefly describe the feature and specify the requirements. > > > > Signed-off-by: Eddie James > > Reviewed-by: Simon Glass > > --- > > Changes since v12: > > - Add a bit of detai

Re: [PATCH u-boot-marvell] arm: mvebu: turris_mox: Extend to support RIPE Atlas Probe

2023-10-26 Thread Stefan Roese
On 10/26/23 09:10, Stefan Roese wrote: On 10/20/23 16:29, Marek Behún wrote: Extend Turris Mox board code to support CZ.NIC's RIPE Atlas Probe. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan Thanks, Stefan ---   arch/arm/dts/Make

Re: [PATCH] arm: kirkwood: Enable bootstd for Zyxel NSA310S board

2023-10-26 Thread Stefan Roese
On 10/26/23 09:09, Stefan Roese wrote: On 10/26/23 00:38, Tony Dinh wrote: Enable bootstd for Zyxel NSA310S board, and remove distroboot. Signed-off-by: Tony Dinh Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan Thanks, Stefan ---   configs/nsa310s_defconfig

Re: [PATCH] arm: kirkwood: Enable bootstd for Pogo V4 board

2023-10-26 Thread Stefan Roese
On 10/26/23 09:08, Stefan Roese wrote: On 10/25/23 01:17, Tony Dinh wrote: Enable bootstd for Pogo V4 board, and remove distroboot. Signed-off-by: Tony Dinh Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan Thanks, Stefan ---   configs/pogo_v4_defconfig |  3

Re: [PATCH v2 1/2] arm: mvebu: allow additional 4096 offset for bootable mmc image

2023-10-26 Thread Stefan Roese
On 10/26/23 09:10, Stefan Roese wrote: On 10/25/23 10:22, Josua Mayer wrote: Disarm the error message forcing u-boot/spl image to be located at sector 0 on eMMC data-partition and microSD. Offset 0 makes sense on eMMC boot partitions only, data partition must use 4096 to avoid conflicting with M

Re: [PATCH v2 2/2] cmd: mvebu/bubt: move eMMC data-partition uboot from LBA-0 to 4096

2023-10-26 Thread Stefan Roese
On 10/26/23 09:10, Stefan Roese wrote: On 10/25/23 10:22, Josua Mayer wrote: A38x bootrom only searches 2 sectors when booting from eMMC, irregardless of data or boot partition: 0 & 4096. For eMMC boot partitions sector 0 is fine, but on data partition it conflicts with MBR. Change bubt comman

Please pull u-boot-marvell/master

2023-10-26 Thread Stefan Roese
Hi Tom, please pull this next batch of Marvell related patches: - kirkwood: Enable bootstd on some boards (Tony) - mvebu: turris_mox: Extend to support RIPE Atlas Probe (Marek) - mvebu/bubt: Support eMMC data partition booting (Jos

<    1   2