Re: [PATCH] phy: Fix generic_setup_phy return value on power on failure

2023-07-12 Thread Jonas Karlman
On 2023-07-12 03:48, Marek Vasut wrote: > On 7/12/23 02:06, Jonas Karlman wrote: >> On 2023-07-12 01:59, Marek Vasut wrote: >>> On 7/12/23 01:48, Jonas Karlman wrote: generic_setup_phy may mask a power on failure due to the return value from generic_phy_exit, typically 0, is being used as

Re: [PATCH] phy: Fix generic_setup_phy return value on power on failure

2023-07-12 Thread Marek Vasut
On 7/12/23 09:36, Jonas Karlman wrote: On 2023-07-12 03:48, Marek Vasut wrote: On 7/12/23 02:06, Jonas Karlman wrote: On 2023-07-12 01:59, Marek Vasut wrote: On 7/12/23 01:48, Jonas Karlman wrote: generic_setup_phy may mask a power on failure due to the return value from generic_phy_exit, typ

Re: [PATCH v1 0/4] Add NPCM8xx more feature support

2023-07-12 Thread Jim Liu
Hi Tom Sorry to bother you. Could I know your merge plans for my commit ? https://patchwork.ozlabs.org/project/uboot/list/?series=362257 https://patchwork.ozlabs.org/project/uboot/list/?series=359454 because MS 、google and other customers will use the new memory layout . So could you provide some

[PATCH v1 0/2] power: pmic: add TPS65913 support

2023-07-12 Thread Svyatoslav Ryhel
Existing PALMAS PMIC driver is fully compatible with TI TPS65913 PMIC found in many Tegra 4 devices, like Tegra Note 7 and ASUS TF701T. Add TPS65913 dts compatible with TPS659038 data. Without regulator_autoset PALMAS regulators are just "requested" without actual initial setup (device tree is com

[PATCH v1 1/2] power: pmic: support TI TPS65913 PMIC

2023-07-12 Thread Svyatoslav Ryhel
Existing PALMAS PMIC driver is fully compatible with TI TPS65913 PMIC found in many Tegra 4 devices, like Tegra Note 7 and ASUS TF701T. TPS65913 shares same structure of regulators like TPS659038 so data can be reused. Tested-by: Svyatoslav Ryhel # NVIDIA Tegratab Signed-off-by: Svyatoslav Ryhel

[PATCH v1 2/2] power: regulator: palmas: set up voltage on probe

2023-07-12 Thread Svyatoslav Ryhel
Without this patch PALMAS regulators are just "requested" without actual initial setup (device tree values are completely ignored). This causes major issue since voltage is usually set on probing and rarely is changed. Drivers which change voltage assume that initial voltage was already set and thi

Re: [PATCH v4] phy: phy-imx8mq-usb: add vbus regulator support

2023-07-12 Thread Marek Vasut
On 7/11/23 22:13, Tim Harvey wrote: On Mon, Jul 10, 2023 at 4:18 PM Marek Vasut wrote: On 7/11/23 00:49, Tim Harvey wrote: Add support for enabling and disabling vbus-supply regulator found on several imx8mp boards in the usb3_phy0 and usb3_phy1 nodes. Signed-off-by: Tim Harvey Reviewed-by:

Re: [PATCH v4 1/3] binman: Add support for externally encrypted blobs

2023-07-12 Thread Taedcke, Christian
Hello Simon, thank you for your help so far. On 11.07.2023 17:01, Simon Glass wrote: Hi Christian, On Tue, 11 Jul 2023 at 08:58, Taedcke, Christian wrote: Hello Jonas, On 10.07.2023 12:48, Jonas Karlman wrote: Hi Christian, On 2023-07-10 11:25, christian.taedcke-...@weidmueller.com wrote

[PATCH 1/2] config: xea: Disable support for boot methods EXTLINUX and VBE

2023-07-12 Thread Lukasz Majewski
The XEA system (imx287 based) is not using support for EXTLINUX and VBE. As those configuration options have been enabled by default with modern Kconfig it is safe to explicitly disable them. After that change the u-boot.img size has been reduced by ~16 KiB. Signed-off-by: Lukasz Majewski --- c

[PATCH 2/2] config: xea: Disable support for FAT file system

2023-07-12 Thread Lukasz Majewski
On the XEA (imx287) system the FAT file system is not used neither in SPL nor u-boot proper. Hence, to save ~6KiB of u-boot.img size - it has been disabled. Signed-off-by: Lukasz Majewski --- configs/imx28_xea_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/imx28_xea_defcon

[PATCH v2 5/5] imx8mn-var-som: adjust PHY reset gpios according to hardware configuration

2023-07-12 Thread sbabic
> From: Hugo Villeneuve > For SOM with the EC configuration, the ethernet PHY is located on the > SOM itself, and connected to the CPU ethernet controller. It has a > reset line controlled via GPIO1_IO9. In this configuration, the PHY > located on the carrier board is not connected to anything and

[PATCH v1 2/2] board: colibri-imx8x: initialize snvs

2023-07-12 Thread sbabic
> Initialize Secure Non-Volatile Storage, aka SNVS. > Signed-off-by: Andrejs Cainikovs Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH,Managing Director: Erika Unt

Re: [PATCH] arm: dts: imx8m: add OPTEE_LOAD_ADDRESS config and tee.bin

2023-07-12 Thread Stefano Babic
Hi Tim, On 22.06.23 19:30, Tim Harvey wrote: Add a Kconfig for OPTEE_LOAD_ADDRESS which adds tee.bin to the imx8m{m,n,p} FIT image. Prior to using binman for image creation the presense of tee.bin in the directory would cause mkimage_fit_atf.sh to add the tee.bin node to the FIT image. Once boa

Re: [RESEND PATCH v2 5/5] imx8mn-var-som: adjust PHY reset gpios according to hardware configuration

2023-07-12 Thread Stefano Babic
Hi Hugo, On 11.07.23 17:45, Hugo Villeneuve wrote: From: Hugo Villeneuve For SOM with the EC configuration, the ethernet PHY is located on the SOM itself, and connected to the CPU ethernet controller. It has a reset line controlled via GPIO1_IO9. In this configuration, the PHY located on the c

[PATCH v3] event: Add fpga load event

2023-07-12 Thread christian . taedcke-oss
From: Christian Taedcke This enables implementing custom logic after a bitstream was loaded into the fpga. Signed-off-by: Christian Taedcke --- Changes in v3: - replace #if with if - remove previously added printf - return notification error from fpga_load() - fix static_assert checking event

Re: [PATCH v2] bdinfo: Correct use of assertions

2023-07-12 Thread Marek Vasut
On 7/12/23 04:46, Simon Glass wrote: This test was written for the incorrect use of assertions. Update it to build with the previous approach, where tests fail at the first assertion. All assertion functions return 0 on success and non-zero on failure. They can be nested into functions simply by

Re: [PATCH v2 01/19] test: Restore test behaviour on failure

2023-07-12 Thread Bin Meng
On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > A recent change makes test continue to run after failure. This results in > a lot of useless output and may lead to a segfault. Fix this by adding > back the 'return' statement. > > Note that this is not a full revert of the original commit. I

Re: [PATCH v2 04/19] bootstd: Use bootdev instead of bootdevice

2023-07-12 Thread Bin Meng
On Tue, Jun 20, 2023 at 4:24 PM Simon Glass wrote: > > It seems better to call this a 'bootdev' since this is name used in the > documentation. The older 'Bootdevice' name is no-longer used and may cause > confusion with the 'bootdevice' environment variable. > > Update throughout to use bootdev.

Re: [PATCH v2 07/19] bootstd: Use the bootargs env var for changing the cmdline

2023-07-12 Thread Bin Meng
Hi Simon, On Tue, Jun 20, 2023 at 4:24 PM Simon Glass wrote: > > The "bootargs" environment variable is used to set the command-line > arguments to pass to the OS. Use this same mechanism with bootstd as well. > When the variable is updated, it is written to the current bootflow. When > the curre

Re: [PATCH v2 08/19] bootstd: Allow storing x86 setup information

2023-07-12 Thread Bin Meng
On Tue, Jun 20, 2023 at 4:24 PM Simon Glass wrote: > > On x86 boards Linux uses a block of binary data to provide information > about the command line, memory map, etc. Provide a way to store this in > the bootflow so it can be passed on to the OS. > > No attempt is made to generalise the code, si

Re: [PATCH v2 10/19] bootstd: Add a function to update a command line

2023-07-12 Thread Bin Meng
On Tue, Jun 20, 2023 at 4:25 PM Simon Glass wrote: > > The Linux command line consists of a number of words with optional values. > At present U-Boot allows this to be changed using the bootargs environment > variable. > > But this is quite painful, since the command line can be very long. > > Add

Re: [PATCH v2 12/19] x86: qemu: Create a little more room for U-Boot

2023-07-12 Thread Bin Meng
On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > We want to enable some of the more interesting bootstd features. Move SPL > up to create some room for the larger U-Boot binary. Also disable > microcode since this is not needed > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add

Re: [PATCH v2 13/19] x86: qemu: Switch to standard boot

2023-07-12 Thread Bin Meng
On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > Drop use of the distro boot script and use standard boot instead. > > Moving to a text-based environment would be desirable also, but requires > additional work. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to swi

Re: [PATCH v2 18/19] x86: coreboot: Adjust various config options

2023-07-12 Thread Bin Meng
On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > Drop IDE since this is not widely used anymore. Add NVME since it is > becoming more popular. This commit message is irrelevant. > > Add ms so it is easier to search for tables in memory. > > Expand the command-line and print buffers so that

Re: [PATCH v2 19/19] x86: coral: Adjust various config options

2023-07-12 Thread Bin Meng
On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > Add ms so it is easier to search for tables in memory. > > Expand the command-line and print buffers so that we can deal with the > very long ChromeOS command lines. (typically 700 characters). > > Enable BOOTSTD_FULL to get the full set of st

Re: [PATCH v2 00/19] bootstd: Add a bootmeth for ChromiumOS on x86

2023-07-12 Thread Bin Meng
Hi Simon, On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > This series adds a simple bootmeth for ChromiumOS on x86. It uses zimage > to boot the kernel. > > Full verified boot is not included at this stage - that is still a > separate chunk of code to be brought into standard boot at some

Re: [PATCH v2 18/19] x86: coreboot: Adjust various config options

2023-07-12 Thread Bin Meng
Hi Simon, On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > Drop IDE since this is not widely used anymore. Add NVME since it is > becoming more popular. > > Add ms so it is easier to search for tables in memory. > > Expand the command-line and print buffers so that we can deal with the > ve

[PATCH 0/2] rockchip: rk35xx: Fix SPI Flash alias

2023-07-12 Thread Jonas Karlman
The series "rockchip: rk35xx: Update defconfigs and enable boot from SPI NOR flash" enabled SPI flash boot support on ROCK 3A and ROCK 5B using a spi0 alias. This spi0 alias should be used for the spi0 device tree node and not the sfc node. Correct this by adding spi4 and spi5 aliases to -u-boot.

[PATCH 1/2] rockchip: rk3568-rock-3a: Fix SPI Flash alias

2023-07-12 Thread Jonas Karlman
The commit 64f79f88a751 ("rockchip: rk3568-rock-3a: Enable boot from SPI NOR flash") enabled SPI flash support by overriding the spi0 alias. Correct this by adding a new spi4 alias in rk356x-u-boot.dtsi and SF_DEFAULT_BUS=4 and SPL_DM_SEQ_ALIAS=y in defconfig. Also enabled support for parsing and

[PATCH 2/2] rockchip: rk3588-rock-5b: Fix SPI Flash alias

2023-07-12 Thread Jonas Karlman
The commit fd6e425be243 ("rockchip: rk3588-rock-5b: Enable boot from SPI NOR flash") enabled SPI flash support by adding a spi0 alias. Correct this by adding spi0-spi5 aliases in rk3588s-u-boot.dtsi and SF_DEFAULT_BUS=5 and SPL_DM_SEQ_ALIAS=y in defconfig. Also enabled support for parsing and auto

Re: [PATCH v4 0/4] SPL NVMe support

2023-07-12 Thread mchitale
Hi Tom, On Tue, 2023-06-20 at 09:37 -0400, Tom Rini wrote: > On Sat, 03 Jun 2023 19:32:52 +0530, Mayuresh Chitale wrote: > > > This patchset adds support to load images of the SPL's next booting > > stage from a NVMe device. > > > > Changes in v4: > > - Drop patch 4 > > - Modify patch 2 to use g

Re: [RFC PATCH] riscv: sifive: fu70: downclock CPU clock for stability

2023-07-12 Thread Maciej W. Rozycki
On Wed, 28 Jun 2023, Icenowy Zheng wrote: > When building the package `rustc` for AOSC OS on HiFive Unmatched, > random SIGSEGV prevents the package from getting correctly built. > Downclocking the CPU PLL clock seems to allow rustc to be built, > although taking much more time. > > Downclock the

Re: [PATCH v4 0/4] SPL NVMe support

2023-07-12 Thread Heinrich Schuchardt
On 12.07.23 15:06, mchit...@ventanamicro.com wrote: Hi Tom, On Tue, 2023-06-20 at 09:37 -0400, Tom Rini wrote: On Sat, 03 Jun 2023 19:32:52 +0530, Mayuresh Chitale wrote: This patchset adds support to load images of the SPL's next booting stage from a NVMe device. Changes in v4: - Drop patch

Re: [RESEND PATCH v2 5/5] imx8mn-var-som: adjust PHY reset gpios according to hardware configuration

2023-07-12 Thread Hugo Villeneuve
On Wed, 12 Jul 2023 12:42:26 +0200 Stefano Babic wrote: > Hi Hugo, > > On 11.07.23 17:45, Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > > > For SOM with the EC configuration, the ethernet PHY is located on the > > SOM itself, and connected to the CPU ethernet controller. It has a > > re

Re: [RESEND PATCH v2 5/5] imx8mn-var-som: adjust PHY reset gpios according to hardware configuration

2023-07-12 Thread Stefano Babic
On 12.07.23 15:31, Hugo Villeneuve wrote: On Wed, 12 Jul 2023 12:42:26 +0200 Stefano Babic wrote: Hi Hugo, On 11.07.23 17:45, Hugo Villeneuve wrote: From: Hugo Villeneuve For SOM with the EC configuration, the ethernet PHY is located on the SOM itself, and connected to the CPU ethernet con

[PATCH v2 5/5] imx8mn-var-som: adjust PHY reset gpios according to hardware configuration

2023-07-12 Thread sbabic
> From: Hugo Villeneuve > For SOM with the EC configuration, the ethernet PHY is located on the > SOM itself, and connected to the CPU ethernet controller. It has a > reset line controlled via GPIO1_IO9. In this configuration, the PHY > located on the carrier board is not connected to anything and

[PATCH v1 3/5] arm64: dts: verdin-imx8mm: add ctrl_sleep_moci# hog

2023-07-12 Thread sbabic
> From: Andrejs Cainikovs > Drive CTRL_SLEEP_MOCI# high at boot (SPL) using a GPIO hog, this signal > may be used to control some power-rails on the carrier board, therefore > it should be set to high when the module is booting. > To do this as early as possible is generally a good idea and the is

[PATCH] arm: dts: imx8mp-beacon-kit: Enable USB Power domains

2023-07-12 Thread sbabic
> The USB Power domains should not have been removed as it causes > the board to hang if the USB is started. > Signed-off-by: Adam Ford > Reviewed-by: Fabio Estevam > diff --git a/arch/arm/dts/imx8mp-beacon-kit-u-boot.dtsi > b/arch/arm/dts/imx8mp-beacon-kit-u-boot.dtsi > index 5ca631e9d8..b56f3a

[PATCH 1/2] clk: imx8mp: Update clocks based on kernel 6.4-RC4

2023-07-12 Thread sbabic
> There are some newer clocks added to the kernel recently, > so to fix prepare for resycing the device trees, update > the clock list. Since there are some minor changes to > the USB clocks, update which USB clocks are enabled > to match with the upstream kernel as well. > Signed-off-by: Adam For

[PATCH v1 2/5] configs: verdin-imx8mm: enable spl_gpio_hog

2023-07-12 Thread sbabic
> From: Andrejs Cainikovs > Enable CONFIG_SPL_GPIO_HOG option to be able to control GPIO hogs from > SPL. > Signed-off-by: Andrejs Cainikovs > Signed-off-by: Marcel Ziswiler Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic --

[PATCH 3/3] mx23_olinuxino: Convert to CONFIG_DM_SERIAL

2023-07-12 Thread sbabic
> From: Fabio Estevam > The conversion to CONFIG_DM_SERIAL is mandatory, so select this option. > Signed-off-by: Fabio Estevam Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering

[PATCH v1 5/5] arm64: dts: verdin-imx8mp: add ctrl_sleep_moci# hog

2023-07-12 Thread sbabic
> From: Andrejs Cainikovs > Drive CTRL_SLEEP_MOCI# high at boot (SPL) using a GPIO hog, this signal > may be used to control some power-rails on the carrier board, therefore > it should be set to high when the module is booting. > To do this as early as possible is generally a good idea and the is

[PATCH 2/3] mx23evk: Convert to CONFIG_DM_SERIAL

2023-07-12 Thread sbabic
> From: Fabio Estevam > The conversion to CONFIG_DM_SERIAL is mandatory, so select this option. > Signed-off-by: Fabio Estevam Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering

[PATCH v1 2/2] board: colibri-imx8x: initialize snvs

2023-07-12 Thread sbabic
> Initialize Secure Non-Volatile Storage, aka SNVS. > Signed-off-by: Andrejs Cainikovs Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH,Managing Director: Erika Unt

[PATCH 1/2] config: xea: Disable support for boot methods EXTLINUX and VBE

2023-07-12 Thread sbabic
> The XEA system (imx287 based) is not using support for EXTLINUX and VBE. > As those configuration options have been enabled by default with modern > Kconfig it is safe to explicitly disable them. > After that change the u-boot.img size has been reduced by ~16 KiB. > Signed-off-by: Lukasz Majewski

[PATCH v1 1/5] verdin-imx8mm/verdin-imx8mp: synchronise device trees with linux

2023-07-12 Thread sbabic
> From: Marcel Ziswiler > Synchronise device trees with linux v6.5-rc1. > Signed-off-by: Marcel Ziswiler Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH,Managing

[PATCH 2/2] config: xea: Disable support for FAT file system

2023-07-12 Thread sbabic
> On the XEA (imx287) system the FAT file system is not used neither in > SPL nor u-boot proper. > Hence, to save ~6KiB of u-boot.img size - it has been disabled. > Signed-off-by: Lukasz Majewski Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic --

[PATCH 1/3] mx28evk: Convert to CONFIG_DM_SERIAL

2023-07-12 Thread sbabic
> From: Fabio Estevam > The conversion to CONFIG_DM_SERIAL is mandatory, so select this option. > Signed-off-by: Fabio Estevam Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering

[PATCH v1 4/5] configs: verdin-imx8mp: enable spl_gpio_hog

2023-07-12 Thread sbabic
> From: Andrejs Cainikovs > Enable CONFIG_SPL_GPIO_HOG option to be able to control GPIO hogs from > SPL. > Signed-off-by: Andrejs Cainikovs > Signed-off-by: Marcel Ziswiler Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic --

[PATCH 2/2] arm: dts: imx8mp: Sync the DT with kernel 6.4-rc4

2023-07-12 Thread sbabic
> Several changes have been made to the device tree > in the kernel, so update that as well as the > corresponding imx8mp-u-boot.dtsi files to prevent > breaking the booting. > Signed-off-by: Adam Ford > Reviewed-by: Fabio Estevam > diff --git a/arch/arm/dts/imx8mp-u-boot.dtsi b/arch/arm/dts/imx8

[PATCH v1 1/3] arm: k3: Fix ft_system_setup so it can be enabled on any SoC

2023-07-12 Thread Francesco Dolcini
From: Emanuele Ghidoli ft_system_setup cannot be enabled on SoC without msmc sram otherwise fdt_fixup_msmc_ram function fails causing system reset. Fix by calling fdt_fixup_msmc_ram only on these specific SoC: - J721S2 - AM654 - J721E This change was verified to not change anything on any exist

[PATCH v1 0/3] arm: mach-k3: am62: Add core number autodetection and fix fdt

2023-07-12 Thread Francesco Dolcini
From: Francesco Dolcini AM62x SoC is available in multiple variant with a different amount of CPU cores (Cortex-A) available, AM62x1, AM62x2, AM62x4 have respectively 1, 2 or 4 cores. Update the FDT with the actual core count as read from the SoC registers, with that change is possible to have a

[PATCH v1 2/3] arm: mach-k3: am62: Add CTRLMMR_WKUP_JTAG_DEVICE_ID register definition

2023-07-12 Thread Francesco Dolcini
From: Emanuele Ghidoli Add register address and relevant bitmasks and shifts. Allow reading these information: - device identification - number of cores (part of device identification) - features (currently: PRU / no PRU) - security - functional safety - speed grade - temperature grade - package

[PATCH v1 3/3] arm: mach-k3: am62: Fixup CPU core counts in fdt

2023-07-12 Thread Francesco Dolcini
From: Emanuele Ghidoli AM62x SoC is available in multiple variant with a different amount of CPU cores (Cortex-A) available, AM62x1, AM62x2, AM62x4 have respectively 1, 2 or 4 cores. Update the FDT with the actual core count as read from the SoC registers, with that change is possible to have a

Re: [PATCH] disk: Use BOOT_DEFAULTS instead of DISTRO_DEFAULTS

2023-07-12 Thread Simon Glass
On Tue, 11 Jul 2023 at 16:37, Jonas Karlman wrote: > > Set default y based on common BOOT_DEFAULTS instead of DISTRO_DEFAULTS. > > No change is intended, affected options is already implied for DISTRO > and BOOTSTD due to BOOT_DEFAULTS imply DOS_PARTITION (USB_STORAGE), > EFI_PARTITION and ISO_PAR

Re: [PATCH] CI: Add automatic retry for test.py jobs

2023-07-12 Thread Simon Glass
Hi Tom, On Tue, 11 Jul 2023 at 20:33, Tom Rini wrote: > > It is not uncommon for some of the QEMU-based jobs to fail not because > of a code issue but rather because of a timing issue or similar problem > that is out of our control. Make use of the keywords that Azure and > GitLab provide so that

Re: [PATCH v3] event: Add fpga load event

2023-07-12 Thread Simon Glass
On Wed, 12 Jul 2023 at 05:39, wrote: > > From: Christian Taedcke > > This enables implementing custom logic after a bitstream was loaded > into the fpga. > > Signed-off-by: Christian Taedcke > --- > > Changes in v3: > - replace #if with if > - remove previously added printf > - return notificati

Re: [RFC PATCH 1/3] scripts: kconfig: Add config fragment support in board/../

2023-07-12 Thread Simon Glass
Hi Jason, On Tue, 11 Jul 2023 at 16:29, Jason Kacines wrote: > > Add support to config fragments (.config) located in the /board > directory. This will allow only base defconfigs to live in /configs and Does this mean defconfigs? > all fragments to live in their respective device directory in /

Re: [RFC PATCH 0/3] Minimal platform configuration

2023-07-12 Thread Simon Glass
Hi Jason, On Tue, 11 Jul 2023 at 16:28, Jason Kacines wrote: > > When someone attempts to bring up a custom board using TI SoCs (am62x in > this case), it often takes several days for someone to reduce the > current configuration from the TI EVM/SK boards to a configuration that > works for their

Re: [PATCH v2 00/19] bootstd: Add a bootmeth for ChromiumOS on x86

2023-07-12 Thread Simon Glass
Hi Bin, On Wed, 12 Jul 2023 at 05:54, Bin Meng wrote: > > Hi Simon, > > On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > > > This series adds a simple bootmeth for ChromiumOS on x86. It uses zimage > > to boot the kernel. > > > > Full verified boot is not included at this stage - that is s

Re: [PATCH v2 18/19] x86: coreboot: Adjust various config options

2023-07-12 Thread Simon Glass
Hi Bin, On Wed, 12 Jul 2023 at 05:58, Bin Meng wrote: > > Hi Simon, > > On Tue, Jun 20, 2023 at 4:23 PM Simon Glass wrote: > > > > Drop IDE since this is not widely used anymore. Add NVME since it is > > becoming more popular. > > > > Add ms so it is easier to search for tables in memory. > > >

Re: [PATCH] fdt: cmd: allow to add chosen properties

2023-07-12 Thread Simon Glass
Hi Alexander, On Sat, 27 May 2023 at 16:02, Alexander Couzens wrote: > > Add command fdt chosenu32/chosenstr to allow setting runtime properties. > This is useful to pass information to the OS. > E.g. which slot is currently booted in a A/B/recovery scheme. > Or the reset reason which may only vi

Re: [PATCH v4 1/3] binman: Add support for externally encrypted blobs

2023-07-12 Thread Simon Glass
Hi Christian, On Wed, 12 Jul 2023 at 03:20, Taedcke, Christian wrote: > > Hello Simon, > > thank you for your help so far. > > On 11.07.2023 17:01, Simon Glass wrote: > > Hi Christian, > > > > On Tue, 11 Jul 2023 at 08:58, Taedcke, Christian > > wrote: > >> > >> Hello Jonas, > >> > >> On 10.07.2

Re: [PATCH v2 07/19] bootstd: Use the bootargs env var for changing the cmdline

2023-07-12 Thread Simon Glass
Hi Bin, On Wed, 12 Jul 2023 at 05:48, Bin Meng wrote: > > Hi Simon, > > On Tue, Jun 20, 2023 at 4:24 PM Simon Glass wrote: > > > > The "bootargs" environment variable is used to set the command-line > > arguments to pass to the OS. Use this same mechanism with bootstd as well. > > When the varia

Re: [PATCH 0/4] introduce EFI_RAM_DISK_PROTOCOL

2023-07-12 Thread Simon Glass
Hi Heinrich, On Wed, 12 Jul 2023 at 00:41, Heinrich Schuchardt wrote: > > On 7/11/23 21:13, Simon Glass wrote: > > Hi, > > > > On Tue, 11 Jul 2023 at 00:23, Masahisa Kojima > > wrote: > >> > >> On Mon, 10 Jul 2023 at 11:28, AKASHI Takahiro > >> wrote: > >>> > >>> On Mon, Jul 10, 2023 at 11:13:1

Re: [PATCH v4 01/45] x86: Return mtrr_add_request() to its old purpose

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > This function used to be for adding a list of requests to be actioned on > relocation. Revert it back to this purpose, to avoid problems with boards > which need control of their MTRRs (i.e. those which don't use FSP). > > The mtrr_

Re: [PATCH v4 02/45] x86: Allow listing MTRRs in SPL

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Move MTRR-listing code into a common file so it can be used from SPL. > Update the 'mtrr' command to call it. > > Use this in SPL just before adjusting the MTRRs, so we can see the state > set up by the board. Only show it when debu

Re: [PATCH v4 03/45] x86: mtrr: Add documentation

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Add documention for the x86 'mtrr' command. > > Signed-off-by: Simon Glass > Suggested-by: Heinrich Schuchardt > --- > > (no changes since v2) > > Changes in v2: > - Add new patch with docs for mtrr command > > doc/usage/cmd/mtrr.rst | 151

Re: [PATCH v4 04/45] bios_emulator: Add Kconfig and adjust Makefile for SPL

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > The Kconfig for this is currently inside a particular board. Move it into > the correct place and allow use in SPL, so that video can be used there > if needed. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > board/google/

Re: [PATCH v4 05/45] bios_emulator: Drop VIDEO_IO_OFFSET

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > This is always zero in the source tree, so drop it. > > While we are here, add a comment to _X86EMU_env since it the symbol is Remove "it" > actually defined twice, which can cause confusion when building. > > Signed-off-by: Simon Glass > -

Re: [PATCH v4 06/45] x86: Tidy up EFI code in interrupt_init()

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > The ll_boot_init() check handles the EFI case so we don't need the rest > of the code. Drop it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/x86/cpu/i386/interrupt.c | 17 + > 1 file changed, 5 inse

Re: [PATCH v4 07/45] x86: Add a comment for board_init_f_r_trampoline()

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Add a comment for this function in the header. > > Change the function (and the one after) to use __noreturn to keep > checkpatch happy. > > Add docs to board_init_f_r() while we are here. > > Signed-off-by: Simon Glass > --- > > (no changes

Re: [PATCH v4 08/45] x86: Show the CPU physical address size with bdinfo

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > This is useful information so show it with the bdinfo command. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/x86/lib/bdinfo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/lib/bdinfo.c

Re: [PATCH v4 09/45] x86: Correct get_sp() implementation for 64-bit

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Use an assembler implementation as is done for i386, so that the results > are equivalent. The commit message is confusing. It says "Correct the implementation ..." and here it says "the results are equivalent", but what was change

Re: [PATCH v4 10/45] x86: Show an error when a BIOS exception occurs

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Rather than silently hanging, show an error first. This can happen when > there is something wrong with the video BIOS. > > Signed-off-by: Simon Glass > --- > > (no changes since v2) > > Changes in v2: > - Fix BINS typo > - Drop the Ooops str

Re: [PATCH v4 11/45] acpi: Add a comment to set the acpi tables

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Sometimes a previous bootloader has written ACPI tables. It is useful to > be able to find and list these. Add an 'acpi set' command to set the > address for these tables. > > Signed-off-by: Simon Glass > --- > > (no changes since

Re: [PATCH v4 12/45] bdinfo: Show the RAM top and approximate stack pointer

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > These are useful pieces of information when debugging. The RAM top shows > where U-Boot started allocating memory from, before it relocated. The > stack pointer can be checked to ensure it is in the correct region. > > Signed-off-by: Simon Gla

Re: [PATCH v4 13/45] part: Allow setting the partition-table type

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Some devices have multiple partition types available on the same media. > It is sometimes useful to see these to check that everything is working > correctly. > > Provide a way to manually set the partition-table type, avoiding the > auto-dete

Re: [PATCH v4 14/45] qfw: Show the file address if available

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Some files have an associated address. Show this with the 'qfw list' > command so that it is possible to dump the data. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > cmd/qfw.c | 2 +- > doc/usage/

Re: [PATCH v4 15/45] log: Tidy up an ambiguous comment.

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Add a a bit more detail so it is clear that multiple devices are Remove one 'a' also, please remove the period in the commit summary > supported, but only one per driver. > > Signed-off-by: Simon Glass > --- > > (no changes sinc

Re: [PATCH v4 16/45] qfw: Set the address of the ACPI tables

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > Once the ACPI tables have been set up, record their address so that it is > possible to list them with 'acpi list'. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/misc/qfw.c | 4 > 1 file changed, 4 insertion

Re: [PATCH v4 17/45] efi: Show all known UUIDs with CONFIG_CMD_EFIDEBUG

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > The CMD_EFIDEBUG option enables debugging so it is reasonable to assume > that all effects should be made to decode the dreaded UUIDs favoured by > UEFI. > > Update the table to show them all when CONFIG_CMD_EFIDEBUG is enabled. > > Signed-off

Re: [PATCH v4 19/45] Show the malloc base with the bdinfo command

2023-07-12 Thread Bin Meng
Hi Simon, On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > nits: please add the 'bdinfo' tag in the commit summary > It is useful to see the base of the malloc region. This is visible when > debugging but not in normal usage. > > Add it to the global data so that it can be shown. > > Signed

Re: [PATCH v4 18/45] x86: Improve the trampoline in 64-bit mode

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > At present this leaves the stack at the pre-relocation value. This is not > ideal since we want to have U-Boot running entirely from the top of > memory. > > In addition, the new global_data pointer is not actually used, since > the global_dat

Re: [PATCH v4 20/45] nvme: Provide more useful debugging messages

2023-07-12 Thread Bin Meng
On Mon, Jun 19, 2023 at 8:01 PM Simon Glass wrote: > > When scanning fails it is useful to be able to decode what went wrong. Add > some debugging for this. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/nvme/nvme.c | 36 ++-- > 1 file

Re: [PATCH v1 1/3] arm: k3: Fix ft_system_setup so it can be enabled on any SoC

2023-07-12 Thread Andrew Davis
On 7/12/23 8:47 AM, Francesco Dolcini wrote: From: Emanuele Ghidoli ft_system_setup cannot be enabled on SoC without msmc sram otherwise fdt_fixup_msmc_ram function fails causing system reset. Fix by calling fdt_fixup_msmc_ram only on these specific SoC: - J721S2 - AM654 - J721E This change w

Re: [PATCH v1 2/3] arm: mach-k3: am62: Add CTRLMMR_WKUP_JTAG_DEVICE_ID register definition

2023-07-12 Thread Andrew Davis
On 7/12/23 8:47 AM, Francesco Dolcini wrote: From: Emanuele Ghidoli Add register address and relevant bitmasks and shifts. Allow reading these information: - device identification - number of cores (part of device identification) - features (currently: PRU / no PRU) - security - functional safe

Re: [PATCH v1 2/3] arm: mach-k3: am62: Add CTRLMMR_WKUP_JTAG_DEVICE_ID register definition

2023-07-12 Thread Francesco Dolcini
On Wed, Jul 12, 2023 at 09:18:42AM -0500, Andrew Davis wrote: > On 7/12/23 8:47 AM, Francesco Dolcini wrote: > > From: Emanuele Ghidoli > > > > Add register address and relevant bitmasks and shifts. > > Allow reading these information: > > - device identification > > - number of cores (part of de

Re: [PATCH v1 1/3] arm: k3: Fix ft_system_setup so it can be enabled on any SoC

2023-07-12 Thread Francesco Dolcini
On Wed, Jul 12, 2023 at 09:15:21AM -0500, Andrew Davis wrote: > On 7/12/23 8:47 AM, Francesco Dolcini wrote: > > From: Emanuele Ghidoli > > > > ft_system_setup cannot be enabled on SoC without msmc sram otherwise > > fdt_fixup_msmc_ram function fails causing system reset. > > > > Fix by calling

Re: [PATCH v1 1/3] arm: k3: Fix ft_system_setup so it can be enabled on any SoC

2023-07-12 Thread Andrew Davis
On 7/12/23 9:32 AM, Francesco Dolcini wrote: On Wed, Jul 12, 2023 at 09:15:21AM -0500, Andrew Davis wrote: On 7/12/23 8:47 AM, Francesco Dolcini wrote: From: Emanuele Ghidoli ft_system_setup cannot be enabled on SoC without msmc sram otherwise fdt_fixup_msmc_ram function fails causing system

[PATCH v3 00/18] bootstd: Add a bootmeth for ChromiumOS on x86

2023-07-12 Thread Simon Glass
This series adds a simple bootmeth for ChromiumOS on x86. It uses zimage to boot the kernel. Full verified boot is not included at this stage - that is still a separate chunk of code to be brought into standard boot at some point. For now it just obtains the kernel and command line and boots. This

[PATCH v3 01/18] test: Skip flat-tree tests if devicetree is not used

2023-07-12 Thread Simon Glass
Many tests don't actually use the devicetree at all so there is no point in running the tests both with livetree and flat tree. Check for this and skip the flat tree test in that case. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) test/test-main.c | 3 ++- 1 file

[PATCH v3 02/18] bootstd: Correct the name of the QEMU bootmeth

2023-07-12 Thread Simon Glass
This does not relate to sandbox. Correct the name. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) boot/bootmeth_qfw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/bootmeth_qfw.c b/boot/bootmeth_qfw.c index ecd4b082fd20..8ebbc3ebcd58 1006

[PATCH v3 04/18] bootstd: Correct baudrate typo

2023-07-12 Thread Simon Glass
This is a copy error. Fix it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) boot/bootmeth-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/bootmeth-uclass.c b/boot/bootmeth-uclass.c index 3b3e0614dafa..33662a753889 100644 --- a/boo

[PATCH v3 05/18] bootstd: Allow storing the OS command line in the bootflow

2023-07-12 Thread Simon Glass
Some operating systems have a command line which can be adjusted before booting. Store this in the bootflow so it can be controlled within U-Boot. Fix up the example output while we are here, since there are a few new items. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes sinc

[PATCH v3 03/18] bootstd: Use bootdev instead of bootdevice

2023-07-12 Thread Simon Glass
It seems better to call this a 'bootdev' since this is name used in the documentation. The older 'Bootdevice' name is no-longer used and may cause confusion with the 'bootdevice' environment variable. Update throughout to use bootdev. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no ch

[PATCH v3 06/18] bootstd: Use the bootargs env var for changing the cmdline

2023-07-12 Thread Simon Glass
The "bootargs" environment variable is used to set the command-line arguments to pass to the OS. Use this same mechanism with bootstd as well. When the variable is updated, it is written to the current bootflow. When the current bootflow is updated, the environment variable is updated too. Signed-

[PATCH v3 07/18] bootstd: Allow storing x86 setup information

2023-07-12 Thread Simon Glass
On x86 boards Linux uses a block of binary data to provide information about the command line, memory map, etc. Provide a way to store this in the bootflow so it can be passed on to the OS. No attempt is made to generalise the code, since other archs don't need this information. The field is prese

[PATCH v3 08/18] bdinfo: Show information about the serial port

2023-07-12 Thread Simon Glass
It is useful to see the detailed setting of the serial port, e.g. to allow setting up earlycon or console for Linux. Add this output to the 'bdinfo' command. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) cmd/bdinfo.c | 21 + 1 file changed, 21

[PATCH v3 09/18] bootstd: Add a function to update a command line

2023-07-12 Thread Simon Glass
The Linux command line consists of a number of words with optional values. At present U-Boot allows this to be changed using the bootargs environment variable. But this is quite painful, since the command line can be very long. Add a function which can adjust a single field in the command line, s

  1   2   >