Re: [PATCH] distroboot: Fix ubifs

2022-07-05 Thread Alexander Dahl
Hello Pali, Am Mon, Jul 04, 2022 at 09:55:53AM +0200 schrieb Pali Rohár: > Hello! > > On Thursday 30 June 2022 08:46:59 Alexander Dahl wrote: > > Hello, > > > > Am Mittwoch, 29. Juni 2022, 15:55:27 CEST schrieb Pali Rohár: > > > Hello! > > > > > > On Wednesday 29 June 2022 15:36:57 Alexander Da

Re: [PATCH 1/8] arm64: dts: sdm845: Remove redundant u-boot DT properties

2022-07-05 Thread Daniel Thompson
On Tue, Jul 05, 2022 at 11:05:04AM +0530, Sumit Garg wrote: > Hi Daniel, > > Thanks for your review. > > On Mon, 4 Jul 2022 at 21:28, Daniel Thompson > wrote: > > > > On Mon, Jul 04, 2022 at 06:28:38PM +0530, Sumit Garg wrote: > > > U-boot specific DT properties belong to *-uboot.dtsi > > > > .

Re: [PATCH] doc: board: amlogic: add documentation on boot flow

2022-07-05 Thread Simon Glass
On Mon, 4 Jul 2022 at 08:10, Neil Armstrong wrote: > > This is a preliminary documentation introducing different > boot sequences, and notably the recovery mode. > > Signed-off-by: Neil Armstrong > --- > doc/board/amlogic/boot-flow.rst | 147 > doc/board/amlogic/

Re: [PATCH v6 5/7] cmd: rng: Use a statically allocated array for random bytes

2022-07-05 Thread Simon Glass
On Mon, 4 Jul 2022 at 07:35, Sughosh Ganu wrote: > > Use a statically allocated buffer on stack instead of using malloc for > reading the random bytes. Using a local array is faster than > allocating heap memory on every initiation of the command. > > Signed-off-by: Sughosh Ganu > --- > Changes s

Re: [PATCH v6 2/7] tpm: rng: Add driver model interface for TPM RNG device

2022-07-05 Thread Simon Glass
Hi Sughosh, On Mon, 4 Jul 2022 at 07:35, Sughosh Ganu wrote: > > The TPM device has a builtin random number generator(RNG) > functionality. Expose the RNG functions of the TPM device to the > driver model so that they can be used by the EFI_RNG_PROTOCOL if the > protocol is installed. > > Also ch

Re: [PATCH v6 0/7] tpm: rng: Move TPM RNG functionality to driver model

2022-07-05 Thread Simon Glass
Hi Sughosh, On Mon, 4 Jul 2022 at 07:35, Sughosh Ganu wrote: > > > The TPM device provides the random number generator(RNG) > functionality, whereby sending a command to the TPM device results in > the TPM device responding with random bytes. > > There was a discussion on the mailing list earlier

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-05 Thread Simon Glass
Hi Sughosh, On Mon, 4 Jul 2022 at 07:35, Sughosh Ganu wrote: > > The TPM device comes with the random number generator(RNG) > functionality which is built into the TPM device. Add logic to add the > RNG child device in the TPM uclass post probe callback. > > The RNG device can then be used to pas

Re: [PATCH] cmd: fix do_adc_single()

2022-07-05 Thread Simon Glass
On Sun, 3 Jul 2022 at 06:49, Vyacheslav Bocharov wrote: > > The source code contains an error: > - argv[2] contains arg, variable for env_set is in argv[3] > - number of args is 4 > > Revert 54d24d72601321f4470c4edf31c6b29adae424a7 > cmd: simplify do_adc_single() > > Fixes 9de612ae4ded53f742f5f

Re: [Update license 1/1] drivers: clk: Update license for Intel N5X device

2022-07-05 Thread Simon Glass
Hi, On Wed, 29 Jun 2022 at 10:58, wrote: > > From: Teik Heng Chong > > All the source code of clk-mem-n5x.c and clk-n5x.c are from Intel, > update the license to use both GPL2.0 and BSD-3 Clause because this > copy of code may used for open source and internal project. > > Signed-off-by: Teik He

Re: [PATCH] log: force DEBUG when LOG_DEBUG is activated

2022-07-05 Thread Simon Glass
Hi Patrick, On Thu, 30 Jun 2022 at 11:33, Patrick Delaunay wrote: > > When CONFIG_LOG is activated, if LOG_DEBUG is defined in a file and > DEBUG is not defined the trace with debug() macro are not displayed, > because the parameter cond : _DEBUG = 0 is checked in debug_cond(). > > With this patc

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-05 Thread Simon Glass
Hi Tom, On Sun, 3 Jul 2022 at 06:43, Tom Rini wrote: > > On Sun, Jul 03, 2022 at 02:32:42AM -0600, Simon Glass wrote: > > Hi, > > > > On Sun, 3 Jul 2022 at 02:25, Simon Glass wrote: > > > > > > The fdt_path_offset() function is slow since it must scan the tree. > > > This substantial overhead no

Re: [PATCH v2 1/6] patman: Fix updating argument defaults from settings

2022-07-05 Thread Simon Glass
On Fri, 1 Jul 2022 at 14:24, Douglas Anderson wrote: > > Ever since commit 4600767d294d ("patman: Refactor how the default > subcommand works"), when I use patman on the Linux tree I get grumbles > about unknown tags. This is because the Linux default making > process_tags be False wasn't working

Re: [PATCH v2 2/6] patman: Fix implicit command inserting

2022-07-05 Thread Simon Glass
On Fri, 1 Jul 2022 at 14:24, Douglas Anderson wrote: > > The logic to insert an implicit command has always been a bit broken > but it was masked by another bug fixed in the patch ("patman: Don't > look at sys.argv when parsing settings"). Specifically, imagine that > you're just calling patman li

Re: [PATCH v2 4/6] patman: Make most bool arguments BooleanOptionalAction

2022-07-05 Thread Simon Glass
On Fri, 1 Jul 2022 at 14:24, Douglas Anderson wrote: > > For boolean arguments it's convenient to be able to specify both the > argument and its opposite on the command line. This is especially > convenient because you can change the default via the settings file > and being able express the oppos

Re: [PATCH v2 3/6] patman: Don't look at sys.argv when parsing settings

2022-07-05 Thread Simon Glass
On Fri, 1 Jul 2022 at 14:24, Douglas Anderson wrote: > > If you call the parser and tell it to parse but don't pass arguments > in then it will default to looking at sys.argv. This isn't really what > was intended and seems to have some side effects. Let's not do it. > > NOTE: to see some of the s

Re: [PATCH v2 6/6] patman: Take project defaults into account for --help

2022-07-05 Thread Simon Glass
On Fri, 1 Jul 2022 at 14:24, Douglas Anderson wrote: > > I'd like it so that when you do "patman send --help" and you're using > Linux that it show it the proper defaults for Linux. > > Signed-off-by: Douglas Anderson > Tested-by: Brian Norris > --- > > Changes in v2: > - Make comment about pars

Re: Please pull u-boot-dm/next

2022-07-05 Thread Simon Glass
Hi Tom, On Tue, 28 Jun 2022 at 07:41, Simon Glass wrote: > > Hi Tom, > > This is for the -next branch. > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/commit/e87da5704ffa6fc782d93d137fa30a37a5df3566 > > > The following changes since commit ea82ed8c2eaee0a0f7dee31016aaee4ce88e9ea7: > >

Re: [PATCH v2 5/6] patman: By default don't pass "--no-tree" to checkpatch for linux

2022-07-05 Thread Simon Glass
On Fri, 1 Jul 2022 at 14:24, Douglas Anderson wrote: > > When you pass "--no-tree" to checkpatch it disables some extra checks > that are important for Linux. Specifically I want checks like: > > warning: DT compatible string "boogie,woogie" appears un-documented > check ./Documentation/device

Re: [PATCH] distroboot: Fix ubifs

2022-07-05 Thread Pali Rohár
On Tuesday 05 July 2022 09:32:09 Alexander Dahl wrote: > Hello Pali, > > Am Mon, Jul 04, 2022 at 09:55:53AM +0200 schrieb Pali Rohár: > > Hello! > > > > On Thursday 30 June 2022 08:46:59 Alexander Dahl wrote: > > > Hello, > > > > > > Am Mittwoch, 29. Juni 2022, 15:55:27 CEST schrieb Pali Rohár:

Re: [PATCH] distroboot: Fix ubifs

2022-07-05 Thread Pali Rohár
On Wednesday 29 June 2022 12:29:40 Frieder Schrempf wrote: > Am 23.06.22 um 18:09 schrieb Pali Rohár: > > On Tuesday 31 May 2022 10:32:36 Pali Rohár wrote: > >> Fix multiple issues in ubifs distroboot code: > >> > >> U-Boot supports attaching only one MTD device as UBI at the time. So > >> always c

Re: [PATCH] Kconfig: Fix SYS_MALLOC_F_LEN for i.MX8MQ

2022-07-05 Thread Heiko Thiery
Hi all, Am Mo., 11. Apr. 2022 um 14:29 Uhr schrieb Tom Rini : > > On Mon, Apr 11, 2022 at 05:07:04PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > i.MX8MQ use SYS_MALLOC_F_LEN 0x2000, not 0x1. The OCRAM_S only has > > 32KB memory, use 0x1 will make SPL not bootable. > > > > Si

Re: [PATCH 6/9] dm: core: Support accessing core tags

2022-07-05 Thread Tom Rini
On Tue, Jun 28, 2022 at 11:18:51PM +0900, AKASHI Takahiro wrote: > On Tue, Jun 28, 2022 at 09:37:56AM -0400, Simon Glass wrote: > > Hi Simon, > > > > On Sun, May 08, 2022 at 04:39:24AM -0600, Simon Glass wrote: > > > At present tag numbers are only allocated for non-core data, meaning that > > > t

[PATCH v1 0/6] Add Rockchip IDB device

2022-07-05 Thread Johan Jonker
From: Johan Jonker Add Rockchip IDB device for U-boot. On Rockchip SoCs with a NAND as boot device the information data base (IDB) loaded by the boot ROM is stored at the beginning of several erase blocks. Rewriting NAND blocks makes them wear out, so some spare blocks and a writing strategy a

[PATCH v1 1/6] rockchip: block: add Rockchip IDB block device

2022-07-05 Thread Johan Jonker
From: Johan Jonker The Rockchip SoCs with a NAND as boot device need a special Rockchip IDB block device to transfer the data from the rockusb gadget to the NAND driver. Signed-off-by: Johan Jonker --- arch/arm/mach-rockchip/Kconfig| 12 + arch/arm/mach-rockchip/Makefile |1

[PATCH v1 2/6] rockchip: spl: allow more boot devices

2022-07-05 Thread Johan Jonker
From: Johan Jonker Rockchip SoCs have more boot device options then currently included in the function spl_boot_device(). Make this function generic for SPI and NAND. Signed-off-by: Johan Jonker --- This patch should replace a patch in the serie called: [PATCH v1 02/17] rockchip: spl: allow mo

[PATCH v1 3/6] rockchip: rk3066: add Rockchip IDB block device as boot action

2022-07-05 Thread Johan Jonker
From: Johan Jonker Add Rockchip IDB block device as boot action for rk3066. When a key is pressed the NAND IDB blocks can be accessed by a USB gadget like rockusb. Signed-off-by: Johan Jonker --- This patch comes on top of a serie called: [PATCH v1 00/17] Add rk3066 ADC and USB support https:/

[PATCH v1 4/6] arm: dts: rockchip: sync rk3066/rk3188 DT files from Linux

2022-07-05 Thread Johan Jonker
From: Johan Jonker Sync rk3066/rk3188 DT files from Linux. This is the state as of v5.18 in Linux + nfc node for MK808 rk3066a. CRU nodes now have a clock property. To prefend dtoc errors a fixed clock must also be included for tpl/spl in the rk3xxx-u-boot.dtsi file. Signed-off-by: Johan Jonker

[PATCH v1 5/6] arm: dts: rockchip: enable nfc node in spl for rk3066 mk808

2022-07-05 Thread Johan Jonker
From: Johan Jonker Enable the nfc node in spl for rk3066 mk808 in the rk3066a-mk808-u-boot.dtsi file. Signed-off-by: Johan Jonker --- arch/arm/dts/rk3066a-mk808-u-boot.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts/rk3066a-mk808-u-boot.dtsi b/arch/arm/dts/rk3066

[PATCH v1 6/6] rockchip: configs: mk808: add idb configs

2022-07-05 Thread Johan Jonker
From: Johan Jonker Add IDB configs for mk808. Signed-off-by: Johan Jonker --- This patch comes on top of a serie called: [PATCH v1 00/17] Add rk3066 ADC and USB support https://lore.kernel.org/u-boot/20220508150825.21711-1-jbx6...@gmail.com/ --- configs/mk808_defconfig | 4 1 file change

Re: [PATCH 6/9] dm: core: Support accessing core tags

2022-07-05 Thread Simon Glass
Hi, On Tue, 5 Jul 2022 at 13:39, Tom Rini wrote: > > On Tue, Jun 28, 2022 at 11:18:51PM +0900, AKASHI Takahiro wrote: > > On Tue, Jun 28, 2022 at 09:37:56AM -0400, Simon Glass wrote: > > > Hi Simon, > > > > > > On Sun, May 08, 2022 at 04:39:24AM -0600, Simon Glass wrote: > > > > At present tag nu

Re: [PATCH] Kconfig: Fix SYS_MALLOC_F_LEN for i.MX8MQ

2022-07-05 Thread Tom Rini
On Tue, Jul 05, 2022 at 12:19:54PM +0200, Heiko Thiery wrote: > Hi all, > > Am Mo., 11. Apr. 2022 um 14:29 Uhr schrieb Tom Rini : > > > > On Mon, Apr 11, 2022 at 05:07:04PM +0800, Peng Fan (OSS) wrote: > > > > > From: Peng Fan > > > > > > i.MX8MQ use SYS_MALLOC_F_LEN 0x2000, not 0x1. The OCRA

Re: [GIT PULL] please pull fsl-qoriq-2022-7-3

2022-07-05 Thread Tom Rini
On Tue, Jul 05, 2022 at 01:29:19AM +, Peng Fan (OSS) wrote: > Hi Tom, > > Please pull fsl-qoriq-2022-7-3 based on your next branch for 2022.10 > CI: > https://source.denx.de/u-boot/custodians/u-boot-fsl-qoriq/-/pipelines/12603 > Applied to u-boot/next, thanks! -- Tom signature.asc Desc

Re: [PATCH] doc: board: amlogic: add documentation on boot flow

2022-07-05 Thread Mattijs Korpershoek
On Mon, Jul 04, 2022 at 16:10, "Neil Armstrong" wrote: > This is a preliminary documentation introducing different > boot sequences, and notably the recovery mode. > > Signed-off-by: Neil Armstrong Reviewed-by: Mattijs Korpershoek > --- > doc/board/amlogic/boot-flow.rst | 147 +++

Re: [PATCH 1/5] lib: crypto: add mscode_parser

2022-07-05 Thread Jason A. Donenfeld
On Tue, Jul 05, 2022 at 02:48:11PM +0900, AKASHI Takahiro wrote: > + This option provides support for parsing MicroSoft's Authenticode > + in pkcs7 message. I chuckled when I saw "MicroSoft" in the cover letter, thinking it was a wink, but here too... haha ummm. We could change it to "

Re: [Update license 1/1] drivers: clk: Update license for Intel N5X device

2022-07-05 Thread Tom Rini
On Tue, Jul 05, 2022 at 03:47:20AM -0600, Simon Glass wrote: > Hi, > > On Wed, 29 Jun 2022 at 10:58, wrote: > > > > From: Teik Heng Chong > > > > All the source code of clk-mem-n5x.c and clk-n5x.c are from Intel, > > update the license to use both GPL2.0 and BSD-3 Clause because this > > copy of

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-05 Thread Rasmus Villemoes
On 05/07/2022 11.47, Simon Glass wrote: > Hi Tom, > > On Sun, 3 Jul 2022 at 06:43, Tom Rini wrote: >> >> On Sun, Jul 03, 2022 at 02:32:42AM -0600, Simon Glass wrote: >>> Hi, >>> >>> On Sun, 3 Jul 2022 at 02:25, Simon Glass wrote: The fdt_path_offset() function is slow since it must sca

Re: [Update license 1/1] drivers: clk: Update license for Intel N5X device

2022-07-05 Thread Sean Anderson
On 7/5/22 5:47 AM, Simon Glass wrote: Hi, On Wed, 29 Jun 2022 at 10:58, wrote: From: Teik Heng Chong All the source code of clk-mem-n5x.c and clk-n5x.c are from Intel, update the license to use both GPL2.0 and BSD-3 Clause because this copy of code may used for open source and internal proj

Re: [Update license 1/1] drivers: clk: Update license for Intel N5X device

2022-07-05 Thread Tom Rini
On Tue, Jul 05, 2022 at 09:48:45AM -0400, Sean Anderson wrote: > On 7/5/22 5:47 AM, Simon Glass wrote: > > Hi, > > > > On Wed, 29 Jun 2022 at 10:58, wrote: > > > > > > From: Teik Heng Chong > > > > > > All the source code of clk-mem-n5x.c and clk-n5x.c are from Intel, > > > update the license

Re: [PATCH v1 1/6] rockchip: block: add Rockchip IDB block device

2022-07-05 Thread Xavier Drudis Ferran
Thanks for your work. El Tue, Jul 05, 2022 at 03:04:15PM +0200, Johan Jonker deia: > From: Johan Jonker > > The Rockchip SoCs with a NAND as boot device need > a special Rockchip IDB block device to transfer the data > from the rockusb gadget to the NAND driver. > Sorry for the fast browsing

[PATCH 3/4] configs: stm32mp15: increase malloc size for pre-reloc

2022-07-05 Thread Patrick Delaunay
With support of SCMI in OP-TEE, the early malloc usage increase, the associated defined CONFIG_SYS_MALLOC_F_LEN need to be increased. For example, for stm32mp15_defconfig and stm32mp157c-dk2-scmi.dtsi, we have: Early malloc usage: 14098 / 8 Signed-off-by: Patrick Delaunay --- configs/stm3

[PATCH 1/4] ARM: dts: stm32mp15: alignment with v5.19

2022-07-05 Thread Patrick Delaunay
Device tree alignment with Linux kernel v5.19-rc1 - ARM: dts: stm32: Add alternate pinmux for ethernet0 pins - ARM: dts: stm32: Add alternate pinmux for mco2 pins - ARM: dts: stm32: fix pinctrl node name warnings (MPU soc) - ARM: dts: stm32: stm32mp15-pinctrl: add spi1-1 pinmux group - dt-bindings

[PATCH 4/4] ARM: dts: stm32: add SCMI version of STM32 boards (DK1/DK2/ED1/EV1)

2022-07-05 Thread Patrick Delaunay
Add a "secure" version of STM32 boards based on SCMI when RCC_TZCR.TZEN=1. Only boards provided by STMicroelectronics are concerned: -STM32MP157A-DK1 -STM32MP157C-DK2 -STM32MP157C-ED1 -STM32MP157C-EV1 The resources secured by RCC_TZCR.TZEN=1 are managed by OP-TEE and the associated SCMI services,

[PATCH 2/4] clk: stm32: add support compatible st, stm32mp1-rcc-secure

2022-07-05 Thread Patrick Delaunay
Add support for new compatible st,stm32mp1-rcc-secure used when the RCC resource is managed by secured world (RCC_TZCR.TZEN=1) iand when SCMI is used. Signed-off-by: Patrick Delaunay --- drivers/misc/stm32_rcc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/stm32_rcc.c b/driv

Re: [PATCH] Kconfig: Fix SYS_MALLOC_F_LEN for i.MX8MQ

2022-07-05 Thread Heiko Thiery
Hi Tom, Am Di., 5. Juli 2022 um 15:35 Uhr schrieb Tom Rini : > > On Tue, Jul 05, 2022 at 12:19:54PM +0200, Heiko Thiery wrote: > > Hi all, > > > > Am Mo., 11. Apr. 2022 um 14:29 Uhr schrieb Tom Rini : > > > > > > On Mon, Apr 11, 2022 at 05:07:04PM +0800, Peng Fan (OSS) wrote: > > > > > > > From: P

Re: [RFC] Proposed location to host the firmware handoff specification.

2022-07-05 Thread Rob Herring
On Thu, Jun 30, 2022 at 3:24 AM Simon Glass wrote: > > Hi Jose, > > I don't think this is correct. TF-A is a project that aims to replace > U-Boot SPL (and perhaps other components) with more closed firmware, > e.g. the permissive license. > > This spec needs to be in a neutral place, not captive

Re: [PATCH 3/5] efi_loader: image_loader: replace EFI_PRINT with log macros

2022-07-05 Thread Heinrich Schuchardt
On 7/5/22 07:48, AKASHI Takahiro wrote: Now We are migrating from EFI_PRINT() to log macro's. I don't understand your logic: log_err("Parsing image's signature failed\n"); log_debug("Signature was rejected by \"dbx\"\n"); Shouldn't everything leading to a signature being rejected be treated t

Re: [PATCH 4/5] efi_loader: image_loader: add a missing digest verification for signed PE image

2022-07-05 Thread Heinrich Schuchardt
On 7/5/22 07:48, AKASHI Takahiro wrote: At the last step of PE image authentication, an image's hash value must be compared with a message digest stored as the content (of SpcPeImageData type) of pkcs7's contentInfo. Fixes: commit 4540dabdcaca ("efi_loader: image_loader: support image authentic

Re: [PATCH] Kconfig: Fix SYS_MALLOC_F_LEN for i.MX8MQ

2022-07-05 Thread Tom Rini
On Tue, Jul 05, 2022 at 05:20:46PM +0200, Heiko Thiery wrote: > Hi Tom, > > Am Di., 5. Juli 2022 um 15:35 Uhr schrieb Tom Rini : > > > > On Tue, Jul 05, 2022 at 12:19:54PM +0200, Heiko Thiery wrote: > > > Hi all, > > > > > > Am Mo., 11. Apr. 2022 um 14:29 Uhr schrieb Tom Rini : > > > > > > > > On

Re: [PATCH] scripts/Makefile.lib: add -D__U_BOOT__ to dtc_cpp_flags

2022-07-05 Thread Tom Rini
On Mon, Jul 04, 2022 at 12:59:58PM +0200, Rasmus Villemoes wrote: > On 01/07/2022 21.25, Tom Rini wrote: > > On Fri, Jul 01, 2022 at 09:27:59AM +0200, Rasmus Villemoes wrote: > >> When trying to use the exact same device tree source to build the dtbs > >> used with U-Boot and linux, one often runs

Re: [RFC] Proposed location to host the firmware handoff specification.

2022-07-05 Thread Simon Glass
Hi Rob, On Tue, 5 Jul 2022 at 09:24, Rob Herring wrote: > > On Thu, Jun 30, 2022 at 3:24 AM Simon Glass wrote: > > > > Hi Jose, > > > > I don't think this is correct. TF-A is a project that aims to replace > > U-Boot SPL (and perhaps other components) with more closed firmware, > > e.g. the perm

Re: [PATCH 1/3] board: freescale: p1_p2_rdb_pc: Add workaround for board reset reboot loop

2022-07-05 Thread Pali Rohár
PING? On Sunday 01 May 2022 14:23:12 Pali Rohár wrote: > CPLD's system reset register on P1/P2 RDB boards is not autocleared after > flipping it. If this register is set to one then CPLD triggers reset of CPU > in few ms. > > This means that trying to reset board via CPLD system reset register ca

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-05 Thread Simon Glass
Hi Rasmus, On Tue, 5 Jul 2022 at 07:47, Rasmus Villemoes wrote: > > On 05/07/2022 11.47, Simon Glass wrote: > > Hi Tom, > > > > On Sun, 3 Jul 2022 at 06:43, Tom Rini wrote: > >> > >> On Sun, Jul 03, 2022 at 02:32:42AM -0600, Simon Glass wrote: > >>> Hi, > >>> > >>> On Sun, 3 Jul 2022 at 02:25, S

[PATCH 0/3] fdt: introduce "apply-all" command

2022-07-05 Thread Andre Przywara
Hi, this is an attempt to simplify the usage of user provided devicetree overlays. The idea is to let the user drop all desired .dtbo files into one directory (for instance on the EFI system partition), and U-Boot just applies all of them, with generic commands: => fdt move $fdtcontroladdr $fdt_ad

[PATCH 1/3] cmd: fdt: move: Use map_sysmem to convert pointers

2022-07-05 Thread Andre Przywara
The "fdt move" subcommand was using the provided DTB addresses directly, without trying to "map" them into U-Boot's address space. This happened to work since on the vast majority of "real" platforms there is a simple 1:1 mapping of VA to PAs, so either value works fine. However this is not true o

[PATCH 2/3] cmd: fdt: allow standalone "fdt move"

2022-07-05 Thread Andre Przywara
At the moment every subcommand of "fdt", except "addr" itself, requires the DT address to be set first. We explicitly check for that before even comparing against the subcommands' string. This early bailout also affects the "move" subcommand, even though that does not require or rely on a previous

[PATCH 3/3] fdt: introduce apply_all command

2022-07-05 Thread Andre Przywara
Explicitly specifying the exact filenames of devicetree overlays files on a U-Boot command line can be quite tedious for users, especially when it should be made persistent for every boot. To simplify the task of applying (custom) DT overlays, introduce a "fdt apply-all" subcommand, that iterates

Re: [PATCH v6 2/7] tpm: rng: Add driver model interface for TPM RNG device

2022-07-05 Thread Sughosh Ganu
hi Simon, On Tue, 5 Jul 2022 at 15:17, Simon Glass wrote: > > Hi Sughosh, > > On Mon, 4 Jul 2022 at 07:35, Sughosh Ganu wrote: > > > > The TPM device has a builtin random number generator(RNG) > > functionality. Expose the RNG functions of the TPM device to the > > driver model so that they can

Re: [RFC] Proposed location to host the firmware handoff specification.

2022-07-05 Thread Rob Herring
On Tue, Jul 5, 2022 at 10:37 AM Simon Glass wrote: > > Hi Rob, > > On Tue, 5 Jul 2022 at 09:24, Rob Herring wrote: > > > > On Thu, Jun 30, 2022 at 3:24 AM Simon Glass wrote: > > > > > > Hi Jose, > > > > > > I don't think this is correct. TF-A is a project that aims to replace > > > U-Boot SPL (a

RE: [RFC] Data structure for information handoff between firmware boot stages

2022-07-05 Thread Jose Marinho
Hi Simon, Thank you for the comments, and for the additional discussion! We'll make the changes requested on comments 1 to 5, 7, 10, 11, 12, 14. Comment 6: During our discussion, we came to the conclusion that a specific TPM log entry is required (instead of leveraging the TPM2 ACPI table),

Re: [PATCH v2 1/6] patman: Fix updating argument defaults from settings

2022-07-05 Thread Sean Anderson
Hi Doug, On 7/1/22 4:23 PM, Douglas Anderson wrote: > Ever since commit 4600767d294d ("patman: Refactor how the default > subcommand works"), when I use patman on the Linux tree I get grumbles > about unknown tags. This is because the Linux default making > process_tags be False wasn't working any

Re: [RFC] Proposed location to host the firmware handoff specification.

2022-07-05 Thread Tom Rini
On Thu, Jun 30, 2022 at 01:40:11PM +0300, Ilias Apalodimas wrote: > Hi all, > > Thanks for pushing on this > > On Thu, 30 Jun 2022 at 12:24, Simon Glass wrote: > > > > Hi Jose, > > > > I don't think this is correct. TF-A is a project that aims to replace > > U-Boot SPL (and perhaps other compone

[PATCH v11 00/13] fpga: zynqmp: Adding support of loading authenticated images

2022-07-05 Thread Oleksandr Suvorov
This patchset introduces support for the authenticated and encrypted FPGA images on ZynqMP boards, besides that introducing common way to pass the compatible property to any fpga driver. It bases on the initial work by Jorge Ramirez-Ortiz https://patchwork.ozlabs.org/project/uboot/patch/2021101

[PATCH v11 01/13] fpga: add option for loading FPGA secure bitstreams

2022-07-05 Thread Oleksandr Suvorov
It allows using this feature without enabling the "fpga loads" command. Signed-off-by: Oleksandr Suvorov Co-developed-by: Adrian Fiergolski Signed-off-by: Adrian Fiergolski Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v1) cmd/Kconfig | 3 ++- d

[PATCH v11 02/13] fpga: xilinx: add missed identifier names

2022-07-05 Thread Oleksandr Suvorov
Function definition arguments should also have identifier names. Add missed ones to struct xilinx_fpga_op callbacks, unifying code. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v1) include/xilinx.h | 10 ++ 1 file chan

[PATCH v11 03/13] fpga: xilinx: add bitstream flags to driver desc

2022-07-05 Thread Oleksandr Suvorov
Store a set of supported bitstream types in xilinx_desc structure. It will be used to determine whether an FPGA image is able to be loaded with a given driver. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v10) Changes in v10: -

[PATCH v11 04/13] fpga: zynqmp: add str2flags call

2022-07-05 Thread Oleksandr Suvorov
Add a call to convert FPGA "compatible" string to a binary flag. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v1) drivers/fpga/zynqmppl.c | 9 + include/xilinx.h| 1 + 2 files changed, 10 insertions(+) diff --

[PATCH v11 05/13] fpga: add fpga_compatible2flag

2022-07-05 Thread Oleksandr Suvorov
Add a "compatible" string to binary flag converter, which uses a callback str2flag() of given FPGA driver if available. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v10) Changes in v10: - fix mixed types of return value; driv

[PATCH v11 06/13] fpga: xilinx: pass compatible flags to xilinx_load()

2022-07-05 Thread Oleksandr Suvorov
This flag is used to check whether a Xilinx FPGA driver is able to load a particular FPGA bitstream image. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v1) drivers/fpga/fpga.c | 2 +- drivers/fpga/xilinx.c | 2 +- include/xi

[PATCH v11 07/13] fpga: pass compatible flags to fpga_load()

2022-07-05 Thread Oleksandr Suvorov
These flags may be used to check whether an FPGA driver is able to load a particular FPGA bitstream image. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v1) boot/image-board.c| 4 ++-- cmd/fpga.c| 8 co

[PATCH v11 08/13] spl: fit: pass real compatible flags to fpga_load()

2022-07-05 Thread Oleksandr Suvorov
Convert taken FPGA image "compatible" string to a binary compatible flag and pass it to an FPGA driver. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v10) Changes in v10: - made the message about ignoring legacy compatibe option

[PATCH v11 09/13] fpga: xilinx: pass compatible flags to load() callback

2022-07-05 Thread Oleksandr Suvorov
These flags may be used to check whether an FPGA driver is able to load a particular FPGA bitstream image. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v1) drivers/fpga/spartan2.c | 2 +- drivers/fpga/spartan3.c | 2 +- driver

[PATCH v11 10/13] fpga: zynqmp: optimize zynqmppl_load() code

2022-07-05 Thread Oleksandr Suvorov
Optimize function code preparing to add secure bitstream types support. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v1) drivers/fpga/zynqmppl.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(

[PATCH v11 11/13] fpga: zynqmp: add bitstream compatible checking

2022-07-05 Thread Oleksandr Suvorov
Check whether the FPGA ZynqMP driver supports the given bitstream image type. Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti Tested-by: Adrian Fiergolski --- (no changes since v10) Changes in v10: - fix grammar; drivers/fpga/zynqmppl.c | 27 +++ 1 file c

[PATCH v11 12/13] fpga: zynqmp: support loading authenticated images

2022-07-05 Thread Oleksandr Suvorov
Add supporting new compatible string "u-boot,zynqmp-fpga-ddrauth" to handle loading authenticated images (DDR). Based on solution by Jorge Ramirez-Ortiz Signed-off-by: Oleksandr Suvorov Tested-by: Ricardo Salveti --- Changes in v11: - Fix treating an incoming FPGA image with empty flags parame

[PATCH v11 13/13] fpga: zynqmp: support loading encrypted bitfiles

2022-07-05 Thread Oleksandr Suvorov
From: Adrian Fiergolski Add supporting new compatible string "u-boot,zynqmp-fpga-enc" to handle loading encrypted bitfiles. This feature requires encrypted FSBL, as according to UG1085: "The CSU automatically locks out the AES key, stored in either BBRAM or eFUSEs, as a key source to the AES en

Re: [PATCH V4 01/49] spl: imx8mm: enlarge SPL_MAX_SIZE

2022-07-05 Thread Peng Fan
On 7/5/2022 2:50 PM, Frieder Schrempf wrote: Am 05.07.22 um 08:05 schrieb Peng Fan (OSS): From: Peng Fan The CONFIG_SPL_MAX_SIZE could be 0x27000 for i.MX8MM when SPL_TEXT_BASE set to 0x7E1000. Signed-off-by: Peng Fan I wonder if there is any more explanation for the maximum size that c

Re: [PATCH 1/5] lib: crypto: add mscode_parser

2022-07-05 Thread AKASHI Takahiro
Hi, On Tue, Jul 05, 2022 at 03:13:17PM +0200, Jason A. Donenfeld wrote: > On Tue, Jul 05, 2022 at 02:48:11PM +0900, AKASHI Takahiro wrote: > > + This option provides support for parsing MicroSoft's Authenticode > > + in pkcs7 message. > > I chuckled when I saw "MicroSoft" in the cover let

Re: [PATCH 6/9] dm: core: Support accessing core tags

2022-07-05 Thread AKASHI Takahiro
Hi Simon, On Tue, Jul 05, 2022 at 02:27:54PM +0100, Simon Glass wrote: > Hi, > > On Tue, 5 Jul 2022 at 13:39, Tom Rini wrote: > > > > On Tue, Jun 28, 2022 at 11:18:51PM +0900, AKASHI Takahiro wrote: > > > On Tue, Jun 28, 2022 at 09:37:56AM -0400, Simon Glass wrote: > > > > Hi Simon, > > > > > >

Re: [PATCH 3/5] efi_loader: image_loader: replace EFI_PRINT with log macros

2022-07-05 Thread AKASHI Takahiro
Heinrich, On Tue, Jul 05, 2022 at 05:26:58PM +0200, Heinrich Schuchardt wrote: > On 7/5/22 07:48, AKASHI Takahiro wrote: > > Now We are migrating from EFI_PRINT() to log macro's. > > I don't understand your logic: > > log_err("Parsing image's signature failed\n"); > log_debug("Signature was reje

Re: [PATCH 4/5] efi_loader: image_loader: add a missing digest verification for signed PE image

2022-07-05 Thread AKASHI Takahiro
Heinrich, On Tue, Jul 05, 2022 at 05:29:07PM +0200, Heinrich Schuchardt wrote: > On 7/5/22 07:48, AKASHI Takahiro wrote: > > At the last step of PE image authentication, an image's hash value must be > > compared with a message digest stored as the content (of SpcPeImageData > > type) > > of pkcs

Re: [PATCH V4 01/49] spl: imx8mm: enlarge SPL_MAX_SIZE

2022-07-05 Thread Frieder Schrempf
Am 06.07.22 um 01:52 schrieb Peng Fan: > > > On 7/5/2022 2:50 PM, Frieder Schrempf wrote: >> Am 05.07.22 um 08:05 schrieb Peng Fan (OSS): >>> From: Peng Fan >>> >>> The CONFIG_SPL_MAX_SIZE could be 0x27000 for i.MX8MM when SPL_TEXT_BASE >>> set to 0x7E1000. >>> >>> Signed-off-by: Peng Fan >> >>