Re: [PATCH 09/25] stm32f429-discovery: Migrate CONFIG_*_LED out of CONFIG namespace

2022-03-31 Thread Patrice CHOTARD
Hi Tom On 3/31/22 00:07, Tom Rini wrote: > These values are only used in one file, reference them more directly. > > Cc: Kamil Lulko > Cc: Patrick Delaunay > Cc: Patrice Chotard > Cc: uboot-st...@st-md-mailman.stormreply.com > Signed-off-by: Tom Rini > --- > board/st/stm32f429-discovery/led.

Re: [PATCH v3 4/9] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-31 Thread Sughosh Ganu
hi Masami, On Thu, 31 Mar 2022 at 08:15, Masami Hiramatsu wrote: > > Hi Sughosh, > > If you remove the DEFAULT_DFU_ALT_INFO definition but introduce > set_dfu_alt_info(), this also must the CONFIG_SET_DFU_ALT_INFO for > each platform configuration too. > Unless that, some platform will not lose t

Re: [PATCH v3 5/9] capsule: kconfig: Select SET_DFU_ALT_INFO config symbol for capsule update

2022-03-31 Thread Sughosh Ganu
hi Masami, On Thu, 31 Mar 2022 at 08:18, Masami Hiramatsu wrote: > > Hi, > > Even with this patch, if the platform configuration doesn't select > EFI_CAPSULE_FIRMWARE_* (or user will disable it when use it), the > platform will lose raw DFU availability. I will have to rely on feedback from boar

Re: [PATCH v7 4/4] configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMER

2022-03-31 Thread Clément Léger
Le Thu, 31 Mar 2022 05:59:02 +, a écrit : > On 3/30/22 6:49 PM, Clément Léger wrote: > > Le Tue, 22 Mar 2022 13:35:08 +0100, > > Clément Léger a écrit : > > > >> Le Tue, 22 Mar 2022 11:18:39 +, > >> a écrit : > >> > > > > [...] > > > >>> > >>> Could not initialize timer (err -2

Re: [PATCH v4 09/11] efi_loader: add menu-driven UEFI Boot Variable maintenance

2022-03-31 Thread Ilias Apalodimas
Hi Kojima-san, On Thu, Mar 24, 2022 at 10:54:41PM +0900, Masahisa Kojima wrote: > + I haven't been able to get the patch working yet. I'll send more feedback once I do. Here's a few comments I have [...] > +struct efi_bootmenu_file_entry_data { > + struct efi_bootmenu_boot_option *bo; > +

Re: [PATCH v3 1/9] capsule: Add Image GUIDs and image index for platforms using capsule updates

2022-03-31 Thread Michal Simek
On 3/30/22 16:50, Sughosh Ganu wrote: Currently, all platforms that enable capsule updates do so using either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID. This is based on the Firmware Management Protocol(FMP) instance used on the platform. However, this me

Re: [PATCH v3 5/9] capsule: kconfig: Select SET_DFU_ALT_INFO config symbol for capsule update

2022-03-31 Thread Sughosh Ganu
hi Masami, On Thu, 31 Mar 2022 at 13:11, Sughosh Ganu wrote: > > hi Masami, > > On Thu, 31 Mar 2022 at 08:18, Masami Hiramatsu > wrote: > > > > Hi, > > > > Even with this patch, if the platform configuration doesn't select > > EFI_CAPSULE_FIRMWARE_* (or user will disable it when use it), the > >

[PATCH v1 2/2] cmd: lcdputs: Escape special characters

2022-03-31 Thread qianfanguijin
From: qianfan Zhao Add support \\, \r, \n, \t and \b. eg: => lcdputs "hello\nworld" Signed-off-by: qianfan Zhao --- drivers/video/vidconsole-uclass.c | 34 +-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/video/vidconsole-uclass.c b/drive

[PATCH v1 1/2] video: Add VIDEO_FONT_4x6 to Kconfig add fix compile waring

2022-03-31 Thread qianfanguijin
From: qianfan Zhao CONFIG_VIDEO_FONT_4x6 is referenced in include/video_font.h, but doesn't has a Kconfig configuration. Add it. Signed-off-by: qianfan Zhao --- drivers/video/Kconfig| 8 include/video_font_4x6.h | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v4 10/11] bootmenu: add removable media entries

2022-03-31 Thread Ilias Apalodimas
On Thu, Mar 24, 2022 at 10:54:42PM +0900, Masahisa Kojima wrote: > UEFI specification requires booting from removal media using > a architecture-specific default image name such as BOOTAA64.EFI. > This commit adds the removable media entries into bootmenu, > so that user can select the removable me

[PATCH v8 1/5] timer: atmel_tcb_timer: add atmel_tcb driver

2022-03-31 Thread Clément Léger
Add a driver for the timer counter block that can be found on sama5d2. This driver will be used when booting under OP-TEE since the pit timer which is part of the SYSC is secured. Channel 1 & 2 are configured to be chained together which allows to have a 64bits counter. Reviewed-by: Claudiu Beznea

[PATCH v8 0/5] add TCB driver for sama5d2

2022-03-31 Thread Clément Léger
When booting under OP-TEE, the SYSC is secured which means the PIT is also not accessible by non-secure world. The TCB 0 however is always available for non-secure world and thus can be used. This series add a TCB driver and enables it in sama5d2 configs. --- Changes in v8: - Switch clock to use t

[PATCH v8 5/5] configs: sama5d2: enable option CONFIG_ATMEL_TCB_TIMER

2022-03-31 Thread Clément Léger
Enable CONFIG_ATMEL_TCB_TIMER and disable CONFIG_ATMEL_PIT_TIMER. This will allow using the TCB timer instead of the PIT one when running under OP-TEE. Reviewed-by: Claudiu Beznea Signed-off-by: Clément Léger --- configs/sama5d2_icp_mmc_defconfig| 2 +- configs/sama5d2_ptc_ek_mmc_de

[PATCH v8 3/5] ARM: dts: at91: sama5d2: add TCB node

2022-03-31 Thread Clément Léger
Add the device-tree node to describe the TCB timer. Signed-off-by: Clément Léger --- arch/arm/dts/sama5d2.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi index 7de58e4a1f..058009adca 100644 --- a/arch/arm/dts/sama5d

[PATCH v8 2/5] ARM: dts: at91: sama5d2: add AIC node

2022-03-31 Thread Clément Léger
When using interrupts property, a global interrupt controller needs to be added to avoid warnings when compiling device-tree: arch/arm/dts/at91-sama5d2_xplained.dtb: Warning (interrupts_property): /ahb/apb/timer@f800c000: Missing interrupt-parent Add AIC node as the sama5d2 global interrupt

Re: [PATCH 02/25] mvebu: Move BOOTROM_ERR_REG out of CONFIG namespace

2022-03-31 Thread Stefan Roese
On 3/31/22 00:07, Tom Rini wrote: This register is referenced in one location and does not seem configurable, so remove it from CONFIG namespace. Cc: Stefan Roese Signed-off-by: Tom Rini Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/cpu.c | 2 +- arch/a

Re: [PATCH 14/25] controlcenterdc: Migrate CUSTOMER_BOARD_SUPPORT to Kconfig

2022-03-31 Thread Stefan Roese
On 3/31/22 00:07, Tom Rini wrote: This symbol is only possibly useful on some mvebu platforms, so move the symbol there and select it for the only current user. Cc: Mario Six Cc: Stefan Roese Signed-off-by: Tom Rini Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kcon

Re: [PATCH v3 5/9] capsule: kconfig: Select SET_DFU_ALT_INFO config symbol for capsule update

2022-03-31 Thread Masami Hiramatsu
Hi Sughosh, 2022年3月31日(木) 17:38 Sughosh Ganu : > > hi Masami, > > On Thu, 31 Mar 2022 at 13:11, Sughosh Ganu wrote: > > > > hi Masami, > > > > On Thu, 31 Mar 2022 at 08:18, Masami Hiramatsu > > wrote: > > > > > > Hi, > > > > > > Even with this patch, if the platform configuration doesn't select

[PATCH v2 1/2] net: phy: marvell: Support reg config via "marvell, reg-init" DT property

2022-03-31 Thread Stefan Roese
This patch adds support for the "marvell,reg-init" DT property, which is used to describe board specific Marvell PHY register configurations in the board dts file. This DT property is supported in the Linux Kernel since a longer time. Adding it to U-Boot now, enables the boards which describe the r

[PATCH v2 2/2] net: phy: marvell: Add support for 88E1240 PHY

2022-03-31 Thread Stefan Roese
This patch adds basic support for the Marvell 88E1240 PHY. This will be used by the upcoming ethernet support addition for the Marvell MIPS Octeon EBB7304 platform. Signed-off-by: Stefan Roese Cc: Ramon Fried Cc: Joe Hershberger Cc: Aaron Williams Cc: Chandrakala Chavva --- v2: - No change

[PATCH v2 2/3] cmd: lcdputs: Escape special characters

2022-03-31 Thread qianfanguijin
From: qianfan Zhao Add support \\, \r, \n, \t and \b. eg: => lcdputs "hello\nworld" Signed-off-by: qianfan Zhao --- drivers/video/vidconsole-uclass.c | 34 +-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/video/vidconsole-uclass.c b/drive

[PATCH v2 1/3] video: Add VIDEO_FONT_4x6 to Kconfig add fix compile waring

2022-03-31 Thread qianfanguijin
From: qianfan Zhao CONFIG_VIDEO_FONT_4x6 is referenced in include/video_font.h, but doesn't has a Kconfig configuration. Add it. Signed-off-by: qianfan Zhao --- drivers/video/Kconfig| 15 +++ include/video_font_4x6.h | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) d

[PATCH v2 3/3] driver: video: font: Introduce 6x8 bitmap font

2022-03-31 Thread qianfanguijin
From: qianfan Zhao 6x8 bitmap font has better display effect on smaller lcd screen. Signed-off-by: qianfan Zhao --- drivers/video/Kconfig|3 + include/video_font.h |4 +- include/video_font_6x8.h | 2580 ++ 3 files changed, 2586 insertions(+)

[PATCH 03/11] virtio_ring: Maintain a shadow copy of descriptors

2022-03-31 Thread Andrew Scull
The shared descriptors should only be written by the guest driver, however, the device is still able to overwrite and corrupt them. Maintain a private shadow copy of the descriptors for the driver to use for state tracking, removing the need to read from the shared descriptors. Signed-off-by: Andr

[PATCH 01/11] virtio_ring: Merge identical variables

2022-03-31 Thread Andrew Scull
The variables `total_sg` and `descs_used` have the same value. Replace the few uses of `total_sg` with `descs_used` to simplify the situation. Signed-off-by: Andrew Scull --- drivers/virtio/virtio_ring.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/virtio/vi

[PATCH 04/11] virtio_ring: Check used descriptors are chain heads

2022-03-31 Thread Andrew Scull
When the device returns used buffers, it should refer to the descriptor that is the head of the descriptor chain for that buffer. Confirm this to be the case by tracking the head of descriptor chains that have been made available to the device. Signed-off-by: Andrew Scull --- drivers/virtio/virt

Re: [PATCH v4 10/11] bootmenu: add removable media entries

2022-03-31 Thread Masahisa Kojima
On Thu, 31 Mar 2022 at 17:48, Ilias Apalodimas wrote: > > On Thu, Mar 24, 2022 at 10:54:42PM +0900, Masahisa Kojima wrote: > > UEFI specification requires booting from removal media using > > a architecture-specific default image name such as BOOTAA64.EFI. > > This commit adds the removable media

Re: [PATCH v2 1/2] net: phy: marvell: Support reg config via "marvell,reg-init" DT property

2022-03-31 Thread Marek Behún
On Thu, 31 Mar 2022 11:43:06 +0200 Stefan Roese wrote: > This patch adds support for the "marvell,reg-init" DT property, which > is used to describe board specific Marvell PHY register configurations > in the board dts file. This DT property is supported in the Linux Kernel > since a longer time.

Re: [PATCH v2 2/2] net: phy: marvell: Add support for 88E1240 PHY

2022-03-31 Thread Marek Behún
On Thu, 31 Mar 2022 11:43:07 +0200 Stefan Roese wrote: > This patch adds basic support for the Marvell 88E1240 PHY. > > This will be used by the upcoming ethernet support addition for the > Marvell MIPS Octeon EBB7304 platform. > > Signed-off-by: Stefan Roese > Cc: Ramon Fried > Cc: Joe Hersh

Re: [PATCH 01/10] Makefile: v2 Allow LTO to be disabled for a build

2022-03-31 Thread Andrew Scull
On Sun, 27 Mar 2022 at 21:27, Simon Glass wrote: > > LTO (Link-Time Optimisation) is an very useful feature which can > significantly reduce the size of U-Boot binaries. So far it has been > made available for selected ARM boards and sandbox. > > However, incremental builds are much slower when LT

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-03-31 Thread Marek Behún
On Wed, 30 Mar 2022 08:46:06 -0700 Tim Harvey wrote: > On Tue, Mar 29, 2022 at 4:22 PM Marek Behún wrote: > > > > On Tue, 29 Mar 2022 15:52:39 -0700 > > Tim Harvey wrote: > > > > > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > > > > > Signed-off-by: Tim Harvey >

[PATCH] imx8ulp: clock: Fix lcd clock algo

2022-03-31 Thread Loic Poulain
The div loop uses reassign and reuse parent_rate, which causes the parent rate reference to be wrong after the first loop, the resulting clock becomes incorrect for div != 1. Fixes: 829e06bf4175 ("imx8ulp: clock: Add MIPI DSI clock and DCNano clock") Signed-off-by: Loic Poulain --- arch/arm/mach

[PATCH] fdt: Add -q option to fdt addr for distro_bootcmd

2022-03-31 Thread Peter Hoyes
From: Peter Hoyes distro_bootcmd uses this construct a few times to test $fdt_addr_r, and fall back on $fdtcontroladdr if not set/invalid: if fdt addr ${fdt_addr_r}; then ... else ... fi If the `fdt addr` test fails, it prints the following message on the console, s

[PATCH] net: tftp: fix tftp server initialization

2022-03-31 Thread Arjan Minzinga Zijlstra
Some globals where not properly initialized causing timeouts as data packets where not immediately acknowledged. Signed-off-by: Arjan Minzinga Zijlstra --- net/tftp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tftp.c b/net/tftp.c index 62a9648474..9d5fe2f2d9 100644 --- a/net/tftp.

Re: [PATCH] IOMUX: Fix access past end of console_devices

2022-03-31 Thread Andy Shevchenko
On Wed, Mar 30, 2022 at 01:25:59PM -0400, Sean Anderson wrote: > On 3/30/22 1:13 PM, Andy Shevchenko wrote: > > On Wed, Mar 30, 2022 at 7:49 PM Sean Anderson wrote: > > > > Also I don't like to have workarounds for the broken tools. > > But if you still want to have something, what about rather t

[PATCH v4 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-03-31 Thread Sughosh Ganu
This series is cleaning up the usage of the image GUIDs that are used in capsule update and the EFI System Resource Table(ESRT). There are some other enhancements being made to the capsule update code to make it more robust. Firstly, an overview of the fixes being made. Currently, there are two

[PATCH v4 3/8] capsule: Put a check for image index before the update

2022-03-31 Thread Sughosh Ganu
The current capsule update code compares the image GUID value in the capsule header with the image GUID value obtained from the GetImageInfo function of the Firmware Management Protocol(FMP). This comparison is done to ascertain if the FMP's SetImage function can be called for the update. Make this

[PATCH v4 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-03-31 Thread Sughosh Ganu
Currently, the image descriptor array that has been passed to the GetImageInfo function of the Firmware Management Protocol(FMP) gets populated through the data stored with the dfu framework. The dfu data is not restricted to contain information only of the images updatable through the capsule upda

[PATCH v4 1/8] capsule: Add Image GUIDs and image index for platforms using capsule updates

2022-03-31 Thread Sughosh Ganu
Currently, all platforms that enable capsule updates do so using either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID. This is based on the Firmware Management Protocol(FMP) instance used on the platform. However, this means that all platforms that enable a partic

[PATCH v4 6/8] FMP: Remove GUIDs for FIT and raw images

2022-03-31 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu ---

[PATCH v4 4/8] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-31 Thread Sughosh Ganu
Currently, there are a bunch of boards which enable the UEFI capsule update feature. The actual update of the firmware images is done through the dfu framework which uses the dfu_alt_info environment variable for getting information on the update, like device, partition number/address etc. Currentl

[PATCH v4 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-03-31 Thread Sughosh Ganu
While building a capsule, the GUID value of that specific image is to be passed through the --guid command option to the mkeficapsule tool. This renders the EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID and EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID values superfluous. Remove the --raw and --fit command line

[PATCH v4 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-03-31 Thread Sughosh Ganu
The current UEFI capsule updation code uses two GUID values, one for FIT images, and one for raw images across platforms. This logic is being changed to have GUID values per image, per platform. Change the tests for the capsule update code to reflect this change. The GUID values now used are the on

[PATCH v4 8/8] doc: uefi: Update the capsule update related documentation

2022-03-31 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V3: * Rephrase the commit message to indicate that the doc changes are not

Re: [PATCH] board: gw_ventana: gsc: fix GSC read/write functions

2022-03-31 Thread Tom Rini
On Thu, Mar 24, 2022 at 08:32:00AM -0700, Tim Harvey wrote: > commit 7c84319af9c7 ("dm: gpio: Correct use of -ENODEV in drivers") > changed the return code for an I2C NAK from -ENODEV to -EREMOTEIO. > > Update the gsc_i2c_read and gsc_i2c_write functions for this change > to properly retry the tr

Re: [PATCH v2] board: gateworks: venice: determine dram size at runtime

2022-03-31 Thread Tom Rini
On Wed, Mar 30, 2022 at 01:39:02PM -0700, Tim Harvey wrote: > The SPL does not update the memory node with the dram size from EEPROM > but instead we can use get_ram_size which does a simple memory test > to determine the available RAM. Update PHYS_SDRAM_SIZE to 4GiB as that > is the max used on t

Re: [PATCH v1 1/1] Revert "x86: Move FACP table into separate functions"

2022-03-31 Thread Tom Rini
On Wed, Mar 30, 2022 at 06:49:18PM +0300, Andy Shevchenko wrote: > Before the culprit patch (see BugLink for the details): > > => acpi list > Name Base Size Detail > - -- > RSDP 000e4500 24 v02 U-BOOT > RSDT 000e4530 38 v01 U-BOOT U-BOOTBL 20

Re: [PATCH] video: Do not show splash and U-Boot logo simultaneously

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 04:40:36PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Currently, on imx6sabresd and gwventana boards, the company logo > and U-Boot logo are shown. > > The correct behavior is to show only the company logo, if available, > and not both logos. > > Reported-by:

Re: [PATCH 1/1] Makefile: make clean should delete include/generated/env.in

2022-03-31 Thread Tom Rini
On Wed, Mar 30, 2022 at 12:11:00PM +0200, Heinrich Schuchardt wrote: > 'make sifive_unamtched_defconfig; make clean; make' fails if file > include/generated/env.in exists. 'make clean' should remove all files that > stop building. > > Add file include/generated/env.in to the clean target. > > Si

Re: [PATCH] powerpc: Fix incorrect SYS_IMMR migration values

2022-03-31 Thread Tom Rini
On Wed, Mar 30, 2022 at 09:30:15AM -0400, Tom Rini wrote: > When migrating SYS_IMMR, I didn't allow for boards to provide > non-default values here. This lead to an incorrect migration on the > platforms where CONFIG_SYS_IMMR is set to CONFIG_SYS_CCSRBAR and > CONFIG_SYS_CSSRBAR is NOT the same a

Re: [PATCH v4 1/8] capsule: Add Image GUIDs and image index for platforms using capsule updates

2022-03-31 Thread Ilias Apalodimas
On Thu, Mar 31, 2022 at 06:57:43PM +0530, Sughosh Ganu wrote: > Currently, all platforms that enable capsule updates do so using > either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or > EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID. This is based on the Firmware > Management Protocol(FMP) instance used on the

Re: [PATCH v4 4/8] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-31 Thread Masami Hiramatsu
Hi Sughosh, OK, this looks good to me. Acked-by: Masami Hiramatsu for DeveloperBox part. Thank you, 2022年3月31日(木) 22:28 Sughosh Ganu : > > Currently, there are a bunch of boards which enable the UEFI capsule > update feature. The actual update of the firmware images is done > through the dfu f

Re: [PATCH v4 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-03-31 Thread Ilias Apalodimas
Hi Sughosh, On Thu, Mar 31, 2022 at 06:57:44PM +0530, Sughosh Ganu wrote: > Currently, the image descriptor array that has been passed to the > GetImageInfo function of the Firmware Management Protocol(FMP) gets > populated through the data stored with the dfu framework. The > dfu data is not res

Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset

2022-03-31 Thread Tim Harvey
On Mon, Mar 28, 2022 at 7:55 AM Marek Vasut wrote: > > On 3/28/22 08:54, Ye Li wrote: > > Hi Marek, > > Hi, > > [...] > > >>> 2. Update the u-boot.itb offset in imx8mp-u-boot.dtsi, set the > >>> offset > >>> to 0x5f000. The previous offset 0x58000 is for SD, calculated by > >>> 0x6 - 0x8000 (

Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset

2022-03-31 Thread Marek Vasut
On 3/31/22 17:09, Tim Harvey wrote: On Mon, Mar 28, 2022 at 7:55 AM Marek Vasut wrote: On 3/28/22 08:54, Ye Li wrote: Hi Marek, Hi, [...] 2. Update the u-boot.itb offset in imx8mp-u-boot.dtsi, set the offset to 0x5f000. The previous offset 0x58000 is for SD, calculated by 0x6 - 0x80

Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset

2022-03-31 Thread Tim Harvey
On Thu, Mar 31, 2022 at 8:26 AM Marek Vasut wrote: > > On 3/31/22 17:09, Tim Harvey wrote: > > On Mon, Mar 28, 2022 at 7:55 AM Marek Vasut wrote: > >> > >> On 3/28/22 08:54, Ye Li wrote: > >>> Hi Marek, > >> > >> Hi, > >> > >> [...] > >> > > 2. Update the u-boot.itb offset in imx8mp-u-boot.dt

Re: [PATCH v4 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-03-31 Thread Sughosh Ganu
hi Ilias, On Thu, 31 Mar 2022 at 20:38, Ilias Apalodimas wrote: > > Hi Sughosh, > > On Thu, Mar 31, 2022 at 06:57:44PM +0530, Sughosh Ganu wrote: > > Currently, the image descriptor array that has been passed to the > > GetImageInfo function of the Firmware Management Protocol(FMP) gets > > popul

Re: [PATCH 13/25] spi: cadence_qspi: Migrate CONFIG_CQSPI_REF_CLK to Kconfig

2022-03-31 Thread Pratyush Yadav
+Vignesh Hi Tom, On 30/03/22 06:07PM, Tom Rini wrote: > This is a little tricky since SoCFPGA has code to determine this as > runtime. Introduce a guard variable for platforms to select if they > have a static value to use. Then for ARCH_SOCFPGA, call > cm_get_qspi_controller_clk_hz() and other

Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset

2022-03-31 Thread Marek Vasut
On 3/31/22 18:03, Tim Harvey wrote: On Thu, Mar 31, 2022 at 8:26 AM Marek Vasut wrote: On 3/31/22 17:09, Tim Harvey wrote: On Mon, Mar 28, 2022 at 7:55 AM Marek Vasut wrote: On 3/28/22 08:54, Ye Li wrote: Hi Marek, Hi, [...] 2. Update the u-boot.itb offset in imx8mp-u-boot.dtsi, set

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-31 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 03:52:38PM -0700, Tim Harvey wrote: > Add support for DM_MDIO by registering a UCLASS_MDIO driver and > attempting to use it. This is necessary if wanting to use a DSA > driver for example hanging off of the FEC MAC. > > Care is taken to fallback to non DM_MDIO as several b

Re: [PATCH 13/25] spi: cadence_qspi: Migrate CONFIG_CQSPI_REF_CLK to Kconfig

2022-03-31 Thread Tom Rini
On Thu, Mar 31, 2022 at 10:00:52PM +0530, Pratyush Yadav wrote: > +Vignesh > > Hi Tom, > > On 30/03/22 06:07PM, Tom Rini wrote: > > This is a little tricky since SoCFPGA has code to determine this as > > runtime. Introduce a guard variable for platforms to select if they > > have a static value

[PATCH 01/10] net: Remove armada100_fec driver

2022-03-31 Thread Tom Rini
This driver is not enabled by any board and not converted to DM_ETH. Remove. Signed-off-by: Tom Rini --- drivers/net/Makefile| 1 - drivers/net/armada100_fec.c | 739 drivers/net/armada100_fec.h | 208 -- 3 files changed, 948 deletions(-) d

[PATCH 03/10] net: Remove cs8900 driver

2022-03-31 Thread Tom Rini
This driver is not enabled by any board and not converted to DM_ETH. Remove. Signed-off-by: Tom Rini --- drivers/net/Makefile | 1 - drivers/net/cs8900.c | 320 --- drivers/net/cs8900.h | 248 - 3 files changed, 569 deleti

[PATCH 05/10] net: Remove ftmac110 driver

2022-03-31 Thread Tom Rini
This driver is not enabled by any board and not converted to DM_ETH. Remove. Signed-off-by: Tom Rini --- drivers/net/Makefile | 1 - drivers/net/ftmac110.c | 491 - drivers/net/ftmac110.h | 175 --- 3 files changed, 667 deletions(-) delete

[PATCH 02/10] net: Remove ax88180 driver

2022-03-31 Thread Tom Rini
This driver is not enabled by any board and not converted to DM_ETH. Remove. Signed-off-by: Tom Rini --- drivers/net/Makefile | 1 - drivers/net/ax88180.c | 755 -- drivers/net/ax88180.h | 396 -- 3 files changed, 1152 deletions(-)

[PATCH 07/10] net: Remove natsemi driver

2022-03-31 Thread Tom Rini
This driver is not enabled by any board and not converted to DM_ETH. Remove. Signed-off-by: Tom Rini --- drivers/net/Makefile | 1 - drivers/net/natsemi.c | 883 -- 2 files changed, 884 deletions(-) delete mode 100644 drivers/net/natsemi.c diff --git

[PATCH 08/10] net: Remove ns8382x driver

2022-03-31 Thread Tom Rini
This driver is not enabled by any board and not converted to DM_ETH. Remove. Signed-off-by: Tom Rini --- drivers/net/Makefile | 1 - drivers/net/ns8382x.c | 854 -- 2 files changed, 855 deletions(-) delete mode 100644 drivers/net/ns8382x.c diff --git

[PATCH 09/10] net: Remove uli526x driver

2022-03-31 Thread Tom Rini
This driver is not enabled by any board and not converted to DM_ETH. Remove. Signed-off-by: Tom Rini --- drivers/net/Makefile | 1 - drivers/net/uli526x.c | 996 -- 2 files changed, 997 deletions(-) delete mode 100644 drivers/net/uli526x.c diff --git

[PATCH 06/10] net: Remove lan91c96 driver

2022-03-31 Thread Tom Rini
This driver is not enabled by any board and not converted to DM_ETH. Remove. Signed-off-by: Tom Rini --- drivers/net/Makefile | 1 - drivers/net/lan91c96.c | 799 - drivers/net/lan91c96.h | 616 --- 3 files changed, 1416 del

[PATCH 04/10] net: Remove dnet driver

2022-03-31 Thread Tom Rini
This driver is not enabled by any board and not converted to DM_ETH. Remove. Signed-off-by: Tom Rini --- drivers/net/Makefile | 1 - drivers/net/dnet.c | 395 --- drivers/net/dnet.h | 166 -- 3 files changed, 562 deletions(-) delete

[PATCH 10/10] arm: Remove unused ep93xx code

2022-03-31 Thread Tom Rini
There are no platforms for this architecture anymore, remove unused code. Signed-off-by: Tom Rini --- arch/arm/cpu/arm920t/Makefile | 1 - arch/arm/cpu/arm920t/ep93xx/Makefile| 19 - arch/arm/cpu/arm920t/ep93xx/cpu.c | 37 -- arch/arm/cpu/arm920t/ep93xx/led.c

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-31 Thread Tim Harvey
On Thu, Mar 31, 2022 at 10:01 AM Vladimir Oltean wrote: > > On Tue, Mar 29, 2022 at 03:52:38PM -0700, Tim Harvey wrote: > > Add support for DM_MDIO by registering a UCLASS_MDIO driver and > > attempting to use it. This is necessary if wanting to use a DSA > > driver for example hanging off of the

Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset

2022-03-31 Thread Tim Harvey
On Thu, Mar 31, 2022 at 9:41 AM Marek Vasut wrote: > > On 3/31/22 18:03, Tim Harvey wrote: > > On Thu, Mar 31, 2022 at 8:26 AM Marek Vasut wrote: > >> > >> On 3/31/22 17:09, Tim Harvey wrote: > >>> On Mon, Mar 28, 2022 at 7:55 AM Marek Vasut wrote: > > On 3/28/22 08:54, Ye Li wrote: >

Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset

2022-03-31 Thread Marek Vasut
On 3/31/22 20:02, Tim Harvey wrote: On Thu, Mar 31, 2022 at 9:41 AM Marek Vasut wrote: On 3/31/22 18:03, Tim Harvey wrote: On Thu, Mar 31, 2022 at 8:26 AM Marek Vasut wrote: On 3/31/22 17:09, Tim Harvey wrote: On Mon, Mar 28, 2022 at 7:55 AM Marek Vasut wrote: On 3/28/22 08:54, Ye Li w

Re: [PATCH v4 6/8] FMP: Remove GUIDs for FIT and raw images

2022-03-31 Thread Ilias Apalodimas
On Thu, Mar 31, 2022 at 06:57:48PM +0530, Sughosh Ganu wrote: > The capsule update code has been modified for getting the image GUID > values from the platform code. With this, each image now has a unique > GUID value. With this change, there is no longer a need for defining > GUIDs for FIT and raw

Re: [PATCH v4 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-03-31 Thread Ilias Apalodimas
On Thu, Mar 31, 2022 at 06:57:49PM +0530, Sughosh Ganu wrote: > While building a capsule, the GUID value of that specific image is to > be passed through the --guid command option to the mkeficapsule > tool. This renders the EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID and > EFI_FIRMWARE_IMAGE_TYPE_UBOOT

Re: [PATCH v4 8/8] doc: uefi: Update the capsule update related documentation

2022-03-31 Thread Ilias Apalodimas
On Thu, Mar 31, 2022 at 06:57:50PM +0530, Sughosh Ganu wrote: > Update the capsule update functionality related documentation to > refect the additional definitions that need to be made per platform > for supporting the capsule update feature. > > Signed-off-by: Sughosh Ganu > --- > > Changes si

Re: [PATCH v4 3/8] capsule: Put a check for image index before the update

2022-03-31 Thread Ilias Apalodimas
On Thu, Mar 31, 2022 at 06:57:45PM +0530, Sughosh Ganu wrote: > The current capsule update code compares the image GUID value in the > capsule header with the image GUID value obtained from the > GetImageInfo function of the Firmware Management Protocol(FMP). This > comparison is done to ascertain

Re: [PATCH 13/25] spi: cadence_qspi: Migrate CONFIG_CQSPI_REF_CLK to Kconfig

2022-03-31 Thread Pratyush Yadav
On 31/03/22 01:41PM, Tom Rini wrote: > On Thu, Mar 31, 2022 at 10:00:52PM +0530, Pratyush Yadav wrote: > > +Vignesh > > > > Hi Tom, > > > > On 30/03/22 06:07PM, Tom Rini wrote: > > > This is a little tricky since SoCFPGA has code to determine this as > > > runtime. Introduce a guard variable for

[v2 13/25] spi: cadence_qspi: Migrate CONFIG_CQSPI_REF_CLK to Kconfig

2022-03-31 Thread Tom Rini
This is a little tricky since SoCFPGA has code to determine this as runtime. Introduce a guard variable for platforms to select if they have a static value to use. Then for ARCH_SOCFPGA, call cm_get_qspi_controller_clk_hz() and otherwise continue the previous behavior. Cc: Jagan Teki Signed-off

Re: [PATCH v4 4/8] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-31 Thread Ilias Apalodimas
Hi Sughosh, Some nots below On Thu, Mar 31, 2022 at 06:57:46PM +0530, Sughosh Ganu wrote: > Currently, there are a bunch of boards which enable the UEFI capsule > update feature. The actual update of the firmware images is done > through the dfu framework which uses the dfu_alt_info environment

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-31 Thread Vladimir Oltean
On Thu, Mar 31, 2022 at 10:48:55AM -0700, Tim Harvey wrote: > > On which branch does this apply? The context above fecmxc_read_rom_hwaddr() > > is different in the branches I've checked: > > https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/net/fec_mxc.c#L1276 > > https://source.denx.de/u-

Re: [v2 13/25] spi: cadence_qspi: Migrate CONFIG_CQSPI_REF_CLK to Kconfig

2022-03-31 Thread Pratyush Yadav
On 31/03/22 03:35PM, Tom Rini wrote: > This is a little tricky since SoCFPGA has code to determine this as > runtime. Introduce a guard variable for platforms to select if they > have a static value to use. Then for ARCH_SOCFPGA, call > cm_get_qspi_controller_clk_hz() and otherwise continue the p

Re: [PATCH 0/6] Add MV88E61xx DSA driver and use on gwventana

2022-03-31 Thread Chris Packham
Hi Tim, On 31/03/22 05:01, Tim Harvey wrote: > On Tue, Mar 29, 2022 at 3:52 PM Tim Harvey wrote: >> This series adds a DSA driver for the MV88E61xx based on >> drivers/net/phy/mv88e61xx and uses in on the gwventana_gw5904_defconfig. >> >> The hope is that the other three boards that use the MV88E

Re: [PATCH v8 01/15] arch: Kconfig: imply BINMAN for SANDBOX

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:56:53PM +0200, Philippe Reynes wrote: > To be able to use the tool binman on sandbox, > the config SANDBOX should imply BINMAN. > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP sig

Re: [PATCH v8 02/15] lib: Kconfig: enhance help for ASN1

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:56:54PM +0200, Philippe Reynes wrote: > Enhance the help for configs ASN1_COMPILER > and ASN1_decoder. > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v8 03/15] lib: Kconfig: enhance the help of OID_REGISTRY

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:56:55PM +0200, Philippe Reynes wrote: > Enhance the help for the config OID_REGISTRY. > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v8 04/15] lib: allow to build asn1 decoder and oid registry in SPL

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:56:56PM +0200, Philippe Reynes wrote: > This commit adds the options: > - SPL_ASN1_DECODER > - SPL_OID_REGISTRY > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v8 05/15] lib: crypto: allow to build crypyo in SPL

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:56:57PM +0200, Philippe Reynes wrote: > This commit adds the options: > - SPL_ASYMMETRIC_KEY_TYPE > - SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE > - SPL_RSA_PUBLIC_KEY_PARSER > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- To

Re: [PATCH v8 06/15] lib: rsa: allow rsa verify with pkey in SPL

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:56:58PM +0200, Philippe Reynes wrote: > This commit adds the option SPL_RSA_VERIFY_WITH_PKEY. > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v8 07/15] boot: image: add a stage pre-load

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:56:59PM +0200, Philippe Reynes wrote: > Add a stage pre-load that could > check or modify an image. > > For the moment, only a header with a signature is > supported. This header has the following format: > - magic : 4 bytes > - version : 4 bytes > - header size : 4 byt

Re: [PATCH v8 08/15] cmd: bootm: add a stage pre-load

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:57:00PM +0200, Philippe Reynes wrote: > Add a stage pre-load to the command bootm. > Right now, this stage may be used to read a > header and check the signature of the full > image. > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next

Re: [PATCH v8 09/15] common: spl: fit_ram: allow to use image pre load

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:57:01PM +0200, Philippe Reynes wrote: > Add the support of image pre load in spl or tpl > when loading an image from ram. > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v8 10/15] mkimage: add public key for image pre-load stage

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:57:02PM +0200, Philippe Reynes wrote: > This commit enhances mkimage to update the node > /image/pre-load/sig with the public key. > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v8 11/15] Makefile: provide sah-key to binman

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:57:03PM +0200, Philippe Reynes wrote: > Set the variable pre-load-key-path with the shell variable > PRE_LOAD_KEY_PATH that contain the keys path (used for signature). > This variable pre-load-key-path is provided to binman. > > Reviewed-by: Simon Glass > Signed-off-by

Re: [PATCH v8 12/15] tools: binman: add support for pre-load header

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:57:04PM +0200, Philippe Reynes wrote: > Adds the support of the pre-load header with the image signature > to binman. > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v8 13/15] configs: sandbox_defconfig: enable stage pre-load in bootm

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:57:05PM +0200, Philippe Reynes wrote: > Enable the support of stage pre-load in bootm. > For the moment, this stage allow to verify the > signature of the full image with a header. > > Reviewed-by: Simon Glass > Signed-off-by: Philippe Reynes Applied to u-boot/next,

Re: [PATCH v8 14/15] test: py: vboot: add test for global image signature

2022-03-31 Thread Tom Rini
On Mon, Mar 28, 2022 at 10:57:06PM +0200, Philippe Reynes wrote: > Adds test units for the pre-load header signature. > > Signed-off-by: Philippe Reynes Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 17/23] i2c: sun8i_rsb: Only do non-DM pin setup for non-DM I2C

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:14 -0500 Samuel Holland wrote: > When the DM_I2C driver is loaded, the pin setup is done automatically > from the device tree by the pinctrl driver. > > Clean up the code in the process: remove #ifdefs and recognize that the > pin configuration is the same for all sun8i

Re: [PATCH v2 23/23] spi: sun4i_spi: Remove non-DM pin setup

2022-03-31 Thread Andre Przywara
On Thu, 17 Mar 2022 22:54:20 -0500 Samuel Holland wrote: > This is now handled automatically by the pinctrl driver. > > Signed-off-by: Samuel Holland Again a nice cleanup! Reviewed-by: Andre Przywara Cheers, Andre > --- > > (no changes since v1) > > drivers/spi/spi-sunxi.c | 84

  1   2   >