Hi Tim, On 31/03/22 05:01, Tim Harvey wrote: > On Tue, Mar 29, 2022 at 3:52 PM Tim Harvey <thar...@gateworks.com> wrote: >> This series adds a DSA driver for the MV88E61xx based on >> drivers/net/phy/mv88e61xx and uses in on the gwventana_gw5904_defconfig. >> >> The hope is that the other three boards that use the MV88E61xx driver >> can move to this as well eventually so that we can remove the non-dm >> driver and the 4 Kconfig options it requires. >> >> The MV88E61xx has an MDIO interface this DM_MDIO must be used so support >> for a UCLASS_MDIO driver is added to the fec_mxc ethernet driver in a >> way that allows a fallback to the previous non DM_MDIO case as there are >> many boards out there using this driver that define DM_MDIO but do not >> have the required dt props for a DM_MDIO driver which would cause a >> regression. >> >> Additionally a patch to ensure MDIO children are scanned on post-bind is >> needed. >> >> I'm making use of the dm_mdio_read/dm_mdio_write wrapper from Merak that >> is pending so it is in this series as well. >> >> Best Regards, >> >> Tim >> >> Tim Harvey (6): >> net: mdio-uclass: scan for dm mdio children on post-bind >> net: dsa: move cpu port probe to dsa_post_probe >> net: mdio-uclass: add wrappers for read/write/reset operations >> net: fec: add support for DM_MDIO >> net: add MV88E61xx DSA driver >> board: gw_ventana: enable MV88E61XX DSA support >> >> arch/arm/dts/imx6qdl-gw5904.dtsi | 35 + >> board/gateworks/gw_ventana/gw_ventana.c | 50 +- >> configs/gwventana_gw5904_defconfig | 7 +- >> drivers/net/Kconfig | 7 + >> drivers/net/Makefile | 1 + >> drivers/net/fec_mxc.c | 113 ++- >> drivers/net/fec_mxc.h | 1 + >> drivers/net/mv88e61xx.c | 982 ++++++++++++++++++++++++ >> include/miiphy.h | 31 + >> net/dsa-uclass.c | 14 +- >> net/mdio-uclass.c | 35 + >> 11 files changed, 1227 insertions(+), 49 deletions(-) >> create mode 100644 drivers/net/mv88e61xx.c >> >> -- >> 2.17.1 >> > Adding Chris and Anotolij to the thread as the maintainers of the only > other boards using drivers/net/phy/mv88e61xx.c. If they can switch to > the DSA driver it would allow us to remove the static Kconfig options > to configure the switch which should be present in the device-tree.
I'd be keen to see DSA support for this chip. We are using the Linux DSA drivers on these boards so I'm reasonably sure the ported driver should work. I won't have much time to actually work on these boards (they're a bit of a pain to test remotely). If any of the code is getting in the way I'd be fine with removing it (effectively leaving eth0 as a fixed-link) and when I get some time I can add support for the 88e6097 back. > > Best Regards, > > Tim
