Re: [PATCH v3 02/10] watchdog: wdt-uclass.c: introduce struct wdt_priv

2021-07-05 Thread Stefan Roese
On 02.07.21 14:45, Rasmus Villemoes wrote: As preparation for having the wdt-uclass provided watchdog_reset() function handle all DM watchdog devices, and not just the first such, introduce a uclass-owned struct to hold the reset_period and next_reset, so these become per-device instead of being

Re: [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list

2021-07-05 Thread Marek Vasut
On 7/5/21 6:17 AM, Heiko Schocher wrote: Hello Marek, On 04.07.21 21:31, Marek Vasut wrote: Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linu

[PATCH] stm32mp: stm32prog: use defines for virtual partition size

2021-07-05 Thread Patrick Delaunay
Use the existing defines PMIC_SIZE and OTP_SIZE and a new define CMD_SIZE for virtual partition size. This patch corrects the size for OTP partition in alternate name (1024 instead of 512) and avoids other alignment issues. Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/cmd_stm32pro

Re: [PATCH V2 1/2] spl: mmc: Factor out eMMC boot partition selection code

2021-07-05 Thread Jaehoon Chung
On 7/3/21 11:55 AM, Marek Vasut wrote: > Factor out eMMC boot partition selection code into > default_spl_mmc_emmc_boot_partition() function and implement > weak spl_mmc_emmc_boot_partition(), so that architecture or > board code can override the eMMC boot partition selection. > > Signed-off-by: M

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Bin Meng
On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland wrote: > > Resetting an XHCI controller inside xhci_register undoes any register > setup performed by the platform driver. And at least on the Allwinner > H6, resetting the XHCI controller also resets the PHY, which prevents > the controller from wor

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Marek Vasut
On 7/5/21 10:04 AM, Bin Meng wrote: On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland wrote: Resetting an XHCI controller inside xhci_register undoes any register setup performed by the platform driver. And at least on the Allwinner H6, resetting the XHCI controller also resets the PHY, which pr

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Bin Meng
On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: > > On 7/5/21 10:04 AM, Bin Meng wrote: > > On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland wrote: > >> > >> Resetting an XHCI controller inside xhci_register undoes any register > >> setup performed by the platform driver. And at least on the All

[PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Ilias Apalodimas
SMBIOS entries for manufacturer and board can't be empty, as the spec explicitly requires a value. Instead of passing "Unknown" and "Unknown product" for the manufacturer and product name if the .dts options are missing, try to use CONFIG_SYS_VENDOR and CONFIG_SYS_BOARD respectively. If those are

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Bin Meng
On Mon, Jul 5, 2021 at 4:49 PM Ilias Apalodimas wrote: > > SMBIOS entries for manufacturer and board can't be empty, as the spec > explicitly requires a value. > Instead of passing "Unknown" and "Unknown product" for the manufacturer and > product name if the .dts options are missing, try to use C

Re: [PATCH] stm32mp: stm32prog: use defines for virtual partition size

2021-07-05 Thread Patrice CHOTARD
Hi Patrick On 7/5/21 9:39 AM, Patrick Delaunay wrote: > Use the existing defines PMIC_SIZE and OTP_SIZE and a new define > CMD_SIZE for virtual partition size. > > This patch corrects the size for OTP partition in alternate name > (1024 instead of 512) and avoids other alignment issues. > > Sign

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Andre Przywara
On Mon, 5 Jul 2021 16:38:29 +0800 Bin Meng wrote: Hi, > On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: > > > > On 7/5/21 10:04 AM, Bin Meng wrote: > > > On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland > > > wrote: > > >> > > >> Resetting an XHCI controller inside xhci_register undoes a

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Bin Meng
Hi Andre, On Mon, Jul 5, 2021 at 5:07 PM Andre Przywara wrote: > > On Mon, 5 Jul 2021 16:38:29 +0800 > Bin Meng wrote: > > Hi, > > > On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: > > > > > > On 7/5/21 10:04 AM, Bin Meng wrote: > > > > On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland > > >

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Marek Vasut
On 7/5/21 10:38 AM, Bin Meng wrote: On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: On 7/5/21 10:04 AM, Bin Meng wrote: On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland wrote: Resetting an XHCI controller inside xhci_register undoes any register setup performed by the platform driver. And

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Heinrich Schuchardt
On 7/5/21 10:49 AM, Ilias Apalodimas wrote: SMBIOS entries for manufacturer and board can't be empty, as the spec explicitly requires a value. Instead of passing "Unknown" and "Unknown product" for the manufacturer and product name if the .dts options are missing, try to use CONFIG_SYS_VENDOR and

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Marek Vasut
On 7/5/21 11:18 AM, Bin Meng wrote: Hi Andre, On Mon, Jul 5, 2021 at 5:07 PM Andre Przywara wrote: On Mon, 5 Jul 2021 16:38:29 +0800 Bin Meng wrote: Hi, On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: On 7/5/21 10:04 AM, Bin Meng wrote: On Sat, Apr 17, 2021 at 10:21 PM Samuel Hollan

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Ilias Apalodimas
Hi Heinrich, On Mon, Jul 05, 2021 at 12:25:47PM +0200, Heinrich Schuchardt wrote: > On 7/5/21 10:49 AM, Ilias Apalodimas wrote: > > SMBIOS entries for manufacturer and board can't be empty, as the spec > > explicitly requires a value. > > Instead of passing "Unknown" and "Unknown product" for the

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Andre Przywara
On Mon, 5 Jul 2021 12:45:59 +0200 Marek Vasut wrote: Hi, > On 7/5/21 11:18 AM, Bin Meng wrote: > > Hi Andre, > > > > On Mon, Jul 5, 2021 at 5:07 PM Andre Przywara > > wrote: > >> > >> On Mon, 5 Jul 2021 16:38:29 +0800 > >> Bin Meng wrote: > >> > >> Hi, > >> > >>> On Mon, Jul 5, 2021 at 4

[PATCH] arm: mach-snapdragon: pinctrl: Place pin_name in .data section

2021-07-05 Thread Stephan Gerhold
According to arch/arm/lib/crt0_64.S, the BSS section is "UNAVAILABLE" and uninitialized before relocation. Also, it overlaps with the appended DTB before relocation, so writing data into a variable in the BSS section might corrupt the appended DTB. Unfortunately, pinctrl-apq8016.c and pinctrl-apq8

[PATCH v3 0/4] Allwinner H6 USB3 support

2021-07-05 Thread Andre Przywara
This series adds PHY and XHCI driver support for the USB3 controller found in the Allwinner H6 SoC. It has been tested and working on both boards enabled in patch 4, although some users experience issues[1]. [1]: https://lists.denx.de/pipermail/u-boot/2021-February/440767.html Changes from v2:

[PATCH v3 1/4] phy: sun50i-usb3: Add a driver for the H6 USB3 PHY

2021-07-05 Thread Andre Przywara
From: Samuel Holland This driver is needed for XHCI to work on the Allwinner H6 SoC. The driver is copied from Linux v5.10. Reviewed-by: Andre Przywara Signed-off-by: Samuel Holland Signed-off-by: Andre Przywara --- drivers/phy/allwinner/Kconfig | 8 ++ drivers/phy/allwinner/Make

[PATCH v3 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Andre Przywara
From: Samuel Holland Resetting an XHCI controller inside xhci_register undoes any register setup performed by the platform driver. And at least on the Allwinner H6, resetting the XHCI controller also resets the PHY, which prevents the controller from working. That means the controller must be tak

[PATCH v3 4/4] configs: Enable USB3 on Allwinner H6 boards

2021-07-05 Thread Andre Przywara
From: Samuel Holland Pine H64 and Orange Pi 3 both provide a USB3 type A port. Enable it in U-Boot. Signed-off-by: Samuel Holland Signed-off-by: Andre Przywara --- configs/orangepi_3_defconfig | 5 + configs/pine_h64_defconfig | 5 + 2 files changed, 10 insertions(+) diff --git a/c

[PATCH v3 3/4] usb: xhci-dwc3: Add support for clocks/resets

2021-07-05 Thread Andre Przywara
From: Samuel Holland Some platforms, like the Allwinner H6, do not have a separate glue layer around the dwc3. Instead, they rely on the clocks/resets/phys referenced from the dwc3 DT node itself. Add support for enabling the clocks/resets referenced from the dwc3 DT node. Signed-off-by: Samuel

Re: [PATCH v5 1/4] rockchip: rk3066: add grf header file

2021-07-05 Thread Johan Jonker
Hi Paweł, Similar to Linux the U-boot tree has scripts to check your patches. Could you fix some? Johan ./scripts/checkpatch.pl --strict v5-0001-rockchip-rk3066-add-grf-header-file.patch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100644 WARNING:

Re: [PATCH v5 2/4] rockchip: rk3066: add clock driver for rk3066 soc

2021-07-05 Thread Johan Jonker
Hi Paweł, Same comment as for [PATCH v5 1/4] the U-boot tree has scripts to check your patches. The script below gives so many notifications that I can't even copy it here. Could you fix some? Also could you add more people to the CC list. Use an editor that can visualise TABs to better fix your i

[PATCH] arm64: rk3399: Optimize performance and cleanup

2021-07-05 Thread Xiaobo Tian
Signed-off-by: Xiaobo Tian --- arch/arm/dts/rk3399-nanopi-r4s.dts | 40 +- 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/arch/arm/dts/rk3399-nanopi-r4s.dts b/arch/arm/dts/rk3399-nanopi-r4s.dts index 6f2cf17bf1..a85f4bf491 100644 --- a/arch/arm/dts/rk

Re: [PATCH] arm64: rk3399: Optimize performance and cleanup

2021-07-05 Thread Peter Robinson
I'm not sure what performance optimisation is being done here? Also we generally sync the rockchip device trees from the Linux kernel so when that next happens if these aren't upstream in Linux they'll likely be lost. Peter On Mon, Jul 5, 2021 at 3:21 PM Xiaobo Tian wrote: > > Signed-off-by: Xi

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Sean Anderson
On 7/5/21 1:07 AM, Steve Bennett wrote: On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: Dear Sean, In message you wrote: Well, since Hush was never updated, I don't believe LIL will be either. Let's please be exact here: Hus has never been updated _in_U-Boot_, but it has seen a lot of ch

[PATCH] arm64: rk3399: Optimize performance and cleanup

2021-07-05 Thread Xiaobo Tian
1. Delete unused Ethernet aliases 2. Modify the label of the LEDS lamp 3. Inherit the definition of the system status lamp in DSTI 4. Removed error 3.3V incorrect use of 5V supply Signed-off-by: Xiaobo Tian --- arch/arm/dts/rk3399-nanopi-r4s.dts | 40 +- 1 file change

[ANN] U-Boot v2021.07 released

2021-07-05 Thread Tom Rini
Hey all, It is release day and here is the v2021.07 release. With this release we are now at the second of our 2 years past a number of DM migration deadlines. Once again, this will be the last release for a number of boards that will be removed shortly, so that we can be done with the migratio

Re: [PATCH v2 4/5] watchdog: rti_wdt: Add support for loading firmware

2021-07-05 Thread Simon Glass
Hi Jan, On Sun, 27 Jun 2021 at 23:40, Jan Kiszka wrote: > > On 27.06.21 20:18, Simon Glass wrote: > > Hi Jan, > > > > On Sun, 27 Jun 2021 at 12:01, Jan Kiszka wrote: > >> > >> On 26.06.21 20:29, Simon Glass wrote: > >>> Hi, > >>> > >>> On Fri, 11 Jun 2021 at 08:08, Tom Rini wrote: > >

Re: [PATCH v2 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-07-05 Thread Simon Glass
Hi Rasmus, On Mon, 28 Jun 2021 at 01:44, Rasmus Villemoes wrote: > > On 26/06/2021 20.32, Simon Glass wrote: > > Hi Rasmus, > > > > On Tue, 22 Jun 2021 at 14:28, Rasmus Villemoes > > wrote: > >> > > >>> I don't think it is good to start it in the post-probe. Can you do it > >>> separately, after

Re: [PATCH v4 3/3] reboot-mode: read the boot mode from RTC memory

2021-07-05 Thread Simon Glass
Hi Nandor, On Mon, 28 Jun 2021 at 03:44, Nandor Han wrote: > > On 6/26/21 9:30 PM, Simon Glass wrote: > > Hi Nandor, > > > > On Thu, 10 Jun 2021 at 07:57, Nandor Han wrote: > >> > >> RTC devices could provide battery-backed memory that can be used for > >> storing the reboot mode magic value. >

Re: [PATCH v2] cmd:Elaborate 'blkcache' cmd HELP statement

2021-07-05 Thread Simon Glass
On Wed, 30 Jun 2021 at 12:27, wrote: > > From: Adarsh Babu Kalepalli > > HELP description is provided for ‘configure’ sub-command > of ‘blkcache’. > > Signed-off-by: Adarsh Babu Kalepalli > --- > > (no changes since v1) > > cmd/blkcache.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-

Re: [RFC PATCH 04/28] cli: lil: Remove most functions by default

2021-07-05 Thread Simon Glass
On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > This helps reduce the size impact of LIL to approximately that of hush. The > builtin functions have been chosen to roughly match the functionality > present in hush. In addition, arithmetic is removed from expr to reduce > size further. > > Si

Re: [PATCH v3 1/3] test/py: rewrite common tools for SquashFS tests

2021-07-05 Thread Simon Glass
On Wed, 30 Jun 2021 at 16:45, Joao Marcos Costa wrote: > > Remove the previous OOP approach, which was confusing and incomplete. > Add more test cases by making SquashFS images with various options, > concerning file fragmentation and its compression. Add comments to > properly document the code.

Re: [RFC PATCH 12/28] cli: lil: Check for ctrl-c

2021-07-05 Thread Simon Glass
On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > Check for ctrl-c in lil_parse. This works out to around every time a > function or command is called. We also check at the beginning of > lil_eval_expr so that constructs like > > while {1} {} > > get interrupted. Since there are no non

Re: [RFC PATCH 13/28] cli: lil: Wire up LIL to the rest of U-Boot

2021-07-05 Thread Simon Glass
Hi Sean, On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > This sets the shell to LIL when CONFIG_LIL is enabled. Repeated commands > are not supporteed. Neither are partial commands a la Hush's secondary > prompt. Setting and getting environmental variables is done through > callbacks to ass

Re: [PATCH 1/2] board-info: Use sysinfo_get()

2021-07-05 Thread Simon Glass
On Sun, 4 Jul 2021 at 13:32, Marek Vasut wrote: > > Replace uclass_first_device_err(UCLASS_SYSINFO, &dev) with sysinfo_get(&dev). > The board_info code may use sysinfo to print board information, so use the > sysinfo functions consistently. The sysinfo_get() is internally implemented > as return u

Re: [PATCH 2/2] board-info: Call sysinfo_detect() before sysinfo_get_str()

2021-07-05 Thread Simon Glass
On Sun, 4 Jul 2021 at 13:32, Marek Vasut wrote: > > The sysinfo_get_str() implementation checks whether the sysinfo was even > detected. In U-Boot proper, sysinfo_detect() is not called anywhere but > on one specific board. Call sysinfo_detect() before sysinfo_get_str() to > make sure the sysinfo

Re: [RFC PATCH 17/28] test: Add tests for LIL

2021-07-05 Thread Simon Glass
On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > This tests several aspects of the parser. These tests are primarily adapted > from the *.lil code examples included with upstream LIL. These tests should > probably get their own category, especially if I add additional styles of > tests. > > S

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Simon Glass
On Mon, 5 Jul 2021 at 02:49, Ilias Apalodimas wrote: > > SMBIOS entries for manufacturer and board can't be empty, as the spec > explicitly requires a value. > Instead of passing "Unknown" and "Unknown product" for the manufacturer and > product name if the .dts options are missing, try to use CON

Re: [RFC PATCH 01/28] Add Zlib License

2021-07-05 Thread Simon Glass
On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > This adds the Zlib License which is compatible with GPLv2 as long as its > terms are met. Files originally licensed as Zlib should use the "GPL-2.0+ > AND Zlib" SPDX identifier. > > Signed-off-by: Sean Anderson > --- > > Licenses/README |

Re: [PATCH v3 2/3] test/py: rewrite sqfsload command test suite

2021-07-05 Thread Simon Glass
On Wed, 30 Jun 2021 at 16:45, Joao Marcos Costa wrote: > > The previous strategy to know if a file was correctly loaded was to > check for how many bytes were read and compare it against the file's > original size. Since this is not a good solution, replace it by > comparing the checksum of the lo

Re: [PATCH 2/3] doc: usage: add description for setexpr command

2021-07-05 Thread Simon Glass
On Mon, 28 Jun 2021 at 09:18, Roland Gaudig wrote: > > From: Roland Gaudig > > Add usage for the setexpr command. It has been added to describe > mainly the new setexpr format string operation. > > Signed-off-by: Roland Gaudig > --- > > MAINTAINERS | 6 ++ > doc/usage/index.rst |

Re: [PATCH 3/3] test: cmd: setexpr: add tests for format string operations

2021-07-05 Thread Simon Glass
On Mon, 28 Jun 2021 at 09:18, Roland Gaudig wrote: > > From: Roland Gaudig > > Series-version 2 missing : > > Signed-off-by: Roland Gaudig > --- > > test/cmd/setexpr.c | 33 + > 1 file changed, 33 insertions(+) Reviewed-by: Simon Glass (please resend as v3 t

Re: [PATCH v3 3/3] test/py: rewrite sqfsls command test suite

2021-07-05 Thread Simon Glass
On Wed, 30 Jun 2021 at 16:45, Joao Marcos Costa wrote: > > Add more details to test cases by comparing each expected line with the > command's output. Add new test cases: > - sqfsls at an empty directory > - sqfsls at a sub-directory > > Signed-off-by: Joao Marcos Costa > --- > .../test_fs/test_

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Simon Glass
Hi, On Mon, 5 Jul 2021 at 08:42, Sean Anderson wrote: > > On 7/5/21 1:07 AM, Steve Bennett wrote: > > On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: > >> > >> Dear Sean, > >> > >> In message you wrote: > >>> > >>> Well, since Hush was never updated, I don't believe LIL will be either. > >> > >

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Simon Glass
Hi Sean, On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: > > Several functions have different names than they do in TCL. To make things > easier for those familiar with TCL, rename them to their TCL equivalents. > At the moment, this is only done for functions not used by LIL_FULL. Some > funct

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Simon Glass
Hi, On Sat, 3 Jul 2021 at 13:33, Wolfgang Denk wrote: > > Dear Sean, > > In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: > > > > > For a partial list, see > > > > > > [1] https://github.com/Forty-Bot/lil/commits/master > > > > Whoops, looks like I completely misread what yo

Re: [PATCH] sysinfo: rcar3: Add Renesas R-Car Gen3 sysinfo driver

2021-07-05 Thread Simon Glass
Hi Marek, On Sun, 4 Jul 2021 at 13:35, Marek Vasut wrote: > > The Renesas R-Car Gen3 development kits contain board ID EEPROM. > This driver parses out the board ID and revision out of that > EEPROM and exports it e.g. for the board-info print on boot. > > Signed-off-by: Marek Vasut > Cc: Sean A

Re: [PATCH v3 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset()

2021-07-05 Thread Simon Glass
Hi Rasmus, On Fri, 2 Jul 2021 at 06:45, Rasmus Villemoes wrote: > > A board can have and make use of more than one watchdog device, say > one built into the SOC and an external gpio-petted one. Having > wdt-uclass only handle the first is both a little arbitrary and > unexpected. > > So change in

Re: [PATCH 1/1] tpm2: Add a TPMv2 MMIO TIS driver

2021-07-05 Thread Simon Glass
Hi Ilias, On Fri, 2 Jul 2021 at 14:29, Ilias Apalodimas wrote: > > On Fri, Jul 02, 2021 at 07:54:13PM +0200, Heinrich Schuchardt wrote: > > On 7/2/21 2:52 PM, Ilias Apalodimas wrote: > > > Add a TPMv2 TIS MMIO compatible driver. > > > This useful for a couple of reasons. First of all we can supp

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Sean Anderson
On 7/5/21 11:29 AM, Simon Glass wrote: Hi, On Mon, 5 Jul 2021 at 08:42, Sean Anderson wrote: On 7/5/21 1:07 AM, Steve Bennett wrote: On 4 Jul 2021, at 5:26 am, Wolfgang Denk wrote: Dear Sean, In message you wrote: Well, since Hush was never updated, I don't believe LIL will be either.

[PATCH 0/9] tpm: Enhance sandbox tpm2 emulation

2021-07-05 Thread Simon Glass
At present the TPM2 emulator lacks the ability to load and save the state. This means it cannot be used for verify-boot flow that includes multiple phases (e.g. VPL and SPL). It also lacks support for non-volatile data storage. This series adds these features to the TPM2 emulator, with some code f

[PATCH 1/9] sandbox: tpm: Split out common nvdata code

2021-07-05 Thread Simon Glass
We want to support nvdata in TPM2 as well. To avoid code duplicating the associated code, move it into a common file. Drop the special-case logic for the kernel space. This can be handled by the higher-level code now, i.e. in vboot itself. Signed-off-by: Simon Glass --- drivers/tpm/Makefile

[PATCH 3/9] sandbox: tpm: Support the define-space command

2021-07-05 Thread Simon Glass
Add support for this command, moving away from the previous approach of hard-coding the initial data in the driver, now that the kernel-space data has to be set up by the higher-level vboot code. Signed-off-by: Simon Glass --- drivers/tpm/sandbox_common.c | 11 +++ drivers/tpm/sandbox_

[PATCH 2/9] sandbox: tpm: Tidy up reading and writing of device state

2021-07-05 Thread Simon Glass
At present this code assumes that the TPM data has been read but this may not be the case. Refactor the code to use a separate pointer so we know the current state of the data. Add error checking for the data size. Signed-off-by: Simon Glass --- drivers/tpm/tpm_tis_sandbox.c | 35 +

[PATCH 5/9] sandbox: tpm: Finish comments for struct sandbox_tpm2

2021-07-05 Thread Simon Glass
Tidy up the missing comments for this struct. Signed-off-by: Simon Glass --- drivers/tpm/tpm2_tis_sandbox.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/tpm/tpm2_tis_sandbox.c b/drivers/tpm/tpm2_tis_sandbox.c index 24c804a5645..5e0bd304699 10

[PATCH 4/9] sandbox: tpm: Correct handling of get-capability

2021-07-05 Thread Simon Glass
This function current handles the kernel case incorrectly. Fix it, and use the shorter TPM_HDR_LEN while we are here. Signed-off-by: Simon Glass --- drivers/tpm/tpm_tis_sandbox.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/tpm/tpm_tis_sandbox.c b/

[PATCH 6/9] sandbox: tpm: Track whether the state is valid

2021-07-05 Thread Simon Glass
Add checking as to whether the current TPM state is valid, so we can implement reading/writing the state. Signed-off-by: Simon Glass --- drivers/tpm/tpm2_tis_sandbox.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/tpm/tpm2_tis_sandbox.c b/drivers/tpm/tpm

[PATCH 9/9] sandbox: tpm: Support extending a PCR multiple times

2021-07-05 Thread Simon Glass
It is fairly easy to handle this case and it makes the emulator more useful, since PCRs are commonly extended several times. Add support for this, using U-Boot's sha256 support. Signed-off-by: Simon Glass --- drivers/tpm/tpm2_tis_sandbox.c | 19 --- 1 file changed, 12 insertion

[PATCH 7/9] sandbox: tpm: Support nvdata in TPM2

2021-07-05 Thread Simon Glass
Add support for this feature in the TPM2 emulator, to support Chromium OS vboot. Signed-off-by: Simon Glass --- drivers/tpm/tpm2_tis_sandbox.c | 68 ++ include/tpm-v2.h | 2 + 2 files changed, 70 insertions(+) diff --git a/drivers/tpm/tpm2_tis_san

[PATCH 8/9] sandbox: tpm: Support storing device state in tpm2

2021-07-05 Thread Simon Glass
At present the tpm2 emulator does not support storing the device state. Add this so we can handle the normal vboot flow through the sandbox executables (VPL->SPL etc.) with the TPM contents staying in place. Note: sandbox has not yet been converted to use livetree for the state information, since

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Sean Anderson
On 7/5/21 11:29 AM, Simon Glass wrote: Hi Sean, On Thu, 1 Jul 2021 at 00:16, Sean Anderson wrote: Several functions have different names than they do in TCL. To make things easier for those familiar with TCL, rename them to their TCL equivalents. At the moment, this is only done for functions

Re: [PATCH] fit: Load DTO into temporary buffer and ignore load address

2021-07-05 Thread Simon Glass
On Sat, 26 Jun 2021 at 13:23, Marek Vasut wrote: > > On 6/26/21 8:31 PM, Simon Glass wrote: > > Hi, > > > > On Thu, 10 Jun 2021 at 20:10, Marek Vasut wrote: > >> > >> The current fitImage DTO implementation expects each fitImage image > >> subnode containing DTO to have 'load' property, pointing

Re: [PATCH v2 1/1] bootcount: add a new driver with syscon as backend

2021-07-05 Thread Simon Glass
On Thu, 10 Jun 2021 at 06:41, Nandor Han wrote: > > The driver will use a syscon regmap as backend and supports both > 16 and 32 size value. The value will be stored in the CPU's endianness. > > Signed-off-by: Nandor Han > --- > > Notes: > Description > --- > Add a new driver

Re: [PATCH 1/1] smbios: error handling for invalid addresses

2021-07-05 Thread Simon Glass
Hi Heinrich, On Sat, 15 May 2021 at 10:08, Heinrich Schuchardt wrote: > > SMBIOS tables only support 32bit addresses. If we don't have memory here > handle the error gracefully: > > * on x86_64 fail to start U-Boot > * during UEFI booting ignore the missing table > > Signed-off-by: Heinrich Schuc

Re: [PATCH] smbios: Fix calculating BIOS Release Date

2021-07-05 Thread Simon Glass
On Thu, 22 Apr 2021 at 10:10, Pali Rohár wrote: > > BIOS Release Date must be in format mm/dd/ and must be release date. > U-Boot currently sets BIOS Release Date from U_BOOT_DMI_DATE macro which is > generated from current build timestamp. > > Fix this issue by setting U_BOOT_DMI_DATE macro t

Re: [PATCH 1/1] smbios: convert function descriptions to Sphinx style

2021-07-05 Thread Simon Glass
On Thu, 10 Jun 2021 at 04:15, Heinrich Schuchardt wrote: > > Use 'Return:' instead of '@return:'. > > Signed-off-by: Heinrich Schuchardt > --- > lib/smbios.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass

[PATCH 0/3] Add support for USB on ST-Ericsson Ux500

2021-07-05 Thread Stephan Gerhold
This patch series adds support for USB on ST-Ericsson Ux500 by: - Adding a driver to talk to the AB8500 PMIC - Adding a driver to enable the USB PHY - Adding a simple Ux500 glue driver for the musb-new driver This was tested on the u8500 "stemmy" board that is already present in U-Boot. St

[PATCH 1/3] power: pmic: Add driver for ST-Ericsson AB8500 via PRCMU

2021-07-05 Thread Stephan Gerhold
All devices based on ST-Ericsson Ux500 use a PMIC similar to AB8500 (Analog Baseband). There is AB8500, AB8505, AB9540 and AB8540 although in practice only AB8500 and AB8505 are relevant since the platforms with AB9540 and AB8540 were cancelled and never used in production. In general, the AB8500

[PATCH 3/3] usb: musb-new: Add glue driver for ST-Ericsson Ux500

2021-07-05 Thread Stephan Gerhold
The ST-Ericsson DB8500 SoC contains a MUSB OTG controller which supports both host and gadget mode. For some reason there is nothing special about it - add a simple glue driver for Ux500 that literally just sets up MUSB together with a generic PHY. There are no SoC-specific registers etc needed to

[PATCH 2/3] phy: Add driver for ST-Ericsson AB8500 USB PHY

2021-07-05 Thread Stephan Gerhold
The AB8500 PMIC contains an USB PHY that needs to be set up in device or host mode to make USB work properly. Add a simple driver for the generic PHY uclass that allows enabling it. The if (CONFIG_IS_ENABLED(USB_MUSB_HOST)) might be a bit strange. The USB PHY must be configured in either host or d

Re: [RFC] Start using guestfish for U-Boot fs tests

2021-07-05 Thread Alper Nebi Yasak
On 05/07/2021 00:14, Tom Rini wrote: > On Sat, Jul 03, 2021 at 05:38:07PM -0400, Tom Rini wrote: >> On Sat, Jul 03, 2021 at 05:27:44PM +0300, Alper Nebi Yasak wrote: >>> >>> >>> On 02/07/2021 23:24, Tom Rini wrote: On Fri, Jul 02, 2021 at 11:03:52PM +0300, Alper Nebi Yasak wrote: > On 02/0

Re: [PATCH 1/1] tpm2: Add a TPMv2 MMIO TIS driver

2021-07-05 Thread Ilias Apalodimas
> > > [...] > > > These definitions match Linux' tpm_tis_core.h. > > > > > > Should they be moved to an include of the same name in U-Boot? > > > > I got a tpm_tis.h in this series, so I might as well move those there > > > > > > > > > [...] > > > > > I would prefer if you would add these functio

Re: [PATCH] sandbox: Support signal handling only when requested

2021-07-05 Thread Heinrich Schuchardt
On 7/4/21 10:15 PM, Simon Glass wrote: Hi Heinrich, On Sun, 6 Jun 2021 at 15:35, Heinrich Schuchardt wrote: Am 6. Juni 2021 20:07:31 MESZ schrieb Sean Anderson : On 6/6/21 1:57 PM, Heinrich Schuchardt wrote: On 6/6/21 7:52 PM, Sean Anderson wrote: On 6/6/21 1:28 PM, Heinrich Schuchardt wro

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Ilias Apalodimas
Simon, Bin, As Heinrich points out some of the CONFIG_SYS_* values are not representing the devices properly. Maybe it's a better idea to only check the .dts? If the values are missing we can pop a runtime warning and keep using 'Unknown'. On Mon, Jul 05, 2021 at 09:29:57AM -0600, Simon Glass wr

[PATCH 1/1] sandbox: don't set SA_NODEFER in signal handler

2021-07-05 Thread Heinrich Schuchardt
The sandbox can handle signals. Due to a damaged global data pointer additional exceptions in the signal handler may occur leading to an endless loop. In this case leave the handling of the secondary exception to the operating system. Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/os.c

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-05 Thread Wolfgang Denk
Dear Sean, In message <5a967151-94f0-6037-2d02-0114c43b8...@gmail.com> you wrote: > > AIUI hush has diverged significantly from what U-Boot has. This would > not be an "update" moreso than a complete port in the style of the > current series. Agreed. However, as you write this it sounds like a b

Re: [PATCH] net: dwc_eth_qos: cosmetic: remove unused define EQOS_DESCRIPTOR_ALIGN

2021-07-05 Thread Patrick DELAUNAY
Hi Ramon, On 3/31/21 4:43 PM, Ramon Fried wrote: On Tue, Mar 30, 2021 at 5:12 PM Marek Vasut wrote: On 3/30/21 2:34 PM, Patrick Delaunay wrote: Remove the define EQOS_DESCRIPTOR_ALIGN unused since the commit 6f1e668d964e ("net: dwc_eth_qos: Pad descriptors to cacheline size") Signed-off-by:

Re: [ANN] U-Boot v2021.07 released

2021-07-05 Thread Tom Rini
On Mon, Jul 05, 2021 at 11:13:17AM -0400, Tom Rini wrote: > Hey all, > > It is release day and here is the v2021.07 release. With this release > we are now at the second of our 2 years past a number of DM migration > deadlines. Once again, this will be the last release for a number of > boards

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Wolfgang Denk
Dear Sean, In message you wrote: > > > Is your intent to create a fork of this in U-Boot? > > Yes. I believe some of the major additions I have made (especially "[RFC > PATCH 21/28] cli: lil: Add a distinct parsing step") would not be > accepted by upstream. Ouch... > > Could we not update thi

Re: [PATCH 1/8] dtoc: Avoid using subscripts on match objects

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: These are not supported before Python 3.6 so avoid them. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Walter Lozano Thanks! Walter diff --git a/tools/dtoc/src_s

Re: [PATCH 2/8] dtoc: Convert to use ArgumentParser

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: Use this parser instead of OptionParser, which is deprecated. Signed-off-by: Simon Glass --- tools/dtoc/main.py | 51 -- 1 file changed, 27 insertions(+), 24 deletions(-) Reviewed-by: Walter Lozan

Re: [PATCH 3/8] dtoc: Allow multiple warnings for a driver

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: At present we show when a driver is missing but this is not always that useful. There are various reasons way a driver may appear to be missing, Did you mean "why" instead of "way"? such as a parse error in the source code or a missing field in

Re: [PATCH 4/8] dtoc: Correct the re_compat regular expression

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: This expects a . before the field name (.e.g '.compatible = ...) but presently accepts anything at all. Fix it. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Wal

Re: [PATCH 7/8] dtoc: Detect drivers which do not parse correctly

2021-07-05 Thread Walter Lozano
On 7/4/21 3:19 PM, Simon Glass wrote: At present if a driver is missing a uclass or compatible stirng, this Most probably it should be "string" is silently ignored. This makes sense in most cases, particularly for the compatible string, since it is not required except when the driver is used

Re: [PATCH 8/8] dtoc: Update documentation to cover warnings in more detail

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: When things go wrong it can be confusing to figure out what to change. Add a few more details to the documentation. Fix a 'make htmldocs' warning while we are here. Signed-off-by: Simon Glass --- doc/develop/driver-model/of-plat.rst | 53

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Tom Rini
On Mon, Jul 05, 2021 at 07:58:18PM +0200, Wolfgang Denk wrote: > Dear Sean, > > In message you wrote: > > > > > Is your intent to create a fork of this in U-Boot? > > > > Yes. I believe some of the major additions I have made (especially "[RFC > > PATCH 21/28] cli: lil: Add a distinct parsing st

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Tom Rini
On Sat, Jul 03, 2021 at 09:33:30PM +0200, Wolfgang Denk wrote: > Dear Sean, > > In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: > > > > > For a partial list, see > > > > > > [1] https://github.com/Forty-Bot/lil/commits/master > > > > Whoops, looks like I completely misread

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Sean Anderson
On 7/5/21 1:58 PM, Wolfgang Denk wrote: Dear Sean, In message you wrote: Is your intent to create a fork of this in U-Boot? Yes. I believe some of the major additions I have made (especially "[RFC PATCH 21/28] cli: lil: Add a distinct parsing step") would not be accepted by upstream. Ouc

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Sean Anderson
On 7/5/21 3:10 PM, Tom Rini wrote: On Sat, Jul 03, 2021 at 09:33:30PM +0200, Wolfgang Denk wrote: Dear Sean, In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: For a partial list, see [1] https://github.com/Forty-Bot/lil/commits/master Whoops, looks like I completely m

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Tom Rini
On Mon, Jul 05, 2021 at 03:47:47PM -0400, Sean Anderson wrote: > On 7/5/21 3:10 PM, Tom Rini wrote: > > On Sat, Jul 03, 2021 at 09:33:30PM +0200, Wolfgang Denk wrote: > > > Dear Sean, > > > > > > In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: > > > > > > > > > For a partia

Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-05 Thread Sean Anderson
On 7/5/21 3:53 PM, Tom Rini wrote: On Mon, Jul 05, 2021 at 03:47:47PM -0400, Sean Anderson wrote: On 7/5/21 3:10 PM, Tom Rini wrote: On Sat, Jul 03, 2021 at 09:33:30PM +0200, Wolfgang Denk wrote: Dear Sean, In message <8bbdb7a1-5085-a3b7-614f-12ae9aee8...@gmail.com> you wrote: For a partia

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Simon Glass
Hi Tom, On Mon, 5 Jul 2021 at 12:51, Tom Rini wrote: > > On Mon, Jul 05, 2021 at 07:58:18PM +0200, Wolfgang Denk wrote: > > Dear Sean, > > > > In message you wrote: > > > > > > > Is your intent to create a fork of this in U-Boot? > > > > > > Yes. I believe some of the major additions I have made

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-05 Thread Tom Rini
On Mon, Jul 05, 2021 at 03:02:24PM -0600, Simon Glass wrote: > Hi Tom, > > On Mon, 5 Jul 2021 at 12:51, Tom Rini wrote: > > > > On Mon, Jul 05, 2021 at 07:58:18PM +0200, Wolfgang Denk wrote: > > > Dear Sean, > > > > > > In message you wrote: > > > > > > > > > Is your intent to create a fork of t

[PATCH 01/22] dm: core: Add logging for DM_SEQ_ALIAS

2021-07-05 Thread Simon Glass
It is sometimes helpful to see which sequence is assigned to a device. Add debugging info for that. Signed-off-by: Simon Glass --- drivers/core/device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/core/device.c b/drivers/core/device.c index 9f1400768de..29668f

[PATCH 04/22] test: Add DM_DMA to be disabled

2021-07-05 Thread Simon Glass
At present if DM_DMA is disabled on a sandbox build, the build fails. Make the test conditional. Signed-off-by: Simon Glass --- test/dm/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/dm/core.c b/test/dm/core.c index 2210345dd14..0492698997c 100644 --- a/test/dm/core.c +++ b/t

[PATCH 03/22] test: Allow CONFIG_SPL_LOAD_FIT to be disabled

2021-07-05 Thread Simon Glass
At present if this is not enabled on a sandbox build, the build fails. Add a condition to avoid this. Signed-off-by: Simon Glass --- test/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/Makefile b/test/Makefile index a26e915e050..117839e5847 100644 --- a/test/Makefile +++ b/

  1   2   >