Re: [RFC PATCH 3/3] net: phy: dp83869: Port the kernel driver

2021-04-27 Thread Christian Gmeiner
Hi Dan I am interested to see the mainline support for the DP83869 phy. Is there any progress on this patch or are there any blocker? Am Di., 21. Apr. 2020 um 16:35 Uhr schrieb Dan Murphy : > > Michal > > On 4/21/20 7:39 AM, Michal Simek wrote: > > On 21. 04. 20 14:04, Dan Murphy wrote: > >> Mich

Re: [PATCH 0/2] reset: fix reset_get_by_index_nodev index handling

2021-04-27 Thread Neil Armstrong
Hi Tom, Simon, On 20/04/2021 10:42, Neil Armstrong wrote: > A regression weas detected on Amlogic G12A/G12B SoCs, where HDMI output was > disable > even when Linux was booting. > > Bisect reports 139e4a1cbe ("drivers: reset: Add a managed API to get reset > controllers from the DT") > as the of

Re: [PATCH] usb: musb-new: Extend Allwinner quirk to newer SoCs

2021-04-27 Thread Andre Przywara
On Tue, 27 Apr 2021 02:37:20 +0200 Marek Vasut wrote: Hi, > On 4/27/21 2:03 AM, Andre Przywara wrote: > > As the comment in musb_regs.h describes, Allwinner saves the > > MUSB_CONFIGDATA register, which always return 0 on those SoCs. > > > > This is also true for the H6 and H616, so extend the

[PATCH] arm: dts: lx2162aqds: support eMMC HS400 mode on esdhc1

2021-04-27 Thread Yangbo Lu
Add properties related to eMMC HS400 mode for esdhc1. Signed-off-by: Yangbo Lu --- arch/arm/dts/fsl-lx2162a-qds-sd1-17.dtsi | 6 ++ arch/arm/dts/fsl-lx2162a-qds-sd1-18.dtsi | 6 ++ arch/arm/dts/fsl-lx2162a-qds-sd1-20.dtsi | 6 ++ arch/arm/dts/fsl-lx2162a-qds.dts | 6 ++ 4

Re: [PATCH v4 0/2] allow opting out of WATCHDOG_RESET() from timer interrupt

2021-04-27 Thread Stefan Roese
On 26.04.21 22:47, Tom Rini wrote: On Mon, Apr 26, 2021 at 10:21:30PM +0200, Rasmus Villemoes wrote: On 14/04/2021 09.18, Rasmus Villemoes wrote: This is a resend of v3 from a year ago. Please consider applying. v4: rebase to current master. v3: add fixup patch for mpc83xx_timer, add document

Re: [PATCH] watchdog: use time_after_eq() in watchdog_reset()

2021-04-27 Thread Stefan Roese
On 13.04.21 16:43, Rasmus Villemoes wrote: Some boards don't work with the rate-limiting done in the generic watchdog_reset() provided by wdt-uclass. For example, on powerpc, get_timer() ceases working during bootm since interrupts are disabled before the kernel image gets decompressed, and when

Please pull u-boot-marvell/master (watchdog related)

2021-04-27 Thread Stefan Roese
Hi Tom, please pull the following watchdog related patches from Rasmus: - WDT: Enable use of hw_margin_ms=0 - PowerPC: Introduce CONFIG_CACHE_FLUSH_WATCHDOG_THRESHOLD - PowerPC: Misc changes and fixes to the WDT handling --

[PATCH] armv8: layerscape: enable eMMC HS400 workarounds for LX2160A/LX2162A

2021-04-27 Thread Yangbo Lu
Enable eMMC HS400 workarounds for LX2160A/LX2162A. Signed-off-by: Yangbo Lu --- arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig index 9d1ba4c771..395e5ccaad 10

Re: [PATCH v3] IOMUX: Fix buffer overflow in iomux_replace_device()

2021-04-27 Thread Peter Robinson
On Mon, Apr 26, 2021 at 12:08 AM Yuichiro Goto wrote: > > Use of strcat() against an uninitialized buffer would lead > to buffer overflow. This patch fixes it. > > Fixes: 694cd5618c ("IOMUX: Introduce iomux_replace_device()") > Signed-off-by: Yuichiro Goto > Cc: Peter Robinson > Cc: Andy Shevche

[PATCH] clk: cosmetic change in uclass

2021-04-27 Thread Patrick Delaunay
Remove the tab in clk_get_bulk to respect the coding rules. Signed-off-by: Patrick Delaunay --- drivers/clk/clk-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 4ab3c402ed..b126c5ed60 100644 --- a/drivers/clk/

[PATCH] dm: define LOG_CATEGORY for all uclass

2021-04-27 Thread Patrick Delaunay
Define LOG_CATEGORY for all uclass to allow filtering with log command. Signed-off-by: Patrick Delaunay --- drivers/adc/adc-uclass.c| 2 ++ drivers/ata/ahci-uclass.c | 2 ++ drivers/axi/axi-emul-uclass.c | 2 ++ drivers/axi/axi-uclass.c

Re: [PATCH] usb: musb-new: Extend Allwinner quirk to newer SoCs

2021-04-27 Thread Marek Vasut
On 4/27/21 10:10 AM, Andre Przywara wrote: On Tue, 27 Apr 2021 02:37:20 +0200 Marek Vasut wrote: Hi, On 4/27/21 2:03 AM, Andre Przywara wrote: As the comment in musb_regs.h describes, Allwinner saves the MUSB_CONFIGDATA register, which always return 0 on those SoCs. This is also true for th

Re: [PATCH] usb: musb-new: Extend Allwinner quirk to newer SoCs

2021-04-27 Thread Jagan Teki
On Tue, Apr 27, 2021 at 1:41 PM Andre Przywara wrote: > > On Tue, 27 Apr 2021 02:37:20 +0200 > Marek Vasut wrote: > > Hi, > > > On 4/27/21 2:03 AM, Andre Przywara wrote: > > > As the comment in musb_regs.h describes, Allwinner saves the > > > MUSB_CONFIGDATA register, which always return 0 on tho

[PATCH 2/4] arm: octeontx2: cn9130-crb.dtsi: Disable eth2 for now

2021-04-27 Thread Stefan Roese
Because of the incorrectly supported SGMII_2500 mode, this patch disables eth2 for now until this issue will be fixed in mainline. Also fix an incorrect comment. Signed-off-by: Stefan Roese Cc: Konstantin Porotchkin Cc: Stefan Chulski Cc: Nadav Haklai Cc: Marek Behun --- This patch is target

[PATCH 1/4] arm: mvebu: armada-3720-uDPU.dts: Change back to phy-mode "2500base-x"

2021-04-27 Thread Stefan Roese
With commit 8678776df6f5 (arm: mvebu: armada-3720-uDPU: fix PHY mode definition to sgmii-2500) the PHY mode was switch to "sgmii-2500", even when this is functionally incorrect since "2500base-x" was not supported in U-Boot at that time. As this mode is now supported (at least present in the header

[PATCH 3/4] net: phy: marvell: Remove PHY_INTERFACE_MODE_SGMII_2500

2021-04-27 Thread Stefan Roese
As was discussed on the list, PHY_INTERFACE_MODE_SGMII_2500 is used incorrectly in the Marvell mvpp2 network driver and the Marvell PHY code. This patch removes the references to this macro in the Marvell PHY driver for now. The correct support shall be implemented at a later time. Signed-off-by:

[PATCH 4/4] net: mvpp2: Remove PHY_INTERFACE_MODE_SGMII_2500

2021-04-27 Thread Stefan Roese
As was discussed on the list, PHY_INTERFACE_MODE_SGMII_2500 is used incorrectly in the Marvell mvpp2 network driver and the Marvell PHY code. This patch removes the references to this macro in the mvpp2 network driver for now. The correct support shall be implemented at a later time. Signed-off-b

Re: [PATCH v7 00/14] mtd: spi-nor: Add support for Cypress s25hl-t/s25hs-t

2021-04-27 Thread Jagan Teki
On Tue, Apr 27, 2021 at 7:54 AM wrote: > > From: Takahiro Kuwano > > The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI. > > The summary datasheets can be found in the following links. > https://www.cypress.com/file/424146/download (256Mb/512Mb/1Gb, single die) > https://www.cyp

Re: [PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-27 Thread Michal Simek
Hi Bin, On 4/27/21 7:17 AM, Bin Meng wrote: > Hi Michal, > > On Mon, Apr 26, 2021 at 8:31 PM Michal Simek wrote: >> >> The commit 6c993815bbea ("net: phy: xilinx: Be compatible with live OF >> tree") change driver behavior to while loop which wasn't correct because >> the driver was looping over

Re: [PATCH 0/2] reset: fix reset_get_by_index_nodev index handling

2021-04-27 Thread Tom Rini
On Tue, Apr 27, 2021 at 09:37:11AM +0200, Neil Armstrong wrote: > Hi Tom, Simon, > > On 20/04/2021 10:42, Neil Armstrong wrote: > > A regression weas detected on Amlogic G12A/G12B SoCs, where HDMI output was > > disable > > even when Linux was booting. > > > > Bisect reports 139e4a1cbe ("drivers

Re: [PATCH] mips: octeon: octeon_ebb7304_defconfig: Fix CFI flash setup

2021-04-27 Thread Daniel Schwierzeck
Am Montag, den 26.04.2021, 16:43 +0200 schrieb Stefan Roese: > This patch makes the necessary adjustments in the defconfig to fully > support the CFI flash on the Octeon EBB7304. > > Signed-off-by: Stefan Roese > Cc: Aaron Williams > Cc: Chandrakala Chavva > Cc: Daniel Schwierzeck > --- > con

Re: [PATCH 1/5] clk: ti: add custom API for memory access

2021-04-27 Thread Tero Kristo
Hi Dario, One question below. On 25/04/2021 17:17, Dario Binacchi wrote: As pointed by [1] and [2], commit d64b9cdcd4 ("fdt: translate address if #size-cells = <0>") is wrong: - It makes every 'reg' DT property translatable. It changes the address translation so that for an I2C 'reg' address

[PATCH v2, 1/2] driver: watchdog: reset watchdog in designware_wdt_stop() function

2021-04-27 Thread Meng . Li
From: MengLi In uboot command line environment, watchdog is not able to be stopped with below commands: SOCFPGA_STRATIX10 # wdt dev watchdog@ffd00200 SOCFPGA_STRATIX10 # wdt stop Refer to watchdog driver in linux kernel, it is also need to reset watchdog after disable it so that the disable actio

[PATCH v2,2/2] driver: watchdog: enable wdt command by default

2021-04-27 Thread Meng . Li
From: MengLi In latest u-boot code, watchdog feature is implemented, so enable wdt command by default. Signed-off-by: Meng Li --- configs/socfpga_stratix10_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/socfpga_stratix10_defconfig b/configs/socfpga_stratix10_defconfig i

Re: [PATCH 1/4] arm: mvebu: armada-3720-uDPU.dts: Change back to phy-mode "2500base-x"

2021-04-27 Thread Jakov Petrina
Hi Stefan, On 27/04/2021 11:48, Stefan Roese wrote: With commit 8678776df6f5 (arm: mvebu: armada-3720-uDPU: fix PHY mode definition to sgmii-2500) the PHY mode was switch to "sgmii-2500", even when this is functionally incorrect since "2500base-x" was not supported in U-Boot at that time. As thi

[PATCH v2 0/2] PE/COFF measurement support

2021-04-27 Thread Masahisa Kojima
This patch series add the PE/COFF measurement support. Extending PCR and Event Log is tested with fTPM running as a OP-TEE TA. Unit test will be added in the separate series. Masahisa Kojima (2): efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled efi_loader: add PE/C

[PATCH v2 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-04-27 Thread Masahisa Kojima
This is preparation for PE/COFF measurement support. PE/COFF image hash calculation is same in both UEFI Secure Boot image verification and measurement in measured boot. PE/COFF image parsing functions are gathered into efi_image_loader.c, and exposed even if UEFI Secure Boot is not enabled. This

[PATCH v2 2/2] efi_loader: add PE/COFF image measurement

2021-04-27 Thread Masahisa Kojima
"TCG PC Client Platform Firmware Profile Specification" requires to measure every attempt to load and execute a OS Loader(a UEFI application) into PCR[4]. This commit adds the PE/COFF image measurement, extends PCR, and appends measurement into Event Log. Signed-off-by: Masahisa Kojima --- Chang

Re: [PATCH 1/4] arm: mvebu: armada-3720-uDPU.dts: Change back to phy-mode "2500base-x"

2021-04-27 Thread Stefan Roese
Hi Jakov, On 27.04.21 14:57, Jakov Petrina wrote: Hi Stefan, On 27/04/2021 11:48, Stefan Roese wrote: With commit 8678776df6f5 (arm: mvebu: armada-3720-uDPU: fix PHY mode definition to sgmii-2500) the PHY mode was switch to "sgmii-2500", even when this is functionally incorrect since "2500base

[PATCH v1 01/10] phy: introduce 1000BaseX and 2500BaseX modes

2021-04-27 Thread Stefan Roese
From: Stefan Chulski Signed-off-by: Stefan Chulski Signed-off-by: Stefan Roese --- include/phy_interface.h | 4 1 file changed, 4 insertions(+) diff --git a/include/phy_interface.h b/include/phy_interface.h index 841ade311efb..ebb18ecd40c0 100644 --- a/include/phy_interface.h +++ b/incl

[PATCH v1 02/10] net: mvpp2: add CP115 port1 10G/5G SFI support

2021-04-27 Thread Stefan Roese
From: Stefan Chulski 1. Differ between Port1 RGMII and SFI modes in Netcomplex config. 2. Remove XPCS config from SFI mode. Port1 doesn't XPCS domain, XPCS config should be removed. Access to Port1 XPCS can cause stall. 3. Add Port1 MPCS configurations. Signed-off-by: Stefan Chulski Signe

[PATCH v1 05/10] net: mvpp2: Fix 2.5G GMII_SPEED configurations

2021-04-27 Thread Stefan Roese
From: Stefan Chulski GMII_SPEED should be enabled for 2.5G speed Signed-off-by: Stefan Chulski Reviewed-by: Yan Markman Reviewed-by: Kostya Porotchkin Tested-by: sa_ip-sw-jenkins Signed-off-by: Stefan Roese --- drivers/net/mvpp2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

[PATCH v1 00/10] net: mvpp2: Sync Marvell mvpp2 driver with Marvell version

2021-04-27 Thread Stefan Roese
This patchset adds the missing ethernet mvpp2 patches from the Marvell U-Boot SDK version to support and fix higher connection speeds. This is done in preparation for the integration of the Octeon TX2 CN913x support, which uses the updated version of this code. Please note that I explicitly did

[PATCH v1 03/10] net: mvpp2: add 1000BaseX and 2500BaseX ppv2 support

2021-04-27 Thread Stefan Roese
From: Stefan Chulski Signed-off-by: Stefan Chulski Signed-off-by: Stefan Roese --- drivers/net/mvpp2.c | 117 ++-- 1 file changed, 112 insertions(+), 5 deletions(-) diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c index 015f5329de74..847007d5b487

[PATCH v1 04/10] net: mvpp2: remove redundant SMI address configuration

2021-04-27 Thread Stefan Roese
From: Marcin Wojtas Because the mvpp2 driver now relies on the PHYLIB and the external MDIO driver, configuring low level SMI bus settings is redundant. Signed-off-by: Marcin Wojtas Tested-by: sa_ip-sw-jenkins Reviewed-by: Kostya Porotchkin Reviewed-by: Stefan Chulski Signed-off-by: Stefan R

[PATCH v1 08/10] net: mvpp2: fix missing switch case break

2021-04-27 Thread Stefan Roese
From: Ben Peled Signed-off-by: Ben Peled Reviewed-by: Stefan Chulski Reviewed-by: Kostya Porotchkin Tested-by: sa_ip-sw-jenkins Signed-off-by: Stefan Roese --- drivers/net/mvpp2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c index 61a0ea08

[PATCH v1 07/10] net: mvpp2: remove unused define MVPP22_SMI_PHY_ADDR_REG

2021-04-27 Thread Stefan Roese
From: Ben Peled Signed-off-by: Ben Peled Reviewed-by: Stefan Chulski Reviewed-by: Kostya Porotchkin Tested-by: sa_ip-sw-jenkins Signed-off-by: Stefan Roese --- drivers/net/mvpp2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c index 87928945

[PATCH v1 06/10] net: mvpp2: AN Bypass in 1000 and 2500 basex mode

2021-04-27 Thread Stefan Roese
From: Ben Peled Signed-off-by: Ben Peled Reviewed-by: Stefan Chulski Reviewed-by: Kostya Porotchkin Tested-by: sa_ip-sw-jenkins Signed-off-by: Stefan Roese --- drivers/net/mvpp2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2.c b/drivers/net/mv

[PATCH v1 09/10] net: mvpp2: allow MDIO registration for fixed links

2021-04-27 Thread Stefan Roese
From: Stefan Chulski Currently, there are 2 valid cases for interface, PHY and mdio relation: - If an interface has PHY handler, it'll call mdio_mii_bus_get_from_phy(), which will register MDIO bus. - If we want to use fixed-link for an interface, PHY handle is not defined in the

[PATCH v1 10/10] net: mvpp2: add explicit sgmii-2500 support

2021-04-27 Thread Stefan Roese
From: Marcin Wojtas Until now the mvpp2 driver used an extra 'phy-speed' DT property in order to differentiate between the SGMII and SGMII @2.5GHz. As there is a dedicated PHY_INTERFACE_MODE_SGMII_2500 flag to mark the latter start using it and drop the custom flag. Signed-off-by: Marcin Wojtas

RE: [EXT] [PATCH v1 05/10] net: mvpp2: Fix 2.5G GMII_SPEED configurations

2021-04-27 Thread Kostya Porotchkin
Hi, Stefan, > -Original Message- > From: Stefan Roese > Sent: Tuesday, April 27, 2021 16:27 > To: u-boot@lists.denx.de > Cc: Stefan Chulski ; Marcin Wojtas > ; Nadav Haklai ; Marek Behun > ; Joe Hershberger ; Kostya > Porotchkin ; Yan Markman > ; sa_ip-sw-jenkins jenk...@marvell.com> > S

Re: [PATCH v2 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-04-27 Thread Heinrich Schuchardt
On 27.04.21 15:08, Masahisa Kojima wrote: > This is preparation for PE/COFF measurement support. > PE/COFF image hash calculation is same in both > UEFI Secure Boot image verification and measurement in > measured boot. PE/COFF image parsing functions are > gathered into efi_image_loader.c, and exp

Re: [EXT] [PATCH v1 05/10] net: mvpp2: Fix 2.5G GMII_SPEED configurations

2021-04-27 Thread Stefan Roese
Hi Kosta, On 27.04.21 15:48, Kostya Porotchkin wrote: Hi, Stefan, -Original Message- From: Stefan Roese Sent: Tuesday, April 27, 2021 16:27 To: u-boot@lists.denx.de Cc: Stefan Chulski ; Marcin Wojtas ; Nadav Haklai ; Marek Behun ; Joe Hershberger ; Kostya Porotchkin ; Yan Markman ; sa

Re: [PATCH 2/2] efi_loader: add PE/COFF image measurement

2021-04-27 Thread Masahisa Kojima
Hi Heinrich, > > +++ b/include/tpm-v2.h > > @@ -61,6 +61,7 @@ struct udevice; > > #define EV_S_CRTM_VERSION ((u32)0x0008) > > #define EV_CPU_MICROCODE((u32)0x0009) > > #define EV_TABLE_OF_DEVICES ((u32)0x000B) > > Please, add a comment here that the following values are def

Re: [PATCH v2, 1/2] driver: watchdog: reset watchdog in designware_wdt_stop() function

2021-04-27 Thread Stefan Roese
On 27.04.21 10:41, meng...@windriver.com wrote: From: MengLi In uboot command line environment, watchdog is not able to be stopped with below commands: SOCFPGA_STRATIX10 # wdt dev watchdog@ffd00200 SOCFPGA_STRATIX10 # wdt stop Refer to watchdog driver in linux kernel, it is also need to reset w

Re: [PATCH v2, 1/2] driver: watchdog: reset watchdog in designware_wdt_stop() function

2021-04-27 Thread Sean Anderson
On 4/27/21 10:23 AM, Stefan Roese wrote: > On 27.04.21 10:41, meng...@windriver.com wrote: >> From: MengLi >> >> In uboot command line environment, watchdog is not able to be >> stopped with below commands: >> SOCFPGA_STRATIX10 # wdt dev watchdog@ffd00200 >> SOCFPGA_STRATIX10 # wdt stop >> Ref

Re: [PATCH V2 24/24] ARM: imx8m: verdin-imx8mm: Enable USB Host support

2021-04-27 Thread Tim Harvey
On Mon, Apr 26, 2021, 5:35 PM Marek Vasut wrote: > > On 4/27/21 2:01 AM, Tim Harvey wrote: > [...] > >>> Why would the power domain get probed/enabled for the usbotg2 > >>> bus but not the usbotg1 bus? Here is some debugging: > >>> u-boot=> usb start > >>> starting USB... > >>> Bus usb@32e4: e

[PATCH] usb: ehci-mx6: Limit PHY address parsing to !CONFIG_PHY

2021-04-27 Thread Marek Vasut
For systems which use generic PHY support and implement USB PHY driver, the parsing of PHY properties is unnecessary, disable it. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: Tim Harvey Cc: Ye Li Cc: uboot-imx --- drivers/usb/host/ehci-mx6.c | 17

Re: [PATCH] usb: ehci-mx6: Limit PHY address parsing to !CONFIG_PHY

2021-04-27 Thread Tim Harvey
On Tue, Apr 27, 2021 at 9:06 AM Marek Vasut wrote: > > For systems which use generic PHY support and implement USB PHY driver, > the parsing of PHY properties is unnecessary, disable it. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Stefano Babic > Cc: Tim Harvey > C

Re: Please pull u-boot-marvell/master (watchdog related)

2021-04-27 Thread Tom Rini
On Tue, Apr 27, 2021 at 10:28:20AM +0200, Stefan Roese wrote: > Hi Tom, > > please pull the following watchdog related patches from Rasmus: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH U-boot v2] fs: btrfs: fix the false alert of decompression failure

2021-04-27 Thread Tom Rini
On Sat, Apr 17, 2021 at 08:52:13PM +0800, Qu Wenruo wrote: > There are some cases where decompressed sectors can have padding zeros. > > In kernel code, we have lines to address such situation: > > /* > * btrfs_getblock is doing a zero on the tail of the page too, > * b

Re: [PATCH] arm: zimage: Use correct symbol to hide messages in SPL

2021-04-27 Thread Tom Rini
On Sat, Apr 17, 2021 at 09:34:37AM -0500, Samuel Holland wrote: > When zImage support was added to SPL, the messages were hidden to reduce > code size. However, the wrong config symbol was used. Since this file is > only built when CONFIG_SPL_FRAMEWORK=y, the messages were always hidden. > > Use

Re: [PATCH 1/2] test: reset: Extend base reset test to catch error

2021-04-27 Thread Tom Rini
On Tue, Apr 20, 2021 at 10:42:25AM +0200, Neil Armstrong wrote: > With this extended test, we get the following failure : > > => ut dm reset_base > Test: dm_test_reset_base: reset.c > test/dm/reset.c:52, dm_test_reset_base(): reset_method3.id == > reset_method3_1.id: Expected 0x14 (20), got 0x2

Re: [PATCH 2/2] reset: fix reset_get_by_index_nodev index handling

2021-04-27 Thread Tom Rini
On Tue, Apr 20, 2021 at 10:42:26AM +0200, Neil Armstrong wrote: > This fixes an issue getting resets index 1 and 3+, the spurius "> 0" > made it return the index 0 or 1, whatever index was passed. > > The dm_test_reset_base() did not catch it, but the dm_test_reset_base() > extension > catches i

Re: [PATCH] Makefile: fix generation of defaultenv.h from empty initial file

2021-04-27 Thread Tom Rini
On Thu, Apr 22, 2021 at 09:44:18AM +0200, Rasmus Villemoes wrote: > When CONFIG_USE_DEFAULT_ENV_FILE=y and the file > CONFIG_DEFAULT_ENV_FILE is empty (or at least doesn't contain any > non-comment, non-empty lines), we end up feeding nothing into xxd, > which in turn then outputs nothing. Then bl

Re: [PATCH] pinctrl: single: check function mask to be non-zero

2021-04-27 Thread Tom Rini
On Thu, Apr 22, 2021 at 06:35:58PM +0200, Dario Binacchi wrote: > Otherwise it can generate a division by zero, which has an undefined > behavior. > > Signed-off-by: Dario Binacchi Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2] pinctrl: single: fix a never true comparison

2021-04-27 Thread Tom Rini
On Thu, Apr 22, 2021 at 10:28:56PM +0200, Dario Binacchi wrote: > As reported by Coverity Scan for Das U-Boot, the 'less-than-zero' > comparison of an unsigned value is never true. > > Signed-off-by: Dario Binacchi > Reviewed-by: Pratyush Yadav Applied to u-boot/master, thanks! -- Tom sign

Re: [PATCH v3] IOMUX: Fix buffer overflow in iomux_replace_device()

2021-04-27 Thread Tom Rini
On Mon, Apr 26, 2021 at 08:08:03AM +0900, Yuichiro Goto wrote: > Use of strcat() against an uninitialized buffer would lead > to buffer overflow. This patch fixes it. > > Fixes: 694cd5618c ("IOMUX: Introduce iomux_replace_device()") > Signed-off-by: Yuichiro Goto > Cc: Peter Robinson > Cc: Andy

[PATCH 1/3] usb: ehci-mx6: move mode set/detect to probe

2021-04-27 Thread Tim Harvey
There is no need to set and/or detect mode in of_to_plat and accessing phy registers at that point before device power domain and clock are enabled will cause hangs on platforms such as IMX8M Mini. Move the mode set/detect from of_to_plat into the probe and remove the unnecessary of_to_plat. Sign

[PATCH 2/3] usb: ehci-mx6: add IMX8MM OTG support

2021-04-27 Thread Tim Harvey
Add support for determining host vs peripheral mode for IMX8MM configured as OTG. Signed-off-by: Tim Harvey --- drivers/usb/host/ehci-mx6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c index c2dfe49012..d055d2b1fe 1

[PATCH 3/3] configs: imx8mm_venice_defconfig: add usb support

2021-04-27 Thread Tim Harvey
Enable USB support for host controller and various USB ethernet devices. Signed-off-by: Tim Harvey --- configs/imx8mm_venice_defconfig | 15 +++ include/configs/imx8mm_venice.h | 4 2 files changed, 19 insertions(+) diff --git a/configs/imx8mm_venice_defconfig b/configs/imx8mm

Re: [PATCH 2/3] usb: ehci-mx6: add IMX8MM OTG support

2021-04-27 Thread Marek Vasut
On 4/27/21 7:08 PM, Tim Harvey wrote: Add support for determining host vs peripheral mode for IMX8MM configured as OTG. Signed-off-by: Tim Harvey --- drivers/usb/host/ehci-mx6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host

Re: [PATCH 1/3] usb: ehci-mx6: move mode set/detect to probe

2021-04-27 Thread Marek Vasut
On 4/27/21 7:08 PM, Tim Harvey wrote: There is no need to set and/or detect mode in of_to_plat and accessing phy registers at that point before device power domain and clock are enabled will cause hangs on platforms such as IMX8M Mini. Move the mode set/detect from of_to_plat into the probe and

Re: [PATCH 2/3] usb: ehci-mx6: add IMX8MM OTG support

2021-04-27 Thread Tim Harvey
On Tue, Apr 27, 2021 at 10:44 AM Marek Vasut wrote: > > On 4/27/21 7:08 PM, Tim Harvey wrote: > > Add support for determining host vs peripheral mode for IMX8MM > > configured as OTG. > > > > Signed-off-by: Tim Harvey > > --- > > drivers/usb/host/ehci-mx6.c | 2 +- > > 1 file changed, 1 insert

Re: [PATCH 2/3] usb: ehci-mx6: add IMX8MM OTG support

2021-04-27 Thread Patrick Wildt
Am Tue, Apr 27, 2021 at 10:50:34AM -0700 schrieb Tim Harvey: > On Tue, Apr 27, 2021 at 10:44 AM Marek Vasut wrote: > > > > On 4/27/21 7:08 PM, Tim Harvey wrote: > > > Add support for determining host vs peripheral mode for IMX8MM > > > configured as OTG. > > > > > > Signed-off-by: Tim Harvey > >

Re: [PATCH 3/3] pci: pcie_dw_rockchip: Use udelay instead of msleep

2021-04-27 Thread Patrick Wildt
Am Tue, Apr 27, 2021 at 11:11:19AM +0530 schrieb Anand Moon: > hi Patrick, > > On Tue, 27 Apr 2021 at 01:38, Patrick Wildt wrote: > > > > Am Mon, Apr 26, 2021 at 01:26:32PM + schrieb Anand Moon: > > > Use udelay instead of msleep fix the below warning. > > > > You sure that's correct? the m i

Re: [PATCH 2/3] usb: ehci-mx6: add IMX8MM OTG support

2021-04-27 Thread Marek Vasut
On 4/27/21 9:24 PM, Patrick Wildt wrote: Am Tue, Apr 27, 2021 at 10:50:34AM -0700 schrieb Tim Harvey: On Tue, Apr 27, 2021 at 10:44 AM Marek Vasut wrote: On 4/27/21 7:08 PM, Tim Harvey wrote: Add support for determining host vs peripheral mode for IMX8MM configured as OTG. Signed-off-by: Ti

Re: [PATCH v2 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-04-27 Thread Masahisa Kojima
On Tue, 27 Apr 2021 at 22:52, Heinrich Schuchardt wrote: > > On 27.04.21 15:08, Masahisa Kojima wrote: > > This is preparation for PE/COFF measurement support. > > PE/COFF image hash calculation is same in both > > UEFI Secure Boot image verification and measurement in > > measured boot. PE/COFF i

Re: [PATCH 1/3] usb: ehci-mx6: move mode set/detect to probe

2021-04-27 Thread Tim Harvey
On Tue, Apr 27, 2021 at 10:45 AM Marek Vasut wrote: > > On 4/27/21 7:08 PM, Tim Harvey wrote: > > There is no need to set and/or detect mode in of_to_plat and > > accessing phy registers at that point before device power domain and > > clock are enabled will cause hangs on platforms such as IMX8M

Re: [PATCH 2/3] usb: ehci-mx6: add IMX8MM OTG support

2021-04-27 Thread Tim Harvey
On Tue, Apr 27, 2021 at 12:52 PM Marek Vasut wrote: > > On 4/27/21 9:24 PM, Patrick Wildt wrote: > > Am Tue, Apr 27, 2021 at 10:50:34AM -0700 schrieb Tim Harvey: > >> On Tue, Apr 27, 2021 at 10:44 AM Marek Vasut wrote: > >>> > >>> On 4/27/21 7:08 PM, Tim Harvey wrote: > Add support for deter

Re: [PATCH 2/3] usb: ehci-mx6: add IMX8MM OTG support

2021-04-27 Thread Marek Vasut
On 4/28/21 3:55 AM, Tim Harvey wrote: On Tue, Apr 27, 2021 at 12:52 PM Marek Vasut wrote: On 4/27/21 9:24 PM, Patrick Wildt wrote: Am Tue, Apr 27, 2021 at 10:50:34AM -0700 schrieb Tim Harvey: On Tue, Apr 27, 2021 at 10:44 AM Marek Vasut wrote: On 4/27/21 7:08 PM, Tim Harvey wrote: Add su

Re: [PATCH 1/3] usb: ehci-mx6: move mode set/detect to probe

2021-04-27 Thread Marek Vasut
On 4/28/21 3:51 AM, Tim Harvey wrote: On Tue, Apr 27, 2021 at 10:45 AM Marek Vasut wrote: On 4/27/21 7:08 PM, Tim Harvey wrote: There is no need to set and/or detect mode in of_to_plat and accessing phy registers at that point before device power domain and clock are enabled will cause hangs

Re: [PATCH v2 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-04-27 Thread Heinrich Schuchardt
Am 28. April 2021 03:06:15 MESZ schrieb Masahisa Kojima : >On Tue, 27 Apr 2021 at 22:52, Heinrich Schuchardt >wrote: >> >> On 27.04.21 15:08, Masahisa Kojima wrote: >> > This is preparation for PE/COFF measurement support. >> > PE/COFF image hash calculation is same in both >> > UEFI Secure Boot

Re: [PATCH v2 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-04-27 Thread Masahisa Kojima
On Wed, 28 Apr 2021 at 11:35, Heinrich Schuchardt wrote: > > Am 28. April 2021 03:06:15 MESZ schrieb Masahisa Kojima > : > >On Tue, 27 Apr 2021 at 22:52, Heinrich Schuchardt > >wrote: > >> > >> On 27.04.21 15:08, Masahisa Kojima wrote: > >> > This is preparation for PE/COFF measurement support.

RE: [PATCH v2, 1/2] driver: watchdog: reset watchdog in designware_wdt_stop() function

2021-04-27 Thread Li, Meng
> -Original Message- > From: Sean Anderson > Sent: Tuesday, April 27, 2021 10:50 PM > To: Stefan Roese ; Li, Meng ; u- > b...@lists.denx.de; chin.liang@intel.com; dinh.ngu...@intel.com; > s...@chromium.org > Subject: Re: [PATCH v2, 1/2] driver: watchdog: reset watchdog in > designwar

RE: [PATCH v2, 1/2] driver: watchdog: reset watchdog in designware_wdt_stop() function

2021-04-27 Thread Li, Meng
> -Original Message- > From: Stefan Roese > Sent: Tuesday, April 27, 2021 10:23 PM > To: Li, Meng ; u-boot@lists.denx.de; > chin.liang@intel.com; dinh.ngu...@intel.com; s...@chromium.org > Subject: Re: [PATCH v2, 1/2] driver: watchdog: reset watchdog in > designware_wdt_stop() functi

Re: [PATCH v2, 1/2] driver: watchdog: reset watchdog in designware_wdt_stop() function

2021-04-27 Thread Stefan Roese
On 28.04.21 04:15, Li, Meng wrote: -Original Message- From: Stefan Roese Sent: Tuesday, April 27, 2021 10:23 PM To: Li, Meng ; u-boot@lists.denx.de; chin.liang@intel.com; dinh.ngu...@intel.com; s...@chromium.org Subject: Re: [PATCH v2, 1/2] driver: watchdog: reset watchdog in desi

Re: [PATCH v2 2/4] efi_loader: Kconfig: Add symbols for embedding the public key into the platform's dtb

2021-04-27 Thread AKASHI Takahiro
On Sun, Apr 25, 2021 at 09:24:39AM +0200, Heinrich Schuchardt wrote: > On 4/12/21 5:05 PM, Sughosh Ganu wrote: > > Add config options EFI_PKEY_DTB_EMBED and EFI_PKEY_FILE which are to > > be used for embedding the public key to be used for capsule > > authentication into the platform's device tree.

Re: [PATCH v2 2/4] efi_loader: Kconfig: Add symbols for embedding the public key into the platform's dtb

2021-04-27 Thread AKASHI Takahiro
On Wed, Apr 28, 2021 at 01:55:18PM +0900, AKASHI Takahiro wrote: > On Sun, Apr 25, 2021 at 09:24:39AM +0200, Heinrich Schuchardt wrote: > > On 4/12/21 5:05 PM, Sughosh Ganu wrote: > > > Add config options EFI_PKEY_DTB_EMBED and EFI_PKEY_FILE which are to > > > be used for embedding the public key t

Re: [PATCH v2, 1/2] driver: watchdog: reset watchdog in designware_wdt_stop() function

2021-04-27 Thread Stefan Roese
On 28.04.21 04:12, Li, Meng wrote: -Original Message- From: Sean Anderson Sent: Tuesday, April 27, 2021 10:50 PM To: Stefan Roese ; Li, Meng ; u- b...@lists.denx.de; chin.liang@intel.com; dinh.ngu...@intel.com; s...@chromium.org Subject: Re: [PATCH v2, 1/2] driver: watchdog: reset

Re: Kirkwood: Fix tv sec/usec normalization in kwboot

2021-04-27 Thread Stefan Roese
On 27.04.21 21:57, Dagan Martinez wrote: From 328c559acf6872bf0cbafe7fbb881748d5c753fb Mon Sep 17 00:00:00 2001 From: Property404 Date: Tue, 27 Apr 2021 15:48:31 -0400 Subject: [PATCH] Kirkwood: Fix tv sec/usec normalization in kwboot `kwboot.c` had an issue where it failed to normalize the `t

Re: [PATCH v2 3/4] efi_capsule: Add a function to get the public key needed for capsule authentication

2021-04-27 Thread AKASHI Takahiro
Simon, On Mon, Apr 12, 2021 at 08:35:25PM +0530, Sughosh Ganu wrote: > Define a function which would be used in the scenario where the > public key is stored on the platform's dtb. This dtb is concatenated > with the u-boot binary during the build process. Platforms which have > a different mechan

Re: [PATCH v2 4/4] Makefile: Add provision for embedding public key in platform's dtb

2021-04-27 Thread AKASHI Takahiro
On Mon, Apr 12, 2021 at 08:35:26PM +0530, Sughosh Ganu wrote: > Add provision for embedding the public key used for capsule > authentication in the platform's dtb. This is done by invoking the > mkeficapsule utility which puts the public key in the efi signature > list(esl) format into the dtb. >

Re: [PATCH 5/5] Makefile: Add provision for embedding public key in platform's dtb

2021-04-27 Thread AKASHI Takahiro
On Thu, Apr 08, 2021 at 09:58:17PM +0200, Heinrich Schuchardt wrote: > On 4/7/21 1:53 PM, Sughosh Ganu wrote: > > Add provision for embedding the public key used for capsule > > authentication in the platform's dtb. This is done by invoking the > > mkeficapsule utility which puts the public key in

Re: [PATCH 5/5] Makefile: Add provision for embedding public key in platform's dtb

2021-04-27 Thread Masami Hiramatsu
2021年4月28日(水) 14:44 AKASHI Takahiro : > > On Thu, Apr 08, 2021 at 09:58:17PM +0200, Heinrich Schuchardt wrote: > > On 4/7/21 1:53 PM, Sughosh Ganu wrote: > > > Add provision for embedding the public key used for capsule > > > authentication in the platform's dtb. This is done by invoking the > > >

Re: [PATCH v7 00/14] mtd: spi-nor: Add support for Cypress s25hl-t/s25hs-t

2021-04-27 Thread Takahiro Kuwano
On 4/27/2021 7:14 PM, Jagan Teki wrote: > On Tue, Apr 27, 2021 at 7:54 AM wrote: >> >> From: Takahiro Kuwano >> >> The S25HL-T/S25HS-T family is the Cypress Semper Flash with Quad SPI. >> >> The summary datasheets can be found in the following links. >> https://www.cypress.com/file/424146/downloa