Re: [U-Boot] [PATCH 1/3] phy: add support for bcm6348 usbh phy

Hi Daniel, El 17/03/2018 a las 20:30, Daniel Schwierzeck escribió: On 04.02.2018 11:18, Álvaro Fernández Rojas wrote: Signed-off-by: Álvaro Fernández Rojas --- drivers/phy/Kconfig| 6 +++ drivers/phy/Makefile | 1 + drivers/phy/bcm6348-usbh-phy.c | 94

[U-Boot] [PATCH 1/1] bios_emulator: remove assignment without effect

Assigning a parameter which is not used afterwards has not effect. Signed-off-by: Heinrich Schuchardt --- drivers/bios_emulator/atibios.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bios_emulator/atibios.c b/drivers/bios_emulator/atibios.c index 2d5b5dc562..545ccd6f1e 100644 --- a

[U-Boot] [PATCH 1/1] i2c: lpi2c: remove superfluous assignments

In lpi2c_status_t result = A; result = B; the first assignment has no effect. Let's remove it. Signed-off-by: Heinrich Schuchardt --- drivers/i2c/imx_lpi2c.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/imx_lpi2c.c b/drivers/i2c/imx

[U-Boot] [PATCH 1/1] drivers: net: cpsw: remove superfluous assignment.

In int ret = A; ret = B; the first assignment has not effect. Signed-off-by: Heinrich Schuchardt --- drivers/net/cpsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c index b72258f83b..e2395dbeb9 100644 --- a/drivers/

[U-Boot] [PATCH 1/1] net: macb: remove superfluous logical constraint

In if (a > =0) {...} else (a < 0) {...} the second logical constraint is superfluous. Signed-off-by: Heinrich Schuchardt --- drivers/net/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index e62aefcd0d..fe370bf7

[U-Boot] [PATCH 1/1] drivers:power:max77693: remove redundant logical constraint

As ret is not set when calling max77693_get_vcell() there is no need to check ret again. Signed-off-by: Heinrich Schuchardt --- drivers/power/mfd/fg_max77693.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/power/mfd/fg_max77693.c b/drivers/power/mfd/fg_max77693.c index df1550816e.

[U-Boot] [PATCH 1/1] regulator: pbias: don't evaluate variable before assignment

We should not evaluate the value of reg before its value is set. Signed-off-by: Heinrich Schuchardt --- drivers/power/regulator/pbias_regulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/regulator/pbias_regulator.c b/drivers/power/regulator/pbias_r

[U-Boot] [RFC 1/1] driver: ram: rockchip: rk3399: missing counter increment

If we want to check the duration we need to increment the counter. Signed-off-by: Heinrich Schuchardt --- I do not have the hardware for testing. But the current coding is obviously flawed. --- drivers/ram/rockchip/sdram_rk3399.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ram/ro

[U-Boot] [PATCH 1/1] spi: atcspi200: avoid NULL dereference

For SPI_XFER_BEGIN | SPI_XFER_END the code sets data_out = NULL. In the debug statement we should not dereference this value. As we do not transfer any data the debug statement is not needed in this case anyway. Signed-off-by: Heinrich Schuchardt --- drivers/spi/atcspi200_spi.c | 6 -- 1 fil

[U-Boot] [PATCH 1/1] spi: fsl_qspi: remove superfluous assignment

In void *rx_addr = NULL; rx_add = A; the first assignment has no effect. Remove it. Signed-off-by: Heinrich Schuchardt --- drivers/spi/fsl_qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index 5dc69a6865

[U-Boot] [PATCH 1/1] spi: lpc32xx: simplify logical expression

A & A & B == A & B Signed-off-by: Heinrich Schuchardt --- drivers/spi/lpc32xx_ssp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/lpc32xx_ssp.c b/drivers/spi/lpc32xx_ssp.c index e2a593b934..b8bce3d6e8 100644 --- a/drivers/spi/lpc32xx_ssp.c +++ b/drivers/spi/lpc3

[U-Boot] [PATCH 1/1] usb: dwc3: remove superfluous assignment

In struct dwc3_request *r = NULL; r = A; the first assignment has no effect. Remove it. Signed-off-by: Heinrich Schuchardt --- drivers/usb/dwc3/ep0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index e6

[U-Boot] [PATCH 1/1] usb: gadget: remove duplicate assignment.

We should not make the same assignement twice. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/composite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index d0ee7847b9..7dd1e13b92 100644 --- a/drive

Re: [U-Boot] [PATCH 1/1] usb: dwc3: remove superfluous assignment

On 03/18/2018 01:00 PM, Heinrich Schuchardt wrote: > In > > struct dwc3_request *r = NULL; > r = A; > > the first assignment has no effect. Remove it. > > Signed-off-by: Heinrich Schuchardt The driver is imported from Linux, did you fix it in Linux too ? > --- > drivers/usb/d

[U-Boot] [PATCH 1/1] usb: f_mass_storage: simplify logical expression

An unsigned int is always >= 0. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/f_mass_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index 1ecb92ac6b..7d7ed4242b 100644 --- a/driv

[U-Boot] [PATCH 1/1] usb: rockchip: remove duplicate assignement.

Assigning f_rkusb->reboot_flag twice doesn't make sense. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/f_rockusb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/f_rockusb.c b/drivers/usb/gadget/f_rockusb.c index d5a10f1904..ad3ae91e6d 100644 --- a/drivers/usb/

[U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

Assigning a value to ret if it is immediately overwritten does not make sense. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/ehci-faraday.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-faraday.c b/drivers/usb/host/ehci-faraday.c index 821222

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: > Assigning a value to ret if it is immediately overwritten does not make > sense. > > Signed-off-by: Heinrich Schuchardt Did you even compile-test this ? I have a feeling this file is not used at all, so maybe we should remove this driver. > -

[U-Boot] [PATCH 1/1] usb: sl811-hcd: remove duplicat assignment

Don't make the same assignment twice. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/sl811-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c index b29c67e189..e587895bfc 100644 --- a/drivers/usb/host/sl8

[U-Boot] [PATCH 1/1] usb: xhci-exynos5: correct error checking

If fdtdec_next_compatible_subnode() fails it returns a negative value. The check (node <= 0) cannot identify this if node is unsigned. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/xhci-exynos5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-

[U-Boot] [PATCH 1/1] usb: xhci-keystone: remove superfluous assignment

There is no need to set variables to NULL if they are not used before the next assignment. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/xhci-keystone.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-keystone.c b/drivers/usb/host/xhci-keys

[U-Boot] [PATCH 1/1] usb: xhci-ring: remove superfluous assignment

No need to set a variable to NULL if the next use is an assignment. Do not define variables in the middle of nowhere. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb

[U-Boot] [PATCH 1/1] usb: xhci: remove superfluous assignment

There is not need to set variables to NULL before an assignment. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 4673738d1e..7e3c373e64 100644 --- a/driv

[U-Boot] [PATCH 1/1] usb: musb: remove superfluous assignment

Setting ret = -EINVAL is superfluous. Signed-off-by: Heinrich Schuchardt --- drivers/usb/musb-new/musb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb-new/musb_core.c b/drivers/usb/musb-new/musb_core.c index 79e118ef85..19c072a67e 100644 --- a/drivers/

[U-Boot] tools/mxsimage: Support building with LibreSSL

The mxsimage utility fails to compile against LibreSSL because LibreSSL says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1 interface. Signed-off-by: Hauke Mehrtens --- tools/mxsimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/mxsimage.c b/to

[U-Boot] [PATCH v2] tools/mxsimage: Support building with LibreSSL

The mxsimage utility fails to compile against LibreSSL because LibreSSL says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1 interface. LibreSSL defines OPENSSL_VERSION_NUMBER with 0x2000L and therefor claims to have an API compatible with OpenSSL 2.0, but it does not imple

Re: [U-Boot] tools/mxsimage: Support building with LibreSSL

On 03/17/2018 03:47 PM, Marek Vasut wrote: > On 03/17/2018 01:23 PM, Hauke Mehrtens wrote: >> The mxsimage utility fails to compile against LibreSSL because LibreSSL >> says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1 >> interface. > > The mxsimage does support OpenSSL 1.1

[U-Boot] pci modify [.l .w .b]

Hi list. If a pci modify command is issued, do_pci() takes the size specifier (.l, .w, .b) and turns it into one of PCI_SIZE_8, PCI_SIZE_16, or PCI_SIZE_32, which correspond to 0, 1, and 2. Consequently, the address increment moves at 0, 1, or 2 bytes. This would be a trivial patch for me to

Re: [U-Boot] [PATCH] davinci: omapl138_lcdk: fix PLL0 frequency

On Fri, 2018-03-16 at 10:45 -0500, David Lechner wrote: > On 03/16/2018 04:26 AM, Sekhar Nori wrote: > > On Thursday 15 March 2018 08:02 PM, David Lechner wrote: > > > > > > Thanks for the tips. I've actually done exactly that (using my > > > own SD > > > card). > > > > > > However, these changes

Re: [U-Boot] tools/mxsimage: Support building with LibreSSL

On 03/18/2018 01:33 AM, Jonathan Gray wrote: > On Sat, Mar 17, 2018 at 05:24:47PM +0100, Marek Vasut wrote: >> On 03/17/2018 04:09 PM, Hauke Mehrtens wrote: >>> On 03/17/2018 03:47 PM, Marek Vasut wrote: On 03/17/2018 01:23 PM, Hauke Mehrtens wrote: > The mxsimage utility fails to compile

[U-Boot] [PATCH 1/1] usb: musb-new: misplaced out of bounds check

musb->endpoints[] has array size MUSB_C_NUM_EPS. We must check array bounds before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt --- drivers/usb/musb-new/musb_gadget_ep0.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/musb

[U-Boot] [PATCH 1/1] video: cfb_console: simplify logical constraint

(A || !A && B) == (A || B) Signed-off-by: Heinrich Schuchardt --- drivers/video/cfb_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c index 0b25897062..5b7795dd44 100644 --- a/drivers/video/cfb_console.c +++ b/

[U-Boot] [PATCH 1/1] video: stb_truetype: simplify expression

Eliminate (x2 - x2) which is always zero. Signed-off-by: Heinrich Schuchardt --- drivers/video/stb_truetype.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/stb_truetype.h b/drivers/video/stb_truetype.h index 26e483cf56..5d00bff9fd 100644 --- a/drivers/video/st

[U-Boot] [PATCH 1/1] video, da8xx-fb: fix time out in wait_for_event()

If an event does not occur the current coding stays in an endless loop. Signed-off-by: Heinrich Schuchardt --- drivers/video/da8xx-fb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c index 6ec4f89e34..26db73b138 100644

[U-Boot] [PATCH 1/1] video: exynos: remove redundant assignments

No need to initialize variables if the next usage is an assignment. Signed-off-by: Heinrich Schuchardt --- drivers/video/exynos/exynos_dp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/exynos/exynos_dp.c b/drivers/video/exynos/exynos_dp.c index 3

[U-Boot] [PATCH 1/1] video: rk3399_mipi: correct error checking

Pointers are never negative. Use macro IS_ERR() for checking. cf. rk3288_mipi.c Signed-off-by: Heinrich Schuchardt --- drivers/video/rockchip/rk3399_mipi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/rockchip/rk3399_mipi.c b/drivers/video/rockchip/rk3399_mi

[U-Boot] [RFC 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

The error checking should also catch the case that no range has beeen defined. syscon_get_first_range() returns NULL if no range is defined. cf. rk3399_mipi.c Signed-off-by: Heinrich Schuchardt --- I do not possess the hardware for testing. But the coding is not consistent with the coding used in

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

On 03/18/2018 01:27 PM, Marek Vasut wrote: > On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >> Assigning a value to ret if it is immediately overwritten does not make >> sense. >> >> Signed-off-by: Heinrich Schuchardt > > Did you even compile-test this ? I have a feeling this file is not used

Re: [U-Boot] [PATCH 1/1] usb: dwc3: remove superfluous assignment

On 03/18/2018 01:10 PM, Marek Vasut wrote: > On 03/18/2018 01:00 PM, Heinrich Schuchardt wrote: >> In >> >> struct dwc3_request *r = NULL; >> r = A; >> >> the first assignment has no effect. Remove it. >> >> Signed-off-by: Heinrich Schuchardt > > The driver is imported from Linux, d

Re: [U-Boot] [PATCH v4 1/2] ARM: AM43xx: Add support for RTC only + DDR in self-refresh mode

On Sat, Mar 17, 2018 at 01:32:52PM +0530, Keerthy wrote: > From: Tero Kristo > > Kernel stores information to the RTC_SCRATCH0 and RTC_SCRATCH1 registers > for wakeup from RTC-only mode with DDR in self-refresh. Parse these > registers during SPL boot and jump to the kernel resume vector if the

Re: [U-Boot] [U-Boot, v3] common: add a prototype for mach_cpu_init()

On Fri, Mar 09, 2018 at 06:28:12PM +0100, Patrick Delaunay wrote: > Add a new file init.h with the prototype for arch_cpu_init > Add a prototype for mach_cpu_init() to avoid a warning: > no previous prototype for ‘mach_cpu_init’ > > It is a first step to move all the functions prototype > used du

Re: [U-Boot] common: remove unused prototypes

On Mon, Mar 12, 2018 at 09:19:22AM +0100, Patrick Delaunay wrote: > Remove the prototypes for 4 functions no more existing > in U-Boot code (checked by grep): > - checkflash > - checkdram > - mdm_init > - setup_board_extra > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: ARM FREESCALE IMX: remove invalid path

On Mon, Mar 12, 2018 at 10:56:18PM +0100, Heinrich Schuchardt wrote: > arch/arm/cpu/armv7/mx*/ does not relate to any existing directory. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Fabio Estevam Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature __

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: ARM SAMSUNG: remove invalid paths

On Mon, Mar 12, 2018 at 11:17:11PM +0100, Heinrich Schuchardt wrote: > Remove non-existing directories. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Minkyu Kang Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature _

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: FLATTENED DEVICE TREE: correct maintained path

On Mon, Mar 12, 2018 at 11:08:09PM +0100, Heinrich Schuchardt wrote: > Change due to commit b08c8c487083 ("libfdt: move headers to > and ") > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature _

Re: [U-Boot] ppc: Remove orphan xilinx_irq.h file

On Tue, Mar 13, 2018 at 11:17:07AM +0100, Michal Simek wrote: > This file is completely unused and it should be removed as the part of > ppc405/ppc440 xilinx platform removal. > > Signed-off-by: Michal Simek Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature _

Re: [U-Boot] [U-Boot, v2, 2/5] common: move board_init.c prototypes in init.h

On Tue, Mar 13, 2018 at 01:57:01PM +0100, Patrick Delaunay wrote: > Move function prototypes for common/init/board_init.c > from common.h to init.h > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature _

Re: [U-Boot] post: remove reference to power functions

On Mon, Mar 12, 2018 at 09:22:44AM +0100, Patrick Delaunay wrote: > The 2 functions board_power_mode and board_poweroff > are no more existing in U-Boot code (check with grep) > This patch updates the documentation and removes > the unnecessary prototypes. > > Signed-off-by: Patrick Delaunay Ap

Re: [U-Boot] [U-Boot, v2, 3/5] common: move board_r.c prototypes in init.h

On Tue, Mar 13, 2018 at 01:57:02PM +0100, Patrick Delaunay wrote: > Move function prototypes used in common/board_r.c > from common.h to init.h > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature _

Re: [U-Boot] [U-Boot, v2, 4/5] common: move board_info.c prototypes in init.h

On Tue, Mar 13, 2018 at 01:57:03PM +0100, Patrick Delaunay wrote: > Move function prototype for common/init/board_init.c > from common.h to init.h > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature __

Re: [U-Boot] [U-Boot, v2, 5/5] common: move init_helpers.h prototypes in init.h

On Tue, Mar 13, 2018 at 01:57:04PM +0100, Patrick Delaunay wrote: > Merge init_helpers.h in the new file init.h > with only prototypes for init_cache_f_r > used in common/board_f.c > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP si

Re: [U-Boot] [U-Boot, v2, 1/5] common: move board_f.c prototypes in init.h

On Tue, Mar 13, 2018 at 01:57:00PM +0100, Patrick Delaunay wrote: > Move prototypes for function used in common/board_f.c > from common.h to init.h > Remove weak for arch_reserve_stacks in prototype > (checkpatch issue) > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! --

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: ARM HISILICON: correct maintained path

On Mon, Mar 12, 2018 at 11:02:17PM +0100, Heinrich Schuchardt wrote: > Fix an incorrect path. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@l

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: ARM TI: remove invalid paths

On Mon, Mar 12, 2018 at 11:40:29PM +0100, Heinrich Schuchardt wrote: > Remove non-existing paths. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Bo

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: TI SYSTEM SECURITY: remove invalid file

On Mon, Mar 12, 2018 at 11:58:33PM +0100, Heinrich Schuchardt wrote: > Remove a link to a non-existent file. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Andrew F. Davis Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI

doc/driver-model/MIGRATION.txt requires to move block drivers to the the driver model by v2018.05 So make the switch for the SUNXI block drivers. Select BLK, DM_MMC, and DM_SCSI. DM_USB dpends on USB but there is no necessity to make it depend on DISTRO_DEFAULTS. Signed-off-by: Heinrich Schucha

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

On 03/18/2018 03:41 PM, Heinrich Schuchardt wrote: > On 03/18/2018 01:27 PM, Marek Vasut wrote: >> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >>> Assigning a value to ret if it is immediately overwritten does not make >>> sense. >>> >>> Signed-off-by: Heinrich Schuchardt >> >> Did you even

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

On 03/18/2018 03:41 PM, Heinrich Schuchardt wrote: > On 03/18/2018 01:27 PM, Marek Vasut wrote: >> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >>> Assigning a value to ret if it is immediately overwritten does not make >>> sense. >>> >>> Signed-off-by: Heinrich Schuchardt >> >> Did you even

Re: [U-Boot] [U-Boot, v1, 1/2] rockchip: pinctrl: rk3399: fix GPIO2B1 and GPIO2B2 shift value

> From: Philipp Tomsich > > The shift values for GPIO2B1 and GPIO2B2 had in fact referred to > GPIO2B0 and GPIO2B1, respectively. This substitutes the correct > values. > > Signed-off-by: Philipp Tomsich > Signed-off-by: Klaus Goger > Acked-by: Philipp Tomsich > --- > > arch/arm/include/as

Re: [U-Boot] [U-Boot, v1, 2/2] rockchip: pinctrl: rk3399: add support for I2C[123467]

> From: Philipp Tomsich > > This adds support for the (to date unsupported) I2C controllers 1~4 > and 6~7 (i.e. now all controllers except I2C5, which is not accessible > on the RK3399-Q7, are supported by pinctrl). > > Signed-off-by: Philipp Tomsich > Tested-by: Klaus Goger > > Signed-off-by

Re: [U-Boot] rockchip: rk3399: set fdtfile

> Signed-off-by: Mark Kettenis > --- > include/configs/rk3399_common.h | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, 1/1] usb: rockchip: remove duplicate assignement.

> Assigning f_rkusb->reboot_flag twice doesn't make sense. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/usb/gadget/f_rockusb.c | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [U-Boot, RFC, 1/1] driver: ram: rockchip: rk3399: missing counter increment

> If we want to check the duration we need to increment the counter. > > Signed-off-by: Heinrich Schuchardt > --- > I do not have the hardware for testing. But the current coding is > obviously flawed. > --- > drivers/ram/rockchip/sdram_rk3399.c | 1 + > 1 file changed, 1 insertion(+) > Acked-

Re: [U-Boot] [U-Boot, v2] rockchip: i2c: enable new I2C controller for rk3066 and rk3188

> rk3066 and rk3188 has two I2C controller implementations. > Current I2C driver wan't work with legacy implementation. > Switching between controllers is performed using a bit inside > GFR_SOC_CON1 register. The bit setting is performed by pinctrl > driver. The patch ask pinctrl to do settings. >

Re: [U-Boot] [U-Boot, 1/1] video: rk3399_mipi: correct error checking

> Pointers are never negative. Use macro IS_ERR() for checking. > cf. rk3288_mipi.c > > Signed-off-by: Heinrich Schuchardt > --- > drivers/video/rockchip/rk3399_mipi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Philipp Tomsich __

Re: [U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

> The error checking should also catch the case that no range has beeen > defined. > syscon_get_first_range() returns NULL if no range is defined. > cf. rk3399_mipi.c > > Signed-off-by: Heinrich Schuchardt > --- > I do not possess the hardware for testing. But the coding is not consistent > with

Re: [U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

> The error checking should also catch the case that no range has beeen > defined. > syscon_get_first_range() returns NULL if no range is defined. > cf. rk3399_mipi.c > > Signed-off-by: Heinrich Schuchardt > --- > I do not possess the hardware for testing. But the coding is not consistent > with

Re: [U-Boot] [U-Boot, RFC, 1/1] driver: ram: rockchip: rk3399: missing counter increment

> If we want to check the duration we need to increment the counter. > > Signed-off-by: Heinrich Schuchardt > --- > I do not have the hardware for testing. But the current coding is > obviously flawed. > --- > drivers/ram/rockchip/sdram_rk3399.c | 1 + > 1 file changed, 1 insertion(+) > Review

Re: [U-Boot] [U-Boot, 1/1] video: rk3399_mipi: correct error checking

> Pointers are never negative. Use macro IS_ERR() for checking. > cf. rk3288_mipi.c > > Signed-off-by: Heinrich Schuchardt > --- > drivers/video/rockchip/rk3399_mipi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Philipp Tomsich _

Re: [U-Boot] [U-Boot, 1/1] usb: rockchip: remove duplicate assignement.

> Assigning f_rkusb->reboot_flag twice doesn't make sense. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich > --- > drivers/usb/gadget/f_rockusb.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Philipp Tomsich ___ U-Boot ma

[U-Boot] [PATCH v1] rtc: rewrite isl1208 to support DM

Adds devicemodel support to the ISL1208 driver. This patch drops the non-dm API as no board was using it anyway. Also add it to Kconfig. Signed-off-by: Klaus Goger --- drivers/rtc/Kconfig | 7 +++ drivers/rtc/isl1208.c | 141 ++ 2 files chang

[U-Boot] [PATCH v3] tools/mxsimage: Support building with LibreSSL

The mxsimage utility fails to compile against LibreSSL version < 2.7.0 because LibreSSL says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1 interface. LibreSSL defines OPENSSL_VERSION_NUMBER with 0x2000L and therefor claims to have an API compatible with OpenSSL 2.0, but i

Re: [U-Boot] [PATCH] davinci: omapl138_lcdk: fix PLL0 frequency

On 16-03-18 16:56, David Lechner wrote: On 03/16/2018 01:26 AM, Mike Looijmans wrote: On 15-03-18 02:36, David Lechner wrote: commit 1601dd97edc6 ("davinci: omapl138_lcdk: increase PLL0 frequency") changed the PLL0 frequency to 456MHz, which is needed for the LCDC IP block. However, in doing s

Re: [U-Boot] [PATCH v1] rtc: rewrite isl1208 to support DM

> On 18 Mar 2018, at 18:35, Klaus Goger > wrote: > > Adds devicemodel support to the ISL1208 driver. > This patch drops the non-dm API as no board was using it anyway. > Also add it to Kconfig. > > Signed-off-by: Klaus Goger Reviewed-by: Philipp Tomsich _

Re: [U-Boot] [U-Boot, 1/3] ubifs: Reintroduce using CONFIG_UBIFS_SILENCE_MSG

Hi, > Use of CONFIG_UBIFS_SILENCE_MSG was added in > 147162dac6 ("ubi: ubifs: Turn off verbose prints") > > Then it was removed in > ff94bc40af ("mtd, ubi, ubifs: resync with Linux-3.14") > > Cc: Joe Hershberger > Cc: Heiko Schocher > Signed-off-by: Petr Vorel > --- > Note, not sure whether we

Re: [U-Boot] iminfo and zImages

Dear Andy, In message you wrote: > > Is it just not possible for the zImages in RAM to be decoded as per the > uImages ? You can decode only the information that is in there. uImage adds an extra 64 byte header with informnation I considered useful to have, like names, timestamp, checksum.

Re: [U-Boot] [ANN] U-Boot v2018.03 released

Dear Tom, In message <20180313121344.gk1...@bill-the-cat.ec.rr.com> you wrote: > > We're a day off schedule, but I wanted to see a final comment on one > last bug fix. So, now, I've released v2018.03 and it's live on git and > FTP and ACD (along with the PGP sig file). Sorry for the long delay

[U-Boot] dhcp command not populating dnsip environment variable

Cause: u-boot/Kconfig DISTRO_DEFAULTS missing variables in Kconfig files u-boot/ config DISTRO_DEFAULTS contains these directives: select HUSH_PARSER select BOOTP_BOOTPATH if NET && CMD_NET select BOOTP_DNS if NET && CMD_NET select BOOTP_GATEWAY if NET && CMD_NET

Re: [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI

Hi, On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote: > doc/driver-model/MIGRATION.txt requires to move block drivers to the > the driver model by v2018.05 > > So make the switch for the SUNXI block drivers. > > Select BLK, DM_MMC, and DM_SCSI. > > DM_USB dpends on USB but th

Re: [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI

On 03/18/2018 10:21 PM, Maxime Ripard wrote: > Hi, > > On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote: >> doc/driver-model/MIGRATION.txt requires to move block drivers to the >> the driver model by v2018.05 >> >> So make the switch for the SUNXI block drivers. >> >> Select BLK

[U-Boot] [PATCH 1/1] lib/slre: remove superfluous assignment

It makes to assign a value to 'res' if the next use of the variable is an assignment. Signed-off-by: Heinrich Schuchardt --- lib/slre.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/slre.c b/lib/slre.c index e26d344865..969c46a859 100644 --- a/lib/slre.c +++ b/lib/slre.c @@ -703,8 +70

Re: [U-Boot] [PATCH 1/1] lib/slre: remove superfluous assignment

On Sun, Mar 18, 2018 at 11:12:10PM +0100, Heinrich Schuchardt wrote: > It makes to assign a value to 'res' if the next use of the variable is an > assignment. I think you meant "It makes no sense to " ... Thanks (and for all of the other load of fixes you've been posting)! -- Tom signature.a

[U-Boot] [PATCH v2 1/1] lib/slre: remove superfluous assignment

It makes no sense to assign a value to 'res' if the next use of the variable is an assignment. Signed-off-by: Heinrich Schuchardt --- v2 correct commit message --- lib/slre.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/slre.c b/lib/slre.c index e26d344865..969c46a859 100644

[U-Boot] [PATCH 1/1] mips: micronas/vct: check array bounds before access

If we check an index against array bounds, we should do so before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt --- board/micronas/vct/scc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/board/micronas/vct/scc.c b/board/micronas/vct/scc.c ind

Re: [U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

On Sat, 17 Mar 2018 16:36:14 + Calvin Johnson wrote: > It would be good to have this cosmetic change into a separate patch. Ok. But at this stage I'm at the "Forgive me Lord for I know not what I do" > IMO, better place for this definition and associated explanation > would be above the c

Re: [U-Boot] [U-Boot, 1/2] rockchip: pinctrl: rk3036: Move the iomux definitions into pinctrl-driver

> Clean the iomux definitions at grf_rk3036.h, and move them into > pinctrl-driver for resolving the compiling error of redefinition. > > Signed-off-by: Alexander Kochetkov > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich > --- > arch/arm/include/asm/arch-rockchip/grf_rk3036.h | 409

Re: [U-Boot] [U-Boot, 2/2] rockchip: pinctrl: rk3188: Move the iomux definitions into pinctrl-driver

> Clean the iomux definitions at grf_rk3188.h, and move them into > pinctrl-driver for resolving the compiling error of redefinition. > > Signed-off-by: Alexander Kochetkov > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich > --- > arch/arm/include/asm/arch-rockchip/grf_rk3188.h | 380

Re: [U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

> The error checking should also catch the case that no range has beeen > defined. > syscon_get_first_range() returns NULL if no range is defined. > cf. rk3399_mipi.c > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich > --- > I do not possess the h

Re: [U-Boot] [U-Boot, 1/1] usb: rockchip: remove duplicate assignement.

> Assigning f_rkusb->reboot_flag twice doesn't make sense. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich > --- > drivers/usb/gadget/f_rockusb.c | 1 - > 1 file changed, 1 deletion(-) > Applied to u-boot-rockchip, thanks! ___

Re: [U-Boot] [U-Boot, RFC, 1/1] driver: ram: rockchip: rk3399: missing counter increment

> If we want to check the duration we need to increment the counter. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich > --- > I do not have the hardware for testing. But the current coding is > obviously flawed. > --- > drivers/ram/rockchip/sdra

Re: [U-Boot] rockchip: clk: rk3188: update dpll settings to make EMAC work

> The patch set dpll settings for 300MHz to values used by binary > blob[1]. With new values dpll still generate 300MHz clock, but > EMAC work. Probably with new values dpll generate more stable clock. > > dpll on rk3188 provide clocks to DDR and EMAC. With current > dpll settings EMAC doesn't wor

Re: [U-Boot] [U-Boot, 1/1] usb: rockchip: remove duplicate assignement.

On 03/19/2018 12:48 AM, Philipp Tomsich wrote: >> Assigning f_rkusb->reboot_flag twice doesn't make sense. >> >> Signed-off-by: Heinrich Schuchardt >> Acked-by: Philipp Tomsich >> Reviewed-by: Philipp Tomsich >> --- >> drivers/usb/gadget/f_rockusb.c | 1 - >> 1 file changed, 1 deletion(-) >> >

Re: [U-Boot] [U-Boot, 1/1] video: rk3399_mipi: correct error checking

> Pointers are never negative. Use macro IS_ERR() for checking. > cf. rk3288_mipi.c > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich > --- > drivers/video/rockchip/rk3399_mipi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied

Re: [U-Boot] [PATCH 1/1] mips: micronas/vct: check array bounds before access

On 18.03.2018 23:43, Heinrich Schuchardt wrote: > If we check an index against array bounds, we should do so before > accessing the array and not afterwards. > > Signed-off-by: Heinrich Schuchardt > --- > board/micronas/vct/scc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > a

Re: [U-Boot] [PATCH 0/3] bmips: add support for bcm6348 usbh phy

On 04.02.2018 11:18, Álvaro Fernández Rojas wrote: > Add support for BCM6348 usbh phy. > > Álvaro Fernández Rojas (3): > phy: add support for bcm6348 usbh phy > mips: bmips: add support for bcm6348 usb > mips: bmips: add ct-5361 usb support > > arch/mips/dts/brcm,bcm6348.dtsi | 20

Re: [U-Boot] [PATCH 0/4] bmips: add support for bcm6358 usbh phy

On 04.02.2018 11:19, Álvaro Fernández Rojas wrote: > Add support for BCM6358 usbh phy. > > Álvaro Fernández Rojas (4): > phy: add support for bcm6358 usbh phy > mips: bmips: add support for bcm6358 usb > mips: bmips: add hg556a usb support > mips: bmips: add nb4-ser usb support > > arc

Re: [U-Boot] [PATCH v2 1/1] lib/slre: remove superfluous assignment

On Sun, Mar 18, 2018 at 11:28:20PM +0100, Heinrich Schuchardt wrote: > It makes no sense to assign a value to 'res' if the next use of the > variable is an assignment. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature _

Re: [U-Boot] [PATCH v2 0/9] bmips: add support for bcm6368 usbh phy

On 04.02.2018 21:10, Álvaro Fernández Rojas wrote: > Add support for BCM 6328/6362/6368/63268 usbh phy. > > v2: use correct phy driver and simplify code. > > Álvaro Fernández Rojas (9): > phy: add support for bcm6368 usbh phy > mips: bmips: add support for bcm6368 usb > mips: bmips: add w

Re: [U-Boot] [PATCH v2 0/3] bmips: add support for bcm6318 usbh phy

On 04.02.2018 21:11, Álvaro Fernández Rojas wrote: > Add support for BCM6318 usbh phy. > > v2: use correct phy driver > > Álvaro Fernández Rojas (3): > phy: add support for bcm6318 usbh phy > mips: bmips: add support for bcm6318 usb > mips: bmips: add ar-5315 usb support > > arch/mips/d

Re: [U-Boot] [PATCH 1/1] usb: xhci-ring: remove superfluous assignment

On Sun, Mar 18, 2018 at 9:01 PM, Heinrich Schuchardt wrote: > No need to set a variable to NULL if the next use is an assignment. > Do not define variables in the middle of nowhere. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/usb/host/xhci-ring.c | 2 +- > 1 file changed, 1 insertion(

  1   2   >