On 03/18/2018 03:41 PM, Heinrich Schuchardt wrote: > On 03/18/2018 01:27 PM, Marek Vasut wrote: >> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >>> Assigning a value to ret if it is immediately overwritten does not make >>> sense. >>> >>> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> >> >> Did you even compile-test this ? I have a feeling this file is not used >> at all, so maybe we should remove this driver. > > CONFIG_USB_EHCI_FARADAY is in config_whitelist.txt. > I cannot find any place where USB_EHCI_FARADAY is actually defined. > The driver was added in 2013. I cannot not find any use in v2014.01 > either. So possibly it was never used. > > Regards > > Heinrich >
Eliminating the driver would allow us to remove the tweaks parameter of ehci_register(), several #ifdefs, and to simplify the ehci coding. Regards Heinrich _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
