[U-Boot] [PATCH 1/1] Makefile: indicate dtc source location

2017-09-24 Thread Heinrich Schuchardt
We now require a dtc version which is not yet available in many distros. Indicate to the user where he will find the sources. Signed-off-by: Heinrich Schuchardt --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index a0d9218515..c17cca5b0d 100644 --- a/Makefil

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Marek Vasut
On 09/24/2017 05:22 AM, Tom Rini wrote: > On Sat, Sep 23, 2017 at 09:07:02PM -0500, Robert Nelson wrote: >> On Sat, Sep 23, 2017 at 8:49 PM, Bin Meng wrote: >>> Hi Tom, >>> >>> On Sun, Sep 24, 2017 at 12:10 AM, Tom Rini wrote: On Sat, Sep 23, 2017 at 03:04:39PM +0200, Marek Vasut wrote:

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Łukasz Majewski
On 09/24/2017 08:41 AM, Heinrich Schuchardt wrote: On 09/23/2017 07:53 PM, Tom Rini wrote: On Sat, Sep 23, 2017 at 07:43:09PM +0200, Marek Vasut wrote: On 09/23/2017 07:37 PM, Tom Rini wrote: On Sat, Sep 23, 2017 at 07:33:44PM +0200, Marek Vasut wrote: On 09/23/2017 07:05 PM, Tom Rini wrote:

Re: [U-Boot] [PATCH 5/6] apalis_imx6: Avoid calling setup_display() from SPL code

2017-09-24 Thread Max Krummenacher
Hi I propose to drop my patches in favor of Fabio's solution. Reviewed-by: Max Krummenacher Max Von: Anatolij Gustschin Gesendet: Samstag, 23. September 2017 21:06:57 An: Stefano Babic Cc: Fabio Estevam; u-boot@lists.denx.de; Max Krummenacher; Fabio Esteva

Re: [U-Boot] [PATCH 6/6] colibri_imx6: Avoid calling setup_display() from SPL code

2017-09-24 Thread Max Krummenacher
Hi I tested this together with Anatolij's patch [1] on a Colibri iMX6. Both with the SPL and non SPL config the behaviour of the graphical output is as expected. Tested-by: Max Krummenacher Thanks Fabio. Max [1] http://patchwork.ozlabs.org/patch/806755

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Tom Rini
On Sun, Sep 24, 2017 at 10:28:18AM +0200, Marek Vasut wrote: > On 09/24/2017 05:22 AM, Tom Rini wrote: > > On Sat, Sep 23, 2017 at 09:07:02PM -0500, Robert Nelson wrote: > >> On Sat, Sep 23, 2017 at 8:49 PM, Bin Meng wrote: > >>> Hi Tom, > >>> > >>> On Sun, Sep 24, 2017 at 12:10 AM, Tom Rini wrot

Re: [U-Boot] [PATCH 1/2] arm: mvebu: fix boot from UART on ClearFog Base

2017-09-24 Thread Baruch Siach
Hi Stefan, On Tue, Sep 19, 2017 at 06:48:59AM +0200, Stefan Roese wrote: > On 18.09.2017 19:57, Baruch Siach wrote: > > On Mon, Sep 18, 2017 at 06:00:23PM +0200, Stefan Roese wrote: > > > On 20.08.2017 15:46, Baruch Siach wrote: > > > > The ClearFog Base boot from UART when setting the DIP switche

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Marek Vasut
On 09/24/2017 01:36 PM, Tom Rini wrote: > On Sun, Sep 24, 2017 at 10:28:18AM +0200, Marek Vasut wrote: >> On 09/24/2017 05:22 AM, Tom Rini wrote: >>> On Sat, Sep 23, 2017 at 09:07:02PM -0500, Robert Nelson wrote: On Sat, Sep 23, 2017 at 8:49 PM, Bin Meng wrote: > Hi Tom, > > On Su

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Łukasz Majewski
Hi Marek, Tom, On 09/24/2017 01:36 PM, Tom Rini wrote: On Sun, Sep 24, 2017 at 10:28:18AM +0200, Marek Vasut wrote: On 09/24/2017 05:22 AM, Tom Rini wrote: On Sat, Sep 23, 2017 at 09:07:02PM -0500, Robert Nelson wrote: On Sat, Sep 23, 2017 at 8:49 PM, Bin Meng wrote: Hi Tom, On Sun, Sep 2

[U-Boot] [PATCH v2 2/2] arm: mvebu: clearfog: document boot from UART

2017-09-24 Thread Baruch Siach
Signed-off-by: Baruch Siach --- board/solidrun/clearfog/README | 20 1 file changed, 20 insertions(+) diff --git a/board/solidrun/clearfog/README b/board/solidrun/clearfog/README index 2cfa5bfc8637..ef1e3bf42666 100644 --- a/board/solidrun/clearfog/README +++ b/board/solidru

[U-Boot] [PATCH v2 1/2] arm: mvebu: fix boot from UART on ClearFog Base

2017-09-24 Thread Baruch Siach
The ClearFog Base boot from UART when setting the DIP switches to 01001. Unfortunately, the SPL code sometimes fails to detect the UART boot method at run-time. Add an alternative SAR UART boot value to fix this. Note that this alternative value is not documented (Armada 38x Hardware Specification

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Tom Rini
On Sun, Sep 24, 2017 at 08:41:32AM +0200, Heinrich Schuchardt wrote: > On 09/23/2017 07:53 PM, Tom Rini wrote: > > On Sat, Sep 23, 2017 at 07:43:09PM +0200, Marek Vasut wrote: > >> On 09/23/2017 07:37 PM, Tom Rini wrote: > >>> On Sat, Sep 23, 2017 at 07:33:44PM +0200, Marek Vasut wrote: > On 0

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Tom Rini
On Sun, Sep 24, 2017 at 02:07:27PM +0200, Marek Vasut wrote: > On 09/24/2017 01:36 PM, Tom Rini wrote: > > On Sun, Sep 24, 2017 at 10:28:18AM +0200, Marek Vasut wrote: > >> On 09/24/2017 05:22 AM, Tom Rini wrote: > >>> On Sat, Sep 23, 2017 at 09:07:02PM -0500, Robert Nelson wrote: > On Sat, Se

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Marek Vasut
On 09/24/2017 02:52 PM, Tom Rini wrote: > On Sun, Sep 24, 2017 at 02:07:27PM +0200, Marek Vasut wrote: >> On 09/24/2017 01:36 PM, Tom Rini wrote: >>> On Sun, Sep 24, 2017 at 10:28:18AM +0200, Marek Vasut wrote: On 09/24/2017 05:22 AM, Tom Rini wrote: > On Sat, Sep 23, 2017 at 09:07:02PM -0

Re: [U-Boot] [PATCH] serial: serial_sh: take into account port->clk_mode for SH7785/7786

2017-09-24 Thread Thomas Petazzoni
Hello, On Sat, 23 Sep 2017 07:19:40 +0900, Nobuhiro Iwamatsu wrote: > Sorry, reply is too late. > > Applied, thanks. Thanks! Do you have any suggestion/comments about: Subject: [U-Boot] I/O accessors on SuperH and endianness Date: Mon, 28 Aug 2017 14:32:49 +0200 and: Subject: [U-Boot] Initi

Re: [U-Boot] [PATCH 3/4] imx: mx7: SPL support for i.MX7

2017-09-24 Thread Fabio Estevam
Hi Uri, On Sun, Sep 24, 2017 at 3:00 AM, Uri Mashiach wrote: > Add configuration file and spl_boot_device function for the i.MX7 SPL. > > Signed-off-by: Uri Mashiach Thanks for working on this! I will test your series and will try to convert imx7d-sabresd to SPL. Thanks! _

[U-Boot] [PATCH 0/5] Follow the Linux Kernel in building dtc as needed

2017-09-24 Thread Tom Rini
The following series has been applied. I am posting this for the record. For the record, I do not believe that using git submodules is a good approach here. We have a small amount of code that we need here, and happily we can leverage infrastructur e from the Linux Kernel. Speaking of, this is

[U-Boot] [PATCH 4/5] dtc: Switch to building and using our own dtc unless provided

2017-09-24 Thread Tom Rini
This makes us act like the Linux Kernel does and allow for dtc to be provided externally but otherwise we use the version of dtc that is included in the sources. This in turn means that we can drop the checkdtc logic. We select DTC in the cases where we will need the dtc tool provided. Signed-of

[U-Boot] [PATCH 3/5] scripts/dtc: Update to upstream version v1.4.4-50-gfe50bd1ecc1d

2017-09-24 Thread Tom Rini
This adds the following commits from upstream: fe50bd1ecc1d fdtget: Split out cell list display into a new function 62d812308d11 README: Add a note about test_tree1.dts 5bed86aee9e8 pylibfdt: Add support for fdt_subnode_offset() 46f31b65b3b3 pylibfdt: Add support for fdt_node_offset_by_phandle() a

[U-Boot] [PATCH 2/5] scripts/dtc: Update to upstream version v1.4.4

2017-09-24 Thread Tom Rini
This adds the following commits from upstream: 558cd81bdd43 dtc: Bump version to v1.4.4 c17a811c62eb fdtput: Remove star from value_len documentation 194d5caaefcb fdtget: Use @return to document the return value d922ecdd017b tests: Make realloc_fdt() really allocate *fdt 921cc17fec29 libfdt: overl

[U-Boot] [PATCH 5/5] tools/mkimage: Make the path to the dtc binary that mkimage calls configurable

2017-09-24 Thread Tom Rini
In some cases, such as FreeBSD, the path to an alternative dtc needs to be used. Rather than override the one given in the Makefile on the command line, make this part of the build configuration. Signed-off-by: Tom Rini --- dts/Kconfig| 9 + tools/Makefile | 2 +- 2 files changed, 1

Re: [U-Boot] [PATCH v2 4/5] mmc: omap_hsmmc: Enable Auto command (CMD12) enable

2017-09-24 Thread Tom Rini
On Thu, Sep 21, 2017 at 04:51:35PM +0200, Jean-Jacques Hiblot wrote: > From: Kishon Vijay Abraham I > > Instead of sending STOP TRANSMISSION command from MMC core, enable > the auto command feature so that the Host Controller issues CMD12 > automatically when last block transfer is completed. >

Re: [U-Boot] [PATCH v2 1/5] Revert "omap_hsmmc: update struct hsmmc to accommodate omap3 from DT"

2017-09-24 Thread Tom Rini
On Thu, Sep 21, 2017 at 04:51:32PM +0200, Jean-Jacques Hiblot wrote: > This reverts commit 46831c1a4cda75d92f7ad18d4e2b1eb196c62b2f. > This reserved area at the beginning of struct hsmm, will be used later to > support ADMA > > Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Tom Rini -- Tom

Re: [U-Boot] [PATCH v2 3/5] mmc: omap_hsmmc: Add support for DMA (ADMA2)

2017-09-24 Thread Tom Rini
On Thu, Sep 21, 2017 at 04:51:34PM +0200, Jean-Jacques Hiblot wrote: > From: Kishon Vijay Abraham I > > The omap hsmmc host controller can have the ADMA2 feature. It brings better > read and write throughput. > On most SOC, the capability is read from the hl_hwinfo register. On OMAP3, > DMA supp

Re: [U-Boot] [PULL] u-boot-socfpga/master

2017-09-24 Thread Tom Rini
On Sat, Sep 23, 2017 at 03:14:49PM +0200, Marek Vasut wrote: > The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5: > > Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-socfpga

Re: [U-Boot] [PATCH v2 2/5] omap: Update the base address of the MMC controllers

2017-09-24 Thread Tom Rini
On Thu, Sep 21, 2017 at 04:51:33PM +0200, Jean-Jacques Hiblot wrote: > Align the base address defined in header files with the base address used > in the DTS. This will facilitate the introduction of the DMA support. > > Of all HSMMC users, only omap3 doesn't have the 0x100 reserved region at > t

Re: [U-Boot] [PATCH 2/4] arm: dra7xx: Fix Linux boot from eMMC

2017-09-24 Thread Tom Rini
On Thu, Sep 21, 2017 at 10:37:57PM +0300, Sam Protsenko wrote: > Right now on OMAP5-based boards we have only one partition defined for > Linux boot, which is rootfs. That doesn't work with bootpart=1:2 (that > is defined in include/environment/ti/boot.h). To fix Linux boot we may > either: > >

Re: [U-Boot] [PATCH 1/4] arm: am57xx: Fix Linux boot from eMMC

2017-09-24 Thread Tom Rini
On Thu, Sep 21, 2017 at 10:37:56PM +0300, Sam Protsenko wrote: > Right now on OMAP5-based boards we have only one partition defined for > Linux boot, which is rootfs. That doesn't work with bootpart=1:2 (that > is defined in include/environment/ti/boot.h). To fix Linux boot we may > either: > >

Re: [U-Boot] [PATCH 3/4] env: ti: boot: Extract command for eMMC Linux boot

2017-09-24 Thread Tom Rini
On Thu, Sep 21, 2017 at 10:37:58PM +0300, Sam Protsenko wrote: > Extract commands for booting Linux from eMMC to separate command. It > seems more logical that way, and allows us to run the whole command set > from U-Boot shell with only one command. > > Signed-off-by: Sam Protsenko Reviewed-by

Re: [U-Boot] [PATCH 4/4] env: ti: boot: Show boot status information

2017-09-24 Thread Tom Rini
On Thu, Sep 21, 2017 at 10:37:59PM +0300, Sam Protsenko wrote: > Add tracing printings to Linux/Android boot commands, so that we can see > what's going on. Helps to trace possible bugs on early stages and > improves the output for user (which is especially useful, because we > have a bunch of boo

Re: [U-Boot] [PATCH v2 5/5] mmc: omap_hsmmc: Fix incorrect bit operations for disabling a bit

2017-09-24 Thread Tom Rini
On Thu, Sep 21, 2017 at 04:51:36PM +0200, Jean-Jacques Hiblot wrote: > From: Kishon Vijay Abraham I > > omap_hsmmc driver uses "|" in a couple of places for disabling a bit. > While it's okay to use it in "mmc_reg_out" (since mmc_reg_out has a > _mask_ argument to take care of resetting a bit),

Re: [U-Boot] Please pull u-boot-fsl-qoriq master

2017-09-24 Thread Tom Rini
On Sat, Sep 23, 2017 at 05:08:51AM +, York Sun wrote: > Tom, > > > The following changes since commit 91ebf300934461e450f5ef8f386ea9e55d2636c5: > >Travis-CI: Checkout only v1.4.3 of dtc (2017-09-22 07:40:06 -0400) > > are available in the git repository at: > >git://git.denx.de/u-

[U-Boot] Make Menuconfig Fails

2017-09-24 Thread Duncan Hare
make menuconfig   HOSTCC  scripts/kconfig/mconf.o In file included from scripts/kconfig/mconf.c:23:0: scripts/kconfig/lxdialog/dialog.h:26:20: fatal error: curses.h: No such file or directory  #include CURSES_LOC Appears CURSES_LOC is undefined. Thanks.  Duncan Hare 714 931 7952

Re: [U-Boot] [PATCH 1/1] efi_loader: fix bug in efi_add_known_memory

2017-09-24 Thread Heinrich Schuchardt
On 09/18/2017 11:04 PM, Alexander Graf wrote: > > > On 18.09.17 12:56, Heinrich Schuchardt wrote: >> In efi_add_known_memory the start address is correctly rounded >> up to a mulitple of EFI_PAGE_SIZE. >> By this rounding we may loose up to EFI_PAGE_MASK bytes. >> The current code does not take t

Re: [U-Boot] [PATCH 0/5] Follow the Linux Kernel in building dtc as needed

2017-09-24 Thread Marek Vasut
On 09/24/2017 04:26 PM, Tom Rini wrote: > The following series has been applied. I am posting this for the record. > > For the record, I do not believe that using git submodules is a good approach > here. We have a small amount of code that we need here, and happily we can > leverage infrastruct

Re: [U-Boot] [PATCH 0/5] Follow the Linux Kernel in building dtc as needed

2017-09-24 Thread Tom Rini
On Sun, Sep 24, 2017 at 06:50:01PM +0200, Marek Vasut wrote: > On 09/24/2017 04:26 PM, Tom Rini wrote: > > The following series has been applied. I am posting this for the record. > > > > For the record, I do not believe that using git submodules is a good > > approach > > here. We have a small

Re: [U-Boot] Makefile: Update minimum dtc version to 1.4.3

2017-09-24 Thread Vagrant Cascadian
On 2017-09-23, Tom Rini wrote: > On Sat, Sep 23, 2017 at 07:43:09PM +0200, Marek Vasut wrote: >> On 09/23/2017 07:37 PM, Tom Rini wrote: >> > On Sat, Sep 23, 2017 at 07:33:44PM +0200, Marek Vasut wrote: >> >> On 09/23/2017 07:05 PM, Tom Rini wrote: >> >>> On Sat, Sep 23, 2017 at 08:56:08AM -0400, T

[U-Boot] [PATCH 04/17] efi_loader: wrong type in wait_for_event

2017-09-24 Thread Heinrich Schuchardt
The UEFI spec defines parameter index of WaitForEvent as UINTN*. So we should use size_t here. I deliberately do not use UINTN because I hold a following patch that will eliminate UINTN because uppercase types to not match the U-Boot coding style. Signed-off-by: Heinrich Schuchardt --- include/

[U-Boot] [PATCH 05/17] efi_loader: incorrect definition of EFI_SIMPLE_NETWORK_PROTOCOL

2017-09-24 Thread Heinrich Schuchardt
WaitForPacket is an event and not a function pointer. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/efi_api.h b/include/efi_api.h index c44dc9d0cb..308baeec49 100644 --- a/include/efi_api.h +++ b/include/efi_a

[U-Boot] [PATCH 00/17] efi_loader: Simple Network Protocol

2017-09-24 Thread Heinrich Schuchardt
This patch series focuses on * correction of parameter types for boot services * fixes for the SetMem and CopyMem boot services * fixes for the simple network protocol implementation (SNP) * a unit test for SetMem, CopyMem and the simple network protocol The unit test broadcasts a DHCPDISCOVER mes

[U-Boot] [PATCH 11/17] efi_loader: implement WaitForPacket event

2017-09-24 Thread Heinrich Schuchardt
The WaitForPacket event informs tha a network package has been received by the SimpleNetworkProtocol. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_net.c | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c index 3

[U-Boot] [PATCH 17/17] efi_loader: supply EFI network test

2017-09-24 Thread Heinrich Schuchardt
This patch provices an EFI application to check the correct function of the Simple Network Protocol implementation. It sends a DHCP request and analyzes the DHCP offer. Different error conditions including a 10s timeout are checked. A successful execution will look like this: => bootefi nettest

[U-Boot] [PATCH 02/17] efi_loader: parameters of CopyMem and SetMem

2017-09-24 Thread Heinrich Schuchardt
The UEFI spec defines the length parameters of CopyMem and SetMem as UINTN. We should size_t here. The source buffer of CopyMem should be marked as const. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h | 7 +++ lib/efi_loader/efi_boottime.c | 10 +- 2 files ch

[U-Boot] [PATCH 09/17] efi_net: return EFI_UNSUPPORTED where appropriate

2017-09-24 Thread Heinrich Schuchardt
U-Boot does not implement all functions of the simple network protocol. The unimplemented functions return either of EFI_SUCCESS and EFI_INVALID_PARAMETER. The UEFI spec foresees to return EFI_UNSUPPORTED in these cases. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_net.c | 10 -

[U-Boot] [PATCH 15/17] efi_selftest: correct definition of efi_st_error

2017-09-24 Thread Heinrich Schuchardt
Enclose definition in parantheses to allow using efi_st_error like a void function. Signed-off-by: Heinrich Schuchardt --- include/efi_selftest.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/efi_selftest.h b/include/efi_selftest.h index 76304a2b2a..7273a0f49a 1

[U-Boot] [PATCH 12/17] efi_loader: fix efi_net_get_status

2017-09-24 Thread Heinrich Schuchardt
The returned interrupt status was wrong. As out transmit buffer is empty we need to always set EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT. When we have received a packet we need to set EFI_SIMPLE_NETWORK_RECEIVE_INTERRUPT. Furthermore we should call efi_timer_check() to handle events. Signed-off-by:

[U-Boot] [PATCH 10/17] efi_loader: use events for efi_net_receive

2017-09-24 Thread Heinrich Schuchardt
A timer event is defined. The timer handler cares for receiving new packets. efi_timer_check is called both in efi_net_transmit and efi_net_receive to enable events during network communication. Calling efi_timer_check in efi_net_get_status is implemented in a separate patch. Signed-off-by: Hein

[U-Boot] [PATCH 01/17] efi_loader: call EFI_EXIT in efi_copy_mem, efi_set_mem

2017-09-24 Thread Heinrich Schuchardt
EFI_ENTRY and EFI_EXIT calls must match. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_boottime.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index cbc4007f7b..2c2620a46d 100644 --- a/lib/efi_loader/efi_boottime.

[U-Boot] [PATCH 13/17] efi_loader: size fields in SimpleNetworkProtocol

2017-09-24 Thread Heinrich Schuchardt
The size fields in the Simple Network Protocol are all UINTN in the UEFI spec. So use size_t. Provide a function description of the receive function. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h| 4 ++-- lib/efi_loader/efi_net.c | 24 2 files change

[U-Boot] [PATCH 03/17] efi_loader: pass GUIDs as const efi_guid_t *

2017-09-24 Thread Heinrich Schuchardt
We need to call some boottime services internally. Our GUIDs are stored as const efi_guid_t *. The boottime services never change GUIDs. So we can define the parameters as const efi_guid_t *. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h | 27 ++-

[U-Boot] [PATCH 07/17] efi_loader: fill simple network protocol revision

2017-09-24 Thread Heinrich Schuchardt
Provide the simple network protocol revision. This revision number could be used to identify backwards compatible enhancements of the protocol. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h| 3 +++ lib/efi_loader/efi_net.c | 1 + 2 files changed, 4 insertions(+) diff --git a/

[U-Boot] [PATCH 16/17] efi_selftest: allow printing MAC addresses

2017-09-24 Thread Heinrich Schuchardt
Add %pm as format string to print a MAC address. This is helpful when analyzing network problems. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_console.c | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/lib/efi_selftest/

[U-Boot] [PATCH 08/17] efi_loader: efi_net: hwaddr_size = 6

2017-09-24 Thread Heinrich Schuchardt
The length of a MAC address is 6. We have to set this length in the EFI_SIMPLE_NETWORK_MODE structure of the EFI_SIMPLE_NETWORK_PROTOCOL. Without this patch iPXE fails to initialize the network with error message SNP MAC(001e0633bcbf,0x0) has invalid hardware address length 0 Signed-off-by: Heinr

[U-Boot] [PATCH 06/17] efi_loader: correct bits of receive_filters bit mask

2017-09-24 Thread Heinrich Schuchardt
Remove extraneous commas. Add comment. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/include/efi_api.h b/include/efi_api.h index 308baeec49..8c227ce703 100644 --- a/include/efi_api.h +++ b/include/efi_api.

[U-Boot] [PATCH 14/17] efi_loader: fill return values in SimpleNetworkProtocol

2017-09-24 Thread Heinrich Schuchardt
In the receive function all return values should be filled. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_net.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_net.c b/lib/efi_loader/efi_net.c index 5344210fff..e5faa

Re: [U-Boot] FAT filesystems and mtools-created filesystems

2017-09-24 Thread Rob Clark
On Sat, Sep 23, 2017 at 6:51 AM, Tuomas Tynkkynen wrote: > On 09/23/2017 01:26 PM, Tuomas Tynkkynen wrote: >> >> Hi, >> >> FAT file systems created by GNU mtools have a problem that mtools doesn't >> initialize the first cluster field of the '.' and '..' directory entries. >> That is, with the fol

Re: [U-Boot] [PATCH 0/5] Follow the Linux Kernel in building dtc as needed

2017-09-24 Thread Łukasz Majewski
Hi Tom, On Sun, Sep 24, 2017 at 06:50:01PM +0200, Marek Vasut wrote: On 09/24/2017 04:26 PM, Tom Rini wrote: The following series has been applied. I am posting this for the record. For the record, I do not believe that using git submodules is a good approach here. We have a small amount of

[U-Boot] [PATCH 1/3] fs-test: Add FAT16 support

2017-09-24 Thread Tuomas Tynkkynen
Currently we can only test FAT32 which is the default FAT version that mkfs.vfat creates by default. Instead make it explicitly create either a FAT16 or a FAT32 volume. This allows us to exercise more code, for instance the root directory handling is done differently in FAT32 than the older FATs.

[U-Boot] [PATCH 3/3] fs-test: Add test for a filename using '..' to go back to the root

2017-09-24 Thread Tuomas Tynkkynen
The previous commit fixed a problem in FAT code where going back to the root directory using '..' wouldn't work correctly on FAT12 or FAT16. Add a test to exercise this case (which was once fixed in commit 18a10d46f26 "fat: handle paths that include ../" but reintroduced due to the directory iterat

[U-Boot] [PATCH 2/3] fs/fat: Fix pathnames using '..' that lead to the root directory

2017-09-24 Thread Tuomas Tynkkynen
If we end up back in the root directory via a '..' directory entry, set itr->is_root accordingly. Failing to do that gives spews like "Invalid FAT entry" and being unable to access directory entries located past the first cluster of the root directory on FAT12/FAT16. Fixes: 8eafae209c35 ("fat/fs:

Re: [U-Boot] [PATCH 1/3] fs-test: Add FAT16 support

2017-09-24 Thread Tom Rini
On Mon, Sep 25, 2017 at 12:07:34AM +0300, Tuomas Tynkkynen wrote: > Currently we can only test FAT32 which is the default FAT version that > mkfs.vfat creates by default. Instead make it explicitly create either a > FAT16 or a FAT32 volume. This allows us to exercise more code, for > instance the r

Re: [U-Boot] [PATCH 2/3] fs/fat: Fix pathnames using '..' that lead to the root directory

2017-09-24 Thread Tom Rini
On Mon, Sep 25, 2017 at 12:07:35AM +0300, Tuomas Tynkkynen wrote: > If we end up back in the root directory via a '..' directory entry, set > itr->is_root accordingly. Failing to do that gives spews like > "Invalid FAT entry" and being unable to access directory entries located > past the first cl

Re: [U-Boot] [PATCH 3/3] fs-test: Add test for a filename using '..' to go back to the root

2017-09-24 Thread Tom Rini
On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote: > The previous commit fixed a problem in FAT code where going back to the > root directory using '..' wouldn't work correctly on FAT12 or FAT16. > Add a test to exercise this case (which was once fixed in commit > 18a10d46f26 "fat:

Re: [U-Boot] [PATCH 1/3] fs-test: Add FAT16 support

2017-09-24 Thread Rob Clark
On Sun, Sep 24, 2017 at 5:07 PM, Tuomas Tynkkynen wrote: > Currently we can only test FAT32 which is the default FAT version that > mkfs.vfat creates by default. Instead make it explicitly create either a > FAT16 or a FAT32 volume. This allows us to exercise more code, for > instance the root dire

Re: [U-Boot] [PATCH 3/3] fs-test: Add test for a filename using '..' to go back to the root

2017-09-24 Thread Rob Clark
On Sun, Sep 24, 2017 at 5:38 PM, Tom Rini wrote: > On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote: > >> The previous commit fixed a problem in FAT code where going back to the >> root directory using '..' wouldn't work correctly on FAT12 or FAT16. >> Add a test to exercise this c

Re: [U-Boot] [PATCH 0/5] Follow the Linux Kernel in building dtc as needed

2017-09-24 Thread Tom Rini
On Sun, Sep 24, 2017 at 10:39:30PM +0200, Łukasz Majewski wrote: > Hi Tom, > > >On Sun, Sep 24, 2017 at 06:50:01PM +0200, Marek Vasut wrote: > >>On 09/24/2017 04:26 PM, Tom Rini wrote: > >>>The following series has been applied. I am posting this for the record. > >>> > >>>For the record, I do no

Re: [U-Boot] [PATCH] ARM: mvebu: handle unused DRAM banks with ECC enabled

2017-09-24 Thread Joshua Scott
I can confirm that this patch fixes the issue I was seeing (data_abort, single and dual-bit ecc errors during dram_ecc_scrubbing). Tested on a board with the Marvell AlleyCat3 switch/SoC. Cheers, Joshua Scott From: Chris Packham Sent: Saturday, 23 Sept

Re: [U-Boot] [PATCH 3/3] fs-test: Add test for a filename using '..' to go back to the root

2017-09-24 Thread Tuomas Tynkkynen
On 09/25/2017 12:53 AM, Rob Clark wrote: On Sun, Sep 24, 2017 at 5:38 PM, Tom Rini wrote: On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote: Can you post, unrelated, the code that totally crashed sandbox? Maybe that's a problem we need to fix too :) jfwiw, I've started lookin

[U-Boot] [PATCH] GPT: fix memory leaks identified by Coverity

2017-09-24 Thread alison
From: Alison Chaiken Create a common exit for most of the error handling code in do_rename_gpt_parts. Delete the list elements in disk_partitions before calling INIT_LIST_HEAD from get_gpt_info() a second time. The SIZEOF_MISMATCH error is not addressed, since that problem was already fixed by

Re: [U-Boot] [PATCH v2 1/5] Revert "omap_hsmmc: update struct hsmmc to accommodate omap3 from DT"

2017-09-24 Thread Jaehoon Chung
On 09/24/2017 11:39 PM, Tom Rini wrote: > On Thu, Sep 21, 2017 at 04:51:32PM +0200, Jean-Jacques Hiblot wrote: > >> This reverts commit 46831c1a4cda75d92f7ad18d4e2b1eb196c62b2f. >> This reserved area at the beginning of struct hsmm, will be used later to >> support ADMA >> >> Signed-off-by: Jean-J

Re: [U-Boot] [PATCH 1/1] efi_loader: provide comment for protocol GUIDs

2017-09-24 Thread Simon Glass
On 15 September 2017 at 01:45, Heinrich Schuchardt wrote: > Add a missing comment. > > Reported-by: Simon Glass > Signed-off-by: Heinrich Schuchardt > --- > Patch is directly applicable to efi-next. > > Reported by Simon > Re: [PATCH 15/23] efi_loader: implement ConnectController > https://lists

Re: [U-Boot] [PATCH 01/10] efi_loader: allow return value in EFI_CALL

2017-09-24 Thread Simon Glass
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > Macro EFI_CALL was introduced to call an UEFI function. > Unfortunately it does not support return values. > Most UEFI functions have a return value. > > So let's rename EFI_CALL to EFI_CALL_VOID and introduce a > new EFI_CALL macro that

Re: [U-Boot] [PATCH 02/10] efi_selftest: provide an EFI selftest application

2017-09-24 Thread Simon Glass
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > A testing framework for the EFI API is provided. > It can be executed with the 'bootefi selftest' command. > > It is coded in a way that at a later stage we may turn it > into a standalone EFI application. The current build system > does

Re: [U-Boot] [PATCH 08/10] efi_selftest: test task priority levels

2017-09-24 Thread Simon Glass
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > Run a 10 ms periodic timer and check that it is called 10 times > while waiting for 100 ms single shot timer. > > Raise the TPL level to the level of the 10 ms timer and observe > that the notification function is not called again. > > Lo

Re: [U-Boot] [PATCH 06/10] efi_selftest: provide unit test for event services

2017-09-24 Thread Simon Glass
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > This unit test uses timer events to check the implementation > of the following boottime services: > CreateEvent, CloseEvent, WaitForEvent, CheckEvent, SetTimer > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/Makefile

Re: [U-Boot] [PATCH 04/10] efi_loader: implement queueing of the notification function

2017-09-24 Thread Simon Glass
Hi Heinrich, On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > For the correct implementation of the task priority level (TPL) > calling the notification function must be queued. > > Add a status field 'queued' to events. > > In function efi_signal_event set status queued if a notificat

Re: [U-Boot] [PATCH v2 1/1] test/py: provide example scripts for integrating qemu

2017-09-24 Thread Simon Glass
On 18 September 2017 at 15:29, Heinrich Schuchardt wrote: > The necessary parameters for running Python tests on qemu are > tedious to find. > > The patch adds examples for u-boot-test-console and > u-boot-test-reset. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > Include all necessa

Re: [U-Boot] [PATCH 09/10] efi_loader: notify when ExitBootServices is invoked

2017-09-24 Thread Simon Glass
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > All events of type EVT_SIGNAL_EXIT_BOOT_SERVICES have to be > notified when ExitBootServices is invoked. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 11 +++ > 1 file changed, 11 insertions(+)

Re: [U-Boot] [PATCH 10/10] efi_selftest: check notification of ExitBootServices

2017-09-24 Thread Simon Glass
Hi Heinrich, On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > Check that the notification function of an > EVT_SIGNAL_EXIT_BOOT_SERVICES event is called > exactly once. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/Makefile| 3 + > lib/efi_

Re: [U-Boot] [PATCH v6 08/10] fdtdec: sort include files

2017-09-24 Thread Simon Glass
Hi Jean-Jacques, On 15 September 2017 at 04:57, Jean-Jacques Hiblot wrote: > Sort include files in accordance to U-Boot coding style. > > Signed-off-by: Jean-Jacques Hiblot > --- > lib/fdtdec.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lib/fdtdec.c b/li

Re: [U-Boot] [PATCH 03/10] test/py: add a test calling the EFI selftest

2017-09-24 Thread Simon Glass
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > A Python test script is provided that runs the EFI selftest > if CONFIG_CMD_EFI_SELFTEST=y. > > Signed-off-by: Heinrich Schuchardt > --- > test/py/tests/test_efi_selftest.py | 25 + > 1 file changed, 25 insertion

Re: [U-Boot] [PATCH 1/1] GPT: incomplete initialization in allocate_disk_part

2017-09-24 Thread Simon Glass
On 21 September 2017 at 23:24, Stefan Roese wrote: > On 21.09.2017 19:03, Heinrich Schuchardt wrote: >> >> memset(newpart, '\0', sizeof(newpart)); >> only initializes the firest 4 or 8 bytes of *newpart and not the whole >> structure disk_part. >> >> We should use sizeof(struct disk_part). >> >> I

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

2017-09-24 Thread Simon Glass
Hi Rob, On 18 September 2017 at 09:07, Rob Clark wrote: > On Mon, Sep 18, 2017 at 10:30 AM, Rob Clark wrote: >> On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark wrote: >>> On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark wrote: On Sun, Sep 17, 2017 at 11:48 PM, Heinrich Schuchardt wrote: >

Re: [U-Boot] [PATCH 06/13] log: Add an implemention of logging

2017-09-24 Thread Simon Glass
Hi Bin, On 22 September 2017 at 07:37, Bin Meng wrote: > Hi Simon, > > On Thu, Sep 21, 2017 at 12:58 PM, Simon Glass wrote: >> Hi Bin, >> >> On 20 September 2017 at 08:41, Bin Meng wrote: >>> >>> Hi Simon, >>> >>> On Wed, Sep 20, 2017 at 9:50 PM, Simon Glass wrote: >>> > Hi Bin, >>> > >>> > On

Re: [U-Boot] [PATCH 07/10] efi_loader: implement task priority level (TPL)

2017-09-24 Thread Simon Glass
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > Define variable holding tpl. > Implement RaiseTPL and RestoreTPL. > Implement TPL check in efi_signal_event. > Implement TPL check in efi_wait_for_event. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 32

Re: [U-Boot] [PATCH 1/3] arm: make save_boot_params_ret prototype visible for AArch64

2017-09-24 Thread Simon Glass
On 15 September 2017 at 06:02, Philipp Tomsich wrote: > The save_boot_params_ret() prototype (for those of us, that have a > valid SP on entry and can implement save_boot_params() in C), was > previously only defined for !defined(CONFIG_ARM64). > > This moves the declaration to a common block to e

Re: [U-Boot] [PATCH 1/2] disk: Provide API to get partition by name for specific type

2017-09-24 Thread Simon Glass
Hi Sam, On 21 September 2017 at 16:51, Sam Protsenko wrote: > There is already existing function part_get_info_by_name(). > But sometimes user is particularly interested in looking for only > specific partition type. This patch implements such an API that > provides partition searching by name fo

Re: [U-Boot] [PATCH v2 8/8] dm: define dev_*() log functions in DM header

2017-09-24 Thread Simon Glass
On 15 September 2017 at 23:10, Masahiro Yamada wrote: > Many drivers use dev_err, dev_info, etc. for logging. Currently, > we are relying on , but I guess the best home is > , taking into account that Linux defines them in > . > > For now, I am keeping the ones in because lots of > Linux-origina

Re: [U-Boot] drivers/core/read.c:64:44: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

2017-09-24 Thread Simon Glass
+Bin Hi Heinrich, On 21 September 2017 at 05:11, Heinrich Schuchardt wrote: > Hello Simon, > > sandbox_defconfig has > > arch/sandbox/include/asm/types.h:60: typedef u32 phys_addr_t; > > even if building on a 64bit machine. > > This results in a warning > > CC drivers/demo/demo-uclass.o >

Re: [U-Boot] [PATCH] rockchip: board: lion-rk3368: avoid ATF overwriting active SPL stage

2017-09-24 Thread Simon Glass
On 15 September 2017 at 07:57, Philipp Tomsich wrote: > The RK3368-uQ7 ATF has been moved back to 0x10 (1MB from the start > of DRAM) to avoid it overwriting the active SPL stage during FIT image > loading. This change adapts the .its to match up (again) with our ATF > repository for the RK33

Re: [U-Boot] [PATCH 05/10] efi_loader: efi_set_timer: reset signaled state

2017-09-24 Thread Simon Glass
On 15 September 2017 at 02:06, Heinrich Schuchardt wrote: > We should be able to call efi_set_timer repeatedly. > So let us reset the signaled state here. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glas

[U-Boot] ZynqMP qspi

2017-09-24 Thread Liam Beguin
Hi, I'm testing a new Xilinx zynqmp dev board and was not able to probe the qspi with the latest mainline U-Boot. I see that there is a 'zynqmp_qspi' driver in the Xilinx tree [1] but nothing in mainline. After a little digging, I found a thread on the list [2] (and [3]) and was wondering in what

Re: [U-Boot] [PATCH] dm: core: Round up size when allocating so that it is cache line aligned

2017-09-24 Thread Simon Glass
On 19 September 2017 at 05:23, Faiz Abbas wrote: > The size variable may not be always be a mulitple of > ARCH_DMA_MINALIGN and using it to flush cache leads to cache > misaligned warnings. > > Therefore, round up the size to a multiple of ARCH_DMA_MINLAIGN > when allocating private data. > > Sign

Re: [U-Boot] [PATCH 1/1] efi_loader: call EFI_EXIT in efi_copy_mem, efi_set_mem

2017-09-24 Thread Simon Glass
On 21 September 2017 at 10:41, Heinrich Schuchardt wrote: > EFI_ENTRY and EFI_EXIT calls must match. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass ___ U

Re: [U-Boot] [PATCH 00/16] efi: Enable basic sandbox support for EFI loader

2017-09-24 Thread Simon Glass
Hi Rob, On 18 September 2017 at 11:03, Rob Clark wrote: > On Mon, Sep 18, 2017 at 11:07 AM, Rob Clark wrote: >> On Mon, Sep 18, 2017 at 10:30 AM, Rob Clark wrote: >>> On Mon, Sep 18, 2017 at 9:31 AM, Rob Clark wrote: On Mon, Sep 18, 2017 at 9:18 AM, Rob Clark wrote: > On Sun, Sep 17,

Re: [U-Boot] [PATCH 1/1] ARMv8: fix error in freeing stack frame

2017-09-24 Thread Simon Glass
On 22 September 2017 at 23:30, zijun_hu wrote: > From: zijun_hu > > relocate_code() allocates 32 bytes stack frame but only 16 bytes are > freed before return. it will cause errors to possible previous frames > and doesn't make relocate_code() look like a function. > > fix by freeing 32 bytes sta

Re: [U-Boot] Request For Comments: wget and TCP listener

2017-09-24 Thread Simon Glass
Hi Duncan, On 21 September 2017 at 14:32, Duncan Hare wrote: > Mods to: > cmd/net.cnet/Makefilenet/net.cinclude/net.hnet/wget.cnet/wget.hnet/ping.c > I do not know how to do patches, I'm a noobat this: There is some documentation here. https://www.denx.de/wiki/U-Boot/Patches If you read all of

Re: [U-Boot] [PATCH 1/1] dm: clk: add missing .priv_auto_alloc_size() for stm32f7

2017-09-24 Thread Simon Glass
On 21 September 2017 at 02:08, wrote: > From: Patrice Chotard > > Add missing .priv_auto_alloc_size() callback. > Previously private struct stm32_clk was not allocate > which leads to unpredictable behaviour > > Signed-off-by: Patrice Chotard > --- > drivers/clk/clk_stm32f7.c | 13 +++-

Re: [U-Boot] setjmp/longjmp prototype in U-Boot

2017-09-24 Thread Simon Glass
Hi, On 22 September 2017 at 10:19, Alexander Graf wrote: > Hi Philipp, > > > On 09/21/2017 10:57 AM, Dr. Philipp Tomsich wrote: >> >> Simon & Alexander, >> >> It appears our setjmp/longjmp prototypes and implementations are >> in non-compliance with current C-standards (I checked against >> both

Re: [U-Boot] [PATCH 1/1] sandbox: avoid memory leak in os_dirent_ls

2017-09-24 Thread Simon Glass
On 21 September 2017 at 04:56, Heinrich Schuchardt wrote: > Realloc does not free the old memory area if it fails. > > Identified by cppcheck. > > Signed-off-by: Heinrich Schuchardt > --- > arch/sandbox/cpu/os.c | 20 ++-- > 1 file changed, 14 insertions(+), 6 deletions(-) Revie

  1   2   >