Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Lukasz Majewski
Hi Simon, > Hi Lukasz, > > On Wed, Jan 2, 2013 at 8:25 AM, Lukasz Majewski > wrote: > > This commit makes the video subsystem code cache aware. > > Memory allocated for decompressed BMP memory is now cache line > > aligned. > > > > Flushing of the dcache is also performed after copying BMP data

Re: [U-Boot] [PATCH] nds32: Add a basic errno.h

2013-01-06 Thread Macpaul Lin
Hi Simon, 2013/1/6 Simon Glass > This is available on other architectures, and nds32 will start to break > without it as code starts to use error numbers more. > > +++ b/arch/nds32/include/asm/errno.h > @@ -0,0 +1 @@ > +#include ___ U-Boot mailing list

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Simon Glass
Hi Lukasz, On Sun, Jan 6, 2013 at 12:03 AM, Lukasz Majewski wrote: > Hi Simon, > >> Hi Lukasz, >> >> On Wed, Jan 2, 2013 at 8:25 AM, Lukasz Majewski >> wrote: >> > This commit makes the video subsystem code cache aware. >> > Memory allocated for decompressed BMP memory is now cache line >> > ali

Re: [U-Boot] [PATCH] nds32: Add a basic errno.h

2013-01-06 Thread Simon Glass
Hi, On Sun, Jan 6, 2013 at 3:37 AM, Macpaul Lin wrote: > Hi Simon, > > 2013/1/6 Simon Glass >> >> This is available on other architectures, and nds32 will start to break >> without it as code starts to use error numbers more. >> >> +++ b/arch/nds32/include/asm/errno.h >> @@ -0,0 +1 @@ >> +#inclu

Re: [U-Boot] [PATCH] nds32: Add a basic errno.h

2013-01-06 Thread Tom Rini
On Sun, Jan 06, 2013 at 08:28:39AM -0800, Simon Glass wrote: [snip] > If you don't support a gcc option it should be possible to disable it > in U-Boot for your toolchain as a temporary workaround. It would be > good to get a pointer to your toolchain at some point. Unfortunately gcc doesn't erro

Re: [U-Boot] [PATCH] nds32: Add a basic errno.h

2013-01-06 Thread Simon Glass
Hi Tom, On Sun, Jan 6, 2013 at 9:16 AM, Tom Rini wrote: > On Sun, Jan 06, 2013 at 08:28:39AM -0800, Simon Glass wrote: > > [snip] >> If you don't support a gcc option it should be possible to disable it >> in U-Boot for your toolchain as a temporary workaround. It would be >> good to get a pointe

[U-Boot] [PATCH] MIPS: bootm.c: use debug macro to print debug message

2013-01-06 Thread Gabor Juhos
The '## Transferring control ...' message is printed only if DEBUG is enabled. Get rid of the 'ifdef DEBUG' statement and use the debug macro instead. Signed-off-by: Gabor Juhos --- arch/mips/lib/bootm.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/mips/lib/boot

Re: [U-Boot] [PATCH v7] qi_lb60: add nand spl support

2013-01-06 Thread Daniel Schwierzeck
2013/1/4 Xiangfu Liu : > Hi > > Any chance merge this commit to upstream. make it a new year gift for me. :) > Thanks > > Xiangfu > hm, somehow I missed that patch. Please prepend your patch subject with "MIPS:" and CC me next time to avoid this. Also send a new patch which is rebased to current m

Re: [U-Boot] [PATCH] MIPS: bootm.c: use debug macro to print debug message

2013-01-06 Thread Daniel Schwierzeck
2013/1/6 Gabor Juhos : > The '## Transferring control ...' message is printed > only if DEBUG is enabled. Get rid of the 'ifdef DEBUG' > statement and use the debug macro instead. > > Signed-off-by: Gabor Juhos > --- > arch/mips/lib/bootm.c |4 +--- > 1 file changed, 1 insertion(+), 3 deletio

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Wolfgang Denk
Dear Lukasz & Simon, In message Simon Glass wrote: > > >> > - dst = malloc(CONFIG_SYS_VIDEO_LOGO_MAX_SIZE); > >> > + dst = memalign(CONFIG_SYS_CACHELINE_SIZE, len); > >> > >> Why do you need to align this one? It is just returned to the caller, > >> isn't it? > > > > Yes, it is retur

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Simon Glass
Hi Wolfgang, On Sun, Jan 6, 2013 at 12:21 PM, Wolfgang Denk wrote: > Dear Lukasz & Simon, > > In message > > Simon Glass wrote: >> >> >> > - dst = malloc(CONFIG_SYS_VIDEO_LOGO_MAX_SIZE); >> >> > + dst = memalign(CONFIG_SYS_CACHELINE_SIZE, len); >> >> >> >> Why do you need to align th

Re: [U-Boot] [PATCH v4 3/4] dtc/libfdt: introduce fdt types for annotation by endian checkers

2013-01-06 Thread Jon Loeliger
> Projects such as linux and u-boot run sparse on libfdt. libfdt > contains the notion of endianness via usage of endian conversion > functions such as fdt32_to_cpu. As such, in order to pass endian > checks, libfdt has to annotate its fdt variables such that sparse > can warn when mixing bitwise

Re: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

2013-01-06 Thread Jeroen Hofstee
On 01/05/2013 08:50 PM, Wolfgang Denk wrote: Dear Anatolij, In message <1357415148-9243-1-git-send-email...@denx.de> you wrote: lcd_color_fg and lcd_color_bg had to be declared in board specific code, but were not actually used there; in addition, we have getter / setter functions for these, wh

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Anatolij Gustschin
Hi Simon, Lukasz, On Sun, 6 Jan 2013 07:47:58 -0800 Simon Glass wrote: ... > >> > diff --git a/common/cmd_bmp.c b/common/cmd_bmp.c > >> > index 5a52edd..57f3eb5 100644 > >> > --- a/common/cmd_bmp.c > >> > +++ b/common/cmd_bmp.c > >> > @@ -55,7 +55,7 @@ bmp_image_t *gunzip_bmp(unsigned long addr,

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Anatolij Gustschin
Hello Wolfgang, On Sun, 06 Jan 2013 21:21:00 +0100 Wolfgang Denk wrote: ... > > OK, so it is directly used as a frame buffer? In that case it looks > > right to me. I doubt you want to be able to control the cache features > > for this area, since you only write it once. But if you did, then the

Re: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

2013-01-06 Thread Anatolij Gustschin
Hello Wolfgang, On Sat, 05 Jan 2013 20:50:01 +0100 Wolfgang Denk wrote: > Dear Anatolij, > > In message <1357415148-9243-1-git-send-email...@denx.de> you wrote: > > lcd_color_fg and lcd_color_bg had to be declared in board specific > > code, but were not actually used there; in addition, we hav

Re: [U-Boot] [PATCH RESEND] video:cache:fix: Buffer alignment and dcache flush for lcd subsystem

2013-01-06 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > I don't think this is as it should be. Any frame buffer that actually > > gets used as such should be located in the memory area specifically > > allocated for this purpose using lcd_setmem(). This is especially > > important when you load a splash scre

Re: [U-Boot] [PATCH 1/2] arm: rmobile: kzm9g: Adjust SDRAM setting

2013-01-06 Thread Nobuhiro Iwamatsu
Hi, Albert. Could you pick-up this patch to your repository? Best regards, Nobuhiro On Thu, Nov 22, 2012 at 7:47 AM, Nobuhiro Iwamatsu wrote: > On Wed, Nov 21, 2012 at 11:29 AM, Tetsuyuki Kobayashi > wrote: >> After stress test, I found some of kzm9g board occures memory failure. >> This pa

Re: [U-Boot] [PATCH 2/2] arm: rmobile: kzm9g: Adjust ETM trace clock

2013-01-06 Thread Nobuhiro Iwamatsu
Hi, Albert. Could you pick-up this patch to your repository? Best regards, Nobuhiro On Thu, Nov 22, 2012 at 7:47 AM, Nobuhiro Iwamatsu wrote: > On Wed, Nov 21, 2012 at 11:29 AM, Tetsuyuki Kobayashi > wrote: >> Set ETM TRCLK down to 78MHz to get clear wave form. >> This patch makes differenc

Re: [U-Boot] [PATCH] arm:exynos4:pinmux: Modify the gpio function for mmc

2013-01-06 Thread Jaehoon Chung
Hi Lukasz, I understood your opinion..it's ok. After applied this patch, i will update the pinmux for MMC4. Best Regards, Jaehoon Chung On 01/04/2013 04:59 PM, Lukasz Majewski wrote: > Hi Jaehoon, > >> On 01/03/2013 04:31 PM, Piotr Wilczek wrote: >>> This patch add pinmux settings for Exynos4 f

Re: [U-Boot] [PATCH V4 7/9] MMC: APIs to support resize of EMMC boot partition

2013-01-06 Thread Amarendra Reddy
Hi Jaehoon, Yes, the functions mmc_boot_partiton_size_change(), mmc_boot_open() & mmc_boot_close() can be used by any vendor to open/close/resize-boot-partition of emmc device. The above 3 functions call the static function "static int mmc_send_cmd(...)" located in drivers/mmc/mmc.c. Any vendor ca

Re: [U-Boot] [PATCH V4 7/9] MMC: APIs to support resize of EMMC boot partition

2013-01-06 Thread Jaehoon Chung
Hi Amar, If you want to access the boot partition, Need to add open/close()? I think we can use like "mmc_boot_part_access(struct mmc *mmc, int ack, int part_num, int access)" How about this? i think it is more generic... On 01/07/2013 01:19 PM, Amarendra Reddy wrote: > Hi Jaehoon, > > Yes, the

Re: [U-Boot] [PATCH V4 7/9] MMC: APIs to support resize of EMMC boot partition

2013-01-06 Thread Amarendra Reddy
Hi Jaehoon, The sequence to be followed to access(read/write) boot partitions is i) open() the boot partition, ii) Do the job , iii) Then close() boot partition. I understand that 1) You want a single generic function "mmc_boot_part_access(struct mmc *mmc, int ack, int part_num, int access)" to