[U-Boot] [PATCH] Fix M548x gcc 4.1.x detection

2010-08-13 Thread Groleo Marius
Fix the M548x falback to -m5407 arch when gcc 4.1.x is detected. Signed-off-by: Marius Groleo --- arch/m68k/cpu/mcf547x_8x/config.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/m68k/cpu/mcf547x_8x/config.mk b/arch/m68k/cpu/mcf547x_8x/config.mk index 83102ab..9c

Re: [U-Boot] Please pull u-boot-cfi-flash/master

2010-08-13 Thread Stefan Roese
Hi Wolfgang, On Thursday 12 August 2010 23:04:55 Wolfgang Denk wrote: > > Kim Phillips (1): > > cfi_flash: flinfo: allow user interrupt in flash print info fn > > Sorry, this patch got a NAK from me. The code needs fixing (actually > the existing code should be fixed first, then Kim can add

[U-Boot] [PATCH] S5P: Use accessor functions instead of SoC specific defines to access the base address

2010-08-13 Thread Minkyu Kang
This patch is intended to prepare the other S5P SoC. (s5pc210) If use SoC specific defines then can't share with other SoC. So, make the accessor functions for access the base address by common way. Signed-off-by: Minkyu Kang Signed-off-by: Kyungmin Park --- arch/arm/cpu/armv7/s5pc1xx/clock.c

Re: [U-Boot] [PATCH] UEC PHY: Speed up initial PHY neg.

2010-08-13 Thread Detlev Zundel
Hi Jocke, >> > Instead of always performing an autoneg, check if the PHY >> > already has a link and if it matches one of the requested >> > modes. Initially only 100MbFD is optimized this way. >> >> Isn't it about time that we think about _not_ stopping the ethernet >> device after every transact

Re: [U-Boot] [PATCH v2] TI: DaVinci DA850 EVM: support passing device speed grade information to kernel

2010-08-13 Thread Detlev Zundel
Hi Nori, >> > The TI DA850/OMAP-L138/AM18x EVM can be populated with devices >> > of different speed grades. >> > >> > The maximum speed the chip can support can only be determined from >> > the label on the package (not software readable). >> > >> > Introduce a method to pass the speed grade info

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Vitaly Kuzmichev
Hi Remy, No, it does not. DEBUG is defined as dev_err and dev_err is defined as printf. Anyway I can change it. On 08/12/2010 10:33 PM, Remy Bohmer wrote: >> @@ -37,8 +37,10 @@ >> #define dev_err(x, stuff...) printf(stuff) >> #define dev_dbg dev_err >> #define dev_warn dev_err >> -#define DEBU

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev : > Hi Remy, > > No, it does not. > DEBUG is defined as dev_err and dev_err is defined as printf. > Anyway I can change it. Please do not top-post! > On 08/12/2010 10:33 PM, Remy Bohmer wrote: >>> @@ -37,8 +37,10 @@ >>>  #define dev_err(x, stuff...) printf(stuff) >

Re: [U-Boot] [PATCH 0/8] USB: gadget: fix porting bugs

2010-08-13 Thread Vitaly Kuzmichev
Hi Remy, On 08/12/2010 10:37 PM, Remy Bohmer wrote: > Hi, > >> 2) Add lost 'qmult' definition for High Speed devices > > Stefano, which version of this fix do you prefer? It seems there are > now 2 patches fixing the same thing... > If I were you I would take my patch for 2 reasons: 1) more ac

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Stefano Babic
Vitaly Kuzmichev wrote: > Take debug printout macros back from linux-2.6.27 and make them more > useful and more compatible. > > Signed-off-by: Vitaly Kuzmichev > --- > drivers/usb/gadget/ether.c | 65 > +++- > 1 files changed, 34 insertions(+), 31 dele

Re: [U-Boot] [PATCH 0/8] USB: gadget: fix porting bugs

2010-08-13 Thread Stefano Babic
Vitaly Kuzmichev wrote: > If I were you I would take my patch for 2 reasons: > 1) more accurate comment (this is not OTG-related) > 2) it is configurable as it was in the kernel > > As alternative way I can add Stefano's signature in the patch. I like > this idea :) > What do you think, Stefano? >

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Remy Bohmer
Hi, > 3. I did not follow the whole USB patches, my concern is > what touches AT91, but please explain to me what for we need > a board under u-boot to be a USB device. Since u-boot per se > is not multitasking how is the traffic handled while > at the command prompt? There is no traffic handled

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Remy Bohmer
Hi Wolfgang, 2010/8/12 Wolfgang Denk : > Dear Remy Bohmer, > > In message you > wrote: >> >> > Use struct access for SoC registers. Offset adressing is depreciated. See >> > the >> > struct in my at91_dbgu.h. Use readl/writel to access the hardware. >> >> Most of the code is copied from Linux. D

Re: [U-Boot] [PATCH] USB-CDC: wrong ep status used

2010-08-13 Thread Vitaly Kuzmichev
Hi Sergei, On 08/12/2010 09:05 PM, Sergei Shtylyov wrote: > Hello. > > Stefano Babic wrote: > >>> We get oops here! > >> Agree, and the issue is not related to this patch, I missed to correct >> it, thanks. If no one complains, I will send a single patch to fix both >> problems (wrong ep status

Re: [U-Boot] [PATCH] USB-CDC: wrong ep status used

2010-08-13 Thread Stefano Babic
Vitaly Kuzmichev wrote: > Hi Sergei, > > On 08/12/2010 09:05 PM, Sergei Shtylyov wrote: >> Hello. >> >> Stefano Babic wrote: >> We get oops here! >>> Agree, and the issue is not related to this patch, I missed to correct >>> it, thanks. If no one complains, I will send a single patch to fix b

Re: [U-Boot] [PATCH v2] TI: DaVinci DA850 EVM: support passing device speed grade information to kernel

2010-08-13 Thread Nori, Sekhar
Hi Detlev, On Fri, Aug 13, 2010 at 14:00:21, Detlev Zundel wrote: > > A revision for me is attached to certain bugs/problems which we may need > to work around in software. Think about something like "we can enable > caching only on rev2 CPUs". For all I know, the ATAG_REVISION tag seems > to c

Re: [U-Boot] [PATCH 1/2] mmc: omap3: make local symbols static

2010-08-13 Thread Grazvydas Ignotas
>> Unfortunately the patches didn't apply cleanly, but the fixes were >> simple.  I have the modified patches in the omap4-next-upstream branch >> of my repo for convenience: >> >> http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u- >> boot.git;a=shortlog;h=refs/heads/omap4-next-upstream >> >> Regards,

Re: [U-Boot] [PATCH 00/26] arm: add full relocation / cache support

2010-08-13 Thread Wolfgang Denk
Dear Magnus Lilja, In message <4c645e51.6020...@gmail.com> you wrote: > Dear Wolfgang Denk, > > > The plan is as follows: > > > > I will pull this stuff into the "next" branch about one week after I > > released "rc1". I intend to keep this "CONFIG_SYS_ARM_WITHOUT_RELOC" > > feature for a full r

Re: [U-Boot] [PATCH] OMAP3: remove unused config macros

2010-08-13 Thread Grazvydas Ignotas
Another ping for this old patch.. This still applies cleanly, and I have verified those macros are unused by those boards. There were no objections so far, and Steve ACKed it. On Wed, Jun 9, 2010 at 12:30 AM, Paulraj, Sandeep wrote: >> Just a ping. >> Sandeep, maybe you could pick this? Those def

Re: [U-Boot] Please pull u-boot-cfi-flash/master

2010-08-13 Thread Wolfgang Denk
Dear Stefan Roese, In message <201008130936.19599...@denx.de> you wrote: > > On Thursday 12 August 2010 23:04:55 Wolfgang Denk wrote: > > > Kim Phillips (1): > > > cfi_flash: flinfo: allow user interrupt in flash print info fn > > > > Sorry, this patch got a NAK from me. The code needs fix

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Wolfgang Denk
Dear Remy Bohmer, In message you wrote: > > >>> +#define WARN INFO > >>> +#define ERROR INFO > >>> +#define DEBUG INFO > >> > >> This switches DEBUG logging on by default. This is not wanted. > >> Can you please change that? > > > No, it does not. > > Well, I see with this patch much more deb

Re: [U-Boot] [PATCH v2a] AT91: add SD/MMC support

2010-08-13 Thread asc0
Hello! I have successfully applied your patch on a AT91SAM9G20 cpu and it reads the correct CID & CSD info. At the end of initialization the bread function fails with the following error: mmc: bread failed, status = 0040c0e5, card status = 0900 Does someone else received this error or have a

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Vitaly Kuzmichev
Hi Sergei, Sergei Shtylyov wrote: >> -printf ("enable %s --> %d\n", >> +DEBUG(dev, "enable %s --> %d\n", > > Well, I think the coding style shouldbe consistent -- you either leave > the space before ( or remove it. And as U-Boot seems to follow the Linux > coding style n

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Wolfgang Denk
Dear Remy Bohmer, In message you wrote: > > > There are so many lines changed already in the code that claoming > > "This file is copied from Linux." does not make much sense any more. > > Well, it is derived from 2.6.27, not latest git. > True, there are differences, but mostly it is a strip

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-13 Thread Sergei Shtylyov
Hello. Remy Bohmer wrote: >>> Mike Frysinger wrote: --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c } else { - if (!toggle) - writew(MUSB_RXCSR_CLRDATATOG, &musbr->rxcsr); - else { +

Re: [U-Boot] [PATCH v2] TI: DaVinci DA850 EVM: support passing device speed grade information to kernel

2010-08-13 Thread Detlev Zundel
Hi Nori, >> A revision for me is attached to certain bugs/problems which we may need >> to work around in software. Think about something like "we can enable >> caching only on rev2 CPUs". For all I know, the ATAG_REVISION tag seems >> to capture this aspect. > > We will most likely end up using

[U-Boot] [PATCH] cfi_flash: Cleanup flash_print_info()

2010-08-13 Thread Stefan Roese
This patch does the following: - Extract code to detect if sector is erased into function sector_erased(). - Because of this, we don't have variable declarations inside the sector loop in flash_print_info() - Change "return" to "break" in the "if (ctrlc()) statement: This fixes a problem wit

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: >>> -printf ("enable %s --> %d\n", >>> +DEBUG(dev, "enable %s --> %d\n", >> Well, I think the coding style shouldbe consistent -- you either leave >> the space before ( or remove it. And as U-Boot seems to follow the Linux >> coding style

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Reinhard Meyer
Dear Remy Bohmer, >> 3. I did not follow the whole USB patches, my concern is >> what touches AT91, but please explain to me what for we need >> a board under u-boot to be a USB device. Since u-boot per se >> is not multitasking how is the traffic handled while >> at the command prompt? > > There

Re: [U-Boot] [PATCH v2 2/3] avr32: Use uncached() macro to get an address for SDRAM init

2010-08-13 Thread Detlev Zundel
Hi Haavard, > Detlev Zundel wrote: >> So this patch replaces a construct which seems to be valid over all >> architectures by a construct which is only used in avr32, right? It >> also deletes the explicit statement that such a mapping is not needed >> any further. > > Problem is that in order t

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Reinhard Meyer : > Dear Remy Bohmer, >>> >>> 3. I did not follow the whole USB patches, my concern is >>> what touches AT91, but please explain to me what for we need >>> a board under u-boot to be a USB device. Since u-boot per se >>> is not multitasking how is the traffic handled w

Re: [U-Boot] [PATCH v2a] AT91: add SD/MMC support

2010-08-13 Thread Reinhard Meyer
asc0 wrote: > Hello! I have successfully applied your patch on a AT91SAM9G20 cpu and it > reads the correct CID & CSD info. > At the end of initialization the bread function fails with the following > error: > > mmc: bread failed, status = 0040c0e5, card status = 0900 > > Does someone else re

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Remy Bohmer
Hi Wolfgang, 2010/8/13 Wolfgang Denk : > Dear Remy Bohmer, > > Well, if your argument is true that the current code can easily be > kept in sync with Linux, then why is it already 8 kernel releases old? Because it lives already for a real long time in the u-boot-usb tree with no requests on the M

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Remy Bohmer
Hi, > DEBUG is already a well-defined name. Any different use of the same > name will result in the patches being rejected. > > Please fix this! > > I also object against names like WARN, ERROR and INFO. They are just > too dangerous. Agree. Remy ___ U

Re: [U-Boot] [PATCH] Fix typo inside atmel_mci driver

2010-08-13 Thread Claudio Mignanti
2010/8/7 Reinhard Meyer : > Wolfgang Denk wrote: >> >> Dear Claudio Mignanti, >> >> In message >> you wrote: >> >>> >>> The function get_mci_clk_rate is used inside atmel_mci driver >>>  but never defined. Fix this typo. >>> > > Thats NOT a typo. The current atmel_mci.c is for AVR32 ONLY. >> Wit

Re: [U-Boot] [PATCH v2a] AT91: add SD/MMC support

2010-08-13 Thread Schleifer, Alexander
Thanks for your reply... The CID part is: mmc: response: 1a50514d 53202020 1018301a ec007b8b Manufacturer ID: 1A OEM/Application ID:5051 Product name: MS Product Revision: 1.0 Product Serial Number: 405805804 Manufacturing Date:07/11 The CSD part is: mmc: response: 005

Re: [U-Boot] [PATCH v2 2/3] avr32: Use uncached() macro to get an address for SDRAM init

2010-08-13 Thread Haavard Skinnemoen
Detlev Zundel wrote: > > Problem is that in order to make the CFI driver work on avr32, we need > > to change the map_physmem() macro to return the physical address > > unchanged. > > I see. And I presume you cannot tell the situation apart inside > map_physmem? I don't think so. How do you pro

[U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Vitaly Kuzmichev
Replace Linux-like debug printout macros by native ones. Signed-off-by: Vitaly Kuzmichev --- drivers/usb/gadget/ether.c | 99 --- 1 files changed, 46 insertions(+), 53 deletions(-) diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c ind

Re: [U-Boot] [PATCH v2 2/3] avr32: Use uncached() macro to get an address for SDRAM init

2010-08-13 Thread Detlev Zundel
Hi Haavard, > Detlev Zundel wrote: >> > Problem is that in order to make the CFI driver work on avr32, we need >> > to change the map_physmem() macro to return the physical address >> > unchanged. >> >> I see. And I presume you cannot tell the situation apart inside >> map_physmem? > > I don't

[U-Boot] [PATCH v2 4/8] USB-CDC: Correct freeing usb requests

2010-08-13 Thread Vitaly Kuzmichev
Fix in_ep and out_ep confusion (rx_req was allocated from out_ep, not from in_ep) and add lost dev->req freeing. Signed-off-by: Vitaly Kuzmichev --- drivers/usb/gadget/ether.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/ether.c b/drivers/us

[U-Boot] [PATCH v2 5/8] USB-CDC: Replace 'strcpy' by 'strlcpy'

2010-08-13 Thread Vitaly Kuzmichev
Replace 'strcpy' by more safe 'strlcpy' that is implemented in ether.c Signed-off-by: Vitaly Kuzmichev --- drivers/usb/gadget/ether.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c index 19a63de..65f3ff9 10064

[U-Boot] [PATCH v2 6/8] USB-CDC: Correct stat_req initialization

2010-08-13 Thread Vitaly Kuzmichev
Fix possible oops on stat_req->buf initialization and fix ep0 and status_ep confusion (last one is just intended for stat_req keeping). Signed-off-by: Vitaly Kuzmichev Signed-off-by: Stefano Babic --- drivers/usb/gadget/ether.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) d

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Rogan Dawes
On 2010/08/13 2:57 PM, Vitaly Kuzmichev wrote: > Replace Linux-like debug printout macros by native ones. > > Signed-off-by: Vitaly Kuzmichev > --- > drivers/usb/gadget/ether.c | 99 > --- > 1 files changed, 46 insertions(+), 53 deletions(-) > > diff --

[U-Boot] [PATCH v2 7/8] USB-CDC: ethernet error path potential oops fix

2010-08-13 Thread Vitaly Kuzmichev
Fix potential oops on rare error path. The patch is based on commit e7b13ec9235b9fded90f826ceeb8c34548631351 (done by David Brownell ) from linux-2.6.git. Description of the issue taken from linux kernel bugzilla: (https://bugzilla.kernel.org/show_bug.cgi?id=9594) The potential error can be track

[U-Boot] [PATCH v2 8/8] USB-CDC: change simple_strtol to simple_strtoul

2010-08-13 Thread Vitaly Kuzmichev
The patch is based on commit bb9496c6f7e853e5d4edd5397c9d45f1968d623c (done by Julia Lawall ) from linux-2.6.git. Since num is unsigned, it would seem better to use simple_strtoul that simple_strtol. Signed-off-by: Vitaly Kuzmichev --- drivers/usb/gadget/epautoconf.c |2 +- 1 files changed,

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Vitaly Kuzmichev
Hi, Rogan Dawes wrote: >> +#define DEBUG >> +#undef DEBUG >> + > > Eh? Such thing is used to let someone know that this driver supports debug output through native U-Boot macros. So one need to comment #undef to compile ether.c with debug messages. There are at least 67 files in U-Boot that use

[U-Boot] [PATCH] [TESTING] da8xx: fixup ARM relocation support

2010-08-13 Thread Ben Gardiner
Split the existing dram_init for da8xx when ARM reloc is enabled, like the changes to arch/arm/cpu/arm926ejs/orion5x/dram.c in 0f234d263b17ccf1b8fd776eb8c15b7cdb27a887 by Heiko Schocher . Without these changes gd->ram_size is '0' which leads to incorrect relocation when CONFIG_SYS_ARM_WITHOUT_RELO

Re: [U-Boot] [PATCH] UEC PHY: Speed up initial PHY neg.

2010-08-13 Thread Joakim Tjernlund
Detlev Zundel wrote on 2010/08/13 10:20:46: > > Hi Jocke, > > >> > Instead of always performing an autoneg, check if the PHY > >> > already has a link and if it matches one of the requested > >> > modes. Initially only 100MbFD is optimized this way. > >> > >> Isn't it about time that we think abou

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Vitaly Kuzmichev
Vitaly Kuzmichev wrote: > There are at least 67 files in U-Boot that use such construction. I was wrong. I calculated for "linux/drivers" directory. Actually 13 for u-boot. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinf

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Stefano Babic
Vitaly Kuzmichev wrote: > Hi, > > Rogan Dawes wrote: >>> +#define DEBUG >>> +#undef DEBUG >>> + >> Eh? > > Such thing is used to let someone know that this driver supports debug > output through native U-Boot macros. So one need to comment #undef to > compile ether.c with debug messages. > There

[U-Boot] [PATCH v2] [TESTING] da8xx: fixup ARM relocation support

2010-08-13 Thread Ben Gardiner
Split the existing dram_init for da8xx when ARM reloc is enabled, like the changes to arch/arm/cpu/arm926ejs/orion5x/dram.c in 0f234d263b17ccf1b8fd776eb8c15b7cdb27a887 by Heiko Schocher . Without these changes gd->ram_size is '0' which leads to incorrect relocation when CONFIG_SYS_ARM_WITHOUT_RELO

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Vitaly Kuzmichev
Hi Stefano, Stefano Babic wrote: > If you want to remember how to set the debug output, it should be enough > to add a comments with "to enable the debugging, define DEBUG before > common.h" or something like that. I vote to remove only the two lines... Would not it be better to make one of the f

Re: [U-Boot] mirror u-boot on github

2010-08-13 Thread Ben Gardiner
On Thu, Aug 12, 2010 at 4:06 PM, Wolfgang Denk wrote: > [...] certainly not going to do it. Their ToS are not acceptable to me. > > For example: "E2. Prices of all Services, including but not limited > to monthly subscription plan fees to the Service, are subject to > change upon 30 days notice fr

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Rogan Dawes
On 2010/08/13 3:40 PM, Vitaly Kuzmichev wrote: > Hi Stefano, > > Stefano Babic wrote: >> If you want to remember how to set the debug output, it should be enough >> to add a comments with "to enable the debugging, define DEBUG before >> common.h" or something like that. I vote to remove only the tw

[U-Boot] NetConsole and network API

2010-08-13 Thread Stefano Babic
Hi all, I have seen an issue using netconsole and I am asking myself if there is a problem in the actual concept of a network interface in u-boot. I admit soon I have not used a "normal" network controller, but I ran NetConsole on Ethernet over USB. However, I have checked with other network driv

Re: [U-Boot] [PATCH 2/3] Connect the AT91 UDC to USB CDC-ethernet support

2010-08-13 Thread Wolfgang Denk
Dear Remy Bohmer, In message you wrote: > > >> > So broken that you cannot get back to the command line interpreter? > >> > Really? > >> > >> If malloc is broken, I consider that reason enough for hang/reboot... > > > > That's not a good idea. =A0Please fix. > > Fix what? > If runtime a condit

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Wolfgang Denk
Dear Vitaly Kuzmichev, In message <1281704276-29115-1-git-send-email-vkuzmic...@mvista.com> you wrote: > Replace Linux-like debug printout macros by native ones. > > Signed-off-by: Vitaly Kuzmichev > --- > drivers/usb/gadget/ether.c | 99 --- > 1 files

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Wolfgang Denk
Dear Vitaly Kuzmichev, In message <4c6544b9.3000...@mvista.com> you wrote: > > >> +#define DEBUG > >> +#undef DEBUG > >> + > > > > Eh? > > Such thing is used to let someone know that this driver supports debug > output through native U-Boot macros. So one need to comment #undef to > compile eth

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Wolfgang Denk
Dear Vitaly Kuzmichev, In message <4c654b30.9060...@mvista.com> you wrote: > Hi Stefano, > > Stefano Babic wrote: > > If you want to remember how to set the debug output, it should be enough > > to add a comments with "to enable the debugging, define DEBUG before > > common.h" or something like t

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Stefano Babic
Vitaly Kuzmichev wrote: > Hi Stefano, > Hi Vitaly, > Stefano Babic wrote: >> If you want to remember how to set the debug output, it should be enough >> to add a comments with "to enable the debugging, define DEBUG before >> common.h" or something like that. I vote to remove only the two lines...

Re: [U-Boot] [PATCH 00/26] arm: add full relocation / cache support

2010-08-13 Thread Shinya Kuribayashi
On 8/13/10 5:17 AM, Wolfgang Denk wrote: >> http://elinux.org/CELF_Project_Proposal/Rework_ARM_architecture_support_in_U-Boot > > Yes, this is the one. [snip[ > If you read the thread you can see that both Heikos tests and other > testers who tried that code see dramatic speed improvements due to >

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: > Rogan Dawes wrote: >>> +#define DEBUG >>> +#undef DEBUG >>> + >> Eh? > Such thing is used to let someone know that this driver supports debug > output through native U-Boot macros. So one need to comment #undef to > compile ether.c with debug messages. > There

[U-Boot] [PATCH] MX51: Update responsible for mx51evk

2010-08-13 Thread Stefano Babic
Signed-off-by: Stefano Babic --- MAINTAINERS |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4b91b0f..6699393 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -152,10 +152,6 @@ Dave Ellis SXNI855TMPC8xx -Fred Fan - -

[U-Boot] [RFC][PATCH 1/3] DDR2: Support new JEDEC DDR2 SPD 1.3 spec

2010-08-13 Thread Kyle Moffett
The new DDR2 SPD spec is backwards-compatible with the old one, but there are DIMMs which are being produced which have new SPD version fields that fail to work with U-boot. To make the code a bit more readable, we add some human-readable SPD_DIMM_TYPE_* constants. Signed-off-by: Kyle Moffett --

[U-Boot] [RFC] Board support patches for the eXMeritus HWW-1U-1A devices

2010-08-13 Thread Kyle Moffett
Hello all! This is my first U-Boot submission, so my apologies if there are any coding style or conventions issues. Please let me know and I'll get them fixed up shortly. In addition, these patches were based on v2010.03 and I realize that the upstream may have diverged a bit since then. Please

[U-Boot] [RFC][PATCH 2/3] e1000: Intel 82571EB: Don't wait for MNG cycle on unmanaged chips

2010-08-13 Thread Kyle Moffett
The Intel 82571EB chipset can be used in an unmanaged configuration as a fast dual-port Gig-E controller. Unfortunately a board consturcted that way would fail to correctly come up because the driver polls for the completion of a management cycle that will never occur. To resolve this problem, we

Re: [U-Boot] [PATCH] Fix typo inside atmel_mci driver

2010-08-13 Thread Reinhard Meyer
Claudio Mignanti wrote: > 2010/8/7 Reinhard Meyer : >> Wolfgang Denk wrote: >>> Dear Claudio Mignanti, >>> >>> In message >>> you wrote: >>> The function get_mci_clk_rate is used inside atmel_mci driver but never defined. Fix this typo. >> Thats NOT a typo. The current atmel_mci.c

Re: [U-Boot] [PATCH v2a] AT91: add SD/MMC support

2010-08-13 Thread Reinhard Meyer
Dear Schleifer, Alexander, > Thanks for your reply... > > The CID part is: > mmc: response: 1a50514d 53202020 1018301a ec007b8b > Manufacturer ID: 1A > OEM/Application ID:5051 > Product name: MS > Product Revision: 1.0 > Product Serial Number: 405805804 > Manufacturing Date

Re: [U-Boot] [PATCH] env_nand: return error when no device is found

2010-08-13 Thread Scott Wood
On Wed, Aug 11, 2010 at 11:42:26PM -0400, Mike Frysinger wrote: > Currently, if there is an error probing the NAND chip and the env is based > in NAND, the readenv() function will use a NULL function pointer and thus > jump to address 0. > > Here I just check for a non-zero value of blocksize as t

Re: [U-Boot] NetConsole and network API

2010-08-13 Thread Joe Hershberger
On Fri, Aug 13, 2010 at 8:52 AM, Stefano Babic wrote: > My main question to the ML is, independently from the particular problem > on my target, if we should change the actual concept. For example, if we > provide to stop all devices only before booting an OS, but leaving them > alive after the fi

Re: [U-Boot] [PATCH 1/8] USB-CDC: Restuct USB gadget Makefile

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/12 Vitaly Kuzmichev : > Prohibit simultaneous usage of both old and new gadget stacks and > allow UDC drivers to be dependent on CONFIG_USB_ETHER. > > Signed-off-by: Vitaly Kuzmichev > --- >  drivers/usb/gadget/Makefile |    9 ++--- >  1 files changed, 6 insertions(+), 3 deletions(

Re: [U-Boot] TFTP timeout issue while downloading the linux kernel in openpxa vpac270 u-boot source code

2010-08-13 Thread Marek Vasut
Dne Pá 13. srpna 2010 12:27:12 StephenPaulraj Chinnadurai-ERS,HCLTech napsal(a): > Dear Marek, > YOU DROPPED THE MAILING LIST AGAIN !! HOW MANY TIMES DO I HAVE TO TELL YOU TO KEEP IT CCED ?! > Even if I assign 0x1234 to MSC2 I am getting the same timeout problem. Because 0x1234 is 16 bit bus ..

Re: [U-Boot] [PATCH 2/8] USB-CDC: Add lost 'qmult' definition

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/12 Vitaly Kuzmichev : > Add lost 'qmult' definition for High Speed devices and make it > configurable through CONFIG_USB_ETH_QMULT. > > Signed-off-by: Vitaly Kuzmichev > --- >  drivers/usb/gadget/ether.c |    6 ++ >  1 files changed, 6 insertions(+), 0 deletions(-) Applied to u-bo

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev : > Replace Linux-like debug printout macros by native ones. > > Signed-off-by: Vitaly Kuzmichev > --- >  drivers/usb/gadget/ether.c |   99 --- >  1 files changed, 46 insertions(+), 53 deletions(-) > > diff --git a/drivers/usb

Re: [U-Boot] [PATCH v2 5/8] USB-CDC: Replace 'strcpy' by 'strlcpy'

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev : > Replace 'strcpy' by more safe 'strlcpy' that is implemented in ether.c > > Signed-off-by: Vitaly Kuzmichev > --- >  drivers/usb/gadget/ether.c |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) > Applied to u-boot-usb/cdc branch. Thanks. Remy __

Re: [U-Boot] [PATCH v2 4/8] USB-CDC: Correct freeing usb requests

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev : > Fix in_ep and out_ep confusion (rx_req was allocated from out_ep, not > from in_ep) and add lost dev->req freeing. > > Signed-off-by: Vitaly Kuzmichev > --- >  drivers/usb/gadget/ether.c |    9 +++-- >  1 files changed, 7 insertions(+), 2 deletions(-) Appli

Re: [U-Boot] [PATCH v2 6/8] USB-CDC: Correct stat_req initialization

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev : > Fix possible oops on stat_req->buf initialization and fix ep0 and > status_ep confusion (last one is just intended for stat_req keeping). > > Signed-off-by: Vitaly Kuzmichev > Signed-off-by: Stefano Babic > --- >  drivers/usb/gadget/ether.c |    7 +++ >  1

Re: [U-Boot] [PATCH v2 8/8] USB-CDC: change simple_strtol to simple_strtoul

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev : > The patch is based on commit bb9496c6f7e853e5d4edd5397c9d45f1968d623c > (done by Julia Lawall ) from linux-2.6.git. > > Since num is unsigned, it would seem better to use simple_strtoul that > simple_strtol. > > Signed-off-by: Vitaly Kuzmichev > --- >  drivers/u

Re: [U-Boot] [PATCH v2 7/8] USB-CDC: ethernet error path potential oops fix

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Vitaly Kuzmichev : > Fix potential oops on rare error path. > The patch is based on commit e7b13ec9235b9fded90f826ceeb8c34548631351 > (done by David Brownell ) from linux-2.6.git. > > Description of the issue taken from linux kernel bugzilla: > (https://bugzilla.kernel.org/show_bug.c

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Wolfgang Denk
Dear Stefano Babic, In message <4c6557c5.4000...@denx.de> you wrote: > > It is ok, but it generates another new CONFIG_ switch, that is unusable > for the rest of u-boot. I agree that in u-boot there is a lot of > different and local functions to setup, and probably a general mechanism > should be

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Wolfgang Denk
Dear Sergei Shtylyov, In message <4c6558d4.9070...@mvista.com> you wrote: > > I'd suggest leaving just #undef DEBUG (which can be edited into #define > DEBUG if desired)... Don't you listen? Remove that, completely, please! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Wolfgang Denk
Dear Remy Bohmer, In message you wrote: > > > +#define DEBUG > > +#undef DEBUG > > Applied to u-boot-usb/cdc branch after removing ' #define DEBUG' as > Sergei suggested. NAK. Please also remove the dead and completely needless #undef DEBUG as well. Thanks. Wolfgang Denk -- DENX Software

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Remy Bohmer
Hi, 2010/8/13 Wolfgang Denk : > Dear Remy Bohmer, > > In message you > wrote: >> >> > +#define DEBUG >> > +#undef DEBUG >> >> Applied to u-boot-usb/cdc branch after removing ' #define DEBUG' as >> Sergei suggested. > > NAK. Please also remove the dead and completely needless #undef DEBUG > as we

Re: [U-Boot] handling of bad blocks in nand

2010-08-13 Thread Grant Edwards
On 2010-07-09, Scott Wood wrote: > On Fri, Jul 09, 2010 at 08:56:40AM -0400, Ben Gardiner wrote: > >> If you are putting an MTD filesystem in that partition then the >> filesystem itself will take care of bad blocks that might occur in >> the partition during runtime. During the flash programming

[U-Boot] [PATCH 02/7] ARMV7: OMAP: add convenience function to set TWL4030 regulator voltages

2010-08-13 Thread Steve Sakoman
This patch adds a function to allow one to easily set the target voltage for the TWL4030 regulators. It also modifies the existing code to use this new function. Applicable definitions are moved out of the driver file and into the header file so that they are generally accessible Signed-off-by:

[U-Boot] [PATCH 03/7] ARMV7: OMAP: Enable input driver on Overo's MMC1_CLK and MMC3_CLK pinmux setup

2010-08-13 Thread Steve Sakoman
This patch modifies the pinmux setup for MMC1_CLK and MMC3_CLK to enable the input driver. MMC2_CLK was already properly configured. Signed-off-by: Steve Sakoman --- board/overo/overo.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/board/overo/overo.h b/board/overo

[U-Boot] [PATCH 01/7] ARMV7: OMAP: Move syslib.c to omap-common since it can be shared by OMAP3 and OMAP4

2010-08-13 Thread Steve Sakoman
The functions in syslib.c can be shared, so this patch moves it from cpu/omap3 to cpu/omap-common Signed-off-by: Steve Sakoman --- arch/arm/cpu/armv7/omap-common/Makefile|2 ++ arch/arm/cpu/armv7/{omap3 => omap-common}/syslib.c |2 -- arch/arm/cpu/armv7/omap3/Makefile

[U-Boot] [PATCH 04/7] ARMV7: OMAP: Add mpurate boot arg for Overo and Beagle

2010-08-13 Thread Steve Sakoman
Allows one to set the processor clock rate via "setenv mpurate 720" for example Default is set to a "safe" 500 Mhz. Signed-off-by: Steve Sakoman --- include/configs/omap3_beagle.h |3 +++ include/configs/omap3_overo.h |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git

[U-Boot] [PATCH 05/7] ARMV7: OMAP: Add board revision detection for Overo

2010-08-13 Thread Steve Sakoman
The latest Overo COM modules encode their revision number on GPIOs 115, 113, and 112. All boards to date have no pullups on these pins and hence appear as revision 0. This patch reads and prints the revision information. Signed-off-by: Steve Sakoman --- board/overo/overo.c | 32 +

[U-Boot] [PATCH 06/7] ARMV7: OMAP: Add detection and support for Beagle C4 revision

2010-08-13 Thread Steve Sakoman
This patch enhances the revision detection function and adds support for the C4 revision. The board revision is printed and approriate revision specific setup is done automatically. Signed-off-by: Steve Sakoman --- board/ti/beagle/beagle.c | 90 +++---

[U-Boot] [PATCH 07/7] ARMV7: OMAP: Configure Overo's second network chip

2010-08-13 Thread Steve Sakoman
Confiures GPMC timings for both chips and also configures pinmux for GPIO_65, which is used as the interrupt signal for the second chip Signed-off-by: Scott Ellis Signed-off-by: Steve Sakoman --- board/overo/overo.c | 26 ++ board/overo/overo.h |2 +- 2 files chang

[U-Boot] [PATCH 00/7] ARMV7: OMAP3: Board updates for Beagle and Overo

2010-08-13 Thread Steve Sakoman
This series does a bit of OMAP housekeeping as well as adding board revision detection for Beagle and Overo. The first patch moves syslib.c from omap3 to omap-common where it can be shared by both OMAP3 and OMAP4 boards. The second patch creates a convenience function to set the voltage regulator

Re: [U-Boot] handling of bad blocks in nand

2010-08-13 Thread Grant Edwards
On 2010-08-13, Grant Edwards wrote: > On 2010-07-09, Scott Wood wrote: >> On Fri, Jul 09, 2010 at 08:56:40AM -0400, Ben Gardiner wrote: >> >>> If you are putting an MTD filesystem in that partition then the >>> filesystem itself will take care of bad blocks that might occur in >>> the partition d

Re: [U-Boot] UNS: [Nios2-dev] [PATCH] nios2: fix out of reach case for do_reset

2010-08-13 Thread Brad Parker
As a comment, that patch looks pretty ugly. I might suggest an inline function (called "callr" or "nios2_callr") which encapsulates the __asm__. That would make the code much easier to read. You could put the inline function in one of the asm headers. -brad Thomas Chou wrote: > The "Nios II

[U-Boot] [PATCH] Add mvsata support for the Sheevaplug devices

2010-08-13 Thread GEAK
Add mvsata support to SHEEVAPLUG Signed-off-by: Gérald Kerma --- include/configs/sheevaplug.h | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h index c5de86e..6a80c15 100644 --- a/

Re: [U-Boot] [PATCH] Add mvsata support for the Sheevaplug devices

2010-08-13 Thread Wolfgang Denk
Dear GEAK, In message <4c6635c1.2080...@gmail.com> you wrote: >Add mvsata support to SHEEVAPLUG ... > --- a/include/configs/sheevaplug.h > +++ b/include/configs/sheevaplug.h > @@ -98,6 +98,7 @@ > #define CONFIG_CMD_NAND > #define CONFIG_CMD_PING > #define CONFIG_CMD_USB > +#define CONFIG_CM

Re: [U-Boot] [PATCH v4] at91: Don't initialize watchdog if CONFIG_SKIP_WATCHDOG_INIT is defined

2010-08-13 Thread Mike Frysinger
On Mon, Aug 9, 2010 at 7:42 AM, Alexander Stein wrote: > Am Montag, 9. August 2010, 09:13:45 schrieb Mike Frysinger: >> > On AT91 the watchdog mode register can only be written once after reset. >> > If this register is written by u-boot e.g. a Linux driver can't >> > reconfigure the watchdog later