Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-27 Thread Stefano Babic
On 04/27/2011 04:57 PM, Detlev Zundel wrote: > I see. Can't we consolidate all those functions into more general > functions higher up in the specialization graph? As I can see, the get_cpu_rev() is already a generalized function, used in more processors. IMHO we should switch back to the usual p

Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-27 Thread Detlev Zundel
Hi Stefano, > On 04/27/2011 11:11 AM, Detlev Zundel wrote: > > This is due to the usage of the const in the mx3_cpu_type: >>> >>> struct mx3_cpu_type { >>> u8 srev; >>>const char *v; >>> >>> Do you agree if I drop myself the const attribute on u-boot-imx before >>> pulling your

Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-27 Thread Stefano Babic
On 04/27/2011 03:16 PM, Fabio Estevam wrote: Hi Fabio, > Will send a patch soon. Ok, thanks. Regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchen

Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-27 Thread Fabio Estevam
Hi Stefano, On 4/27/2011 6:40 AM, Stefano Babic wrote: ... >> but why not change get_cpu_rev to 'const char *' >> which it actually is? > > This is correct. However, I have not noted before that the last > introduced get_cpu_rev() in MX31 is an exception in u-boot. For all > other processors, it

Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-27 Thread Stefano Babic
On 04/27/2011 11:11 AM, Detlev Zundel wrote: This is due to the usage of the const in the mx3_cpu_type: >> >> struct mx3_cpu_type { >> u8 srev; >>const char *v; >> >> Do you agree if I drop myself the const attribute on u-boot-imx before >> pulling your patch to the arm tree ?

Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-27 Thread Detlev Zundel
Hi Stefano, > On 04/15/2011 08:07 PM, Stefano Babic wrote: >> On 04/12/2011 04:18 AM, Fabio Estevam wrote: >>> Use the same method of the Linux kernel to print the MX31 silicon version >>> on >>> boot. >>> >>> Tested on a MX31PDK with a 2.0 silicon, where it shows: >>> >>> CPU: Freescale i.MX3

Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-21 Thread Stefano Babic
On 04/15/2011 08:07 PM, Stefano Babic wrote: > On 04/12/2011 04:18 AM, Fabio Estevam wrote: >> Use the same method of the Linux kernel to print the MX31 silicon version on >> boot. >> >> Tested on a MX31PDK with a 2.0 silicon, where it shows: >> >> CPU: Freescale i.MX31 rev 2.0 at 531 MHz >> >>

Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-15 Thread Stefano Babic
On 04/12/2011 04:18 AM, Fabio Estevam wrote: > Use the same method of the Linux kernel to print the MX31 silicon version on > boot. > > Tested on a MX31PDK with a 2.0 silicon, where it shows: > > CPU: Freescale i.MX31 rev 2.0 at 531 MHz > > Signed-off-by: Fabio Estevam > Applied to u-boot-

Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-14 Thread stefano babic
Am 14/04/2011 13:14, schrieb Albert ARIBAUD: > > Seems this is ok. It is for me ok, too. > > Stefano, will you take this patch in and send a pull request, or do you > want me to pick it? I will take this patch and I wiil send you a pull request. Stefano -- =

Re: [U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

2011-04-14 Thread Albert ARIBAUD
Le 12/04/2011 04:18, Fabio Estevam a écrit : > Use the same method of the Linux kernel to print the MX31 silicon version on > boot. > > Tested on a MX31PDK with a 2.0 silicon, where it shows: > > CPU: Freescale i.MX31 rev 2.0 at 531 MHz > > Signed-off-by: Fabio Estevam > > --- > Changes since v4: