Re: [U-Boot] [PATCH v3] config.mk: fix -fstack-usage support test

2013-10-15 Thread Albert ARIBAUD
Hi Masahiro, > > Regarding the patch itself, why a shell script rather than a variant > > of cc-option? > > I chose a shell script because I wanted to keep Makefile cleaner > and this is the way Linux Kernel often uses. > > Please refer to > - scripts/gcc-goto.sh > - scripts/gcc-version.sh > e

Re: [U-Boot] [PATCH v3] config.mk: fix -fstack-usage support test

2013-10-15 Thread Masahiro Yamada
Hello Albert > Much better than the previous one (with a nitpick: superfluous "s" in > "This commits")... But now we lack the rationale part, which was > dropped rather than moved after the '---' line. I will add the rationale part in v4 along with s/commits/commit/. Thanks. > Regarding the p

Re: [U-Boot] [PATCH v3] config.mk: fix -fstack-usage support test

2013-10-15 Thread Albert ARIBAUD
Hi Masahiro, On Tue, 15 Oct 2013 19:11:26 +0900, Masahiro Yamada wrote: > If -fstack-usage option is given for such architecures > that do not support it, gcc displays a warning message > but still exits with status 0. > > This commits adds a new scripts to test -fstack-usage support > because