Hi Masahiro,
On Tue, 15 Oct 2013 19:11:26 +0900, Masahiro Yamada
<yamad...@jp.panasonic.com> wrote:
> If -fstack-usage option is given for such architecures
> that do not support it, gcc displays a warning message
> but still exits with status 0.
>
> This commits adds a new scripts to test -fstack-usage support
> because we cannot rely on $(call cc-option,...) .
Much better than the previous one (with a nitpick: superfluous "s" in
"This commits")... But now we lack the rationale part, which was
dropped rather than moved after the '---' line.
Regarding the patch itself, why a shell script rather than a variant
of cc-option?
> Signed-off-by: Masahiro Yamada <yamad...@jp.panasonic.com>
> Cc: Tom Rini <tr...@ti.com>
> Cc: Michal Simek <mon...@monstr.eu>
> Cc: Jeroen Hofstee <jer...@myspectrum.nl>
> Cc: Albert ARIBAUD <albert.u.b...@aribaud.net>
> ---
> config.mk | 5 +++--
> scripts/gcc-stack-usage.sh | 18 ++++++++++++++++++
> 2 files changed, 21 insertions(+), 2 deletions(-)
> create mode 100755 scripts/gcc-stack-usage.sh
>
> diff --git a/config.mk b/config.mk
> index 3441387..8a82ab4 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -279,8 +279,9 @@ CFLAGS_WARN := $(call cc-option,-Wno-format-nonliteral) \
> CFLAGS += $(CFLAGS_WARN)
>
> # Report stack usage if supported
> -CFLAGS_STACK := $(call cc-option,-fstack-usage)
> -CFLAGS += $(CFLAGS_STACK)
> +ifeq ($(shell $(SHELL) $(SRCTREE)/scripts/gcc-stack-usage.sh $(CC)), y)
> + CFLAGS += -fstack-usage
> +endif
>
> BCURDIR = $(subst $(SRCTREE)/,,$(CURDIR:$(obj)%=%))
>
> diff --git a/scripts/gcc-stack-usage.sh b/scripts/gcc-stack-usage.sh
> new file mode 100755
> index 0000000..53eb10a
> --- /dev/null
> +++ b/scripts/gcc-stack-usage.sh
> @@ -0,0 +1,18 @@
> +#!/bin/sh
> +# Test for gcc '-fstack-usage' support
> +# Copyright (C) 2013, Masahiro Yamada <yamad...@jp.panasonic.com>
> +#
> +# SPDX-License-Identifier: GPL-2.0+
> +#
> +
> +TMP=${OBJTREE}/"$$"
> +
> +cat << "END" | $@ -Werror -fstack-usage -x c - -c -o $TMP >/dev/null 2>&1 \
> + && echo "y"
> +int main(void)
> +{
> + return 0;
> +}
> +END
> +
> +rm -f $TMP $TMP.su
Amicalement,
--
Albert.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
