Re: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers

2012-08-17 Thread Stefano Babic
On 16/08/2012 23:25, Matt Sealey wrote: > On Thu, Aug 16, 2012 at 3:09 PM, Benoît Thébaudeau > wrote: >> Dear Matt Sealey, >> Hi Matt, >>> I'm gonna NACK this because most of these pin settings are actually >>> the POR defaults anyway (UART1 is >>> the example I can easily pick out). >>> >>> ..

Re: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers

2012-08-17 Thread Benoît Thébaudeau
Dear Matt Sealey, > On Thu, Aug 16, 2012 at 5:51 PM, Benoît Thébaudeau > wrote: > > Dear Matt Sealey, > > > >> On Thu, Aug 16, 2012 at 3:09 PM, Benoît Thébaudeau > >> wrote: > > > > To improve code quality... And because I have local boards that > > also needed the > > same functions, so it avoi

Re: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers

2012-08-17 Thread Matt Sealey
On Thu, Aug 16, 2012 at 5:51 PM, Benoît Thébaudeau wrote: > Dear Matt Sealey, > >> On Thu, Aug 16, 2012 at 3:09 PM, Benoît Thébaudeau >> wrote: > > To improve code quality... And because I have local boards that also needed > the > same functions, so it avoided more duplications. > >> For i.MX w

Re: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers

2012-08-16 Thread Benoît Thébaudeau
Dear Matt Sealey, > On Thu, Aug 16, 2012 at 3:09 PM, Benoît Thébaudeau > wrote: > > Dear Matt Sealey, > > > >> I'm gonna NACK this because most of these pin settings are > >> actually > >> the POR defaults anyway (UART1 is > >> the example I can easily pick out). > >> > >> .. unless someone's set

Re: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers

2012-08-16 Thread Matt Sealey
On Thu, Aug 16, 2012 at 3:09 PM, Benoît Thébaudeau wrote: > Dear Matt Sealey, > >> I'm gonna NACK this because most of these pin settings are actually >> the POR defaults anyway (UART1 is >> the example I can easily pick out). >> >> .. unless someone's setting them up wrong between warn reboots, o

Re: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers

2012-08-16 Thread Marek Vasut
Dear Matt Sealey, > I'm gonna NACK You can't, only the custodians can ... you can only disagree and provide your opinion, which you did ;-) > this because most of these pin settings are actually > the POR defaults anyway (UART1 is > the example I can easily pick out). > > .. unless someone's s

Re: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers

2012-08-16 Thread Benoît Thébaudeau
Dear Matt Sealey, > I'm gonna NACK this because most of these pin settings are actually > the POR defaults anyway (UART1 is > the example I can easily pick out). > > .. unless someone's setting them up wrong between warn reboots, or > changing a UART into something else > later in boot.. which is

Re: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers

2012-08-16 Thread Matt Sealey
I'm gonna NACK this because most of these pin settings are actually the POR defaults anyway (UART1 is the example I can easily pick out). .. unless someone's setting them up wrong between warn reboots, or changing a UART into something else later in boot.. which is unfathomable.. we don't need to

Re: [U-Boot] [PATCH 2/2] mx5: Use default pin initializers

2012-08-15 Thread Benoît Thébaudeau
> Use the newly created mx5 default pin initialization functions in mx5 > board > files. > > Signed-off-by: Benoît Thébaudeau > Cc: Stefano Babic Adding missing board maintainers to Cc. > --- > .../board/efikamx/efikamx.c| 133 > ++-- > .../board/free