Re: [U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

2009-07-17 Thread Kim Phillips
On Fri, 17 Jul 2009 16:54:40 +0200 André Schwarz wrote: > If there are no further objections I'll submit v3 adressing Heiko's > comments and fixing a warning due to missing #include statement. please do. > Both board binaries compile and work as expected. > > Sorry for the trouble - I'm not an

Re: [U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

2009-07-17 Thread André Schwarz
On Fri, 2009-07-17 at 16:44 +0200, Wolfgang Denk wrote: > Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz, > > In message <1247840636.3953.78.ca...@swa-m460> you wrote: > > > > > > +#define CONFIG_MISC_INIT_R > > > > > > So misc_init_r () gets called, but I didn;t find this in your > > > patch? May I miss

Re: [U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

2009-07-17 Thread Wolfgang Denk
Dear =?ISO-8859-1?Q?Andr=E9?= Schwarz, In message <1247840636.3953.78.ca...@swa-m460> you wrote: > > > > +#define CONFIG_MISC_INIT_R > > > > So misc_init_r () gets called, but I didn;t find this in your > > patch? May I miss something ... > > It's included in the other "common code" patch. You m

Re: [U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

2009-07-17 Thread André Schwarz
On Fri, 2009-07-17 at 16:32 +0200, Heiko Schocher wrote: > Hello André, > > André Schwarz wrote: > > Heiko, > > > > this patch is no longer valid since I already posted v2. > > Ah, ok. > > > But your comments are correct ... > > > > Will wait for WD's comments and send v3. > > OK, one more mi

Re: [U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

2009-07-17 Thread Heiko Schocher
Hello André, André Schwarz wrote: > Heiko, > > this patch is no longer valid since I already posted v2. Ah, ok. > But your comments are correct ... > > Will wait for WD's comments and send v3. OK, one more minor comment ... > On Fri, 2009-07-17 at 16:15 +0200, Heiko Schocher wrote: >> Hello

Re: [U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

2009-07-17 Thread André Schwarz
Heiko, this patch is no longer valid since I already posted v2. But your comments are correct ... Will wait for WD's comments and send v3. Regards, André On Fri, 2009-07-17 at 16:15 +0200, Heiko Schocher wrote: > Hello André, > > André Schwarz wrote: > > This patch fixes DDR-II settings and

Re: [U-Boot] [PATCH 1/2] update config for mvBL-M7 (MPC8343)

2009-07-17 Thread Heiko Schocher
Hello André, André Schwarz wrote: > This patch fixes DDR-II settings and adds I2C support. > > > Signed-off-by: André Schwarz > --- > > include/configs/MVBLM7.h | 48 > - > 1 files changed, 21 insertions(+), 27 deletions(-) > > diff --git a/inclu