Re: [U-Boot] [PATCH 06/20] iMX28: Add GPIO control

2011-11-10 Thread Marek Vasut
> On Thursday 10 November 2011 11:58:17 Marek Vasut wrote: > > > On Wednesday 09 November 2011 04:18:13 Marek Vasut wrote: > > > > +int gpio_request(int gp, const char *label) > > > > > > all of these gpio funcs should be "unsigned gpio" > > > > It's a problem of API then? > > > > include/asm/gp

Re: [U-Boot] [PATCH 06/20] iMX28: Add GPIO control

2011-11-10 Thread Mike Frysinger
On Thursday 10 November 2011 11:58:17 Marek Vasut wrote: > > On Wednesday 09 November 2011 04:18:13 Marek Vasut wrote: > > > +int gpio_request(int gp, const char *label) > > > > all of these gpio funcs should be "unsigned gpio" > > It's a problem of API then? > > include/asm/gpio.h:int gpio_requ

Re: [U-Boot] [PATCH 06/20] iMX28: Add GPIO control

2011-11-10 Thread Marek Vasut
> On Wednesday 09 November 2011 04:18:13 Marek Vasut wrote: > > +int gpio_request(int gp, const char *label) > > all of these gpio funcs should be "unsigned gpio" > -mike It's a problem of API then? include/asm/gpio.h:int gpio_request(int gp, const char *label); TBH, I can't imagine gpio number

Re: [U-Boot] [PATCH 06/20] iMX28: Add GPIO control

2011-11-10 Thread Mike Frysinger
On Wednesday 09 November 2011 04:18:13 Marek Vasut wrote: > +int gpio_request(int gp, const char *label) all of these gpio funcs should be "unsigned gpio" -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list

Re: [U-Boot] [PATCH 06/20] iMX28: Add GPIO control

2011-11-10 Thread Stefano Babic
On 11/09/2011 10:18 AM, Marek Vasut wrote: > Signed-off-by: Marek Vasut > Cc: Stefano Babic > Cc: Wolfgang Denk > Cc: Detlev Zundel > --- > arch/arm/cpu/arm926ejs/mx28/mx28.c|6 ++ > arch/arm/include/asm/arch-mx28/gpio.h | 32 > drivers/gpio/Makefile |1 +