Re: [U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

2011-08-31 Thread Kumar Gala
On Aug 31, 2011, at 3:37 PM, Wolfgang Denk wrote: > Dear Kumar, > > In message <1311581699-6301-1-git-send-email...@denx.de> I wrote: >> lc_common_dimm_params.c was too verbose and corrupted the boot >> message display like this: >> >> ... >> DRAM: Detected UDIMM M2U25664DS88C3G-6K >

Re: [U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

2011-08-31 Thread Wolfgang Denk
Dear Kumar, In message <1311581699-6301-1-git-send-email...@denx.de> I wrote: > lc_common_dimm_params.c was too verbose and corrupted the boot > message display like this: > > ... > DRAM: Detected UDIMM M2U25664DS88C3G-6K > DDR: 256 MiB (DDR1, 64-bit, CL=2, ECC off) > ...

Re: [U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

2011-07-29 Thread Wolfgang Denk
Dear Kumar, In message <73174ea1-7cbe-4c0f-a426-08f3c0eb7...@kernel.crashing.org> you wrote: > > > It may have value to you, but for 99.X % of the users it is completey > > meaningless. > > Its quite helpful for debug of customer issues. Should we add a CONFIG_ = > option for this? I already s

Re: [U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

2011-07-29 Thread Kumar Gala
On Jul 28, 2011, at 2:11 PM, Wolfgang Denk wrote: > Dear York Sun, > > In message <1311879751.29459.24.camel@oslab-l1> you wrote: >> >> I don't agree one line with the module information corrupts the boot >> messages. Do we have fixed format? Am I missing something? > > Yes, we have a well def

Re: [U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

2011-07-28 Thread Wolfgang Denk
Dear York Sun, In message <1311879751.29459.24.camel@oslab-l1> you wrote: > > I don't agree one line with the module information corrupts the boot > messages. Do we have fixed format? Am I missing something? Yes, we have a well defined format with clear indentation. Just see my commit message fo

Re: [U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

2011-07-28 Thread York Sun
On Thu, 2011-07-28 at 20:45 +0200, Wolfgang Denk wrote: > Dear York Sun, > > In message <1311875176.29459.14.camel@oslab-l1> you wrote: > > > > > - printf("Detected RDIMM %s\n", > > > + debug("Detected RDIMM %s\n", > > >

Re: [U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

2011-07-28 Thread Wolfgang Denk
Dear York Sun, In message <1311875176.29459.14.camel@oslab-l1> you wrote: > > > - printf("Detected RDIMM %s\n", > > + debug("Detected RDIMM %s\n", > > dimm_params[i].mpart); > > } else { > >

Re: [U-Boot] [PATCH] mpc8xxx: lc_common_dimm_params: make less verbose

2011-07-28 Thread York Sun
On Mon, 2011-07-25 at 10:14 +0200, Wolfgang Denk wrote: > lc_common_dimm_params.c was too verbose and corrupted the boot > message display like this: > > ... > DRAM: Detected UDIMM M2U25664DS88C3G-6K > DDR: 256 MiB (DDR1, 64-bit, CL=2, ECC off) > ... > > Turn printf() int