Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-10-07 Thread Tom Rini
On Sun, Oct 7, 2012 at 2:28 AM, Albert ARIBAUD wrote: > Hi ub...@lukaperkov.net, > > On Sun, 7 Oct 2012 09:15:52 +0200, ub...@lukaperkov.net wrote: > >> Hi Tom, Albert, Prafulla and others, >> >> On Tue, Apr 17, 2012 at 09:06:49PM +0200, Luka Perkov wrote: >> > IDE_BUS assumes that each bus has tw

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-10-07 Thread Albert ARIBAUD
Hi ub...@lukaperkov.net, On Sun, 7 Oct 2012 09:15:52 +0200, ub...@lukaperkov.net wrote: > Hi Tom, Albert, Prafulla and others, > > On Tue, Apr 17, 2012 at 09:06:49PM +0200, Luka Perkov wrote: > > IDE_BUS assumes that each bus has two devices and thus returns the first > > bus even when the secon

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-10-07 Thread uboot
Hi Tom, Albert, Prafulla and others, On Tue, Apr 17, 2012 at 09:06:49PM +0200, Luka Perkov wrote: > IDE_BUS assumes that each bus has two devices and thus returns the first > bus even when the second one should be probed. > > Signed-off-by: Simon Baatz > Tested-by: Luka Perkov > --- > > Simon

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-08-14 Thread DrEagle
Hi, It works great for my IB-6220 (Dual Sata). Without the patch, the same disk is seen twice, I have only checked disks serial numbers : ib62x0 => version U-Boot 2012.07-00123-g4d3c95f-dirty (Aug 13 2012 - 11:30:58) RaidSonic ICY BOX IB-NAS62x0 arm-linux-gnueabi-gcc (Debian 4.4.5-8) 4.4.5 GNU

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-08-14 Thread Albert ARIBAUD
On Mon, 13 Aug 2012 14:27:16 +0200, Albert ARIBAUD wrote: > Hi Wolfgang, > > On Thu, 09 Aug 2012 22:36:33 +0200, Wolfgang Denk wrote: > > Dear Albert ARIBAUD, > > > > In message > > > > you wrote: > > > Sorry Luka (and all), been tied up pretty heavily recently, had to > > > adjust to find som

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-08-13 Thread Albert ARIBAUD
Hi Wolfgang, On Thu, 09 Aug 2012 22:36:33 +0200, Wolfgang Denk wrote: > Dear Albert ARIBAUD, > > In message > > you wrote: > > Sorry Luka (and all), been tied up pretty heavily recently, had to > > adjust to find some free time again. > > > > I will test your patch today and post results tonig

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-08-09 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message you wrote: > Sorry Luka (and all), been tied up pretty heavily recently, had to > adjust to find some free time again. > > I will test your patch today and post results tonight. What was the outcome of this? I cannot find any further messages to this thread...

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-06-20 Thread Albert ARIBAUD
Sorry Luka (and all), been tied up pretty heavily recently, had to adjust to find some free time again. I will test your patch today and post results tonight. 2012/6/7 Luka Perkov > > Hi Albert, > > On Tue, May 15, 2012 at 09:42:59PM +0200, Albert ARIBAUD wrote: > > >On Sun, Apr 29, 2012 at 10:1

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-06-07 Thread Luka Perkov
Hi Albert, On Tue, May 15, 2012 at 09:42:59PM +0200, Albert ARIBAUD wrote: > >On Sun, Apr 29, 2012 at 10:19:41PM +0200, Luka Perkov wrote: > >>On Thu, Apr 19, 2012 at 08:38:19AM +0200, Albert ARIBAUD wrote: > >>>Not my main area of expertise here, but I am not sure how this plays > >>>on Marvell n

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-06-03 Thread Luka Perkov
Hi Rogan, On Sun, Jun 03, 2012 at 10:23:15PM +0200, Rogan Dawes wrote: > I had something similar for my DNS323 port (orion5x-based), which > other people may be remembering. > > http://lists.denx.de/pipermail/u-boot/2010-August/075589.html > > I seem to recall Wolfgang was not terribly enthused

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-06-03 Thread Luka Perkov
Hi Tibor, On Sun, Jun 03, 2012 at 05:03:13PM +0200, Vágó Tibor wrote: > Hi, > > I've tested this IDE patch on my NAS6220 and it works. > > U-boot detect both HDD correctly and boot from them. Thank you for testing. Regards, Luka ___ U-Boot mailing li

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-06-03 Thread Rogan Dawes
On 19/04/2012 08:38, Albert ARIBAUD wrote: Hi Dave, Le 18/04/2012 23:37, David Purdy a écrit : On Tue, Apr 17, 2012 at 2:06 PM, Luka Perkov wrote: IDE_BUS assumes that each bus has two devices and thus returns the first bus even when the second one should be probed. Signed-off-by: Simon Baatz

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-06-03 Thread Vágó Tibor
Hi, I've tested this IDE patch on my NAS6220 and it works. U-boot detect both HDD correctly and boot from them. Cheers, Tibor Original message IDE_BUS assumes that each bus has two devices and thus returns the first bus even when the second one should be probed. Signed-off-

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-06-03 Thread Vágó Tibor
Hi, I've tested this IDE patch on my NAS6220 and it works. U-boot detect both HDD correctly and boot from them. Cheers, Tibor Original message IDE_BUS assumes that each bus has two devices and thus returns the first bus even when the second one should be probed. Signed-off-

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-05-15 Thread Luka Perkov
Hi Albert, On Tue, May 15, 2012 at 09:42:59PM +0200, Albert ARIBAUD wrote: > >diff --git a/include/ide.h b/include/ide.h > >index 8ecc9dd..385e909 100644 > >--- a/include/ide.h > >+++ b/include/ide.h > >@@ -24,7 +24,7 @@ > > #ifndef_IDE_H > > #define _IDE_H > > > >-#define IDE_BUS(dev)

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-05-15 Thread Albert ARIBAUD
Hi Luka, Le 14/05/2012 21:29, Luka Perkov a écrit : Hi Albert, On Sun, Apr 29, 2012 at 10:19:41PM +0200, Luka Perkov wrote: On Thu, Apr 19, 2012 at 08:38:19AM +0200, Albert ARIBAUD wrote: Not my main area of expertise here, but I am not sure how this plays on Marvell non-kirkwood platforms (e

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-05-14 Thread Luka Perkov
Hi Albert, On Sun, Apr 29, 2012 at 10:19:41PM +0200, Luka Perkov wrote: > On Thu, Apr 19, 2012 at 08:38:19AM +0200, Albert ARIBAUD wrote: > > Not my main area of expertise here, but I am not sure how this plays > > on Marvell non-kirkwood platforms (e.g., orion5x). > > > > ISTR it is not the firs

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-04-29 Thread Luka Perkov
Hi Albert, On Thu, Apr 19, 2012 at 08:38:19AM +0200, Albert ARIBAUD wrote: > Not my main area of expertise here, but I am not sure how this plays > on Marvell non-kirkwood platforms (e.g., orion5x). > > ISTR it is not the first time we deal with the whole IDE number of > bus / number of ports [ /

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-04-21 Thread David Purdy
On Thu, Apr 19, 2012 at 1:38 AM, Albert ARIBAUD wrote: > Hi Dave, > > > > > Not my main area of expertise here, but I am not sure how this plays on > Marvell non-kirkwood platforms (e.g., orion5x). > > ISTR it is not the first time we deal with the whole IDE number of bus / > number of ports [ / u

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-04-19 Thread Prafulla Wadaskar
> -Original Message- > From: u-boot-boun...@lists.denx.de [mailto:u-boot- > boun...@lists.denx.de] On Behalf Of Luka Perkov > Sent: 18 April 2012 00:37 > To: u-boot@lists.denx.de > Subject: [U-Boot] [PATCH] fix IDE_BUS(dev) macro > > IDE_BUS assumes that each bus has two devices and thus

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-04-18 Thread Albert ARIBAUD
Hi Dave, Le 18/04/2012 23:37, David Purdy a écrit : On Tue, Apr 17, 2012 at 2:06 PM, Luka Perkov wrote: IDE_BUS assumes that each bus has two devices and thus returns the first bus even when the second one should be probed. Signed-off-by: Simon Baatz Tested-by: Luka Perkov --- Simon discover

Re: [U-Boot] [PATCH] fix IDE_BUS(dev) macro

2012-04-18 Thread David Purdy
On Tue, Apr 17, 2012 at 2:06 PM, Luka Perkov wrote: > IDE_BUS assumes that each bus has two devices and thus returns the first > bus even when the second one should be probed. > > Signed-off-by: Simon Baatz > Tested-by: Luka Perkov > --- > > Simon discovered this while adding support for new boa