Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-16 Thread Albert ARIBAUD
Hi Macpaul Lin, Le 16/04/2011 13:17, Macpaul Lin a écrit : > Hi all, > > 2011/4/16 Graeme Russ: >> On 16/04/11 16:22, Albert ARIBAUD wrote: >>> >>> If the goal is to have the !defined aligned, then maybe a solution here >>> would be toput a tab rather than a space after the #if? >>> > > Do you guy

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-16 Thread Macpaul Lin
Hi all, 2011/4/16 Graeme Russ : > On 16/04/11 16:22, Albert ARIBAUD wrote: >> >> If the goal is to have the !defined aligned, then maybe a solution here >> would be toput a tab rather than a space after the #if? >> Do you guys means #if"\t"defined (XX) || "\t"defined (XX) instead of #if d

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-16 Thread Graeme Russ
On 16/04/11 16:22, Albert ARIBAUD wrote: > Hi all, > > Le 15/04/2011 12:09, Wolfgang Denk a écrit : >> Dear Mike Frysinger, >> >> In message<201104150453.21441.vap...@gentoo.org> you wrote: >>> > On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote: >> #if !defined(CONFIG_ENV_IS_IN_EEPR

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-15 Thread Albert ARIBAUD
Le 16/04/2011 08:18, Macpaul Lin a écrit : > HI all, > > 2011/4/15 Mike Frysinger: up to Wolfgang how he feels about ifdef indentation >>> >>> In this specific case of #ifdef indentation I feel that the original >>> form (which causes checkpatch warnings) is actually easier to read, so >>> I t

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-15 Thread Albert ARIBAUD
Hi all, Le 15/04/2011 12:09, Wolfgang Denk a écrit : > Dear Mike Frysinger, > > In message<201104150453.21441.vap...@gentoo.org> you wrote: >> On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote: > #if !defined(CONFIG_ENV_IS_IN_EEPROM)&& \ > -!defined(CONFIG_ENV_IS_IN_FLASH)&

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-15 Thread Macpaul Lin
HI all, 2011/4/15 Mike Frysinger : >> > up to Wolfgang how he feels about ifdef indentation >> >> In this specific case of #ifdef indentation I feel that the original >> form (which causes checkpatch warnings) is actually easier to read, so >> I tend to keep it.  But I am aware that this is incons

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-15 Thread Mike Frysinger
On Friday, April 15, 2011 06:09:12 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > > On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote: > > > >> #if !defined(CONFIG_ENV_IS_IN_EEPROM)&& \ > > > >> > > > >> -!defined(CONFIG_ENV_IS_IN_FLASH) && \ > > > >> + !defined(CONFIG_ENV_

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-15 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201104150453.21441.vap...@gentoo.org> you wrote: > > > > On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote: > > >> #if !defined(CONFIG_ENV_IS_IN_EEPROM)&& \ > > >> -!defined(CONFIG_ENV_IS_IN_FLASH) && \ > > >> + !defined(CONFIG_ENV_IS_IN_FLASH)

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-15 Thread Macpaul Lin
Hi Mike, 2011/4/15 Mike Frysinger : >> Do you mean the replacement with space to ident? >> >> According to the 2.6.38.1's checkpatch, it reported: >> WARNING: please, no spaces at the start of a line > > this particular check has already been posted upstream as generally causing > more harm than g

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-15 Thread Mike Frysinger
On Friday, April 15, 2011 04:25:58 Macpaul Lin wrote: > 2011/4/15 Mike Frysinger: > > On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote: > >> #if !defined(CONFIG_ENV_IS_IN_EEPROM)&& \ > >> -!defined(CONFIG_ENV_IS_IN_FLASH) && \ > >> + !defined(CONFIG_ENV_IS_IN_FLASH)&& \

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-15 Thread Macpaul Lin
Hi Mike, 2011/4/15 Mike Frysinger : > On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote: >>  #if !defined(CONFIG_ENV_IS_IN_EEPROM)        && \ >> -    !defined(CONFIG_ENV_IS_IN_FLASH) && \ >> +     !defined(CONFIG_ENV_IS_IN_FLASH)        && \ > > not sure this one hunk is desirable, but the res

Re: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

2011-04-15 Thread Mike Frysinger
On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote: > #if !defined(CONFIG_ENV_IS_IN_EEPROM)&& \ > -!defined(CONFIG_ENV_IS_IN_FLASH) && \ > + !defined(CONFIG_ENV_IS_IN_FLASH)&& \ not sure this one hunk is desirable, but the rest are fine -mike signature.asc Description: