Re: [PATCH 14/32] efi: Rename ImageBase to image_base

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 05:49:55PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, 6 Feb 2025 at 16:24, Tom Rini wrote: > > > > On Thu, Feb 06, 2025 at 02:27:30PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > > > > > > > On Mon, Feb 03, 2025

Re: [PATCH 14/32] efi: Rename ImageBase to image_base

2025-02-06 Thread Simon Glass
Hi Tom, On Thu, 6 Feb 2025 at 16:24, Tom Rini wrote: > > On Thu, Feb 06, 2025 at 02:27:30PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > > > > > On Mon, Feb 03, 2025 at 10:42:07AM -0700, Simon Glass wrote: > > > > > > > It is confusing to have a

Re: [PATCH 14/32] efi: Rename ImageBase to image_base

2025-02-06 Thread Tom Rini
On Thu, Feb 06, 2025 at 02:27:30PM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > > > On Mon, Feb 03, 2025 at 10:42:07AM -0700, Simon Glass wrote: > > > > > It is confusing to have a camel-case indentifier in the link scripts. > > > Rename it to fit with

Re: [PATCH 14/32] efi: Rename ImageBase to image_base

2025-02-06 Thread Simon Glass
Hi Tom, On Mon, 3 Feb 2025 at 13:09, Tom Rini wrote: > > On Mon, Feb 03, 2025 at 10:42:07AM -0700, Simon Glass wrote: > > > It is confusing to have a camel-case indentifier in the link scripts. > > Rename it to fit with U-Boot's snake-case style. > > > > Signed-off-by: Simon Glass > > This isn't

Re: [PATCH 14/32] efi: Rename ImageBase to image_base

2025-02-03 Thread Tom Rini
On Mon, Feb 03, 2025 at 10:42:07AM -0700, Simon Glass wrote: > It is confusing to have a camel-case indentifier in the link scripts. > Rename it to fit with U-Boot's snake-case style. > > Signed-off-by: Simon Glass This isn't the linker script, it's the crt0 file. Given that this is intended t