Re: [PATCH] usb: ehci-omap: Drop dead code

2022-02-14 Thread Adam Ford
On Sun, Feb 13, 2022 at 9:10 PM Marek Vasut wrote: > > On 2/14/22 01:05, Adam Ford wrote: > > On Sat, Feb 12, 2022 at 8:26 AM Adam Ford wrote: > >> > >> omap_ehci_hcd_stop appears to be dead code, and omap_ehci_hcd_init > >> is only called by the probe function, so it can be static to that > >> f

Re: [PATCH] usb: ehci-omap: Drop dead code

2022-02-13 Thread Marek Vasut
On 2/14/22 01:05, Adam Ford wrote: On Sat, Feb 12, 2022 at 8:26 AM Adam Ford wrote: omap_ehci_hcd_stop appears to be dead code, and omap_ehci_hcd_init is only called by the probe function, so it can be static to that function. Remove both from the header along with some additional checking fo

Re: [PATCH] usb: ehci-omap: Drop dead code

2022-02-13 Thread Adam Ford
On Sat, Feb 12, 2022 at 8:26 AM Adam Ford wrote: > > omap_ehci_hcd_stop appears to be dead code, and omap_ehci_hcd_init > is only called by the probe function, so it can be static to that > function. Remove both from the header along with some additional > checking for DM_USB. > If it's not too