Re: [U-Boot] mmc tests incorrectly implemented

2019-04-10 Thread Stephen Warren
On 4/10/19 11:22 AM, Tom Rini wrote: On Wed, Apr 10, 2019 at 11:13:32AM -0600, Stephen Warren wrote: On 4/10/19 10:23 AM, Marek Vasut wrote: On 4/10/19 5:12 PM, Stephen Warren wrote: Hi, it would be nice if I was CCed on this. Sorry, I didn't drill down in Jenkins/git data to find out where

Re: [U-Boot] mmc tests incorrectly implemented

2019-04-10 Thread Tom Rini
On Wed, Apr 10, 2019 at 11:13:32AM -0600, Stephen Warren wrote: > On 4/10/19 10:23 AM, Marek Vasut wrote: > > On 4/10/19 5:12 PM, Stephen Warren wrote: > > > > Hi, > > > > it would be nice if I was CCed on this. > > Sorry, I didn't drill down in Jenkins/git data to find out where the > commits c

Re: [U-Boot] mmc tests incorrectly implemented

2019-04-10 Thread Stephen Warren
On 4/10/19 10:23 AM, Marek Vasut wrote: > On 4/10/19 5:12 PM, Stephen Warren wrote: > > Hi, > > it would be nice if I was CCed on this. Sorry, I didn't drill down in Jenkins/git data to find out where the commits came from; I just had a list of commit descriptions and knew which branch they show

Re: [U-Boot] mmc tests incorrectly implemented

2019-04-10 Thread Tom Rini
On Wed, Apr 10, 2019 at 06:23:46PM +0200, Marek Vasut wrote: > On 4/10/19 5:12 PM, Stephen Warren wrote: > > Hi, > > it would be nice if I was CCed on this. > > > I see that some mmc tests have been added to test/py, but I see problems > > with them: > > > > 1) test_mmc_rescan assumes that each

Re: [U-Boot] mmc tests incorrectly implemented

2019-04-10 Thread Marek Vasut
On 4/10/19 5:12 PM, Stephen Warren wrote: Hi, it would be nice if I was CCed on this. > I see that some mmc tests have been added to test/py, but I see problems > with them: > > 1) test_mmc_rescan assumes that each entry in env__mmc_rd_configs is a > separate device that can be rescanned. This

[U-Boot] mmc tests incorrectly implemented

2019-04-10 Thread Stephen Warren
I see that some mmc tests have been added to test/py, but I see problems with them: 1) test_mmc_rescan assumes that each entry in env__mmc_rd_configs is a separate device that can be rescanned. This isn't actually true; entries in that array are intended to drive the mmc read test, and so can poin