On Wed, Apr 10, 2019 at 06:23:46PM +0200, Marek Vasut wrote: > On 4/10/19 5:12 PM, Stephen Warren wrote: > > Hi, > > it would be nice if I was CCed on this. > > > I see that some mmc tests have been added to test/py, but I see problems > > with them: > > > > 1) test_mmc_rescan assumes that each entry in env__mmc_rd_configs is a > > separate device that can be rescanned. This isn't actually true; entries > > in that array are intended to drive the mmc read test, and so can point > > at partitions or specific sector numbers. > > Is that documented somewhere ? I assumed they are separate devices and > if you need to test multiple partitions, you will have multiple entries > in this array, one for each device:partition pair. > > > Running an mmc rescan test on > > the entire array results in duplicated tests. A new data array should be > > created for different tests. > > I don't have such a usecase, but the fix should be easy to implement. > Can you do that ? > > > 2) It relies on test data that was not previously required. In > > particular, I see new test failures because the "info_device" key is now > > required. New tests should either (a) use new optional data arrays to > > configure their operation, or (b) access any new data in an optional > > way, skipping the test if it's not present, so as not to cause test > > failures. > > Either that, or update your tests. Can you submit a patch for this ? > > > Also, shouldn't things like new tests be announced to the board > > maintainers list, so that people can update their test/py configurations > > to enable new tests if they're appropriate for their platform? > > I don't know , should it ?
On me, yes, this is probably something worth poking folks on the board maintainers ML about, especially once it's shown useful on two SoCs :) -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
