Hi Frans,
> (btw personally I feel that it is a sign of clean programming to
> declare all exported functions in a header file, and only to use
> header files to import functions, but maybe that is a personal
> thingie).
Seconded. Any patch to this end is highly welcome ;)
Cheers
Detlev
--
On 3/24/2010 2:08 PM, Wolfgang Denk wrote:
> Dear Ben,
>
> In message<4baa6f5c.5060...@gmail.com> you wrote:
>
>> ... You'll get more feedback when people don't like what you did,
>> but any EE will tell you that negative feedback is the path to stability :)
>>
> May I add this to
Dear Ben,
In message <4baa6f5c.5060...@gmail.com> you wrote:
>
> ... You'll get more feedback when people don't like what you did,
> but any EE will tell you that negative feedback is the path to stability :)
May I add this to my list of signature quotes?
Best regards,
Wolfgang Denk
--
Oops. Replied to Ben only not to the list. Here is my reply.
Actually did a quick grep -r -w afterwards: there are roughly 475 .c
files with extern in it.
Guess this is a more widely spread issue.
(btw personally I feel that it is a sign of clean programming to
declare all exported functions in a
Hi Frans,
On 3/24/2010 12:52 PM, Frans Meulenbroeks wrote:
> yet another potential cleanup:
>
> I see both:
> extern char console_buffer[];
> and
> extern char console_buffer[CONFIG_SYS_CBSIZE];
>
> (and in fact console_buffer is declared as:
> charconsole_buffer[CONFIG_SYS_CBSIZE + 1];
yet another potential cleanup:
I see both:
extern char console_buffer[];
and
extern char console_buffer[CONFIG_SYS_CBSIZE];
(and in fact console_buffer is declared as:
charconsole_buffer[CONFIG_SYS_CBSIZE + 1]; /* console I/O buffer
*/
so with a +1).
Questions:
is the first or th
6 matches
Mail list logo
