yet another potential cleanup:

I see both:
extern char console_buffer[];
and
extern char console_buffer[CONFIG_SYS_CBSIZE];

(and in fact console_buffer is declared as:
char        console_buffer[CONFIG_SYS_CBSIZE + 1];      /* console I/O buffer   
*/
so with a +1).

Questions:
is the first or the 2nd form preferred?
and if it is the 2nd form should it not have the +1?
and wouldn't it be better to have this extern in a .h file (and if so
which one)?

Frans
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to