Re: [U-Boot] config USB_STORAGE: defconfig vs include header

2016-09-08 Thread Tom Rini
On Fri, Sep 09, 2016 at 10:09:56AM +0900, Masahiro Yamada wrote: > 2016-09-09 5:17 GMT+09:00 Tom Rini : > > On Thu, Sep 08, 2016 at 02:13:21PM -0400, Tom Rini wrote: > >> On Thu, Sep 08, 2016 at 09:58:13AM -0600, Stephen Warren wrote: > >> > On 09/07/2016 07:29 PM, Masahiro Yamada wrote: > >> > >Hi

Re: [U-Boot] config USB_STORAGE: defconfig vs include header

2016-09-08 Thread Masahiro Yamada
2016-09-09 5:17 GMT+09:00 Tom Rini : > On Thu, Sep 08, 2016 at 02:13:21PM -0400, Tom Rini wrote: >> On Thu, Sep 08, 2016 at 09:58:13AM -0600, Stephen Warren wrote: >> > On 09/07/2016 07:29 PM, Masahiro Yamada wrote: >> > >Hi Stephen >> > > >> > > >> > >2016-09-08 1:15 GMT+09:00 Stephen Warren : >>

Re: [U-Boot] config USB_STORAGE: defconfig vs include header

2016-09-08 Thread Tom Rini
On Thu, Sep 08, 2016 at 02:13:21PM -0400, Tom Rini wrote: > On Thu, Sep 08, 2016 at 09:58:13AM -0600, Stephen Warren wrote: > > On 09/07/2016 07:29 PM, Masahiro Yamada wrote: > > >Hi Stephen > > > > > > > > >2016-09-08 1:15 GMT+09:00 Stephen Warren : > > >>Masahiro, > > >> > > >>In patch 6e7e9294d3

Re: [U-Boot] config USB_STORAGE: defconfig vs include header

2016-09-08 Thread Tom Rini
On Thu, Sep 08, 2016 at 09:58:13AM -0600, Stephen Warren wrote: > On 09/07/2016 07:29 PM, Masahiro Yamada wrote: > >Hi Stephen > > > > > >2016-09-08 1:15 GMT+09:00 Stephen Warren : > >>Masahiro, > >> > >>In patch 6e7e9294d321 "usb: add basic USB configs in Kconfig", you added > >>"config USB_STORAG

Re: [U-Boot] config USB_STORAGE: defconfig vs include header

2016-09-08 Thread Stephen Warren
On 09/07/2016 07:29 PM, Masahiro Yamada wrote: Hi Stephen 2016-09-08 1:15 GMT+09:00 Stephen Warren : Masahiro, In patch 6e7e9294d321 "usb: add basic USB configs in Kconfig", you added "config USB_STORAGE" to drivers/usb/Kconfig. However, it's still just #defined by many include/configs/*.h ra

Re: [U-Boot] config USB_STORAGE: defconfig vs include header

2016-09-07 Thread Masahiro Yamada
Hi Stephen 2016-09-08 1:15 GMT+09:00 Stephen Warren : > Masahiro, > > In patch 6e7e9294d321 "usb: add basic USB configs in Kconfig", you added > "config USB_STORAGE" to drivers/usb/Kconfig. However, it's still just > #defined by many include/configs/*.h rather than being defined in > configs/*_de

[U-Boot] config USB_STORAGE: defconfig vs include header

2016-09-07 Thread Stephen Warren
Masahiro, In patch 6e7e9294d321 "usb: add basic USB configs in Kconfig", you added "config USB_STORAGE" to drivers/usb/Kconfig. However, it's still just #defined by many include/configs/*.h rather than being defined in configs/*_defconfig. Is that a problem? It seems to work in practice, but