Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Reinhard Meyer
Dear Wolfgang Denk, >> The general question, however was, if that approach is OK with you. > > Well, I still prefer to have this added to a single, central location > instead to a large number of board config files. AT91 does not have a really large number of config files. > > However, if you hav

Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Wolfgang Denk
Dear Reinhard Meyer, In message <4caa0bb1.7010...@emk-elektronik.de> you wrote: > > I agree here, and will change that whenever I encounter it in files > I touch (most is copied from the atmel EK config file). Thanks. > The general question, however was, if that approach is OK with you. Well, I

Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Reinhard Meyer
Dear Wolfgang Denk, > In message<4ca9eb88.5000...@emk-elektronik.de> you wrote: >> >> 1. The board's config file defines "CONFIG_AT91FAMILY" like this: >> /* SoC */ >> #define CONFIG_ARM926EJS 1 /* ARM926EJS Core */ >> #define CONFIG_AT91FAMILY 1 /* it's a member o

Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Wolfgang Denk
Dear Reinhard Meyer, In message <4ca9eb88.5000...@emk-elektronik.de> you wrote: > > 1. The board's config file defines "CONFIG_AT91FAMILY" like this: > /* SoC */ > #define CONFIG_ARM926EJS 1 /* ARM926EJS Core */ > #define CONFIG_AT91FAMILY 1 /* it's a member of A

Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Reinhard Meyer
Dear Wolfgang Denk, > > I see the misunderstanding here: > >> It will be needed to replace the "#if defined(CONFIG_AT91SAM9260) || >> defined(CONFIG_AT91SAM9XE)" in global_data.h and a ton of similar >> ocurrences like these: > > That does not exist yet (its only in my local tree so far!) > >>

Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Reinhard Meyer
Dear Wolfgang Denk, >>> Patch 1 will change the #if and introduce CONFIG_AT91SAM9_FAMILY >>> instead. >>> >>> Patch 2 will fix at91/clock.c+timer.c >> Maybe there is a misunderstanding here. I see three patches >> >> 1. introduce CONFIG_AT91SAM9_FAMILY to common.h >> >> 2. add an #ifdef CONFIG_AT91

Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Wolfgang Denk
Dear Reinhard Meyer, In message <4ca99373.7020...@emk-elektronik.de> you wrote: > > > Patch 1 will change the #if and introduce CONFIG_AT91SAM9_FAMILY > > instead. > > > > Patch 2 will fix at91/clock.c+timer.c > > Maybe there is a misunderstanding here. I see three patches > > 1. introduce CONF

Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Reinhard Meyer
Dear Wolfgang Denk, I see the misunderstanding here: > It will be needed to replace the "#if defined(CONFIG_AT91SAM9260) || > defined(CONFIG_AT91SAM9XE)" in global_data.h and a ton of similar > ocurrences like these: That does not exist yet (its only in my local tree so far!) > arch/arm/cpu/arm

Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Reinhard Meyer
Dear Wolfgang Denk, >> The Qs that remain now are: >> >> 1. currently I see about 8 CONFIG_AT91SAMxxx defines required >> (not only 2 like above). The method is still undecided how to >> handle this. Add "CONFIG_AT91SAM9_FAMILY" to "common.h"? Or put >> all 8 defined() into "global_data.h" (would g

Re: [U-Boot] AT91 clock and timer cleanups

2010-10-04 Thread Wolfgang Denk
Dear Reinhard Meyer, In message <4ca995d7.5010...@emk-elektronik.de> you wrote: > > >> Maybe there is a misunderstanding here. I see three patches > >> > >> 1. introduce CONFIG_AT91SAM9_FAMILY to common.h > >> > >> 2. add an #ifdef CONFIG_AT91SAM9_FAMILY to global_data.h with the > >> required var

Re: [U-Boot] AT91 clock and timer cleanups (was: ARM relocation, probably trivial mistake - back to original problem)

2010-10-04 Thread Wolfgang Denk
Dear Reinhard Meyer, In message <4ca985dc.4000...@emk-elektronik.de> you wrote: > > The Qs that remain now are: > > 1. currently I see about 8 CONFIG_AT91SAMxxx defines required > (not only 2 like above). The method is still undecided how to > handle this. Add "CONFIG_AT91SAM9_FAMILY" to "common.

[U-Boot] AT91 clock and timer cleanups (was: ARM relocation, probably trivial mistake - back to original problem)

2010-10-04 Thread Reinhard Meyer
I wrote: > Dear Wolfgang Denk, >> In message <4ca5d26d.2090...@emk-elektronik.de> you wrote: If this is really for all AT91 SoCs, then please feel free to introduce a common define (CONFIG_SYS_AT91 ?) and use that. Eventually you can clean up some other such #if's on the way. >>> Tha