Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-03-09 Thread Wolfgang Denk
Dear Rohit Hagargundgi, In message <200903091604.45906.h.ro...@samsung.com> you wrote: > Currently OneNAND initial program loader (ipl) reads only block 0. > However, u-boot image for apollon board is 195KB making the board > unbootable with OneNAND. > Fix ipl to read 256KB. NAK. The description

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-03-09 Thread Rohit Hagargundgi
Currently OneNAND initial program loader (ipl) reads only block 0. However, u-boot image for apollon board is 195KB making the board unbootable with OneNAND. Fix ipl to read 256KB. Signed-off-by: Rohit Hagargundgi --- include/configs/apollon.h |1 + onenand_ipl/onenand_read.c | 27 +++

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-03-08 Thread Wolfgang Denk
Dear Rohit Hagargundgi, In message <49ae99c0.9040...@samsung.com> you wrote: > Hi, > > Here is the updated patch. > > Thanks, > Rohit This is not an acceptable commit message. Please include a reasonable commit message that explains what you are doinbg and why. > Signed-off-by: Rohit Hagargun

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-03-07 Thread Rohit Hagargundgi
Hi, Kyungmin Park wrote: >> >> + /* Check for invalid block mark*/ >> + if (page < 2 && (onenand_readw(THIS_ONENAND(ONENAND_SPARERAM)) != >> 0x)) >> + return 1; >> + > > No need to check invalid block. Note that block 0 is always good > block. no exception. Correct

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-03-04 Thread Kyungmin Park
On Thu, Mar 5, 2009 at 12:09 AM, Rohit Hagargundgi wrote: > Hi, > > Here is the updated patch. > > Thanks, > Rohit > > Signed-off-by: Rohit Hagargundgi > --- >  include/configs/apollon.h  |    1 + >  onenand_ipl/onenand_read.c |   27 --- >  2 files changed, 21 insertions(+

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-03-04 Thread Rohit Hagargundgi
Hi, Here is the updated patch. Thanks, Rohit Signed-off-by: Rohit Hagargundgi --- include/configs/apollon.h |1 + onenand_ipl/onenand_read.c | 27 --- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/include/configs/apollon.h b/include/configs/a

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-02-26 Thread Rohit Hagargundgi
Hi, Kyungmin Park wrote: > Hi, > > In the previous mail, I also solve this issue. multi-block read for IPL > > http://www.mail-archive.com/u-boot@lists.denx.de/msg04641.html oh, okay. So this merge first. To Scott, Wolfgang - can you please apply this patch. Also environment block is affected

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-02-26 Thread Wolfgang Denk
Dear Rohit Hagargundgi, In message <49a68ba2.80...@samsung.com> you wrote: > > Jean-Christophe PLAGNIOL-VILLARD wrote: > >> #define ONENAND_BLOCK_SIZE 2048 > >> +#define ONENAND_BOOTLOADER_SIZE 0x4 > > why hardcoded value? > > Is it possible to get image size instead

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-02-26 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:01 Thu 26 Feb , Rohit Hagargundgi wrote: > Hi, > > Jean-Christophe PLAGNIOL-VILLARD wrote: >>> #define ONENAND_BLOCK_SIZE 2048 >>> +#define ONENAND_BOOTLOADER_SIZE0x4 >> why hardcoded value? > > Is it possible to get image size instead of hard value. > Then

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-02-26 Thread Rohit Hagargundgi
Hi, Jean-Christophe PLAGNIOL-VILLARD wrote: >> #define ONENAND_BLOCK_SIZE 2048 >> +#define ONENAND_BOOTLOADER_SIZE 0x4 > why hardcoded value? Is it possible to get image size instead of hard value. Then we can read exactly u-boot image size on boot up. >> +/* C

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-02-26 Thread Kyungmin Park
Hi, In the previous mail, I also solve this issue. multi-block read for IPL http://www.mail-archive.com/u-boot@lists.denx.de/msg04641.html Of course, it's not consider the Flex-OneNAND, please apply this one first and then fix it for Flex-OneNAND. How do you think? Thank you, Kyungmin Park On

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-02-26 Thread Wolfgang Denk
Dear Rohit Hagargundgi, In message <49a645e0.9060...@samsung.com> you wrote: > Currently OneNAND initial program loader (ipl) reads only block 0. > However, u-boot image for apollon board is 195KB making the board > unbootable with OneNAND. > Fix ipl to read 256KB. What if there is a board that e

Re: [U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-02-26 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:03 Thu 26 Feb , Rohit Hagargundgi wrote: > Currently OneNAND initial program loader (ipl) reads only block 0. > However, u-boot image for apollon board is 195KB making the board > unbootable with OneNAND. > Fix ipl to read 256KB. > > Signed-off-by: Rohit Hagargundgi > --- > onenand_ip

[U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

2009-02-25 Thread Rohit Hagargundgi
Currently OneNAND initial program loader (ipl) reads only block 0. However, u-boot image for apollon board is 195KB making the board unbootable with OneNAND. Fix ipl to read 256KB. Signed-off-by: Rohit Hagargundgi --- onenand_ipl/onenand_ipl.h |1 + onenand_ipl/onenand_read.c | 29 +