Dear Rohit Hagargundgi,

In message <49a645e0.9060...@samsung.com> you wrote:
> Currently OneNAND initial program loader (ipl) reads only block 0.
> However, u-boot image for apollon board is 195KB making the board
> unbootable with OneNAND.
> Fix ipl to read 256KB.

What if there is a board that enables additional features and the size
grows above 256 kB?

>   #include <linux/mtd/onenand_regs.h>
> 
>   #define ONENAND_BLOCK_SIZE              2048
> +#define ONENAND_BOOTLOADER_SIZE              0x40000

Why do we need a new #define here. CONFIG_SYS_MONITOR_LEN already
contains the U-Boot image size, and is configurable for each board.

Please drop this #define here and substitute ONENAND_BOOTLOADER_SIZE
by CONFIG_SYS_MONITOR_LEN in the rest of the patch.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
It's not an optical illusion, it just looks like one.   -- Phil White
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to