Re: [U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

Hi Simon, 2015-12-28 13:29 GMT+09:00 Simon Glass : > Hi Masahiro, > > On 22 December 2015 at 20:52, Masahiro Yamada > wrote: >> Hi Simon, >> >> >> BTW, the "Include file order" in http://www.denx.de/wiki/U-Boot/CodingStyle Is this your opinion? Or community's opinion. >>

Re: [U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

Hi Mateusz, 2015-12-28 1:51 GMT+09:00 Mateusz Kulikowski : > Hi Masahiro, > > On 23.12.2015 04:52, Masahiro Yamada wrote: > [..] >> I guess Linux sorts headers from global to local. >> >> #include global in the project >> #include arch-specific >> #include "foo.h"local in the dir

Re: [U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

Hi Masahiro, On 22 December 2015 at 20:52, Masahiro Yamada wrote: > Hi Simon, > > > >>> BTW, the "Include file order" in >>> http://www.denx.de/wiki/U-Boot/CodingStyle >>> >>> Is this your opinion? Or community's opinion. >>> >>> Did anybody review it? >> >> This came from Mike Frysinger some yea

Re: [U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

Hi Masahiro, On 23.12.2015 04:52, Masahiro Yamada wrote: [..] > I guess Linux sorts headers from global to local. > > #include global in the project > #include arch-specific > #include "foo.h"local in the directory > > > Likewise, the following makes sense for U-Boot > > #inc

Re: [U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

Hi Simon, >> BTW, the "Include file order" in >> http://www.denx.de/wiki/U-Boot/CodingStyle >> >> Is this your opinion? Or community's opinion. >> >> Did anybody review it? > > This came from Mike Frysinger some years ago on the mailing list and I > have followed it since. I took it to be a U-Bo

Re: [U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

Hi Masahiro, On 20 December 2015 at 23:50, Masahiro Yamada wrote: > 2015-12-16 3:58 GMT+09:00 Simon Glass : > >>> +++ b/drivers/serial/serial_msm.c >>> @@ -0,0 +1,204 @@ >>> +/* >>> + * Qualcomm UART driver >>> + * >>> + * (C) Copyright 2015 Mateusz Kulikowski >>> + * >>> + * UART will work in D

Re: [U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

2015-12-16 3:58 GMT+09:00 Simon Glass : >> +++ b/drivers/serial/serial_msm.c >> @@ -0,0 +1,204 @@ >> +/* >> + * Qualcomm UART driver >> + * >> + * (C) Copyright 2015 Mateusz Kulikowski >> + * >> + * UART will work in Data Mover mode. >> + * Based on Linux driver. >> + * >> + * SPDX-License-Identi

Re: [U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Simon, Thank you for awesome review! I fully agree with most of the suggestions (for this and following patches), so to keep it short will reply only to questions (or where I disagree) On 15.12.2015 19:58, Simon Glass wrote: > Hi Mateusz, >

Re: [U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

Hi Mateusz, On 10 December 2015 at 14:41, Mateusz Kulikowski wrote: > This driver works in "new" Data Mover UART mode, so > will be compatible with modern Qualcomm chips only. > > Signed-off-by: Mateusz Kulikowski > --- > > drivers/serial/Kconfig | 5 ++ > drivers/serial/Makefile |

[U-Boot] [RFC PATCH 01/11] serial: Add support for Qualcomm serial port

This driver works in "new" Data Mover UART mode, so will be compatible with modern Qualcomm chips only. Signed-off-by: Mateusz Kulikowski --- drivers/serial/Kconfig | 5 ++ drivers/serial/Makefile | 1 + drivers/serial/serial_msm.c | 204