2015-12-16 3:58 GMT+09:00 Simon Glass <s...@chromium.org>: >> +++ b/drivers/serial/serial_msm.c >> @@ -0,0 +1,204 @@ >> +/* >> + * Qualcomm UART driver >> + * >> + * (C) Copyright 2015 Mateusz Kulikowski <mateusz.kulikow...@gmail.com> >> + * >> + * UART will work in Data Mover mode. >> + * Based on Linux driver. >> + * >> + * SPDX-License-Identifier: GPL-2.0+ >> + */ >> + >> +#include <asm/io.h> >> +#include <common.h> >> +#include <dm.h> >> +#include <clk.h> >> +#include <errno.h> >> +#include <linux/compiler.h> >> +#include <serial.h> >> +#include <watchdog.h> > > Ordering: > > common.h > clk.h > dm.h > errno.h > serial.h > watchdog.h > asm/ > linux/ > >
No. Put <linux/*.h> above <asm/*.h>, at least. (the same order in Linux) BTW, the "Include file order" in http://www.denx.de/wiki/U-Boot/CodingStyle Is this your opinion? Or community's opinion. Did anybody review it? -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
