Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

2010-12-02 Thread Darius Augulis
Hi Albert, On 12/01/2010 08:42 AM, Albert ARIBAUD wrote: > Hi Darius, > > Le 30/11/2010 10:19, Darius Augulis a écrit : > >> I understand, that there is such rule in u-boot, but it's ... at least >> strange. >> Even linux kernel doesn't use such approach and uses simple defines instead. >> One bi

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

2010-11-30 Thread Albert ARIBAUD
Hi Darius, Le 30/11/2010 10:19, Darius Augulis a écrit : > I understand, that there is such rule in u-boot, but it's ... at least > strange. > Even linux kernel doesn't use such approach and uses simple defines instead. > One big disadvantage for already existing platforms - one must convert > a

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

2010-11-30 Thread Darius Augulis
Hi, On Tue, Nov 30, 2010 at 10:50 AM, Minkyu Kang wrote: > Dear Darius Augulis, > > On 30 November 2010 17:17, Darius Augulis wrote: >> Hi, >> >> thank you for review. Please find my questions inline: >> + +static void dm9000_pre_init(void) +{ +       SROM_BW_REG &= ~(0xf <<

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

2010-11-30 Thread Minkyu Kang
Dear Darius Augulis, On 30 November 2010 17:17, Darius Augulis wrote: > Hi, > > thank you for review. Please find my questions inline: > >>> + >>> +static void dm9000_pre_init(void) >>> +{ >>> +       SROM_BW_REG &= ~(0xf << 4); >> >> u-boot don't allow it. >> Please use read/write function. >> A

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

2010-11-30 Thread Darius Augulis
Hi, thank you for review. Please find my questions inline: >> + >> +static void dm9000_pre_init(void) >> +{ >> +       SROM_BW_REG &= ~(0xf << 4); > > u-boot don't allow it. > Please use read/write function. > And please access the register by C structure. it's clear about read/write. But why C

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

2010-11-29 Thread Minkyu Kang
Dear Darius Augulis, On 18 November 2010 06:26, Darius Augulis wrote: > Add support for mini6410 from FriendlyARM > > Signed-off-by: Darius Augulis > --- >  MAKEALL                                         |    1 >  Makefile                                        |    4 >  arch/arm/cpu/arm1176/s3

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

2010-11-22 Thread Minkyu Kang
Dear Darius Augulis, On 23 November 2010 03:28, Darius Augulis wrote: > Hi all, > > is there anybody interested in U-boot for s3c64xx? > If not, at least I would like to ask Wolfgang to review generic things > (not architecture specific). > I will send some minor issues fixed with next patch vers

Re: [U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

2010-11-22 Thread Darius Augulis
Hi all, is there anybody interested in U-boot for s3c64xx? If not, at least I would like to ask Wolfgang to review generic things (not architecture specific). I will send some minor issues fixed with next patch version. Mostly they will be board specific initialisation issues. New nand spl code i

[U-Boot] [RFC PATCH] ARM: S3C64XX: add support for mini6410

2010-11-17 Thread Darius Augulis
Add support for mini6410 from FriendlyARM Signed-off-by: Darius Augulis --- MAKEALL |1 Makefile|4 arch/arm/cpu/arm1176/s3c64xx/Makefile |6 - board/friendly_arm/mini6410/Makefile