Re: [U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

2018-03-19 Thread Duncan Hare
On Mon, 19 Mar 2018 09:53:24 + Calvin Johnson wrote: > > > > > void net_set_udp_header(uchar *pkt, struct in_addr dest, int > > > > dport, > > > > - int sport, int len); > > > > - > > > > + int sport, int len); > > > > > Why do you need

Re: [U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

2018-03-19 Thread Calvin Johnson
> > It would be good to have this cosmetic change into a separate patch. > > Ok. But at this stage I'm at the "Forgive me Lord for I know not what > I do" 😊 . Let me know, if you need steps to separate this out. To me, it is okay even If you keep this in the same patch. > > > /* Set IP hea

Re: [U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

2018-03-18 Thread Duncan Hare
On Sat, 17 Mar 2018 16:36:14 + Calvin Johnson wrote: > It would be good to have this cosmetic change into a separate patch. Ok. But at this stage I'm at the "Forgive me Lord for I know not what I do" > IMO, better place for this definition and associated explanation > would be above the c

Re: [U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

2018-03-17 Thread Calvin Johnson
> -Original Message- > From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of > d...@synoia.com > Sent: Thursday, March 8, 2018 10:14 AM > To: duncanch...@yahoo.com > Cc: Duncan Hare ; Joe Hershberger > ; u-boot@lists.denx.de > Subject: [U-Boot] [PATCH v8

Re: [U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

2018-03-17 Thread Calvin Johnson
Hi Duncan, > -Original Message- > From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Joe > Hershberger > Sent: Friday, March 9, 2018 12:23 AM > To: Duncan Hare > Cc: Duncan Hare ; Joe Hershberger > ; Duncan Hare ; u-boot > > Subject: Re: [U-Boot

Re: [U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

2018-03-08 Thread Joe Hershberger
Hi Duncan, Still some issues, but getting closer to parsable. The subject of this should be something like, "net: Adjust UDP implementation to prepare for TCP support" On Wed, Mar 7, 2018 at 10:43 PM, wrote: > From: Duncan Hare > >> > I think these are coming from your commit log. Y

[U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

2018-03-07 Thread DH
From: Duncan Hare > cover-letter: Why netboot: Central management, including logs and change control, coupled with with enhanced security and unauthorized change detection and remediation by exposing a small attack surface. Why TCP: Currently file transfer are done using tftp or NFS b