On Mon, 19 Mar 2018 09:53:24 +0000 Calvin Johnson <calvin.john...@nxp.com> wrote:
> > > > > void net_set_udp_header(uchar *pkt, struct in_addr dest, int > > > > dport, > > > > - int sport, int len); > > > > - > > > > + int sport, int len); > > > > > Why do you need this change in the set_udp_header? > > > > This is a shim to bridge between the original udp to ip procedure > > call and the extra parameters in the enhanced ip procedure call to > > the ip layer for TCP. > > > > The original udp call is unchanged, because I did not want a > > change to a procedure call to ripple through many applications. > > For now, I'm okay with the change you made to net_set_ip_header. > > - int sport, int len); > - > + int sport, int len); > I'm concerned about above 3 line change. Here, you are decreasing > indent and removing an empty line. This change may not be required. yes, I don't remember this, but its probably driven by patman messages. These are both issues which can generated patman error messages. Duncan _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
