Re: [U-Boot] [PATCH v5 0/4] Buffer overruns in printf

2011-11-02 Thread Simon Glass
Hi Wolfgang, On Tue, Nov 1, 2011 at 6:18 PM, Simon Glass wrote: > Hi Wolfgang, > > On Tue, Nov 1, 2011 at 2:21 PM, Wolfgang Denk wrote: >> Dear Simon Glass, >> >> In message >> you >> wrote: >>> >>> I have suggested making these functions available by default, and >>> having CONFIG_NO_SYS_VSN

Re: [U-Boot] [PATCH v5 0/4] Buffer overruns in printf

2011-11-01 Thread Simon Glass
Hi Wolfgang, On Tue, Nov 1, 2011 at 2:21 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> I have suggested making these functions available by default, and >> having CONFIG_NO_SYS_VSNPRINT to remove them. The rationale is that it > > This makes little sense to m

Re: [U-Boot] [PATCH v5 0/4] Buffer overruns in printf

2011-11-01 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > I have suggested making these functions available by default, and > having CONFIG_NO_SYS_VSNPRINT to remove them. The rationale is that it This makes little sense to me. We don't need an opt out here, but an opt in instead. Otherwise you willprobab

Re: [U-Boot] [PATCH v5 0/4] Buffer overruns in printf

2011-11-01 Thread Simon Glass
Hi, On Tue, Oct 25, 2011 at 4:42 PM, Simon Glass wrote: > The printf family of functions in U-Boot cannot deal with a situation where > the caller provides a buffer which turns out to be too small for the format > string. This can result in buffer overflows, stack overflows and other bad > behavi

[U-Boot] [PATCH v5 0/4] Buffer overruns in printf

2011-10-25 Thread Simon Glass
The printf family of functions in U-Boot cannot deal with a situation where the caller provides a buffer which turns out to be too small for the format string. This can result in buffer overflows, stack overflows and other bad behavior. This patch series tidies this up in the common vsprintf.c cod