Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-25 Thread Sebastian Hesselbarth
On 06/25/2013 10:38 PM, Sascha Silbe wrote: Sebastian Hesselbarth writes: [...] I was under the impression that you resent the patches because you have a CuBox you want to get supported. Exactly. I'd like to see support for CuBox enter mainline U-Boot. However, there's also a limit to the amo

Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-25 Thread Sascha Silbe
Sebastian Hesselbarth writes: [...] > I was under the impression that you resent the patches because you have > a CuBox you want to get supported. Exactly. I'd like to see support for CuBox enter mainline U-Boot. However, there's also a limit to the amount of time I can afford to spend on it (bo

Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-25 Thread Sascha Silbe
Hello Jagan, Jagan Teki writes: > Looks ok to me as per coding style after a quick look. Thanks for the review. [...] > Done use the below tag code instead go for spi_alloc_slave() > see the sample code on "drivers/spi/exynos_spi.c" > > --- TAG+ >> + slave = malloc(s

Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-25 Thread Sebastian Hesselbarth
On 06/25/2013 09:33 PM, Sascha Silbe wrote: Sebastian Hesselbarth writes: Either orion_spi as it was named originally, or mv_spi as Prafulla suggested. Then move mpp (pinctrl) from kirkwood_spi to corresponding boards, switch to orion_/mv_spi, and remove kirkwood_spi. I suggest orion_spi, but

Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-25 Thread Sascha Silbe
Sebastian Hesselbarth writes: > Either orion_spi as it was named originally, or mv_spi as Prafulla > suggested. Then move mpp (pinctrl) from kirkwood_spi to corresponding > boards, switch to orion_/mv_spi, and remove kirkwood_spi. > > I suggest orion_spi, but Prafulla had his word so it should be

Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-12 Thread Sebastian Hesselbarth
On 06/12/2013 09:30 PM, Jagan Teki wrote: On Thu, Jun 13, 2013 at 12:56 AM, Sebastian Hesselbarth wrote: Is any of you even listening? Please do _not_ name it after Dove! It is compatible with _at least_ Kirkwood, Orion5x and MV78x00. Now is the chance to have a common name or you will end up

Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-12 Thread Jagan Teki
On Thu, Jun 13, 2013 at 12:56 AM, Sebastian Hesselbarth wrote: > On 06/12/2013 08:58 PM, Jagan Teki wrote: >> >> On 03-06-2013 23:50, Jagan Teki wrote: >>> >>> Looks ok to me as per coding style after a quick look. >>> On Mon, May 27, 2013 at 12:06 AM, Sascha Silbe >>> wrote: From: Seba

Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-12 Thread Sebastian Hesselbarth
On 06/12/2013 08:58 PM, Jagan Teki wrote: On 03-06-2013 23:50, Jagan Teki wrote: Looks ok to me as per coding style after a quick look. On Mon, May 27, 2013 at 12:06 AM, Sascha Silbe wrote: From: Sebastian Hesselbarth This adds an SPI driver for Marvell Dove SoCs. This driver is taken from k

Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-12 Thread Jagan Teki
Hi, On 03-06-2013 23:50, Jagan Teki wrote: Hi, Looks ok to me as per coding style after a quick look. On Mon, May 27, 2013 at 12:06 AM, Sascha Silbe wrote: From: Sebastian Hesselbarth This adds an SPI driver for Marvell Dove SoCs. This driver is taken from kirkwood_spi but removes mpp conf

Re: [U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-06-03 Thread Jagan Teki
Hi, Looks ok to me as per coding style after a quick look. On Mon, May 27, 2013 at 12:06 AM, Sascha Silbe wrote: > From: Sebastian Hesselbarth > > This adds an SPI driver for Marvell Dove SoCs. This driver is taken > from kirkwood_spi but removes mpp configuration as dove has dedicated > spi pi

[U-Boot] [PATCH v4 05/10] SPI: Add Dove SPI driver

2013-05-26 Thread Sascha Silbe
From: Sebastian Hesselbarth This adds an SPI driver for Marvell Dove SoCs. This driver is taken from kirkwood_spi but removes mpp configuration as dove has dedicated spi pins. As a future clean-up step, the code for orion5x, kirkwood and dove could be merged, with MPP configuration being be hand