Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-05 Thread Stephen Warren
On 08/05/2013 02:08 PM, Tom Rini wrote: > On Mon, Aug 05, 2013 at 01:21:50PM -0600, Stephen Warren wrote: >> On 07/30/2013 02:00 PM, Stephen Warren wrote: ... (discussion of >> instantiating/initializing I2C devices from device tree, and the >> fact U-Boot attempts to do that before .data or malloc

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-05 Thread Stephen Warren
On 08/05/2013 02:08 PM, Tom Rini wrote: > On Mon, Aug 05, 2013 at 01:21:50PM -0600, Stephen Warren wrote: >> On 07/30/2013 02:00 PM, Stephen Warren wrote: ... (discussion of >> instantiating/initializing I2C devices from device tree, and the >> fact U-Boot attempts to do that before .data or malloc

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-05 Thread Stephen Warren
On 08/05/2013 02:12 PM, Simon Glass wrote: > Hi Stephen, > > > On Mon, Aug 5, 2013 at 11:28 AM, Stephen Warren > wrote: > > On 08/05/2013 09:40 AM, Simon Glass wrote: > ... > > Yes I think we should fix the problem properly rather than just > revert

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-05 Thread Simon Glass
Hi Stephen, On Mon, Aug 5, 2013 at 11:28 AM, Stephen Warren wrote: > On 08/05/2013 09:40 AM, Simon Glass wrote: > ... > > Yes I think we should fix the problem properly rather than just revert. > > I will take a look. > > How long will fixing it properly take? > I expect to have a patch tomorro

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-05 Thread Tom Rini
On Mon, Aug 05, 2013 at 01:21:50PM -0600, Stephen Warren wrote: > On 07/30/2013 02:00 PM, Stephen Warren wrote: > ... > (discussion of instantiating/initializing I2C devices from device tree, > and the fact U-Boot attempts to do that before .data or malloc can be > touched/used, which doesn't work)

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-05 Thread Stephen Warren
On 07/30/2013 02:00 PM, Stephen Warren wrote: ... (discussion of instantiating/initializing I2C devices from device tree, and the fact U-Boot attempts to do that before .data or malloc can be touched/used, which doesn't work) ... > It seems like much of U-Boot's initialization architecture simply w

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-05 Thread Stephen Warren
On 08/02/2013 09:55 PM, Heiko Schocher wrote: > Hello Stephen, > > Am 02.08.2013 23:43, schrieb Stephen Warren: >> On 08/01/2013 10:40 PM, Heiko Schocher wrote: >>> Am 01.08.2013 22:32, schrieb Stephen Warren: >> ... Given how long this discussion is going on, can we please just revert t

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-05 Thread Stephen Warren
On 08/05/2013 09:40 AM, Simon Glass wrote: ... > Yes I think we should fix the problem properly rather than just revert. > I will take a look. How long will fixing it properly take? I've already received at least a couple reports from people outside NVIDIA and a couple from people inside NVIDIA w

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-05 Thread Simon Glass
Hi, On Fri, Aug 2, 2013 at 9:55 PM, Heiko Schocher wrote: > Hello Stephen, > > Am 02.08.2013 23:43, schrieb Stephen Warren: > > On 08/01/2013 10:40 PM, Heiko Schocher wrote: >> >>> Am 01.08.2013 22:32, schrieb Stephen Warren: >>> >> ... >> >>> Given how long this discussion is going on, can we

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-02 Thread Heiko Schocher
Hello Stephen, Am 02.08.2013 23:43, schrieb Stephen Warren: On 08/01/2013 10:40 PM, Heiko Schocher wrote: Am 01.08.2013 22:32, schrieb Stephen Warren: ... Given how long this discussion is going on, can we please just revert the commit so that the code works for everyone who's trying to use i

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-02 Thread Stephen Warren
On 08/01/2013 10:40 PM, Heiko Schocher wrote: > Am 01.08.2013 22:32, schrieb Stephen Warren: ... >> Given how long this discussion is going on, can we please just revert >> the commit so that the code works for everyone who's trying to use it, >> then fix the problem later? > > Yes, but not revert

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-02 Thread Simon Glass
Hi Heiko, On Thu, Aug 1, 2013 at 10:40 PM, Heiko Schocher wrote: > Hello Stephen, > > Am 01.08.2013 22:32, schrieb Stephen Warren: > > On 08/01/2013 12:02 AM, Heiko Schocher wrote: >> >>> Am 01.08.2013 07:39, schrieb Stephen Warren: >>> On 07/31/2013 10:32 PM, Heiko Schocher wrote: >>

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-02 Thread Simon Glass
Hi Albert, On Thu, Aug 1, 2013 at 2:16 PM, Albert ARIBAUD wrote: > Hi Simon, > > On Thu, 1 Aug 2013 08:22:55 -0600, Simon Glass wrote: > > > Hi, > > > > On Thu, Aug 1, 2013 at 2:38 AM, Heiko Schocher wrote: > > > > > Hello Albert, > > > > > > Am 01.08.2013 08:53, schrieb Albert ARIBAUD: > > > >

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-01 Thread Heiko Schocher
Hello Stephen, Am 01.08.2013 22:32, schrieb Stephen Warren: On 08/01/2013 12:02 AM, Heiko Schocher wrote: Am 01.08.2013 07:39, schrieb Stephen Warren: On 07/31/2013 10:32 PM, Heiko Schocher wrote: Am 31.07.2013 21:31, schrieb Stephen Warren: On 07/30/2013 11:46 PM, Heiko Schocher wrote: ...

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-01 Thread Stephen Warren
On 08/01/2013 12:53 AM, Albert ARIBAUD wrote: > Hi Heiko, > > On Thu, 01 Aug 2013 08:02:42 +0200, Heiko Schocher wrote: > >>> I suppose you could. It seems conceptually /far/ simpler to just scan >>> the DT once up-front rather than having to defer all this stuff until >> >> on the other hand we

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-01 Thread Stephen Warren
On 08/01/2013 12:02 AM, Heiko Schocher wrote: > Am 01.08.2013 07:39, schrieb Stephen Warren: >> On 07/31/2013 10:32 PM, Heiko Schocher wrote: >>> Am 31.07.2013 21:31, schrieb Stephen Warren: On 07/30/2013 11:46 PM, Heiko Schocher wrote: ... 2) Actually initializing or using the I2C HW. Th

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-01 Thread Albert ARIBAUD
Hi Simon, On Thu, 1 Aug 2013 08:22:55 -0600, Simon Glass wrote: > Hi, > > On Thu, Aug 1, 2013 at 2:38 AM, Heiko Schocher wrote: > > > Hello Albert, > > > > Am 01.08.2013 08:53, schrieb Albert ARIBAUD: > > > > Hi Heiko, > >> > >> On Thu, 01 Aug 2013 08:02:42 +0200, Heiko Schocher wrote: > >>

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-01 Thread Albert ARIBAUD
Hi Heiko, On Thu, 01 Aug 2013 10:38:15 +0200, Heiko Schocher wrote: > Hello Albert, > > Am 01.08.2013 08:53, schrieb Albert ARIBAUD: > > Hi Heiko, > > > > On Thu, 01 Aug 2013 08:02:42 +0200, Heiko Schocher wrote: > > > >>> I suppose you could. It seems conceptually /far/ simpler to just scan >

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-01 Thread Heiko Schocher
Hello Simon, Am 01.08.2013 16:22, schrieb Simon Glass: Hi, On Thu, Aug 1, 2013 at 2:38 AM, Heiko Schocher wrote: Hello Albert, Am 01.08.2013 08:53, schrieb Albert ARIBAUD: Hi Heiko, On Thu, 01 Aug 2013 08:02:42 +0200, Heiko Schocher wrote: I suppose you could. It seems conceptuall

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-01 Thread Simon Glass
Hi, On Thu, Aug 1, 2013 at 2:38 AM, Heiko Schocher wrote: > Hello Albert, > > Am 01.08.2013 08:53, schrieb Albert ARIBAUD: > > Hi Heiko, >> >> On Thu, 01 Aug 2013 08:02:42 +0200, Heiko Schocher wrote: >> >> I suppose you could. It seems conceptually /far/ simpler to just scan the DT once

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-08-01 Thread Heiko Schocher
Hello Albert, Am 01.08.2013 08:53, schrieb Albert ARIBAUD: Hi Heiko, On Thu, 01 Aug 2013 08:02:42 +0200, Heiko Schocher wrote: I suppose you could. It seems conceptually /far/ simpler to just scan the DT once up-front rather than having to defer all this stuff until on the other hand we ri

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Albert ARIBAUD
Hi Heiko, On Thu, 01 Aug 2013 08:02:42 +0200, Heiko Schocher wrote: > > I suppose you could. It seems conceptually /far/ simpler to just scan > > the DT once up-front rather than having to defer all this stuff until > > on the other hand we ring for every ms boot time ... and here we want > to

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Heiko Schocher
Hello Stephen, Am 01.08.2013 07:39, schrieb Stephen Warren: On 07/31/2013 10:32 PM, Heiko Schocher wrote: Hello Stephen, Am 31.07.2013 21:31, schrieb Stephen Warren: On 07/30/2013 11:46 PM, Heiko Schocher wrote: ... Hmm.. each i2c adapter has its own init function ... why the tegra driver do

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Stephen Warren
On 07/31/2013 10:32 PM, Heiko Schocher wrote: > Hello Stephen, > > Am 31.07.2013 21:31, schrieb Stephen Warren: >> On 07/30/2013 11:46 PM, Heiko Schocher wrote: >> ... >>> Hmm.. each i2c adapter has its own init function ... why the tegra >>> driver do not use it? And do the necessary inits in it?

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Heiko Schocher
Hello Stephen, Am 31.07.2013 21:41, schrieb Stephen Warren: On 07/31/2013 02:31 AM, Heiko Schocher wrote: Am 31.07.2013 10:16, schrieb Albert ARIBAUD: On Wed, 31 Jul 2013 09:36:19 +0200, Heiko Schocher wrote: ... In the present instance, I'd rather we either: - removed dependency on DT et

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Heiko Schocher
Hello Stephen, Am 31.07.2013 21:31, schrieb Stephen Warren: On 07/30/2013 11:46 PM, Heiko Schocher wrote: ... Hmm.. each i2c adapter has its own init function ... why the tegra driver do not use it? And do the necessary inits in it? So we initialize an adapater only if we use it, which is also

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Stephen Warren
On 07/31/2013 02:31 AM, Heiko Schocher wrote: > Am 31.07.2013 10:16, schrieb Albert ARIBAUD: >> On Wed, 31 Jul 2013 09:36:19 +0200, Heiko Schocher wrote: ... In the present instance, I'd rather we either: - removed dependency on DT etc. by using "hard-coded" low level I2C r

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Wolfgang Denk
Dear Albert, In message <20130731090644.2b4ce215@lilith> you wrote: > > > On some boards, yes. For example, if they store the environment in an > > I2C attached EEPROM. Then you need I2C support early, before console, > > to read for example the baudrate setting. > > Thanks, so some I2C reads a

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Stephen Warren
On 07/30/2013 11:46 PM, Heiko Schocher wrote: ... > Hmm.. each i2c adapter has its own init function ... why the tegra > driver do not use it? And do the necessary inits in it? So we > initialize an adapater only if we use it, which is also a rule > for u-boot ... > > I have no hw, but it should b

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Heiko Schocher
Hello Simon, Am 31.07.2013 14:30, schrieb Simon Glass: Hi, On Wed, Jul 31, 2013 at 3:38 AM, Albert ARIBAUD wrote: Hi Heiko, On Wed, 31 Jul 2013 10:31:12 +0200, Heiko Schocher wrote: Hello Albert, Am 31.07.2013 10:16, schrieb Albert ARIBAUD: Hi Heiko, On Wed, 31 Jul 2013 09:36:19 +0200,

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Simon Glass
Hi, On Wed, Jul 31, 2013 at 3:38 AM, Albert ARIBAUD wrote: > Hi Heiko, > > On Wed, 31 Jul 2013 10:31:12 +0200, Heiko Schocher wrote: > > > Hello Albert, > > > > Am 31.07.2013 10:16, schrieb Albert ARIBAUD: > > > Hi Heiko, > > > > > > On Wed, 31 Jul 2013 09:36:19 +0200, Heiko Schocher wrote: > >

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Albert ARIBAUD
Hi Heiko, On Wed, 31 Jul 2013 10:31:12 +0200, Heiko Schocher wrote: > Hello Albert, > > Am 31.07.2013 10:16, schrieb Albert ARIBAUD: > > Hi Heiko, > > > > On Wed, 31 Jul 2013 09:36:19 +0200, Heiko Schocher wrote: > > > >>> On the other hand, it may be hard to immediately know what functions >

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Heiko Schocher
Hello Albert, Am 31.07.2013 10:16, schrieb Albert ARIBAUD: Hi Heiko, On Wed, 31 Jul 2013 09:36:19 +0200, Heiko Schocher wrote: On the other hand, it may be hard to immediately know what functions throughout U-boot are safe to call from within board_init_f(); maybe we should start thinking ab

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Albert ARIBAUD
Hi Heiko, On Wed, 31 Jul 2013 09:36:19 +0200, Heiko Schocher wrote: > > On the other hand, it may be hard to immediately know what functions > > throughout U-boot are safe to call from within board_init_f(); maybe we > > should start thinking about checking and marking these, the simplest > > wa

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Heiko Schocher
Hello Albert, Am 31.07.2013 09:06, schrieb Albert ARIBAUD: Hi Wolfgang, On Wed, 31 Jul 2013 07:18:21 +0200, Wolfgang Denk wrote: Dear Albert ARIBAUD, In message<20130731000921.724f5c71@lilith> you wrote: board_init_f() is supposed to initialize just enough of the system to allow relocati

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-31 Thread Albert ARIBAUD
Hi Wolfgang, On Wed, 31 Jul 2013 07:18:21 +0200, Wolfgang Denk wrote: > Dear Albert ARIBAUD, > > In message <20130731000921.724f5c71@lilith> you wrote: > > > > board_init_f() is supposed to initialize just enough of the system to > > allow relocation. Is initializing i2c necessary in this cont

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Heiko Schocher
Hello Wolfgang, Am 31.07.2013 07:18, schrieb Wolfgang Denk: Dear Albert ARIBAUD, In message<20130731000921.724f5c71@lilith> you wrote: board_init_f() is supposed to initialize just enough of the system to allow relocation. Is initializing i2c necessary in this context? On some boards, yes.

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Heiko Schocher
Hello Albert, Am 31.07.2013 00:09, schrieb Albert ARIBAUD: Hi Stephen, On Tue, 30 Jul 2013 15:51:44 -0600, Stephen Warren wrote: On 07/30/2013 03:46 PM, Simon Glass wrote: On Tue, Jul 30, 2013 at 3:32 PM, Stephen Warrenmailto:swar...@wwwdotorg.org>> wrote: On 07/30/2013 03:21 PM, Si

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Heiko Schocher
Hello Simon, Am 31.07.2013 00:05, schrieb Simon Glass: Hi Stephen, On Tue, Jul 30, 2013 at 3:51 PM, Stephen Warrenwrote: On 07/30/2013 03:46 PM, Simon Glass wrote: On Tue, Jul 30, 2013 at 3:32 PM, Stephen Warrenmailto:swar...@wwwdotorg.org>> wrote: On 07/30/2013 03:21 PM, Simon Glass

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message <20130731000921.724f5c71@lilith> you wrote: > > board_init_f() is supposed to initialize just enough of the system to > allow relocation. Is initializing i2c necessary in this context? On some boards, yes. For example, if they store the environment in an I2C atta

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Heiko Schocher
Hello Stephen, Am 30.07.2013 22:00, schrieb Stephen Warren: On 07/30/2013 01:22 PM, Stephen Warren wrote: On 07/29/2013 10:28 PM, Heiko Schocher wrote: Hello Stephen, Am 29.07.2013 18:12, schrieb Stephen Warren: On 05/04/2013 06:01 AM, Heiko Schocher wrote: From: Simon Glass This enables C

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Heiko Schocher
Hello Stephen, Am 30.07.2013 21:22, schrieb Stephen Warren: On 07/29/2013 10:28 PM, Heiko Schocher wrote: Hello Stephen, Am 29.07.2013 18:12, schrieb Stephen Warren: On 05/04/2013 06:01 AM, Heiko Schocher wrote: From: Simon Glass This enables CONFIG_SYS_I2C on Tegra, updating existing board

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Heiko Schocher
Hello Stephen Am 30.07.2013 20:56, schrieb Stephen Warren: On 07/29/2013 10:28 PM, Heiko Schocher wrote: Hello Stephen, Am 29.07.2013 18:12, schrieb Stephen Warren: On 05/04/2013 06:01 AM, Heiko Schocher wrote: From: Simon Glass This enables CONFIG_SYS_I2C on Tegra, updating existing boards

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Simon Glass
Hi Albert, On Tue, Jul 30, 2013 at 4:09 PM, Albert ARIBAUD wrote: > Hi Stephen, > > On Tue, 30 Jul 2013 15:51:44 -0600, Stephen Warren > wrote: > > > On 07/30/2013 03:46 PM, Simon Glass wrote: > > > On Tue, Jul 30, 2013 at 3:32 PM, Stephen Warren > > > wrote: > > >

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Albert ARIBAUD
Hi Stephen, On Tue, 30 Jul 2013 15:51:44 -0600, Stephen Warren wrote: > On 07/30/2013 03:46 PM, Simon Glass wrote: > > On Tue, Jul 30, 2013 at 3:32 PM, Stephen Warren > > wrote: > > > > On 07/30/2013 03:21 PM, Simon Glass wrote: > > > On Tue, Jul 30, 2013

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Simon Glass
Hi Stephen, On Tue, Jul 30, 2013 at 3:51 PM, Stephen Warren wrote: > On 07/30/2013 03:46 PM, Simon Glass wrote: > > On Tue, Jul 30, 2013 at 3:32 PM, Stephen Warren > > wrote: > > > > On 07/30/2013 03:21 PM, Simon Glass wrote: > > > On Tue, Jul 30, 2013 at 2:

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Stephen Warren
On 07/30/2013 03:46 PM, Simon Glass wrote: > On Tue, Jul 30, 2013 at 3:32 PM, Stephen Warren > wrote: > > On 07/30/2013 03:21 PM, Simon Glass wrote: > > On Tue, Jul 30, 2013 at 2:00 PM, Stephen Warren > mailto:swar...@wwwdotorg.org> > >

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Simon Glass
On Tue, Jul 30, 2013 at 3:32 PM, Stephen Warren wrote: > On 07/30/2013 03:21 PM, Simon Glass wrote: > > On Tue, Jul 30, 2013 at 2:00 PM, Stephen Warren > > wrote: > ... > > Oh, with the options Tegra has enabled, perhaps the call sequence is: > > > > board_in

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Simon Glass
On Tue, Jul 30, 2013 at 3:21 PM, Stephen Warren wrote: > On 07/30/2013 03:19 PM, Simon Glass wrote: > > Hi Stephen, > > > > On Tue, Jul 30, 2013 at 1:22 PM, Stephen Warren > > wrote: > ... > > I think when init_sequence_f[] is running, there may be no serial > >

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Stephen Warren
On 07/30/2013 03:21 PM, Simon Glass wrote: > On Tue, Jul 30, 2013 at 2:00 PM, Stephen Warren > wrote: ... > Oh, with the options Tegra has enabled, perhaps the call sequence is: > > board_init_f() (which uses init_sequence_f[]) -> init_func_i2c() -> > i2c

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Simon Glass
Hi Stephen, On Tue, Jul 30, 2013 at 2:00 PM, Stephen Warren wrote: > On 07/30/2013 01:22 PM, Stephen Warren wrote: > > On 07/29/2013 10:28 PM, Heiko Schocher wrote: > >> Hello Stephen, > >> > >> Am 29.07.2013 18:12, schrieb Stephen Warren: > >>> On 05/04/2013 06:01 AM, Heiko Schocher wrote: > >>>

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Stephen Warren
On 07/30/2013 03:19 PM, Simon Glass wrote: > Hi Stephen, > > On Tue, Jul 30, 2013 at 1:22 PM, Stephen Warren > wrote: ... > I think when init_sequence_f[] is running, there may be no serial > console to report errors. If so, moving the I2C initialization to t

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Simon Glass
Hi Stephen, On Tue, Jul 30, 2013 at 1:22 PM, Stephen Warren wrote: > On 07/29/2013 10:28 PM, Heiko Schocher wrote: > > Hello Stephen, > > > > Am 29.07.2013 18:12, schrieb Stephen Warren: > >> On 05/04/2013 06:01 AM, Heiko Schocher wrote: > >>> From: Simon Glass > >>> > >>> This enables CONFIG_SYS

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Stephen Warren
On 07/30/2013 01:22 PM, Stephen Warren wrote: > On 07/29/2013 10:28 PM, Heiko Schocher wrote: >> Hello Stephen, >> >> Am 29.07.2013 18:12, schrieb Stephen Warren: >>> On 05/04/2013 06:01 AM, Heiko Schocher wrote: From: Simon Glass This enables CONFIG_SYS_I2C on Tegra, updating existi

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Stephen Warren
On 07/29/2013 10:28 PM, Heiko Schocher wrote: > Hello Stephen, > > Am 29.07.2013 18:12, schrieb Stephen Warren: >> On 05/04/2013 06:01 AM, Heiko Schocher wrote: >>> From: Simon Glass >>> >>> This enables CONFIG_SYS_I2C on Tegra, updating existing boards and >>> the Tegra >>> i2c driver to support

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-30 Thread Stephen Warren
On 07/29/2013 10:28 PM, Heiko Schocher wrote: > Hello Stephen, > > Am 29.07.2013 18:12, schrieb Stephen Warren: >> On 05/04/2013 06:01 AM, Heiko Schocher wrote: >>> From: Simon Glass >>> >>> This enables CONFIG_SYS_I2C on Tegra, updating existing boards and >>> the Tegra >>> i2c driver to support

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-29 Thread Simon Glass
Hi Heiko, On Mon, Jul 29, 2013 at 10:28 PM, Heiko Schocher wrote: > Hello Stephen, > > Am 29.07.2013 18:12, schrieb Stephen Warren: > > On 05/04/2013 06:01 AM, Heiko Schocher wrote: >> >>> From: Simon Glass >>> >>> This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the >>> Tegra

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-29 Thread Heiko Schocher
Hello Stephen, Am 29.07.2013 18:12, schrieb Stephen Warren: On 05/04/2013 06:01 AM, Heiko Schocher wrote: From: Simon Glass This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra i2c driver to support this. Heiko, the latest U-Boot tree hangs during boot on Tegra, and "

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-07-29 Thread Stephen Warren
On 05/04/2013 06:01 AM, Heiko Schocher wrote: > From: Simon Glass > > This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra > i2c driver to support this. Heiko, the latest U-Boot tree hangs during boot on Tegra, and "git bisect" points at this patch. Olof reported the issu

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-05-07 Thread Heiko Schocher
: Heiko Schocher >> Cc: u-boot@lists.denx.de; Tom Warren >> Subject: Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C >> framework >> >> On 05/04/2013 06:01 AM, Heiko Schocher wrote: >>> From: Simon Glass >>> >>> This enables CONFIG_

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-05-07 Thread Heiko Schocher
Hello Stephen, Am 06.05.2013 21:08, schrieb Stephen Warren: > On 05/04/2013 06:01 AM, Heiko Schocher wrote: >> From: Simon Glass >> >> This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra >> i2c driver to support this. > >> include/configs/beaver.h| 5 ++- >> includ

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-05-06 Thread Stephen Warren
On 05/04/2013 06:01 AM, Heiko Schocher wrote: > From: Simon Glass > > This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra > i2c driver to support this. > include/configs/beaver.h| 5 ++- > include/configs/cardhu.h| 3 +- > include/configs/dalmore.h | 3 +- >

[U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C framework

2013-05-04 Thread Heiko Schocher
From: Simon Glass This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the Tegra i2c driver to support this. Signed-off-by: Simon Glass Signed-off-by: Heiko Schocher --- - changes for v2: new in v2 posted from Simon Glass here: http://patchwork.ozlabs.org/patch/195568/ a