Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-29 Thread Eugeniu Rosca
Hello, On Thu, Mar 28, 2019 at 03:58:48PM -0400, Tom Rini wrote: > On Thu, Mar 28, 2019 at 05:30:30PM +0100, Eugeniu Rosca wrote: > > Hello Igor, All, > > > > On Thu, Mar 21, 2019 at 05:39:36PM +0200, Igor Opaniuk wrote: > > > Hi Eugeniu, > > > > > > On Fri, Mar 8, 2019 at 7:29 PM Eugeniu Rosca

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-28 Thread Tom Rini
On Thu, Mar 28, 2019 at 05:30:30PM +0100, Eugeniu Rosca wrote: > Hello Igor, All, > > On Thu, Mar 21, 2019 at 05:39:36PM +0200, Igor Opaniuk wrote: > > Hi Eugeniu, > > > > On Fri, Mar 8, 2019 at 7:29 PM Eugeniu Rosca wrote: > [..] > > > > > > The s/uint8_t/u8/ and s/uint32_t/u32/ conversion crea

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-28 Thread Eugeniu Rosca
Hello Igor, All, On Thu, Mar 21, 2019 at 05:39:36PM +0200, Igor Opaniuk wrote: > Hi Eugeniu, > > On Fri, Mar 8, 2019 at 7:29 PM Eugeniu Rosca wrote: [..] > > > > The s/uint8_t/u8/ and s/uint32_t/u32/ conversion creates noise > > comparing the in-tree versus out-of-tree files and will add some >

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-22 Thread Igor Opaniuk
Hi Eugeniu, On Fri, Mar 8, 2019 at 7:29 PM Eugeniu Rosca wrote: > > Hello Igor, > > Thanks for the series. Some questions below. > > First, my understanding is that the patches replace the deprecated > libavb_ab and make it trully obsolete, i.e. there should be no need to > import libavb_ab into

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-19 Thread Eugeniu Rosca
Hi Praneeth, Igor, On Mon, Mar 18, 2019 at 04:20:16PM -0500, Bajjuri, Praneeth wrote: > Eugeniu, [..] > Not a glitch, Igor's linaro email id is no longer active. He might respond > with updated email > address soon. Great news. Looking forward for v4 of this series. Many thanks, Eugeniu. ___

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-18 Thread Bajjuri, Praneeth
Eugeniu, On 3/18/2019 3:21 PM, Eugeniu Rosca wrote: I received the following bounce: Thank you for your email. Igor Opaniuk no longer works for Linaro. If your email is related to Linaro business, please use the Contact form (https://www.linaro.org/contact/) if you do not have another Linaro

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-18 Thread Eugeniu Rosca
I received the following bounce: > Thank you for your email. > > Igor Opaniuk no longer works for Linaro. > > If your email is related to Linaro business, please use the Contact > form (https://www.linaro.org/contact/) if you do not have another > Linaro email address to use. I hope this is a gli

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-18 Thread Eugeniu Rosca
jFYI/FWIW, AOSP U-Boot [1] seems to currently import the bootloader message header [2] at least twice: - as include/android_bl_msg.h via https://android.googlesource.com/platform/external/u-boot/+/86a4b492b5db%5E!/ - as include/android_bootloader_message.h via https://android.googlesource.c

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-11 Thread Eugeniu Rosca
FWIW, below are some dangling struct name references due to: - s/bootloader_message/andr_bl_msg/ - s/bootloader_message_ab/andr_bl_msg_ab/ - s/bootloader_control/andr_bl_control/ On Mon, Feb 18, 2019 at 5:25 PM Igor Opaniuk wrote: [..] > + * uncrypt. Move it into struct bootloader_message_ab t

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-10 Thread Simon Glass
Hi Igor, On Mon, 18 Feb 2019 at 10:22, Igor Opaniuk wrote: > > From: Ruslan Trofymenko > > This patch determines the A/B-specific bootloader message structure > that is the basis for implementation of recovery and A/B update > functions. A/B metadata is stored in this structure and used to decid

Re: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-03-08 Thread Eugeniu Rosca
Hello Igor, Thanks for the series. Some questions below. First, my understanding is that the patches replace the deprecated libavb_ab and make it trully obsolete, i.e. there should be no need to import libavb_ab into U-Boot (unlike some of our suppliers still do). Can you please confirm? On Mon,

[U-Boot] [PATCH v3 3/7] common: Implement A/B metadata

2019-02-18 Thread Igor Opaniuk
From: Ruslan Trofymenko This patch determines the A/B-specific bootloader message structure that is the basis for implementation of recovery and A/B update functions. A/B metadata is stored in this structure and used to decide which slot should we use to boot the device. Also some basic functions