Re: [U-Boot] [PATCH v3 3/3] spl: dfu: reduce spl-dfu MLO size

2017-05-24 Thread B, Ravi
Hi Tom >> >> >This doesn't make sense. CONFIG_IS_ENABLED(DFU_MMC) is true for >> >> >CONFIG_DFU_MMC or CONFIG_SPL_DFU_MMC. Thanks! >> >> >> >> True, My bad, I realized it lately after posting the patch. >> >> >> >> I will use run_command() only, which abstrace use of both >> >> simple_cli_xx(

Re: [U-Boot] [PATCH v3 3/3] spl: dfu: reduce spl-dfu MLO size

2017-05-24 Thread Tom Rini
On Wed, May 24, 2017 at 12:11:57PM +, B, Ravi wrote: > Hi Tom > > >> >> obj-$(CONFIG_USB_FUNCTION_DFU) += dfu.o > >> >> +ifndef CONFIG_SPL_BUILD > >> >> obj-$(CONFIG_DFU_MMC) += dfu_mmc.o > >> >> +endif > >> >> +obj-$(CONFIG_SPL_DFU_MMC) += dfu_mmc.o > >> > >> >This becomes obj-$(CONFIG_$(S

Re: [U-Boot] [PATCH v3 3/3] spl: dfu: reduce spl-dfu MLO size

2017-05-24 Thread B, Ravi
Hi Tom >> >> obj-$(CONFIG_USB_FUNCTION_DFU) += dfu.o >> >> +ifndef CONFIG_SPL_BUILD >> >> obj-$(CONFIG_DFU_MMC) += dfu_mmc.o >> >> +endif >> >> +obj-$(CONFIG_SPL_DFU_MMC) += dfu_mmc.o >> >> >This becomes obj-$(CONFIG_$(SPL_)DFU_MMC) += dfu_mmc.o >> >> >> diff --git a/drivers/dfu/dfu_mmc.c b/dr

Re: [U-Boot] [PATCH v3 3/3] spl: dfu: reduce spl-dfu MLO size

2017-05-13 Thread Tom Rini
On Fri, May 12, 2017 at 08:44:31AM +, B, Ravi wrote: > Hi Tom > > Sorry for late response, some how missed this mail. > > >> > >> obj-$(CONFIG_USB_FUNCTION_DFU) += dfu.o > >> +ifndef CONFIG_SPL_BUILD > >> obj-$(CONFIG_DFU_MMC) += dfu_mmc.o > >> +endif > >> +obj-$(CONFIG_SPL_DFU_MMC) += df

Re: [U-Boot] [PATCH v3 3/3] spl: dfu: reduce spl-dfu MLO size

2017-05-12 Thread B, Ravi
Hi Tom Sorry for late response, some how missed this mail. >> >> obj-$(CONFIG_USB_FUNCTION_DFU) += dfu.o >> +ifndef CONFIG_SPL_BUILD >> obj-$(CONFIG_DFU_MMC) += dfu_mmc.o >> +endif >> +obj-$(CONFIG_SPL_DFU_MMC) += dfu_mmc.o >This becomes obj-$(CONFIG_$(SPL_)DFU_MMC) += dfu_mmc.o >> diff --g

Re: [U-Boot] [PATCH v3 3/3] spl: dfu: reduce spl-dfu MLO size

2017-05-04 Thread Tom Rini
On Thu, May 04, 2017 at 03:45:30PM +0530, Ravi Babu wrote: > compile out cli_hush.c for spl/dfu and > use cli_simple_run_command for dfu to > reduce the spl-dfu memory foot print. > > Adding CONFIG_SPL_DFU_MMC to Kconfig and > use CONFIG_IS_ENABLED(DFU_MMC). > > Signed-off-by: Ravi Babu [snip]

[U-Boot] [PATCH v3 3/3] spl: dfu: reduce spl-dfu MLO size

2017-05-04 Thread Ravi Babu
compile out cli_hush.c for spl/dfu and use cli_simple_run_command for dfu to reduce the spl-dfu memory foot print. Adding CONFIG_SPL_DFU_MMC to Kconfig and use CONFIG_IS_ENABLED(DFU_MMC). Signed-off-by: Ravi Babu --- --- common/Makefile | 1 - drivers/dfu/Kconfig | 5 + drivers/dfu/