Hi Tom >> >> >This doesn't make sense. CONFIG_IS_ENABLED(DFU_MMC) is true for >> >> >CONFIG_DFU_MMC or CONFIG_SPL_DFU_MMC. Thanks! >> >> >> >> True, My bad, I realized it lately after posting the patch. >> >> >> >> I will use run_command() only, which abstrace use of both >> >> simple_cli_xx() and hush_parser. >> >> >> >> Since cli_hush.c is compile out for SPL to reduce the size. SPL >> >> must use simple_cli_xx(). >> >> Since by default CONFIG_HUSH_PARSER is defined for both SPL/U-BOOT, >> >> this leads to compile error. I need to fix this way. >> >> >We keep running into problems due to trying to whack in what to do in DFU >> >via command rather than via API. Can you make an attempt to convert things >> >over, in both SPL and not SPL, in DFU to using ABI instead, to see if we >> >can get the size reduction here still, >and >not have to try and put >> >fragile to other use cases ifdefs in common code? Thanks! >> >> Use of direct mmc read/write API instead of using the run_command() is not >> feasible in this case. As the DFU does read/write to mmc through fat/ext4 >> files system, uses "fatload/fatwrite" or "ext4load/ext4write" command to >> perform read/write to specific >partition of mmc device. I think use of >> run_command() is more appropriate.
>OK. Can you go back to https://patchwork.ozlabs.org/patch/758485/ and clean >that up as I was saying? We should be able to call cli_simple_run_command in >all cases and then not need cli_hush.c, yes? >And we can then move common/cli.c into being compiled only in the non-SPL case >I think (but use travis-ci to confirm). Thanks! Ok, will do. Thanks. In latest mainline, dfu has broken due to commit 1a9a5f7a: usb: host: xhci-omap: fix double weak board_usb_init functions. Due to this DFU gadget mode fails, due to weak board_usb_init() gets called which does not initialize the usb controller. I will fix this as well and send the patch. Regards Ravi _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
