Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-30 Thread Tom Rini
On Thu, May 30, 2013 at 06:57:02AM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, May 16, 2013 at 11:49 AM, Simon Glass wrote: > > > Hi Tom, > > > > On Thu, May 16, 2013 at 9:26 AM, Tom Rini wrote: > > > On Wed, May 15, 2013 at 07:13:18AM -0700, Simon Glass wrote: > > > > > > [snip] > > >> I'

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-30 Thread Simon Glass
Hi Tom, On Thu, May 16, 2013 at 11:49 AM, Simon Glass wrote: > Hi Tom, > > On Thu, May 16, 2013 at 9:26 AM, Tom Rini wrote: > > On Wed, May 15, 2013 at 07:13:18AM -0700, Simon Glass wrote: > > > > [snip] > >> I've brought over the patches that I can that don't depend on autoconf: > >> > >> 6c0e

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-16 Thread Simon Glass
Hi Tom, On Thu, May 16, 2013 at 9:26 AM, Tom Rini wrote: > On Wed, May 15, 2013 at 07:13:18AM -0700, Simon Glass wrote: > > [snip] >> I've brought over the patches that I can that don't depend on autoconf: >> >> 6c0e6c9 (HEAD, ws/us-config5, us-config5) main: Add debug_bootkeys to >> avoid #ifdef

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-16 Thread Tom Rini
On Wed, May 15, 2013 at 07:13:18AM -0700, Simon Glass wrote: [snip] > I've brought over the patches that I can that don't depend on autoconf: > > 6c0e6c9 (HEAD, ws/us-config5, us-config5) main: Add debug_bootkeys to > avoid #ifdefs > 9777b9f main: Add debug_parser() to avoid #ifdefs > 2fc85b6 mai

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-15 Thread Simon Glass
Hi Tom, On Tue, May 14, 2013 at 3:28 PM, Tom Rini wrote: > On Tue, May 14, 2013 at 03:22:04PM -0700, Vadim Bendebury wrote: >> On Tue, May 14, 2013 at 3:15 PM, Tom Rini wrote: >> > On Tue, May 14, 2013 at 02:27:32PM -0700, Simon Glass wrote: >> >> Hi Tom, >> >> >> >> On Tue, May 14, 2013 at 2:21

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-14 Thread Tom Rini
On Tue, May 14, 2013 at 03:22:04PM -0700, Vadim Bendebury wrote: > On Tue, May 14, 2013 at 3:15 PM, Tom Rini wrote: > > On Tue, May 14, 2013 at 02:27:32PM -0700, Simon Glass wrote: > >> Hi Tom, > >> > >> On Tue, May 14, 2013 at 2:21 PM, Tom Rini wrote: > >> > On Mon, May 13, 2013 at 03:12:07PM -0

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-14 Thread Vadim Bendebury
On Tue, May 14, 2013 at 3:15 PM, Tom Rini wrote: > On Tue, May 14, 2013 at 02:27:32PM -0700, Simon Glass wrote: >> Hi Tom, >> >> On Tue, May 14, 2013 at 2:21 PM, Tom Rini wrote: >> > On Mon, May 13, 2013 at 03:12:07PM -0700, Simon Glass wrote: >> >> Hi Tom, >> >> >> >> On Thu, Mar 21, 2013 at 7:3

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-14 Thread Tom Rini
On Tue, May 14, 2013 at 02:27:32PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, May 14, 2013 at 2:21 PM, Tom Rini wrote: > > On Mon, May 13, 2013 at 03:12:07PM -0700, Simon Glass wrote: > >> Hi Tom, > >> > >> On Thu, Mar 21, 2013 at 7:38 AM, Tom Rini wrote: > >> > On Tue, Feb 26, 2013 at 08:1

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-14 Thread Simon Glass
Hi Tom, On Tue, May 14, 2013 at 2:21 PM, Tom Rini wrote: > On Mon, May 13, 2013 at 03:12:07PM -0700, Simon Glass wrote: >> Hi Tom, >> >> On Thu, Mar 21, 2013 at 7:38 AM, Tom Rini wrote: >> > On Tue, Feb 26, 2013 at 08:10:53AM -0800, Simon Glass wrote: >> > >> >> Many parts of the U-Boot code bas

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-14 Thread Tom Rini
On Mon, May 13, 2013 at 03:12:07PM -0700, Simon Glass wrote: > Hi Tom, > > On Thu, Mar 21, 2013 at 7:38 AM, Tom Rini wrote: > > On Tue, Feb 26, 2013 at 08:10:53AM -0800, Simon Glass wrote: > > > >> Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes > >> different boards com

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-05-13 Thread Simon Glass
Hi Tom, On Thu, Mar 21, 2013 at 7:38 AM, Tom Rini wrote: > On Tue, Feb 26, 2013 at 08:10:53AM -0800, Simon Glass wrote: > >> Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes >> different boards compile different versions of the source code, meaning >> that we must build a

Re: [U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-03-21 Thread Tom Rini
On Tue, Feb 26, 2013 at 08:10:53AM -0800, Simon Glass wrote: > Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes > different boards compile different versions of the source code, meaning > that we must build all boards to check for failures. It is easy to misspell > an #ifd

[U-Boot] [PATCH v3 0/16] Provide a mechanism to avoid using #ifdef everywhere

2013-02-26 Thread Simon Glass
Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of the source code, meaning that we must build all boards to check for failures. It is easy to misspell an #ifdef and there is not as much checking of this by the compiler. Multiple