Re: [U-Boot] [PATCH v2 5/7] x86: i8042: Correctly initialize the controller

2015-08-23 Thread Simon Glass
Hi Bin, On 23 August 2015 at 06:25, Bin Meng wrote: > Hi Simon, > > On Sat, Aug 22, 2015 at 7:27 AM, Simon Glass wrote: >> Hi Bin, >> >> On 21 August 2015 at 01:18, Bin Meng wrote: >>> The existing i8042 keyboard controller driver has some issues. >>> First of all, it does not issue a self-test

Re: [U-Boot] [PATCH v2 5/7] x86: i8042: Correctly initialize the controller

2015-08-23 Thread Bin Meng
Hi Simon, On Sat, Aug 22, 2015 at 7:27 AM, Simon Glass wrote: > Hi Bin, > > On 21 August 2015 at 01:18, Bin Meng wrote: >> The existing i8042 keyboard controller driver has some issues. >> First of all, it does not issue a self-test command (0xaa) to the >> controller at the very beginning. With

Re: [U-Boot] [PATCH v2 5/7] x86: i8042: Correctly initialize the controller

2015-08-21 Thread Simon Glass
Hi Bin, On 21 August 2015 at 01:18, Bin Meng wrote: > The existing i8042 keyboard controller driver has some issues. > First of all, it does not issue a self-test command (0xaa) to the > controller at the very beginning. Without this, the controller > does not respond any command at all. Secondly

[U-Boot] [PATCH v2 5/7] x86: i8042: Correctly initialize the controller

2015-08-21 Thread Bin Meng
The existing i8042 keyboard controller driver has some issues. First of all, it does not issue a self-test command (0xaa) to the controller at the very beginning. Without this, the controller does not respond any command at all. Secondly, it initializes the configuration byte reigster to turn on ke