Re: [U-Boot] [PATCH v2 2/4] nds32/ag102: add ag102 soc support

2011-11-29 Thread Macpaul Lin
Hi Mike, 2011/11/30 Macpaul Lin > Hi Mike, > > err, i thought i saw u-boot had this in common code. seems it is not (i >>> must >>> have been looking in the Linux tree). don't worry about it until we get >>> that >>> addressed. >>> -mike >>> >> >> >> > It seems the only architecture related p

Re: [U-Boot] [PATCH v2 2/4] nds32/ag102: add ag102 soc support

2011-11-29 Thread Macpaul Lin
Hi Mike, 2011/11/30 Macpaul Lin > Hi Mike and Wolfgang, > > 2011/11/30 Mike Frysinger > >> > For supporting this kind of implementation, I must to put header support >> > like linkage.h >> >> err, i thought i saw u-boot had this in common code. seems it is not (i >> must >> have been looking i

Re: [U-Boot] [PATCH v2 2/4] nds32/ag102: add ag102 soc support

2011-11-29 Thread Macpaul Lin
Hi Mike and Wolfgang, 2011/11/30 Mike Frysinger > > For supporting this kind of implementation, I must to put header support > > like linkage.h > > err, i thought i saw u-boot had this in common code. seems it is not (i > must > have been looking in the Linux tree). don't worry about it until

Re: [U-Boot] [PATCH v2 2/4] nds32/ag102: add ag102 soc support

2011-11-29 Thread Mike Frysinger
On Tuesday 29 November 2011 23:32:27 Macpaul Lin wrote: > these kind of implementation? I know there are such code in Linux. > One benefits might be alignment (marco ENDPROC), and the other looks like > for coding style. makes sure the visibility/alignment/ELF size is correct. for the last part,

Re: [U-Boot] [PATCH v2 2/4] nds32/ag102: add ag102 soc support

2011-11-29 Thread Macpaul Lin
Hi Mike, 2011/11/30 Mike Frysinger > On Tuesday 29 November 2011 04:15:05 Macpaul Lin wrote: > > +.globl turnoff_watchdog > > +turnoff_watchdog: > > should be: > ENTRY(turnoff_watchdog) > > > + ret > > and at the end, add: > ENDPROC(turnoff_watchdog) > > seems a lot of the nds32 code c

Re: [U-Boot] [PATCH v2 2/4] nds32/ag102: add ag102 soc support

2011-11-29 Thread Mike Frysinger
On Tuesday 29 November 2011 04:15:05 Macpaul Lin wrote: > +.globl turnoff_watchdog > +turnoff_watchdog: should be: ENTRY(turnoff_watchdog) > + ret and at the end, add: ENDPROC(turnoff_watchdog) seems a lot of the nds32 code could use this fixup ... -mike signature.asc Description: T

[U-Boot] [PATCH v2 2/4] nds32/ag102: add ag102 soc support

2011-11-29 Thread Macpaul Lin
Add lowlevel ag102 soc support. Signed-off-by: Macpaul Lin --- Changes for v2: - cpu.c: - 1. Remove unused variables. - 2. Replace while(1) in do_reset by hang(). - 3. Clean up other coding styles. - timer.c: remove unneccessary static declaration arch/nds32/cpu/n1213/ag102/Makefil