Hi Mike, 2011/11/30 Mike Frysinger <vap...@gentoo.org>
> On Tuesday 29 November 2011 04:15:05 Macpaul Lin wrote: > > +.globl turnoff_watchdog > > +turnoff_watchdog: > > should be: > ENTRY(turnoff_watchdog) > > > + ret > > and at the end, add: > ENDPROC(turnoff_watchdog) > > seems a lot of the nds32 code could use this fixup ... > -mike > Thanks for your suggestion, however, I'd like to confirm what is the benefits of these kind of implementation? I know there are such code in Linux. One benefits might be alignment (marco ENDPROC), and the other looks like for coding style. For supporting this kind of implementation, I must to put header support like linkage.h from blackfin into nds32's common includes. Currently I don't see other architecture support these kind of code. Would you like to make some comment in more detail and also suggest other custodians? I think if this kind of implementation is good then it is worthy to be adopt to other architectures as well just like Linux. Thanks. -- Best regards, Macpaul Lin
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
